-
Benni Mack authored
There was a time when new code for TYPO3 Core was introduced by using "MyClass::getInstance()" to act as a factory for this class, which _would_ be OK if these classes are actually prototypes and not services (or singleton services), as GeneralUtility::makeInstance() or DI via Services.yaml works as well. This change deprecates all getInstance methods around such code with GeneralUtility::makeInstance() calls. At a later point, proper DI can be introduced in these cases. * TYPO3\CMS\Core\Resource\Index\ExtractorRegistry::getInstance() * TYPO3\CMS\Core\Resource\Index\FileIndexRepository::getInstance() * TYPO3\CMS\Core\Resource\Index\MetaDataRepository::getInstance() * TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\OnlineMediaHelperRegistry::getInstance() * TYPO3\CMS\Core\Resource\Rendering\RendererRegistry::getInstance() * TYPO3\CMS\Core\Resource\TextExtraction\TextExtractorRegistry::getInstance() * TYPO3\CMS\Form\Service\TranslationService::getInstance() * TYPO3\CMS\T3editor\Registry\AddonRegistry::getInstance() * TYPO3\CMS\T3editor\Registry\ModeRegistry::getInstance() Resolves: #95326 Releases: master Change-Id: Ie3160c67792e115cf5488dc800bd717c0b913ab9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71178 Tested-by: core-ci <typo3@b13.com> Tested-by: Wouter Wolters <typo3@wouterwolters.nl> Tested-by: Oliver Bartsch <bo@cedev.de> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by: Oliver Bartsch <bo@cedev.de> Reviewed-by: Benni Mack <benni@typo3.org>
cb355fa5