WIP: Resolve "Show team protocols on typo3.org"
Closes #354 (closed)
Merge request reports
Activity
changed milestone to %Sprint 3 (2019)
Some initial thoughts about
t3o_mom
:- Don't prefix the controllers, models and properties with
t3
, ex.:-
T3MomController
->MomController
-
T3Mom
->Mom
-
t3teams
->teams
- ...
- Don't forget to rename the getters and setters accordingly
-
- Use expressive names for controllers and models, ex.:
-
MomController
->MinutesOfMeetingController
-
Mom
->MinutesOfMeeting
- ...
-
- Don't prefix properties with the model name, ex.:
-
momauthor
->author
-
momdate
->date
- ...
- Don't forget to rename the getters and setters accordingly
-
- Above is also true for the translation keys
- There are references to
T3teams
andT3jobs
classes and repositories all across the place but I don't find any fitting extension containing those. After talking with @stefan.busemann I found out that these extensions currently reside in a MR related to my.typo3.org, the t3o_jobs extension either needs to be generalized or moved to typo3.org for this to work. - Remove Extension Builder specific things:
- the
ExtensionBuilder.json
- the Extension Builder information text in the Fluid templates
- the
Note: I haven't validated any functionality yet, this is a pure code review from inside GitLabs "Changes" tab.
- Don't prefix the controllers, models and properties with
assigned to @pixeldesu
assigned to @siddharth.nitsan
Thanks for your approach, but this is a very big overload of code.
In the issue we wanted two content elements. That can be done with a little TCA, some lines of TypoScript and Fluid templates. No need to build a complete Extbase extension with many lines of code that need to be maintained.
Please take a look at the tutorial here: https://usetypo3.com/custom-fsc-element.html Would be cool to have an approach like this.
Dear @tomalo.stuttgart
I can understand your concern. Actually, we already confirmed the technical approach with @stefan.busemann Our goal is to make sure the extendibility of the whole concept/feature.
Cheers!
changed milestone to %Sprint 4 (2019)
changed milestone to %_Ready for sprint