- 02 Nov, 2021 3 commits
-
-
Benni Mack authored
Change-Id: Ia1abfc52ec70cb81d005d41158c715a585061554 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72020 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
In some places the file extensions of language files are missing and properly added with this patch. Resolves: #95842 Releases: master Change-Id: Iea638f9386a094214115d2c7c2c039b2c0f37f82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72018 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Remember the current page in the redirects module if the pagination is used - just as filter values. Resolves: #95784 Releases: master, 10.4 Change-Id: I5903b8985bcbeb5a0a7c3fd9c7f404f2ee048ea1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71996 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Sybille Peters <sypets@gmx.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Sybille Peters <sypets@gmx.de>
Reviewed-by:
-
- 01 Nov, 2021 6 commits
-
-
Albeit we're removing jQuery step by step, we shall provide updated libs, which takes effect for jquery. Executed commands: cd Build yarn add "jquery@^3.6.0" yarn build Resolves: #95346 Releases: master Change-Id: I70fe3880ed76c79fcd2f80735dc266d24c3a9077 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71957 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Resolves: #95837 Releases: master Change-Id: I0b7169ec25a7f17ded6735b612ee51c25aa39d4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72016 Tested-by:
core-ci <typo3@b13.com>
Reviewed-by: -
The XliffParserTest are refactored using a DataProvider which also eliminates duplicate test code. The override tests are moved to the LanguageServiceTest and extended by more test scenarios. The LocalizationFactoryTest is refactored using prohecies instead of mocking the classes and a new test is added. Resolves: #95805 Releases: master Change-Id: I21df7a83ea6e4bca795d3ea19424bf1120db96ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71994 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Instead of throwing an exception when resolving the path to private resources, a deprecation message is now shown. Releases: master Resolves: #95800 Change-Id: I7bb4e705c8734d4a54938d027eb0edf9c90e745e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71995 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: -
Resolves: #95804 Releases: master Change-Id: I884741a4ecb7fdbc0cabd96f4975ea6629726d31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72000 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Fixes two undefined array keys in the install system extension's UpgradeWizardsService.php that cause errors in PHP 8. Resolves: #95824 Releases: master Change-Id: I4fc37952f16920f01032400682e883cee101f180 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72008 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 29 Oct, 2021 1 commit
-
-
RedirectService has been using LinkHandler to retrieve the targeturl, thus supporting all TYPO3 has to offer, like t3:// support, but also the legacy types for link fields. This had the effect, that for regexp redirects with capture group replacement, this has not been executed, this leading to incorrect redirects. This patch assumes for undetermined urls for redirect targets starting with an '/', that they are meant as relative target redirects on the current request host. This patch returns link details as type 'url' with the relative path in the resolving method for redirects, thus returning correct relative redirects but ensures that regexp capture group replacements are done. Redirects target without a leading slash could not be handled in the same way, as they are assumed and resolved as page links with the target as pageid. These cannot be safely changed. Further tests are added to cover these cases. Relative redirects are executed relatively, without adding a domain and scheme. Resolves: #91796 Related: #89799 Releases: master, 10.4 Change-Id: I944ad4570b0cc8c3cdaf1a86c5383facb76c0860 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71889 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Sybille Peters <sypets@gmx.de>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by:
-
- 28 Oct, 2021 1 commit
-
-
Resolves: #95809 Releases: master Change-Id: I7e5e9edc404ed8131461d112abee4c1cedb2ab1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72002 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- 27 Oct, 2021 4 commits
-
-
Check if filemounts are available before accessing those. Resolves: #95780 Releases: master Change-Id: I0f475a7add63eec1ec105760f745dd09113867c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71993 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Resolves: #95803 Releases: master Change-Id: I3c69e40bac77c46a5c2bd0d5bf68a20f36a037a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71999 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
\PDO::quote() is picky about the type argument in PHP 8.1. doctrine/dbal partially works around that and will improve with upcoming releases in this area. Our facade classes should still sanitize null arguments in a backwards compatible way. The patch adjusts signatures of quote() and literal() and explitictly avoids handing null to doctrine and lower level PDO methods. A unit test prophecy dealing with defaults needs to be adjusted along the way. Resolves: #95794 Releases: master Change-Id: Id1a3d454bee11e6e3a45bdaf33c507d92206d839 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71992 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Protected method linkWrap() should only be called with string arguments - they are for instance fed to explode(). Instead of casting accordingly, we harden the method signature and add a return type along the way. A unit test low-level tests linkWrap(), one data set does non make sense with that change anymore, and is removed. Change-Id: Id3e5d1fa514a396c8fe1a836a57496c809d07d25 Resolves: #95793 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71991 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by:
-
- 26 Oct, 2021 14 commits
-
-
When the mime type of a file can not be correctly determined by ImageMagick when detecting image sizes, fail silently and write the underlying Exception to the error log. This makes sure that multi file operations like copying or moving a folder do not lead to an inconsistent index state when the process is aborted due to an Exception. Resolves: #95695 Releases: master Change-Id: I55a23966e44558d94fde123b7c895ad81cf1f128 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71881 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
getData() may emit E_WARNING accessing $tsfe->page and $config. Sanitize that by null coalescing to empty string. Releases: master Resolves: #95782 Change-Id: I3093e07f6e3b47a4a792a6a2d66534c829d76d5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71982 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
This prevents exceptions for missing array keys when using the query generator for the DB Check backend module. Resolves: #95741 Releases: master Change-Id: I03269cf28d54904d19e1c71f1f674e5eab556947 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71944 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
PHP 8.1 in non strict_types context emits E_DEPRECATED with various functions that expect strings but are called giving null instead. The patch sanitizes a series of places to explicitely string cast arguments. Resolves: #95791 Releases: master Change-Id: I7605a3789c99ae944f5c03ac1401bab741db7957 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71987 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: -
ActionControllerTest mocks a view to test things. The subject calls renderSection() on that mock. renderSection() must return strings and always does that in non-testing context. The mock is fine tuned to return strings, too. Resolves: #95792 Releases: master Change-Id: Iec56bd2fa534505b39c74433855563d3a9342d8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71989 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: -
.stylelintrc is a json-like config and needs to quote keys. Releases: master Resolves: #95785 Change-Id: I626e956af5ffa70f664764fd746c102c73e740be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71980 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The function fputcsv gets an enclosure as third parameter. Providing an empty string as enclosure leads to following warning: fputcsv(): enclosure must be a character To prevent this, the header line should also be surrounded by quotation marks. Resolves: #95734 Releases: master, 10.4 Change-Id: I39e550d1dd4b185845984a6d7fddd73fa143374b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71939 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Table sys_file_processedfile field configuration is a blob. It usually contains a serialized array with processing information, but can be null due to the nature of blob. unserialize(null) emits an E_DEPRECATED error with PHP 8.1. ProcessedFileTest stumbles here, we however don't fix that in the test, but in the code to deal with the fact that this table field might be null in DB for whatever reasons. Resolves: #95790 Releases: master Change-Id: I961f042088347ade2689fb2c085543373d1104f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71986 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
That's a seldom gem. Method convNumEntityToByteValue() in DataHandler is *seriously* strange. It exists since very early TYPO3 claiming to fix a "very rare" MSIE bug. It *tries* to convert the "{" of a string like "foo{bar" to an ascii char ("{") and does this with a weird logic that includes a microtime(). Testing this thing locally reveals the method returns different results per execution! The patch drops that @internal method and it's caller. Change-Id: If9da47cc39d7c811b80879a4b532af90e9ea6f20 Resolves: #95789 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71985 Tested-by:core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
PageRender sanitizes array values in two methods, using array walk with trim(). These values can be other types then string, which trigger deprecation warning in PHP 8.1. This patch change the array walk to an closure to have an explicit type cast to string for passing the value to trim(). Additional a return type ': string' is added to the protected method getTemplate(), as this method always returns a string. Resolves: #95788 Releases: master Change-Id: Id0cdef928f977fdc1a9d476475bd3a44c5783922 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71984 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Various functions expect string arguments and emit E_DEPRECATED with PHP 8.1 in non strict_types=1 calls. The patch adjusts some null coalescence fallbacks from null to string to satisfy this. Resolves: #95787 Releases: master Change-Id: Ie1b28bc285c33af3509d18eaeb7d0b6013284434 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71983 Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Jochen <rothjochen@gmail.com>
Reviewed-by: -
The assumption for FilePathSanitizer::sanitize is to return file names relative to the public directory of TYPO3. Therefore, when making a given absolute file path relative with PathUtility::getPublicResourceWebPath, we must ensure to set the second argument to false to avoid adding the current site path to the relative path, but just directly return the relative path. This bug was not covered by the test, because on CLI this API NEVER appends the current site path. Therefore the test is now adapted to simulate a frontend web request. Also streamline usage of Environment API in tests to clarify intent. Releases: master Resolves: #95644 Change-Id: I20e7e6f434e4b4ca47aca35c79ec20e659fd7114 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71804 Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: physikbuddha <r.kaerner@oranto.de> Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: -
Resolves: #95778 Releases: master Change-Id: I764dc299cb192e4ebbcb00b21553f474355c55cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71976 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
Calling LanguageService->sL() should *always* return a string, even if it's empty. The patch enforces this. This reveals a couple of incomplete unit test mocks, which are fixed to keep the test suite happy. Resolves: #95776 Releases: master Change-Id: I2fbd272cebdbf76eeec354b3bc8750c172b3ece3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71974 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 25 Oct, 2021 11 commits
-
-
Christian Kuhn authored
Calling trim() with something else than a string emits a E_DEPRECATED error with PHP 8.1. Some ContentObjectRenderer->stdWrap_*() are affected by this and sanitized with explicit string casts. This is a bit of an artificial thing that mostly only happens in tests since in TypoScript usually everything is a string anyways. However, depending on how stdWrap_* methods are fed and used code-wise, it could also be a db return, which might be int or null. We thus can't simply change the method signature to 'string $content' and need to go with casts instead. Resolves: #95774 Releases: master Change-Id: Ifbb90170c4561e1570444c0c3d818aa32e58c827 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71972 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
Calling str_replace() with second argument non-string is deprecated as of PHP 8.1. Sanitize stdWrap_brTag() in ContentObjectRenderer to avoid a case found by unit tests. Resolves: #95775 Releases: master Change-Id: I9353ec28d23ec3b0ef50b8ecf48053ce27f5645e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71973 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
PHP 8.1 emits E_DEPRECATED if second argument to str_replace() is null. Adapt a null coalescence and add a cast to string for TSFE->page['uid'] in AbstractMenuContentObject to avoid this. Change-Id: Iafcf027471b976b160db768b4ada4a9535190319 Resolves: #95773 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71971 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The filter_var() filter FILTER_SANITIZE_STRING is deprecated as of PHP 8.1. Extbase TextValidator uses it. Goal of the text validator is to allow most 'casual' characters and strings as long as they don't contain HTML. The path switches to strip_tags() to validate. Tests are refactored and extended to show more cases. https://wiki.php.net/rfc/deprecations_php_8_1 Change-Id: Ifbf3de7a7200512d1281b694a7a6c2f8fb3ac781 Resolves: #95768 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71968 Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
We unfortunately still didn't manage to drop remaining usages of GeneralUtility::getIndpEnv() and deprecate the method in v11. So we have to harden it a bit towards better PHP compatibility: The method states it always returns string, but it doesn't. Especially HTTP_HOST and REMOTE_ADDR tend to return null. This isn't critical since that's usually just triggered by tests, but still, these calls should fall back to empty string instead of null. The return values are often further processed with string related methods, both in getIndpEnv() itself, in other consumers, and in other helper methods like cmpIp(). It absolutely makes sense to return empty string over null in lowlevel getIndpEnv() directly. Resolves: #95764 Releases: master Change-Id: I008452bb8445f1c23f634312d205102e4bb7602d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71966 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
FluidTemplateContentObject calls: $headerAssets = $this->view->renderSection(...); if (!empty(trim($headerAssets))) { ... This expects that renderSection() actually returns a string, which it usually does. Not returning a string and then calling trim(null) emits a PHP 8.1 E_DEPRECATED error. The heavy mocking FluidTemplateContentObjectTest class however misses to mock the view properly in many places and then triggers the trim(null) deprecation since especially renderSection() method mock is not instructed to return string and falls back to null. The patch takes care of proper mocking and adds a todo these tests would benefit from being turned into functional tests to avoid the mock party. Change-Id: Ifc2cb6ca00f09af0c6bd850f31c8807347e8c645 Resolves: #95771 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71969 Tested-by:core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
StringUtility::multibyteStringPad() does a happy division feeding str_repeat() to evenly pad on left and right side. The division result can be a float. With PHP 8.1, str_repeat($string, float) emits E_DEPRECATED "Implicit conversion from float looses precision.". Avoid this with an explicit cast. Resolves: #95772 Releases: master Change-Id: I8b918f6a4a304a059729e573a45626d1d5d27d10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71970 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
GeneralUtility::_POST($this->formfield_permanent) returns null if that field is not set in $_POST. Feeding null to strlen() emits a E_DEPRECATED PHP 8.1 error. Sanitize that call. Change-Id: Ib2712ee04807f2853f6dc4b66c76293ce6e161e8 Resolves: #95765 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71967 Reviewed-by:
Jochen <rothjochen@gmail.com>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: -
This change uses the PackageManager API to fetch the extension key title, and also solves a small issue when the TCA title is not prefixed with "LLL:". Resolves: #95716 Releases: master Change-Id: I199a44dae03968a549876b7862b01f2865269c8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71934 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Georg Ringer authored
With #94996 the behavior for composer based installations changed: - All extensions are always active - PackageStates.php is not used anymore - ext_emconf.php is not used anymore More information makes updates easier for integrators. Resolves: #95647 Releated: #94996 Releases: master Change-Id: I24f727987484e9eb2cefec37d85293dc2657aa66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71805 Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: -
- Error code 500 used to be displayed as the generic "Network error / invalid domain" which was misleading - Libcurl errors were always displayed with complete exception message which always added the URL to the libcurl errors. This bloated up the results page We now display short, localized error messages for the most common messages, falling back to the exception message. Resolves: #92231 Releases: master Change-Id: I7cc73a47912bf6bc25d74fa7fcfd8a33084a96cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
-
