1. 07 May, 2022 1 commit
  2. 04 May, 2022 1 commit
  3. 27 Apr, 2022 1 commit
  4. 25 Apr, 2022 2 commits
  5. 20 Apr, 2022 1 commit
  6. 07 Apr, 2022 1 commit
  7. 06 Apr, 2022 1 commit
  8. 31 Mar, 2022 1 commit
  9. 16 Feb, 2022 1 commit
  10. 07 Feb, 2022 1 commit
  11. 29 Jan, 2022 1 commit
    • Stefan Bürk's avatar
      [TASK] Revamp phpstan config and handling · 997722b8
      Stefan Bürk authored and Christian Kuhn's avatar Christian Kuhn committed
      We currently have the situation that phpstan is
      hard to update and maintain due to the phpstan
      config file that sets very specific rulesets.
      
      This is unfortunate since phpstan tends to change
      and rename rules at will.
      
      The general usage API of phpstan is basically as
      follows: Have a slim config file that sets the
      basic level. Then maintain a 'baseline' file that
      lists violations, using the --generate-baseline
      command option. The todo job for people working
      on phpstan errors is then to look at the baseline
      file, pick up some issues, fix them, then re-generate
      baseline. When baseline is small enough, the level
      is raised, a new baseline is generated, and the
      fix-job starts again.
      
      The patch does exactly this: The existing config
      is dropped and runTests.sh receives a command to
      generate baseline.
      
      With this in place, we can easily raise phpstan
      to a PHP 8.1 compatible version:
      
      > composer req friendsoftypo3/phpstan-typo3:"^0.9.0" --dev
      > composer req phpstan/phpstan:"^1.4.3" --dev
      > Build/Script/runTests.sh -s phpstanGenerateBaseline
      
      This initialy adds about 4000 ignores to the baseline
      with level 3, but we can reduce this drastically with
      just a couple of dedicated patches, soon.
      
      The config is heavily streamlined and for instance does
      *not* ignore tests anymore, which actually finds a ton
      of misuses and bugs within tests and classes.
      
      Resolves: #96675
      Releases: main, 11.5
      Change-Id: I0e7ff7aa796e59a2c5eedde0b673f741f8b87dea
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73037
      
      
      Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
      Tested-by: Daniel Goerz's avatarDaniel Goerz <daniel.goerz@posteo.de>
      Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
      Reviewed-by: Daniel Goerz's avatarDaniel Goerz <daniel.goerz@posteo.de>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      997722b8
  12. 21 Jan, 2022 1 commit
  13. 19 Jan, 2022 1 commit
  14. 18 Jan, 2022 1 commit
  15. 04 Jan, 2022 1 commit
  16. 15 Dec, 2021 1 commit
    • Stefan Bürk's avatar
      [TASK] Integrate sqlite acceptance testing · a2537436
      Stefan Bürk authored and Christian Kuhn's avatar Christian Kuhn committed
      Add support for sqlite acceptance testing to
      'Build/Scripts/runTests.sh'.
      
      Run acceptance/sqlite testing with PHP 8.1 in nightly
      as a first execution implementation, which could be
      reshuffled when minimum PHP requirements have
      been decided.
      
      Furthermore two acceptance tests are marked as skipped
      when executed with sqlite, which should be fixed in
      dedicated patches:
      
      * MaintenanceCest.php->analyzeDatabaseStructureWorks()
        Skipped, as database compare is never clean and ends
        in endless loop with sqlite, when ext:indexed_search is
        installed. This is a general issue, existing at least
        since v10.4. Needs investigation and a dedicated patch.
      
      * UpgradeCest.php->seeUpgradeWizard()
        Skipped, as utf-8 charset upgrade wizard is not visible
        for sqlite dbms backend, thus rendering this test obsolete
        with sqlite. Needs another update wizard test and possibly
        a dedicated patch.
      
      Resolves: #96340
      Releases: main
      Change-Id: I74c8f1156d98a5419309e110ed761e3de21fa37a
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72446
      
      
      Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      a2537436
  17. 08 Dec, 2021 1 commit
  18. 06 Dec, 2021 1 commit
  19. 17 Nov, 2021 1 commit
  20. 15 Nov, 2021 1 commit
  21. 19 Oct, 2021 1 commit
  22. 15 Oct, 2021 3 commits
  23. 24 Sep, 2021 2 commits
  24. 13 Sep, 2021 2 commits
  25. 11 Sep, 2021 1 commit
  26. 07 Sep, 2021 1 commit
  27. 02 Sep, 2021 1 commit
    • Jochen Roth's avatar
      [TASK] runTest.sh: Version check docker-compose v2 · 3c00759d
      Jochen Roth authored and Christian Kuhn's avatar Christian Kuhn committed
      Docker for Mac (and Windows?) currently misuses their
      users as canary testers by actively activating an
      "experimental" feature toggle which then ships
      a docker-compose v2 rc release.
      
      docker-composer v2's yaml parsing however is broken
      (you had ONE job!): It does not properly detect strings
      as strings and mumbles about this, and worse, it transforms
      shell "don't linebreak!" '\' operator into linebreaks. This
      breaks our carefully crafted and formatted testing related
      docker-compose.yml configuration.
      
      The situation persists for weeks already, there is no
      solution except manually disabling this docker for mac
      experimental feature toggle.
      
      The patch makes runTests.sh detect docker-composer v2,
      exits out with an error message telling the version
      is not supported and how to disable it. ddev went with
      a similar approach recently.
      
      Resolves: #95057
      Releases: master, 10.4, 9.5
      Change-Id: Iee1e6fd28d876262f00aba769a7e047c14db903c
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70845
      
      
      Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      3c00759d
  28. 29 Aug, 2021 1 commit
  29. 25 Aug, 2021 1 commit
  30. 13 Aug, 2021 3 commits
  31. 06 Aug, 2021 3 commits