- 04 Jan, 2021 1 commit
-
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- 30 Sep, 2020 1 commit
-
-
The "ResourceFactory" class was introduced as a "god class" to build any File/Folder object (from a string, DB row or integer), but is also there for building sys_file_storage (ResourceStorage) objects, so it is mixing a lot of concerns (also driver setup). However, all creation of ResourceStorage objects should be moved into the StorageRepository (which already exists), thus reducing the dependencies towards ResourceFactory. This makes it much easier to not juggle with storage UIDs anymore but actually work with storage objects throughout the internal FAL API. The StorageRepository is not extending from the AbstractRepository anymore, which is breaking. Resolves: #92289 Releases: master Change-Id: Ib367164535550e280a6907f4d4473aa0417c3813 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65184 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
- 17 Apr, 2020 1 commit
-
-
This patch has been created with rector and php-cs-fixer Releases: master Resolves: #91092 Change-Id: I80956bc210237169034acd86ef26c1e8f9725ddb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64212 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 30 Jan, 2020 1 commit
-
-
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 18 Dec, 2019 1 commit
-
-
php bin/rector process Releases: master Resolves: #89807 Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448 Tested-by:Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 01 Oct, 2018 1 commit
-
-
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:indexed_search - EXT:info - EXT:linkvalidator - EXT:lowlevel - EXT:opendocs - EXT:recordlist - EXT:recycler - EXT:redirects - EXT:reports - EXT:scheduler All @api annotations have been removed. Resolves: #86511 Releases: master Change-Id: I80de460142266305c1af3ad437f939b7e4448676 Reviewed-on: https://review.typo3.org/58530 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
- 13 Jan, 2018 1 commit
-
-
Christian Kuhn authored
Apply a series of CGL whitespace fixes, mostly: * No whitespace after type cast * One space around '=' Change-Id: I6279e083a4bd867bfb70c9567c35b6bab1412043 Resolves: #83557 Releases: master Reviewed-on: https://review.typo3.org/55352 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 27 Nov, 2017 1 commit
-
-
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
-
- 23 Aug, 2017 1 commit
-
-
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
- 18 Aug, 2017 1 commit
-
-
When creating an "update storage index" task, now the selected storage is saved correct. Resolves: #67241 Releases: master Change-Id: I371c5aa882ff78095536f1e413d58850ccb46c2b Reviewed-on: https://review.typo3.org/51036 Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- 04 Mar, 2015 1 commit
-
-
Streamline the layout of the scheduler. Resolves: #65233 Releases: master Change-Id: I2f91f187e21359d2228e81efb198b9bf9134d400 Reviewed-on: http://review.typo3.org/37110 Reviewed-by:
-
- 18 Jan, 2015 1 commit
-
-
* use "resource" or MySQL result instead of "pointer" * use the specific class instead of "object" * drop the @param of some removed parameters * fix a few typos in comments * add the missing parameter name in some @param This changeset does not add any type hinting in order to not break any existing code. Resolves: #38270 Releases: master Change-Id: Ied64439162d45fccafd15694f56ce675b5001a71 Reviewed-on: http://review.typo3.org/35885 Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Reviewed-by:
-
- 13 Dec, 2014 1 commit
-
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
- 13 Nov, 2014 1 commit
-
-
Xavier Perseguers authored
Since PHP 5.5 is a requirement, calls to GeneralUtility::makeInstance() should use the ::class construct instead of a string argument. Releases: master Resolves: #61788 Change-Id: Ia2efc5a4cb7ecea80b8a1c8e5ff7b5d6fa9a07ce Reviewed-on: http://review.typo3.org/32913 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
- 28 Oct, 2014 1 commit
-
-
Wouter Wolters authored
* Use bool in @return * Use int in @return * Use bool in @param * Use int in @param * Remove extra tabs and spaces in @param Resolves: #62506 Releases: master Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2 Reviewed-on: http://review.typo3.org/33577 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
- 08 Sep, 2014 1 commit
-
-
Wouter Wolters authored
* Move images to Resources/Public/Images/ * Move language files to Resources/Private/Language/ * Migrate ExtJs to jQuery * Move module template to Resources/Private/Template/ * Add strict comparison were possible Resolves: #60630 Releases: 6.3 Change-Id: I7bae64263268562b158dccf9b9c8fa6d6726fe52 Reviewed-on: http://review.typo3.org/31875 Reviewed-by:
-
- 25 Jul, 2014 1 commit
-
-
Resolves: #60562 Releases: 6.3 Change-Id: I321f32f85df90e11443837c2704eba5c097e7ea1 Reviewed-on: http://review.typo3.org/31808 Reviewed-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
-
- 22 Jun, 2014 1 commit
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59785 for further details. Resolves: #59785 Releases: 6.3, 6.2 Change-Id: If6a4795e7f2841474241d236d8ed33baceee0d2e Reviewed-on: https://review.typo3.org/31030 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- 09 Feb, 2014 1 commit
-
-
Exception codes are unique now. Resolves: #52294 Releases: 6.2 Change-Id: I4ad49b1ff0342ea36147b6ba0b01d270d9d9f3c5 Reviewed-on: https://review.typo3.org/27462 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- 01 Feb, 2014 1 commit
-
-
Jo Hasenau authored
This patch replaces most of around 1600 occurrences of intval() and every (integer) in the whole core. Additionally it changes GeneralUtility::intExplode to use references and typecasting as well. Some occurrences of strstr() together with intval() have been replaced with strpos() as well. And some superfluous intval calls have been removed or reduced to a single one i.e. for protected variables or before loops. Patch updated after Core CGL decision from 30.01.2014 Resolves: #54265 Releases: 6.2 Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8 Reviewed-on: https://review.typo3.org/26740 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- 16 Nov, 2013 1 commit
-
-
Steffen Ritter authored
This patch adds the indexing scheduler tasks See: http://wiki.typo3.org/Blueprints/FAL-IndexerRework Releases: 6.2 Resolves: #53601 Change-Id: I276bc9e02adcb5b4835fdfa80b1171b1bb21ec9f Reviewed-on: https://review.typo3.org/25372 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
