- 04 Jan, 2021 1 commit
-
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- 20 Dec, 2020 1 commit
-
-
This changes removes the frontend framework Bootstrap 3, and adds Bootstrap 5 beta 1 (we expect Bootstrap 5 final by the time we release TYPO3 v11 LTS). Bootstrap v3 is not supported by the Bootstrap team any longer, so an update is critical for TYPO3 Core. Bootstrap v5 adds a few accessibility improvements as well as flexbox for rendering containers and grids throughout TYPO3 Backend. All JS components are not bound to jQuery anymore, and have been reworked. A lot of HTML/CSS changes happened, which we slowly migrate (and not in a huge change) to TYPO3's templates, in order to keep this change managable. A legacy CSS/SCSS file is added to keep some backwards-compatibility classes to ease the migration for extension developers who have built their own backend modules. Key features of Bootstrap 5: * "rem" instead of "px" is used by default * CSS variables are introduced * Improved bootstrap focus outline styling (buttons / inputs / links) * Simplified grid functionality * use new button color mixin to increase contrast: Primary, Success and Warning Button color is now dark instead of white EXT:styleguide was used as a basis for upgrading to keep compatibility as much as possible, but more changes will be coming in the next few minor releases. Resolves: #92616 Releases: master Change-Id: Iec989f39649b5460b055ec879199faf38e424f2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66247 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 27 Sep, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92161 Resolves: #92164 Resolves: #92175 Resolves: #92176 Resolves: #92177 Resolves: #92178 Change-Id: I420ea01ba1d277f9a9147d076bc58a13175c8afb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65540 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 13 Apr, 2020 1 commit
-
-
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 24 Mar, 2020 2 commits
-
-
The check was removed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/53481 However, it is still needed and therefore reinstalled. Resolves: #90202 Releases: master, 9.5 Change-Id: Ib92b610ea744b41553245a80922080d3ab42a3ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63883 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Resolves: #83138 Releases: master, 9.5 Change-Id: I369b750c951c408cd880cab8a64dd6a3734c47aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63882 Reviewed-by:
-
- 10 Feb, 2020 1 commit
-
-
Benni Mack authored
This patch removes the dependency to DocumentTemplate from all LinkHandler + ElementBrowser popups, paving the way to move HTML generation of these parts into Fluid templates more and more. In this iteration however, the main focus relies on using ModuleTemplate instead of having everything built within Fluid. Resolves: #90326 Releases: master Change-Id: Idfa3f10a43392893e875bbbd2290f7a8557dc8e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63176 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Daniel Gorges <daniel.gorges@b13.com> Tested-by:
-
- 29 Jan, 2020 1 commit
-
-
- Add phpdoc for variables to let phpstan know their type - Do not use ::class syntax for PHP 7.4 classes (yet) - Add missing class properties - Do not unset non-existing variables Releases: master Resolves: #90207 Change-Id: I01ae756c03f7dfc286bedd2577979e0d79ca3d9b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63039 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 14 Jan, 2020 1 commit
-
-
LanguageService a.k.a. $GLOBALS[LANG] is used in various places, not just for backend-labels anymore. The "init()" method (which stems from the fact that PHP did not have constructors !!! back then), should be covered - which is now done via factory methods. The goal of the factory methods are to explicitly define the dependencies where LanguageService is used, instead of calling "init()" in the emitters code. This change is a pre-cursor for TYPO3 to - avoid accessing Bootstrap API for initializing $GLOBALS[LANG] - streamline the various places where this API is instantiated - have a first step to switch to "real" locales at _some_ point - and eventually get rid of accessing LanguageService via globals. In addition the PHP class comments are streamlined to reflect the purpose of this class. The next step is to adapt the testing framework to easily use this API so our tests will not have to worry about $GLOBALS[LANG] anymore. My 2c: We should actually rename "LanguageService" to "LabelService" or "LabelProvider" at some point. Resolves: #90062 Releases: master Change-Id: Ib1b6a8aacb2c2aecc3ab2931db04002dd02f0a99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62826 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Tested-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
-
- 15 Jan, 2019 1 commit
-
-
Last part of controller deprecation removals and deprecation trait usages. Affects extensions recordlist, reports and rte_ckeditor. Change-Id: I88f7ea2e708629b889b09b279f09a7f82dcb8801 Resolves: #87439 Releases: master Reviewed-on: https://review.typo3.org/59439 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 28 Oct, 2018 1 commit
-
-
This patch moves the current value of the link into the parameter array for the linkbrowser to keep the value in all linked actions inside the linkbrowser for the RTE CKEditor. This keeps the update button in the page linkhandler, if an existing page link will be edited. Resolves: #83545 Releases: master, 8.7 Change-Id: Ia9217057e45a5d94668bb5ac2f111198da9a69d1 Reviewed-on: https://review.typo3.org/58737 Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
- 01 Oct, 2018 1 commit
-
-
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:seo - EXT:setup - EXT:rte_ckeditor - EXT:workspaces - EXT:viewpage - EXT:tstemplate - EXT:taskcenter - EXT:t3editor - EXT:sys_action - EXT:sys_note All leftover @api methods have been removed. Resolves: #86509 Releases: master Change-Id: I6e5ee2302055de9ea4c124ca913e4677d62721fe Reviewed-on: https://review.typo3.org/58529 Tested-by:
-
- 30 Sep, 2018 1 commit
-
-
This patch streamlines all deprecation messages and follow the following rules. 1. All @deprecated should contain @deprecated since TYPO3 xx, will be removed in TYPO3 v10.0 (not "core v10" or just "v10" 2. trigger_error() - All trigger_error() messages MUST end with a "." (dot). - Never use "This method" but the method name (enjoy the logs otherwise) - "has been deprecated" can be spared - we KNOW it's deprecated once its in the deprecation log. Instead "Will be removed in TYPO3 v10.0" SHOULD be in the log file. - Do not use "__METHOD__" or some other "magic". Resolves: #86488 Releases: master Change-Id: I6a34593ff89ecafe649366d60d725daa3aa6676c Reviewed-on: https://review.typo3.org/58494 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- 09 Sep, 2018 1 commit
-
-
Some public -> protected changes for AbstractLinkBrowserController and BrowseLinksController Resolves: #86193 Releases: master Change-Id: I349dd5961ac2d90ede36a17c4d4ca550171e315e Reviewed-on: https://review.typo3.org/58223 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 02 Jul, 2018 1 commit
-
-
Fix the link browser to not drop the CSS-Class value with multiple classes if editing the same link. Resolves: #85182 Releases: master, 8.7 Change-Id: Id7819f25c6a456c379de406816e44d7d1d76157e Reviewed-on: https://review.typo3.org/57387 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 18 Jun, 2018 1 commit
-
-
Resolves: #85291 Releases: master Change-Id: Ia8db330043ccd2d123be8d6257189774969a951c Reviewed-on: https://review.typo3.org/57246 Tested-by:
Stefan Bürk <stefan.buerk@pure-metal.de> Tested-by:
-
- 07 Jun, 2018 1 commit
-
-
Fix the link browser to not drop the additional link params if editing a link with additional link params set. Resolves: #85040 Releases: master, 8.7 Change-Id: I4c016f701b38e048aa999c4e96365019eae4a237 Reviewed-on: https://review.typo3.org/57009 Tested-by:
-
- 01 Jun, 2018 1 commit
-
-
Tymoteusz Motylewski authored
Replaces hardcoded RTE configuration in BrowseLinksController with one resolved by Formengine when rendering a field. This takes into account e.g. column overrides. The RTE configuration preset name is now kept by Formengine in ['processedTca']['columns'][$fieldName]['config']['richtextConfigurationName'] Then it's being passed as parameter P[richtextConfigurationName] from RTE field to the BrowseinksController Resolves: #84943 Releases: master, 8.7 Change-Id: Id4f1c350f6eb6dfad4d49ec759a23939bbc45eda Reviewed-on: https://review.typo3.org/56881 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- 13 Jan, 2018 1 commit
-
-
This cosmetical CGL change just substitutes all declare(strict_types=1); with declare(strict_types = 1); to be in line with the general 'spaces around =' rule. While that is cosmetical, it makes scrutinizer-ci a bit more happy and prevents it from creating auto-patches for these cases. Change-Id: Ic754b3fd2a0f06624909e6188ed270bd2797745c Resolves: #83554 Releases: master Reviewed-on: https://review.typo3.org/55349 Tested-by:
-
- 27 Dec, 2017 1 commit
-
-
Using null coalescing operator in PHP 7 simplifies code structure. Resolves: #83129 Releases: master Change-Id: I449415c99ccb0ea158d3943800bc824514f7629c Reviewed-on: https://review.typo3.org/54810 Reviewed-by:
-
- 18 Oct, 2017 1 commit
-
-
Fixes the TypeError htmlspecialchars() expects parameter 1 to be string, null given Resolves: #82787 Releases: master,8.7 Change-Id: I38a689022ed45c34a8ae78c046abe51803eb0f4c Reviewed-on: https://review.typo3.org/54415 Reviewed-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
- 30 Sep, 2017 1 commit
-
-
The CKEditor link browser handled the configuration array still as a TypoScript array with dots. But the parsed YAML config is a plain array now. This patch makes sure the BrowserLinkController handles this config like a normal array. Further it fixes the missing JavaScript part to set the link title based on selected css class. Resolves: #81381 Releases: master, 8.7 Change-Id: Ie4749f820082e185208bf811aad7133bfc82d37a Reviewed-on: https://review.typo3.org/53481 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
Markus Sommer <markus.sommer@typo3.org> Tested-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 29 Mar, 2017 1 commit
-
-
Introducing a more adaptive and inclusive experience to the element- and linkbrowser. Resolves: #80463 Resolves: #80205 Releases: master Change-Id: I78d631dbf3ea206c78d65c6e4d3a60ab984fa1c9 Reviewed-on: https://review.typo3.org/52170 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- 28 Mar, 2017 2 commits
-
-
Make sure to check the correct variable classesAnchorDefaultTitle when fetching the title of anchors. This affects CKeditor as well as htmlarea. Resolves: #80209 Releases: master, 7.6 Change-Id: I1cdd760ee1fe2879ac53edff38f25515d656d706 Reviewed-on: https://review.typo3.org/52205 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 10 Mar, 2017 1 commit
-
-
Changed so the correct variable classesAnchorDefaultTitle is checked. In BrowseLinksController::getTitleField the wrong variable was checked, which could cause faulty behaviour and an PHP warning since $title could become null instead of the empty string. Resolves: #80209 Releases: master Change-Id: Ie2c82085438d0f0303d0d61ccb0a095ee37da338 Reviewed-on: https://review.typo3.org/51991 Tested-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
-
- 26 Feb, 2017 1 commit
-
-
Use Bootstrap grid for form field 'style' in link wizard. Resolves: #80011 Releases: master Change-Id: Icb62d5f4e8cc3990b774ddf0ba56ab9fb301d17c Reviewed-on: https://review.typo3.org/51843 Tested-by:
Anders Kostending <aha@systime.dk> Tested-by:
-
- 21 Feb, 2017 1 commit
-
-
The internals of the LinkBrowser and LinkHandler depend on all the field specific info to be in the P parameter. Further the DatabaseBrowser used by the RecordBrowser fetches the table parameter form global url query scope what collides with the params set by the CKEditor RichTextElement. To prevent the parameter collision the params set by the RichTextElement are moved to the P prefix what is also more inline with the other LinkBrowser implementations. This patch also resolves the lasts issues related to the new recordHandler + CKEditor. Resolves: #79645 Releases: master Change-Id: Id7cab0f0a012c5de11a2038e1d579d87599d47cd Reviewed-on: https://review.typo3.org/51760 Tested-by:
-
- 06 Feb, 2017 1 commit
-
-
Use correct field to determine page uid Resolves: #78917 Releases: master Change-Id: I01101640ff8ac1d801ef1619f8bc3c885aee2713 Reviewed-on: https://review.typo3.org/51555 Reviewed-by:
-
- 01 Feb, 2017 1 commit
-
-
Benni Mack authored
The main problem with the current RTE configuration relies in the fact that it is *only* configurable via pageTS. CKEditor can now be configured via YAML, but the configuration preset can be overriden via pageTS. Additionally, the CKEditor Form Element is cleaned up. A different preset can be used via PageTS config: - RTE.default.preset = minimal - RTE.config.tt_content.bodytext.preset = full Once included, the next features will be - a configuration backend module for ckeditor - Make sure to re-add the feature for RTE.anchorClasses - Check the languages of CKeditor that they are in line with the TYPO3 languages (possibility to add others) - image handling - table handling Resolves: #78917 Releases: master Change-Id: Ia222b73072b9e3fdb3a120d0be0a24a913552126 Reviewed-on: https://review.typo3.org/50919 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
- 17 Jan, 2017 1 commit
-
-
Configuring a richtext field in TCA with the "defaultExtras" setting (which was formerly the 5th showitem parameter) has been ugly ever since: The DataHandler needed a special _TRANSFORM_ field to trigger required RTE transformations, further config depends on pageTs settings. The patch gets rid of "defaultExtras" for richtext elements and adds a new option "enableRichtext=true" within the config section for type=text TCA fields. This setting can be set via "columnsOverrides" for specific types, too. As an intermediate solution, the configuration class "Richtext" is added to fetch richtext configuration. This will be extended with another patch to provide ckeditor configuration on TCA level. Change-Id: I70f4cb26e2a45629b99680e532d376538afd2b90 Resolves: #79341 Releases: master Reviewed-on: https://review.typo3.org/51311 Reviewed-by:
-
- 09 Dec, 2016 2 commits
-
-
Streamlined added config and moved plugin out of the Contrib folder and pass correct contents language to editor. Releases: master Resolves: #78917 Change-Id: Iccd66e2bea7f1503e2c4b3ae68096da70e9822ef Reviewed-on: https://review.typo3.org/50912 Tested-by:
-
Releases: master Resolves: #78917 Change-Id: I864b7798cd30f0eec63f4ec719f8dfebca1086ba Reviewed-on: https://review.typo3.org/50901 Tested-by:
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 10 Aug, 2016 1 commit
-
-
A new and unified syntax to link to pages, files, folders within a TYPO3 instance is added. All links are prefixed with "t3://". This patch adds a LinkService to convert from the "old" typolink syntax to the new syntax, and also allows to add the new syntax to typolink syntax. The further steps are * Don't replace the <a> tags with <links-tags inside the RTE transformations anymore * Make the frontend lib.parseFunc_RTE deal with <a> tags directly * Add a migration wizard for existing content Resolves: #74365 Releases: master Change-Id: I95a68c5770f4e4c5d9f8b3973817f1a270353217 Reviewed-on: https://review.typo3.org/47094 Reviewed-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
-
- 27 May, 2016 1 commit
-
-
Wouter Wolters authored
Remove the second parameter of getLL and replace it with htmlspecialchars directly in the code. Resolves: #76321 Related: #71917 Releases: master Change-Id: Iaccd3e31b235632fac9022e9120a35426bd5d99b Reviewed-on: https://review.typo3.org/48320 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- 19 Apr, 2016 1 commit
-
-
Restructured the HTML arround the form field in the element/link browser to be more in line with the rest of the BE. Resolves: #71840 Releases: master Change-Id: Icbfc9b6c30e974f15e64d93cf327e05c2574525c Reviewed-on: https://review.typo3.org/45210 Reviewed-by:
Michiel Roos <michiel@maxserv.com> Tested-by:
-
