- 04 Jan, 2021 2 commits
-
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Running a clean installation minimal setup throws a lot of "PHP Notice: Undefined index: " notices. This commit removes the ones from the frontend. Resolves: #91116 Releases: master, 10.4 Change-Id: I1f81150ed48ae170682d68d1169c1de2963e0021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64238 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 21 Dec, 2020 1 commit
-
-
Bootstrap v5 – introduced in #92616 – was added with CCS from beta1 but JavaScript from alpha2. bootstrap.bundle.js was manually wrapped into a AMD closure, and because bootstrap 5.0.0-beta1 contains alot of changes regarding data tags, it couldn't be updated in the initial patch. Bootstrap is now bundled using rollup using the ES6 sources in order to allow for automatic updates through `grunt build`. popperjs – previously bundled into bootstrap distributed files – is now added as dependency. The bootstap ES6 sources, that we now use through rollup, do not bundle this external dependency (for good reasons). Dependency added with: yarn add @popperjs/core Further adaptions contained in this change to ensure beta1 compatibility: a) Carousel "item" to "carousel-item" class migration b) $.fn.modal(options) does no longer imply $.fn.modal('show') c) Fix panels, both JS and CSS (card-group can't be used here) d) All bootstrap data- tags are migrated to data-bs-. (see https://github.com/twbs/bootstrap/pull/31827) Migrated with # renderes a sed substition with the help of a nested sed from all the # data-bs attributes that where changed in the twbs/bootstrap commit git grep -l data- | xargs sed -i $( \ curl -s \ https://patch-diff.githubusercontent.com/raw/twbs/bootstrap/pull/31827.patch | \ sed 's/data-bs-[a-z-]*/\n&\n/g' | grep "data-bs-[a-z-]" | \ sort | uniq | \ sed 's/data-bs-\(.*\)\([^a-z-]\|$\)/ -e s\/data-\1\\\([^a-z-]\\\)\/data-bs-\1\\1\/g -e s\/data('"'"'\1'"'"')\/data('"'"'bs-\1'"'"')\/g/g' \ ) # Revert false positives from the above auto-replacement git checkout -- typo3/sysext/core/Documentation/Changelog/ \ typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php \ Build/Sources/TypeScript/backend/Resources/Public/TypeScript/LiveSearch.ts \ Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineFlexForm.ts \ Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/ExtensionConfiguration.ts \ Build/Sources/Sass/typo3/_element_panel.scss (cd Build && grunt build) Resolves: #93126 Resolves: #93123 Resolves: #93132 Related: #92616 Releases: master Change-Id: Ie194d0f87d2c60df7b9e8a6de4893cfaaea55356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67215 Tested-by:Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 20 Dec, 2020 1 commit
-
-
This changes removes the frontend framework Bootstrap 3, and adds Bootstrap 5 beta 1 (we expect Bootstrap 5 final by the time we release TYPO3 v11 LTS). Bootstrap v3 is not supported by the Bootstrap team any longer, so an update is critical for TYPO3 Core. Bootstrap v5 adds a few accessibility improvements as well as flexbox for rendering containers and grids throughout TYPO3 Backend. All JS components are not bound to jQuery anymore, and have been reworked. A lot of HTML/CSS changes happened, which we slowly migrate (and not in a huge change) to TYPO3's templates, in order to keep this change managable. A legacy CSS/SCSS file is added to keep some backwards-compatibility classes to ease the migration for extension developers who have built their own backend modules. Key features of Bootstrap 5: * "rem" instead of "px" is used by default * CSS variables are introduced * Improved bootstrap focus outline styling (buttons / inputs / links) * Simplified grid functionality * use new button color mixin to increase contrast: Primary, Success and Warning Button color is now dark instead of white EXT:styleguide was used as a basis for upgrading to keep compatibility as much as possible, but more changes will be coming in the next few minor releases. Resolves: #92616 Releases: master Change-Id: Iec989f39649b5460b055ec879199faf38e424f2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66247 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 17 Dec, 2020 1 commit
-
-
To be able to introduce URL rewrites for the backend, the internal handling and registration of the shortcut PHP API is reworked. The Shortcut PHP API previously has the full URL of the shortcut target stored in the database. This lead to many problems such as shortcuts got invalid as soon as their target module changed its route path. Furthermore, this required unnecessary functionality like replacing tokens on URL creation. Therefore, a shortcut record now stores only the route identifier of the module to link to and necessary arguments in two new database columns. A upgrade wizard is in place to migrate existing data. The rework also required to deprecate some methods in the ShortcutButton API and a parameter signature change of the JavaScript function `TYPO3.ShortcutMenu.createShortcut()` which performs the AJAX call to create new shortcuts. Side effect, this also deprecated the last remains of xMOD_alt_doc.php in the core. Resolves: #93093 Releases: master Change-Id: I07666a299651e4953b4adf2987fcd3469094c288 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67143 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- 14 Dec, 2020 1 commit
-
-
The ShortcutRepository should not deal with generating shortcut titles based on the provided arguments. This can never be reliable, especially for custom extension code. The appropriate title must be set by the calling controller since this is the place where all necessary information, to define such title, are available. Therefore, adding a new shortcut button without defining a display name is deprecated. All Core controllers are adjusted to provide the necessary title themself. Resolves: #93060 Releases: master Change-Id: Ic15fe13769dec841868977a862464f8dd3c73c42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67096 Tested-by:
-
- 10 Dec, 2020 1 commit
-
-
Inline JavaScript produced by BackendUtility:viewOnClick is substituted with markup based instructions and static JavaScript event handlers. // basically delivers window.open(generatedUri) BackendUtility::viewOnClick($pageId, $backPath, $rootLine, $section, $viewUri, $getVars, $switchFocus); can be substituted with e.g. \TYPO3\CMS\Backend\Routing\PreviewUriBuilder::create($pageId, $viewUri) ->withRootLine($rootLine) ->withSection($section) ->withAdditionalQueryParameters($getVars) ->serializeDispatcherAttributes([ PreviewUriBuilder::OPTION_SWITCH_FOCUS => $switchFocus, ]); which results in the following HTML data attributes (data can be retrieved as array of complete element as well) data-dispatch-action="TYPO3.WindowManager.localOpen" data-dispatch-args="["https://...",null,"previewWin"]" Resolves: #91123 Releases: master Change-Id: Iedd9bfe60827977677ee68e2c948c63e359abf84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64243 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 23 Oct, 2020 1 commit
-
-
A <button> tag is now being used instead of an <a> tag as collapsing / expanding the tables is an interaction on the same page rather than opening a new one (<a> tag had empty `href` attribute). The button now also provides a proper aria-label with a descriptive text and gets the aria-expandend state initially set. Furthermore the button now uses common styling to be directly recognized as such. Resolves: #92657 Releases: master Change-Id: I7d98720f49b549bd74af1632c1fdd9fb9accbdba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66244 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Jens Ulrich <jens.ulrich@snk.de> Tested-by:
-
- 21 Oct, 2020 1 commit
-
-
A '"' is too much in the record list. Resolves: #92638 Releases: master Change-Id: I00eb74b3376d42ddf614d389d3bf9336e225d20c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66228 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
- 12 Oct, 2020 1 commit
-
-
Workspaces ("Element-based versioning") previously had - due to the "pid=-1" logic until TYPO3 v10 - a so-called "MOVE PLACEHOLDER". This was indicated by t3ver_state = 3, all relevant fields: * t3ver_state = 3 (move placeholder) * t3ver_oid = 0 no connected live record, it allowed fetching these records with one query together with live records as db restrictions t3ver_oid > 0 * t3ver_wsid = workspace UID * t3ver_move_id = UID of the live record * pid = new PID the version was moved to * sorting - when a record was moved within page with activated sorting Other record fields were not important. However, when moving a record, the value from TCA ctrl section "shadowColumnsForMovePlaceholders" was used to fill in gaps from the live record. The ACTUAL versioned record was indicated by t3ver_state = 4, the so-called "MOVE POINTER". In previous version until TYPO3 v10, it's PID field was set to -1, but since TYPO3 v10, it has the same PID as the "MOVE PLACEHOLDER". Characteristics of the move pointer as of TYPO3 v10: * t3ver_state = 4 (move pointer) * t3ver_oid = UID of the live record * t3ver_wsid = workspace UID * t3ver_move_id = 0 * pid = PID the version was moved to * sorting - same value as the live record (not evaluated until now) * All other fields with optionally modified content Both move placeholder and move pointer did not know each other directly. Fetching the move pointer for a move placeheldor (or the other way around) involved the live record, leading to many queries. The patch obsoletes the move placeholder records, moving necessary information to the move pointer: It now contains the updated sorting and is considered in the Database Restrictions to be fetched. In general, when publishing, the moved record now behaves identical to the other versioned types. This makes the internal code much easier, creates less DB queries on read + write and leads to less DB records in the database. The change removes creation of move placeholders, and considers the move pointers when evaluating sorting and PID in DataHandler. Read functionality from BackendUtility and PageRepository don't need an additional step to fetch the live version of a move placeholder anymore. An upgrade wizard takes existing move placeholders (state=3), updates pid+sorting (PID generally not needed, just to be sure) of the move pointer (state=4) and then deletes the move placeholder. TCA definition $TCA[my-table][ctrl][shadowColumnsForMovePlaceholders] is not needed anymore and removed by an auto TCA migration. Finally, workspace enabled tables do not need the t3ver_move_id field anymore: The live record UID is already in t3ver_oid field for state=4 records, just like with all other versioned records. The field will be fully removed with a separate patch in order to keep the actual CSV tests readable for this patch. Resolves: #92497 Releases: master Change-Id: I206336aec8be8a324fefdfd69f648f5a298c6ad1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65797 Tested-by:Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 02 Oct, 2020 2 commits
-
-
Resolves: #92475 Releases: master Change-Id: I9586e9602d54f36abd9474e7506a5697aad88dfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66001 Tested-by:
-
With #92133 the translation and localization behaviour within recordlist was streamlined. Thereby some changes were made that led to unexpected changes. These are now fixed. The LocalizationPanel is not shown anymore for records which are already localized in all possible languages, are in free mode or have sys_language_uid -1 set. This is achieved by taking the TranslationConfigurationProvider::translationInfo() result into account again. The indentation of the "Localization" column on localized rows is added again. Furthermore, a misbehaviour is fixed in which the rows' l18n_parent field was checked directly instead of the defined transOrigPointerField field. As a result, the indentation was only applied to tt_content rows as this is the only core table having l18n_parent as transOrigPointerField configured. Resolves: #92447 Relates: #92133 Releases: master Change-Id: Ib9cc5af0bddc40d1546224e4b886135bda125a3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65961 Tested-by:
-
- 27 Sep, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Resolves: #92172 Releases: master, 10.4 Change-Id: I9c01e01e6d085acc5e9399ba307b082436bb34b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65905 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 26 Sep, 2020 1 commit
-
-
Use a fluid template to render the field selection. Releases: master Resolves: #92411 Change-Id: I46a6410873665f061a1607fb82ea8ddfd8974aa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65877 Tested-by:
-
- 25 Sep, 2020 1 commit
-
-
Replace BackendUtility::getLinkToDataHandlerAction and use the uriBuilder instead. Releases: master Resolves: #92407 Change-Id: I96b2f1698aa5dcf056fa24fd548c01cc3fb4ce6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65873 Tested-by:
-
- 20 Sep, 2020 1 commit
-
-
Show only the default table columns, if no columns are set (backend user configuration). Resolves: #92347 Related: #92154 Releases: master Change-Id: Ib1406a4b693515d1ea799d591657a301c10bb29a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65792 Tested-by:
-
- 18 Sep, 2020 1 commit
-
-
Use `editContentPermissionIsGranted()` to calculate the permission to cut records (except pages). Releases: master Related: #89465 Resolves: #92307 Change-Id: I387c486c3814c3e5b6f4959d6c725ff59562c32e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65736 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 17 Sep, 2020 1 commit
-
-
The classes `firstcol` and `lastcol` for the first and last row of a table were not used anymore. Therefore, they have been removed. As the property `totalRowCount` was only used to set the class `lastcol`, it also has been removed. Releases: master Resolves: #92302 Change-Id: I12873b4604a165743a83019a123a72eb75b039a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65732 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
- 08 Sep, 2020 5 commits
-
-
Streamline translation fetching: To get a better overview, the fetching of the translations for each record has been moved to the `getTable()` method. Therewith, the main translation related queries are together, as the workspace overlay is already there. The translations are now handed over to the methods that render the list of records. This allows to remove the properties `translations` and `selFieldList` as the fields to select are already in the `getTable()` method and the translation must no longer be transferred back to the `getTable()` from the `makeLocalizationPanel()` method. Furthermore, this also avoids a db query for each translated record (in strict translation mode). Previously, a query with an always empty result set was in place. Streamline localization (all records excluding pages): The localization of each record (excluding pages) depends on the available languages of the site configuration and the already translated pages. This information is collected in the `getPossibleTranslations()` method, which depends on the current page uid and replaces the `initializeLanguages()` method. It is used to set the possible translations to the `possibleTranslations` property in the `start()` method. The property `possibleTranslations` replaces the properties `pageOverlays` and `systemLanguagesOnPage`. Streamline localization for pages: The localization of page records does not depend on the translation status of the parent page, because otherwise the first translation of one page would not be possible. The restriction for the page translations is now the same as in the `languageSelector()`. Streamline `makeLocalizationPanel()` method: This method is now only used to create the possible localization buttons. Releases: master Resolves: #92133 Change-Id: Iaf5f9f8cee795c4245d8201b20617df5d95570a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65505 Tested-by:
-
In order to be consistent with other views, the backend user's avatar and name is displayed instead of the uid. Releases: master Resolves: #92227 Change-Id: I585f5d851352822bee2909d92259942eadfcefe8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65634 Tested-by:
-
After the removal of TCA [ctrl][thumbnails] in #92118, the method 'getVisibleColumns()' isn't used any more. Therefore, it has been removed. Releases: master Resolves: #92226 Change-Id: Iff0ad528e96a0f89fc1f59d9728d9a96374f793f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65629 Tested-by:
-
The property `showIcon` was always 1. Therefore, it has been removed. Releases: master Resolves: #92211 Change-Id: I852bc2c007f77522b3b80423f92f28a5be3c22b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65591 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Releases: master Resolves: #92210 Change-Id: Ie8c160fae548ae8cf013200e4a6d2e6344244f23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65590 Tested-by:
-
- 05 Sep, 2020 2 commits
-
-
The `fieldArray` related configuration has been moved to the `getTable` method. The configuration handling for the `fieldArray` has been changed, in order to avoid later unset on the `fieldArray`. The `fieldArray` is only in the `getTable` and subordinated render methods. Therefore, the implicit configuration transfer like `fieldArray[0]` for the label column has been replaced. Releases: master Resolves: #92154 Change-Id: I04287e90e8cffc2ab768bd5399a8155f823fdfe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65534 Tested-by:
-
The backend shortcut / bookmark handlig API was designed to hand over relevant get/post arguments as key only (eg. 'id'). The underlying code then pulled values from GET/POST or from SOBE->MOD_SETTINGS. This is ugly, there shouldn't be such magic: Only controllers know relevant keys and values, so it should hand them over directly to the shortcut API. The patch changes this: * Old and unused ViewHelper f:be.buttons.shortcut is deprecated. * ViewHelper be:moduleLayout.button.shortcutButton deprecates argument 'getVars' and adds new argument 'arguments'. * Class ShortcutButton has a new setter 'setArguments' that accepts all relevant argument key/value pairs to create a shortcut. Existing get/set related methods are deprecated. * Helper methods 'makeShortcutIcon' and 'makeShortcutUrl' of class ModuleTemplate are deprecated and implemented in class ShortcutButton directly. * All core usages are adapted to new API. * Shortcut handling was the last core usage of SOBE, so last $GLOBALS['SOBE'] = $this assignments can be finally removed. Impact: * Shortcuts to modules not directly reachable via main menu do not work due to limits of the module registration API. An example is the 'create multiple pages' controller. This issue exists before the patch, affected controllers no longer render a shortcut button for now. * The old code usually added the 'route' argument twice for shortcuts. This has been resolved. As a side effect, the comparison if a shortcuts exists (yellow shortcut icon) fails currently for existing shortcuts when the patch is applied: The comparison relies on direct string equality since shortcuts always store the final url in the database. This storage strategy should be changed with another patch that will solve the 'no yellow icon' issue at the same time. Change-Id: I3ccd2b8f6adab8e7780c5f9911fdea013ccfa99b Resolves: #92132 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65503 Tested-by:
-
- 04 Sep, 2020 1 commit
-
-
The method `listURL()` is used to set the `returnUrl` for all actions in the `DatabaseRecordList`. It replaces the usages of the method `makeReturnUrl`. Therefore, this method has been removed. Furthermore, `GeneralUtility::getIndpEnv('REQUEST_URI')` has been replaced by `listURL()`. This leads to a consistent behaviour after performing any kind of action in the `DatabaseRecordList`. Releases: master Resolves: #92192 Resolves: #83758 Change-Id: I2dc84a2c4e4103d5b4e77ebb646158e8c15f3202 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65574 Tested-by:
-
- 03 Sep, 2020 1 commit
-
-
The Permission class unnecessarily had been implemented as Enumeration although the features of the Enumeration base class hadn't been used. As the Permission class only handles boolean flags, it is now implemented as bit set, which improves the performance in comparison to Enumeration classes. Releases: master Resolves: #89465 Change-Id: I73eff34090a7ea8e02f7d538e2db52045c86d438 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099 Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 30 Aug, 2020 4 commits
-
-
The TCA configuration `searchFields` in the `ctrl` section has been introduced in TYPO3 4.6. This configuration allows setting the search columns. Those columns are taken into account by the search in the TYPO3 backend. To enable a smooth transition between TYPO3 4.5 and 4.6, the hook `$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['mod_list'] ['getSearchFieldList']` has been introduced as well. It allows to set the `searchFields` for the list module's search. As this transition should be finished now, the hook has been removed. Extension authors are encouraged to set the `searchFields` via the TCA configuration. Releases: master Resolves: #92128 Change-Id: I3afef4f248797345e4feac14a10a7c7797bc86e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65502 Tested-by:
-
The property `HTMLcode` was only used to collect the output for the tables in `generateList()`. Therefore, `generateList()` returns the collected output and the property `HTMLcode` has been removed. Releases: master Resolves: #92130 Change-Id: I938174a4f25b08281b54883c7f0f3cf62c70c9f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65504 Tested-by:
-
The following items have been removed as they haven't any impact: * `_LOCALIZATION_` * `_CLIPBOARD_` * `_CONTROL_` `_LOCALIZATION_` and `_CLIPBOARD_` are always filtered out. `_CONTROL_` is always added, if not selected in the field selection. Furthermore, the `ctrl` values `tstamp` and `crdate` could be added by any user regardless of the column name (respecting the configuration in TCA). Finally, the column showing the references is added, if selected. Releases: master, 10.4 Resolves: #80396 Change-Id: Ie809a0e6f76e62166dc2d6f9cecfb3c68750e70e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65501 Tested-by:
-
The properties `iLimit` and `totalItems` were only used in the `getTable()` method and in subordinated methods for the pagination. Therefore, they have been replaced by local variables. Releases: master Resolves: #92127 Change-Id: Idb3db75a3f0da62d594cb1a4eadde5c15d5b7a8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65500 Tested-by:
-
- 28 Aug, 2020 5 commits
-
-
The actual limit, used in the getTable(), depends on various configurations, current view (default view, single table view) and current action (view, search or csv export). To get a better overview, the patch moves limit handling to the getTable() method, so limit handling in start() and generateList() can be removed. The properties itemsLimitPerTable and itemsLimitSingleTable are removed as well. The configured limit (excluding search and CSV export) is now forced to be in a range from 5 to 10000. For translated pages, the pages configuration is used to set the limit. The limit is set by the following chain: [default view with multiple tables; single table view] - default value [20; 100] - if page ts config is set [itemsLimitPerTable; itemsLimitSingleTable] - if tca configuration is set [maxDBListItems; maxSingleDBListItems] - a forced range from 5 to 10000 - if limit is set in the search - no limit for a csv export Releases: master Resolves: #92103 Change-Id: I823c039aa063df8f99e08e190990c5e34466c253 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65461 Tested-by:
-
The property `fixedL` was only used once (see `ElementBrowserRecordList`, `BackendUtility::getRecordTitlePrep`). The removal of the second parameter `fixedL` in `getRecordTitlePrep` hasn't changed the behaviour, as the backend user's UC `titleLen` is used as default constraint anyway. Therefore, the property `fixedL` has been removed. Releases: master Resolves: #92114 Change-Id: Ib15a268e3c81f72737a310c71fc3800b13288c30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65470 Tested-by:
-
The property `counter` is not used anymore, so it's getting removed. Releases: master Resolves: #92115 Change-Id: I009bb526e025a47f48bd1eb417eb0fff666a9f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65471 Tested-by:
-
The information about the page record is only needed in the `addPageIdConstraint` method. The information is now collected there and the property `pageRecord` has been removed. Releases: master Resolves: #92116 Change-Id: I3f96f52b58441e85d60a2bc4d70a9bc5ff9f4d5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65492 Tested-by:
-
When a record that exists in live is deleted in a workspace, a new 'delete placeholder' record is created in the workspace. This record is used to mark the live workspace record as 'to be deleted' when the workspace is published. Those delete placeholder are not shown in the page tree and not in the page module. The page / element is simply gone. Only the list module renders those records. This is confusing usability wise: A user clicks on 'delete' in list module, reloads the module, and the record is back again. Additionally, there is an even more confusing mechanism: The 'waste' icon is substituted by a different icon called 'restore'. 'restore' however does not actually restore changes that may have been done to the record in the workspace before, instead it simply sets the delete placeholder record to deleted, which makes the underlying live record 'shine through' in the workspace again. Interacting with delete placeholder records is also useless, for instance edited content of delete placeholder records is always gone in the end. So most action icons don't make sense. Looking at the lifecycle of workspace records, there are only two final results: A change is either discarded, or is published to live. This is managed exclusively in the workspace module. Having the third option 'restore' in the list module - that is basically the same as discarding a delete placeholder in workspace module - is very confusing. The best option would be to not render delete placeholder rows in the list module at all. Unfortunately this can't be done due to the workspace overlay mechanics: Especially the count and limit / pagination handling in list module is done on db level before the module knows that certain rows shouldn't be rendered. We need to have some serious refactoring before this can be solved. For now, the solution is to still render delete placeholder records in list module, to 'strike through' their title (similar to workspace module) and to disable all control icons and the click menu on them. This way the final fate of a delete placeholder can be decided only in the workspace module - just like all other workspace records. Change-Id: Id8a95c41f2bbe90ea68f40e376a4d36d3a2019b8 Resolves: #90679 Resolves: #52700 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65495 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- 27 Aug, 2020 1 commit
-
-
Setting TCA[$someTable]['ctrl']['thumbnail'] to some image related column made the list module show attached images as preview. Until core v8, this has been used for tt_content and has been dropped for this table because two different fields (images, media) are used and the setting could not cope with that. For extensions with own tables, this setting has been used very seldom. It also partially destroys the list module view. The patch drops evaluation of this ctrl setting in the list module. With this gone, the 'thumbnailsByDefault' setting of the user settings module only affects the file list module. The file list module has it's own checkbox to toggle image preview rendering, so the setup module checkbox has little benefit and is removed as well. This additionally fixes a bug that thumbnail preview rendering in file list module can't be turned off if the setup module checkbox is set. Additionally, the patch drops some unused css for the list module, 'typo3-dblist' simply does not exist as class. Change-Id: If9365b5a26e708cc4d4d57cfcddd728cf97d7811 Resolves: #92118 Related: #79622 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65493 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
- 25 Aug, 2020 2 commits
-
-
Do not allow creating new records after translated records in the connected translation mode. Furthermore, disable cut, copy and paste for translated records in the connected translation mode. Finally, disable move records in the connected translation mode. Releases: master, 10.4 Resolves: #92084 Change-Id: I3a8bc68f572984d6c01a18719223a1e23a9034a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65445 Tested-by:
-
The internal property oddColumnsCssClass is always empty. So it has been removed. Releases: master Resolves: #92085 Change-Id: I909fb72ea6e5edfdf321b8971f68484c41b990c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65446 Tested-by:
-
- 23 Aug, 2020 1 commit
-
-
Since the bugfix #92075 the internal property pageinfo isn't used anymore. Releases: master Resolves: #92076 Change-Id: I9e21b9ac0e789b3a7554b4e103815646c166a93a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65436 Tested-by:
-
