Skip to content
GitLab
Switch branch/tag
  1. 04 Jan, 2021 2 commits
  3. 27 Sep, 2020 1 commit
  5. 25 Sep, 2020 1 commit
  7. 18 Sep, 2020 1 commit
  9. 08 Sep, 2020 1 commit
    • Daniel Windloff's avatar
      [TASK] DatabaseRecordList: Streamline translation and localization · 21f738cb
      Daniel Windloff authored and Christian Kuhn's avatar Christian Kuhn committed 
      Streamline translation fetching:
To get a better overview, the fetching of the translations for each
record has been moved to the `getTable()` method.
Therewith, the main translation related queries are together, as the
workspace overlay is already there.
The translations are now handed over to the methods that render the
list of records.
This allows to remove the properties `translations` and `selFieldList`
as the fields to select are already in the `getTable()` method and
the translation must no longer be transferred back to the `getTable()`
from the `makeLocalizationPanel()` method.
Furthermore, this also avoids a db query for each translated record
(in strict translation mode). Previously, a query with an always empty
result set was in place.

Streamline localization (all records excluding pages):
The localization of each record (excluding pages) depends on the
available languages of the site configuration and the already
translated pages.
This information is collected in the `getPossibleTranslations()` method,
which depends on the current page uid and replaces the
`initializeLanguages()` method.
It is used to set the possible translations to the `possibleTranslations`
property in the `start()` method.
The property `possibleTranslations` replaces the properties
`pageOverlays` and `systemLanguagesOnPage`.

Streamline localization for pages:
The localization of page records does not depend on the translation status
of the parent page, because otherwise the first translation of one page
would not be possible.
The restriction for the page translations is now the same as in the
`languageSelector()`.

Streamline `makeLocalizationPanel()` method:
This method is now only used to create the possible localization
buttons.

Releases: master
Resolves: #92133
Change-Id: Iaf5f9f8cee795c4245d8201b20617df5d95570a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65505

Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      21f738cb
  11. 05 Sep, 2020 1 commit
    • Christian Kuhn's avatar
      [!!!][TASK] Refactor create bookmark handling · 5be7b805
      Christian Kuhn authored and Anja Leichsenring's avatar Anja Leichsenring committed 
      The backend shortcut / bookmark handlig API was designed to
hand over relevant get/post arguments as key only (eg. 'id').
The underlying code then pulled values from GET/POST or from
SOBE->MOD_SETTINGS. This is ugly, there shouldn't be such
magic: Only controllers know relevant keys and values, so
it should hand them over directly to the shortcut API.

The patch changes this:
* Old and unused ViewHelper f:be.buttons.shortcut is deprecated.
* ViewHelper be:moduleLayout.button.shortcutButton deprecates
  argument 'getVars' and adds new argument 'arguments'.
* Class ShortcutButton has a new setter 'setArguments' that
  accepts all relevant argument key/value pairs to create a
  shortcut. Existing get/set related methods are deprecated.
* Helper methods 'makeShortcutIcon' and 'makeShortcutUrl' of
  class ModuleTemplate are deprecated and implemented in class
  ShortcutButton directly.
* All core usages are adapted to new API.
* Shortcut handling was the last core usage of SOBE, so last
  $GLOBALS['SOBE'] = $this assignments can be finally removed.

Impact:
* Shortcuts to modules not directly reachable via main menu
  do not work due to limits of the module registration API. An
  example is the 'create multiple pages' controller. This issue
  exists before the patch, affected controllers no longer render
  a shortcut button for now.
* The old code usually added the 'route' argument twice for shortcuts.
  This has been resolved. As a side effect, the comparison if a
  shortcuts exists (yellow shortcut icon) fails currently for existing
  shortcuts when the patch is applied: The comparison relies on
  direct string equality since shortcuts always store the final url in
  the database. This storage strategy should be changed with another
  patch that will solve the 'no yellow icon' issue at the same time.

Change-Id: I3ccd2b8f6adab8e7780c5f9911fdea013ccfa99b
Resolves: #92132
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65503

Tested-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez's avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      5be7b805
  13. 03 Sep, 2020 1 commit
  15. 30 Aug, 2020 2 commits
  17. 28 Aug, 2020 2 commits
  19. 27 Aug, 2020 1 commit
    • Christian Kuhn's avatar
      [!!!][TASK] Drop TCA [ctrl][thumbnail] and user uc[thumbnailsByDefault] · ae39eb5a
      Christian Kuhn authored and Anja Leichsenring's avatar Anja Leichsenring committed 
      Setting TCA[$someTable]['ctrl']['thumbnail'] to some image related
column made the list module show attached images as preview.
Until core v8, this has been used for tt_content and has been
dropped for this table because two different fields (images, media)
are used and the setting could not cope with that.
For extensions with own tables, this setting has been used
very seldom. It also partially destroys the list module view.

The patch drops evaluation of this ctrl setting in the list module.
With this gone, the 'thumbnailsByDefault' setting of the user settings
module only affects the file list module. The file list module has
it's own checkbox to toggle image preview rendering, so the setup module
checkbox has little benefit and is removed as well. This additionally
fixes a bug that thumbnail preview rendering in file list module can't
be turned off if the setup module checkbox is set.

Additionally, the patch drops some unused css for the list module,
'typo3-dblist' simply does not exist as class.

Change-Id: If9365b5a26e708cc4d4d57cfcddd728cf97d7811
Resolves: #92118
Related: #79622
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65493

Tested-by: Achim Fritz's avatarAchim Fritz <af@achimfritz.de>
Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: Daniel Windloff
Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Achim Fritz's avatarAchim Fritz <af@achimfritz.de>
Reviewed-by: Daniel Windloff
Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      ae39eb5a
  21. 01 Jun, 2020 1 commit
  23. 22 Apr, 2020 1 commit
  25. 15 Apr, 2020 1 commit
  27. 14 Apr, 2020 2 commits
  29. 28 Feb, 2020 1 commit
  31. 14 Feb, 2020 1 commit
  33. 18 Jan, 2020 1 commit
  35. 09 Nov, 2019 1 commit
  37. 10 Oct, 2019 1 commit
  39. 04 Sep, 2019 1 commit
  41. 05 Aug, 2019 1 commit
  43. 31 Jul, 2019 1 commit
  45. 30 Jul, 2019 1 commit
  47. 13 Jul, 2019 1 commit
  49. 12 Jul, 2019 1 commit
  51. 05 Jul, 2019 1 commit
  53. 09 Jun, 2019 1 commit
  55. 08 Jan, 2019 1 commit
  57. 01 Oct, 2018 1 commit
  59. 30 Sep, 2018 1 commit
  61. 29 Sep, 2018 1 commit
  63. 28 Sep, 2018 1 commit
  65. 09 Sep, 2018 1 commit
  67. 02 Sep, 2018 1 commit
  69. 22 Aug, 2018 1 commit
  71. 22 Jun, 2018 1 commit