- 04 Jan, 2021 1 commit
-
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- 19 Oct, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92579 Change-Id: I488edd51d9af44107969335b8f955cb69734c42b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66158 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 07 Oct, 2019 1 commit
-
-
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- 14 Mar, 2019 1 commit
-
-
This patch splits the FormEngine.js into smaller, logically separated parts. This increases readability and maintainability and has a positive effect on the client's performance as only the required code is loaded. Not every aspect of the FormEngine JavaScript is handled here yet, since other areas, e.g. IRRE, need refactoring as well. Resolves: #87324 Releases: master Change-Id: I6704445254a524f8ed3152ab6b0b7105fb97d65a Reviewed-on: https://review.typo3.org/c/58608 Tested-by:
André Schließer <andy.schliesser@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
André Schließer <andy.schliesser@gmail.com>
Reviewed-by:
-
- 11 Aug, 2018 1 commit
-
-
Reduce the HTML of a record form by rendering divs of wizards only if those are required. Resolves: #85577 Releases: master Change-Id: I6ca6ad5c3ebd1a1aa949a9a0349bd7894e4532df Reviewed-on: https://review.typo3.org/57614 Reviewed-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
- 18 Jul, 2018 1 commit
-
-
When the site configuration module has been introduced, it came with a custom functionality to show an additional help text when editing site records between the field label and the field input. This useful feature is now changed into a general TCA feature available everywhere: A new field information node expansion / "wizard" is added to all form elements, the inline and flex containers: If the property "description" is set for a TCA column type (same array level as "label", it will show the value as localized string between the field label and the input section. There are three available render types for "wizard a-like" output: * Field information - text between label+field * Field control - buttons next to input sections like the link popup button * Field wizards - clickable stuff below the input section, for example the localization state selector If a field has been set to readOnly=true in TCA, field control and field wizards do not make sense to render since they are meant to act with the field value. The field information node however has only informational character which is useful for readOnly fields, too. Thus, this node expansion type is now the only one that is always rendered, even if a field has been set to readOnly. Note this patch is fully covered by ext:styleguide (master) to have examples for all changed elements now using the description property. Resolves: #85410 Releases: master Change-Id: Idcfacafa19b8208614b653b8fac22ce47bca3b8f Reviewed-on: https://review.typo3.org/57397 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
- 17 May, 2018 1 commit
-
-
When useOrOverridePlaceholder mode is used for TCA input type, use opt-in for the checkbox when placeholder is empty. In some cases, the placeholder can be empty. Especially when the placeholder uses data from another field. When information is added to the corresponding field, the input field does not take this in account because the override checkbox is set by default. This can lead to problems for title and alternative fields in the sys_file_metadata table. When adding a file reference and setting the title or alternative field afterwards in the original file, the reference is still using the empty override from file reference. Resolves: #84563 Releases: master, 8.7 Change-Id: I84a37d55a48464b6249fc8bcee405a7cd909016a Reviewed-on: https://review.typo3.org/56486 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- 25 Apr, 2018 1 commit
-
-
This commit moves any language file of EXT:lang into a proper destination, which renders EXT:lang obsolete. This change requires an update of typo3/testing-framework, done with this command: composer update typo3/testing-framework Resolves: #84680 Releases: master Change-Id: I7ba59c1a10015121ed444a9c98082bad0348e03d Reviewed-on: https://review.typo3.org/56017 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
- 01 Apr, 2018 1 commit
-
-
Show the description as a placeholder when an image is added as a reference. Resolves: #81235 Releases: master, 8.7 Change-Id: I75363f74ba72bf4fd95b2a2e9a2a061ad250f825 Reviewed-on: https://review.typo3.org/56438 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 22 Nov, 2017 1 commit
-
-
Add for/id so clicking the label toggles the checkbox. Resolves: #83040 Releases: master, 8.7, 7.6 Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326 Reviewed-on: https://review.typo3.org/54715 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 20 Apr, 2017 1 commit
-
-
Christian Kuhn authored
Resolves: #80913 Releases: master Change-Id: I151fbf7a02df3e4713d623eb1659ac35ae2cb35a Reviewed-on: https://review.typo3.org/52490 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
- 11 Feb, 2017 1 commit
-
-
Resolves: #79729 Releases: master Change-Id: I689e8ecd0ffa2d005931e6162fb8df5d9694da3d Reviewed-on: https://review.typo3.org/51629 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
- 07 Feb, 2017 1 commit
-
-
This feature introduces a new functionality called "allowLanguageSynchronization" which can be set on a field configuration of a TCA column. This is the successor of "l10n_mode=mergeIfNotBlank" as the old option had several conceptual downsides: 1) "mergeIfNotBlank" took the value of the default record during runtime, but only if the translation field was empty. This means it was not possible to see what the record actually contained without having all fields of the parent at hand. 2) It was not possible to have a value "santa" in the original record but remove the option in a translation (because an empty string "" implicitly triggered the runtime call in the frontend) 3) "mergeIfNotBlank" did not work on relations except for files fetched via the FileRepository API calls, but for no other inline elements. 4) "mergeIfNotBlank" did the overlay functionality in the frontend, but only FormEngine and DataHandler took care of the option. Custom backend modules had to implement the same functionality. 5) In FormEngine, there was an icon in the translation record that if the record kept empty the value of the original language was taken, but this is not optimal in terms of usability. 6) "mergeIfNotBlank" did not take the new l10n_source option into account, where localizations could be made from other records than the default language "0". The new feature can be set on any TCA column setting: $GLOBALS['TCA'][<table-name>]['columns'] [<field-name>]['config']['behaviour'] ['allowLanguageSynchronization'] = true; This brings an option to records with translations (both from l10n_parent and l10n_source) to have the value for all translations synchronized or explictly have a checkbox to use a custom value. The information whether a field is custom filled, or kept in sync from l10n_parent/l10n_source is stored in a separate field called "l10n_state" inside the database. The introduced upgrade wizard and TCA migration to remove "l10n_mode=mergeIfNotBlank" has been modified to migrate to this option and add a l10n_state database field if a TCA table used "mergeIfNotBlank" but did not add the l10n_state field manually via ext_tables.sql yet. New extensions can easily use the new option right away, extensions that need to stay compatible with v7 and v8 can add both options right away to have the same output. The main goals to achieve with this change is now: * Have consistent database values for all records regardless of l10n_mode=mergeIfNotBlank paving the way to fetch translated records without having to overlay (once l10n_mode=exclude is also copying values and relations) * Be more explicit for editors about records that have a different or the same state as their l10n_parent/l10n_source as a benefit for bigger instances with a lot of languages * Avoid hidden magic when retrieving localized records in the TYPO3 Frontend. Resolves: #79658 Related: #79243 Releases: master Change-Id: I6c2dbfeb09b47f958a536c9ab050c24ba4bbcbbd Reviewed-on: https://review.typo3.org/51291 Tested-by:
-
- 31 Jan, 2017 1 commit
-
-
Remove additional lines around the actual content of a textarea. Resolves: #79573 Releases: master Change-Id: I636afb0ec63d34d4a209caeaa1369bc65727665d Reviewed-on: https://review.typo3.org/51490 Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
-
- 26 Jan, 2017 1 commit
-
-
Christian Kuhn authored
The patch introduces a new API on FormEngine element level that substitutes the old "wizards" / renderWizard() API with a more powerful system. Single wizards are now split into one of three categories: * An informational wizard * A control button / icon * A true wizard with additonal functionality Method renderWizards() is still called in elements for compatibility reasons if people added own scrip/popup/userFunc wizards, but all core wizards are migrated. The patch significantly cleans the HTML of single elements, especially HTML stuff that was added by the SingleFieldContainer is now put down to single elements, while main HTML wraps formerly done by renderWizards() is fetched "up" to single elements. This gives single elements full control about the main HTML it is producing, which is a must have preparation in order to further advance in this area and to switch single elements to fluid rendering in one of the next steps. The patch brings a pretty huge list of TCA changes and simplifications, all TCA changes are supported by TCA migration, so existing extensions should benefit out of the box and just get deprecations logged. Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab Resolves: #79440 Resolves: #70032 Releases: master Reviewed-on: https://review.typo3.org/51151 Tested-by:
-
- 01 Dec, 2016 1 commit
-
-
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
-
- 09 Oct, 2016 1 commit
-
-
Resolves: #77819 Releases: master Change-Id: If39540863a1114ce5ce3e57289da54bdfdffc4f2 Reviewed-on: https://review.typo3.org/49764 Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Reviewed-by:
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 17 Apr, 2016 1 commit
-
-
In TYPO3 6.2 palette fields have been handled by an individual on-focus DOM events, depending on a particular user setting. During the FormEngine rewrite with TYPO3 CMS 7, these parts have been kept and transported through the system. Since this information is not used anymore, it can be removed without any substitution. Resolves: #75657 Releases: master Change-Id: I7ab55d3f38b8f34e85027cdbbe8d5850f91dddb5 Reviewed-on: https://review.typo3.org/47699 Reviewed-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
-
- 17 Jan, 2016 1 commit
-
-
Add the data-formengine-input-name attribute to FormEngine TextElements so that the wizards can locate it. As the textareas don't differentiate between human readable and hidden fields add a check to the tbe change handler if the form field and the human readable field are identical and skip triggering the change event again. Resolves: #71679 Releases: master, 7.6 Change-Id: I69e6a4f3e9f19c68bd02a0029322d52323286194 Reviewed-on: https://review.typo3.org/46032 Reviewed-by:
-
- 20 Nov, 2015 1 commit
-
-
Resolves: #71726 Releases: master Change-Id: I4a356c8da668acee555149eee9cf56ccdb4dc0ee Reviewed-on: https://review.typo3.org/44822 Reviewed-by:
-
- 24 Oct, 2015 1 commit
-
-
Resolves: #70977 Releases: master Change-Id: I4a0c4f998452fc832d724cad22d84765eb522c63 Reviewed-on: https://review.typo3.org/44248 Reviewed-by:
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- 05 Oct, 2015 1 commit
-
-
Resolving of placeholder for field types text and input has been moved from the element rendering into the form data providers. The data provider approach allows reuse of existing providers and data groups and reduces the amount of database queries by having access to previously parsed data. Resolves: #70370 Resolves: #70146 Resolves: #70297 Releases: master Change-Id: I05fa2c6d3237e65627cae74811d1a9202e3ac0c8 Reviewed-on: http://review.typo3.org/43748 Reviewed-by:
-
- 14 Sep, 2015 1 commit
-
-
Change-Id: I0db183c873b16607a55683f195da5cf25ff6fff5 Resolves: #69787 Releases: master Reviewed-on: http://review.typo3.org/43297 Reviewed-by:
Thorsten Bringewatt <t.bringewatt@mittwald.de> Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 12 Sep, 2015 1 commit
-
-
This patch add the function StringUtility::getUniqueId() which gets an unique id (with using more entropy for Windows users) and removes the included dot to be able to use the generated id in HTML as the dot is an invalid character in some tag attributes e.g. id. Resolves: #69730 Releases: master Change-Id: Ic8a83df0a8b02f6778f0f5588d237379d909b59e Reviewed-on: http://review.typo3.org/43244 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- 08 Sep, 2015 1 commit
-
-
Christian Kuhn authored
tl;dr: This patch makes FormEngine insanely flexible, extensions however should not rely on structures for now, since class names and array content will change. The patch applies a separation of concerns to the FormEngine class structure by extracting the data processing from rendering. As a main goal the render part consisting of container and element classes routed through the flexible NodeFactory only works on data created by the new FormDataCompiler class construct. This makes the FormEngine much more flexible and opens ways to not only use the render part in the context of database driven data, but on anything that is fed to it. This patch creates the main structure for this. The FormDataCompiler class returns a defined array container and elements can work on it. Data is added by single FormDataProvider, which are combined in FormDataGroups. FormDataProvider may depend on each other and a FormDataGroup "knows" its providers and calls them in a dedicated order. For instance, the "FullDatabaseRecord" FormDataGroup first calls a provider that fetches the record defined by uid and table name and a later called provider determines the given record type this record is assigned to, so another provider can then work on TCA to determine the list of record fields to be shown. The FormDataProvider used for the main FormDataGroup are defined in TYPO3_CONF_VARS, so extensions can add and remove their own providers to add or change certain data if needed. This is highly flexible and extensions are able to hook in at a specific position within the provider chain for the main data groups. This construct obsoletes the DataPreprocessor as well as several other side classes. With this patch the main architecture is created and lots of data preparation is transfered already, supported by a high unit test coverage. The FormEngine class itself is removed: The inline ajax entry point is moved to an own controller class, the getMainFields() and friends methods are substituted with FormDataCompiler / NodeFactory combinations and the data gathering is for now parked in a FormResultCompiler class. However, this process is not yet finished and lots of @todo statements are added to the code base to document open ends and to further separate the data handling from the render engine. Especially the IRRE data handling is currently still located within the render engine and makes the whole thing much more complicated than it should be. Lots of detail patches need to follow to bring this code to a level where it belongs to be. Warning: While this patch is already insanely huge touching more than 22 thousands lines of code, lots of loose ends need to be tackled and the API is not final yet. The arrays will be reduced and sharpened during the next weeks, class names may change and structures will change. Change-Id: Ief1769f478373cc26d1bf6c49114258f0dae8355 Resolves: #69568 Releases: master Reviewed-on: http://review.typo3.org/41933 Reviewed-by:
Florian Peters <fpeters1392@googlemail.com> Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
- 14 Jul, 2015 2 commits
-
-
The functionality provided by _HIDDENFIELD and hideParent on TCA wizard level can be better realized with the new renderType registration provided by the NodeFactory. A search showed that not a single TER extension used the two options, and it is probably also used very rarely in other 3rd party extensions. It is dropped now without substitution. Resolves: #68092 Releases: master Change-Id: I95fb96561e1879e302ba927d70d72bd454b7fa15 Reviewed-on: http://review.typo3.org/41150 Reviewed-by:
-
Benni Mack authored
Resolves: #68098 Releases: master Change-Id: Ice78388b6e39886bb3f2be13701d4b85f01f3967 Reviewed-on: http://review.typo3.org/41157 Reviewed-by:
-
- 26 Jun, 2015 1 commit
-
-
This patch removes the required images and adds CSS based styling for required fields and minitems/maxitems validation. Resolves: #67354 Releases: master Change-Id: I5dbccb1c84035fa21079b09748c767bc4f3d06d0 Reviewed-on: http://review.typo3.org/39302 Reviewed-by:
-
- 25 Jun, 2015 1 commit
-
-
Switch some hooks from getUserObj() to makeInstance() and rely on auto loading. Resolves: #67749 Releases: master Change-Id: Ib89e920fd50a40103a38eedb229382d547de62e1 Reviewed-on: http://review.typo3.org/40621 Reviewed-by:
-
- 03 Jun, 2015 1 commit
-
-
For details, see the ReST files with examples for new API and TCA changes. * Split TCA config "type" to "type" and "renderType": TCA config "type" is a technical debt since it both defines the database storage as well as the widget that is used to render a certain field in FormEngine. While "type" is kept, the render widget is now extracted to a "renderType". * t3editor uses this "renderType" now. type=text with renderType=t3editor will call the new T3editorElement provided by ext:t3editor, and falls back to TextElement if t3editor is not loaded. * t3editor is now enabled for "setup" and "constants" of sys_template records if opening the whole record. * t3editor now works when configured in a flex form. * Introduce an API in FormEngine NodeFactory to register new renderType, used by t3editor. * Introduce a resolver API in FormEngine NodeFactory to change the class that renders a widget or container. * Split TextElement into TextElement that only renders a textarea and RichTextElement provided by ext:rtehtmlarea that renders RTE. ext:rtehtmlarea uses the new resolver API to route rendering to its own class in case RTE is enabled and configured for a field. * In TCA section "types" a new array "columnsOverrides" is introduced that allows overwriting some column configurations of fields. Currently, this works for some View/FormEngine related settings like renderType and defaultExtras. * TCA Migration is introduced to dynamically rewrite TCA before it is put into cache. * TCA migration is called a second time in ext:compatibility6 in case TCA is still registered via ext_tables.php. This has performance penalty since it is done on every frontend and backend call. * TCA migration is also called dynamically for flex form definitions. * TCA migration moves configured t3editor wizards to type=text with renderType=t3editor. * TCA migration removes the 5th parameter "style pointer" from types showitem * TCA migration moves the 4th showitem parameter "extra configuration" to "defaultExtras" of "columnsOverrides" of given TCA type. Change-Id: Ia2c2bc16463a01021c7a6be765b4efa872a130fd Resolves: #67229 Releases: master Reviewed-on: http://review.typo3.org/39662 Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
- 18 May, 2015 1 commit
-
-
Christian Kuhn authored
Creation of container and elements instances in the FormEngine is hard coded and hard to overwrite or adapt. The patch extends the existing NodeFactory with resolver code to find an appropriate class for a given requested type. All FormEngine internal container and element requests are now routed through NodeFactory. This allows to loosen the strict dependency between TCA config "type" to an implementing class by moving the resolving code into the factory. This is done for SelectElement which is now split into multiple smaller classes - one for each display type. The NodeFactory is covered by unit tests since the resolving code will become more complex and fine grained in the future. As a side effect the patch resolves a hack in the FormDataTraverser which no longer calls internal stuff of the select element. The NodeFactory is prepared to be extended with an API for extensions to steer and overwrite default implementations. This will be added with a next patch. Change-Id: I2253a0fe3240366d0d271a3cd82119ce3dc52012 Resolves: #67006 Releases: master Reviewed-on: http://review.typo3.org/39517 Reviewed-by:
-
- 08 May, 2015 1 commit
-
-
Wouter Wolters authored
Resolves: #66849 Releases: master Change-Id: Iad61ca580344c9794d8ad19721c11689fc5a2e16 Reviewed-on: http://review.typo3.org/39347 Reviewed-by:
-
- 07 May, 2015 1 commit
-
-
There is a global counter in PHP to handle the sequence of RTE's in one form. This is given along a long everywhere but fits no real purpose. Parameter and usages are removed with the patch. Resolves: #63891 Releases: master Change-Id: If10be8773ff13e5965b594c3a94da210d1c0f782 Reviewed-on: http://review.typo3.org/39111 Reviewed-by:
-
- 01 May, 2015 1 commit
-
-
Resolves: #63843 Releases: master Change-Id: I4b736b76d4a8e92f54d0ec3961f93030737ffe39 Reviewed-on: http://review.typo3.org/35429 Reviewed-by:
-
- 28 Apr, 2015 1 commit
-
-
Christian Kuhn authored
This patch introduces a structural code refactoring to the FormEngine class and its related friend classes. FormEngine used to call itself over and over again with itself and sub classes writing to public properties of FormEngine keeping a global state that is then magically merged to sometimes working output. The patch introduces a tree approach with lots of small containers doing an encapsulated part of the rendering process and calling sub containers for inner details. As main construct a "globalOptions" array is modified in containers and given down to sub containers (tree knots) or elements (leaves), while sub structures always return a defined array that is merged by the parent and accumulates the full result. Goal is to have a better encapsulated code structure with better visible impact on changes done to this system. The patch creates this main structure. There is still a lot of mess around and additional patches can further improve the overall situation with smaller changes. Change-Id: I56b898dc0eaae8de4d31016997cfefe8d14ec53e Releases: master Resolves: #63846 Resolves: #63854 Resolves: #63856 Resolves: #63858 Resolves: #63859 Resolves: #63860 Resolves: #63861 Resolves: #63862 Resolves: #63863 Resolves: #63865 Resolves: #63876 Resolves: #63881 Resolves: #63882 Resolves: #63883 Resolves: #63893 Reviewed-on: http://review.typo3.org/38433 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
