- 04 Jan, 2021 1 commit
-
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- 19 Oct, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92579 Change-Id: I488edd51d9af44107969335b8f955cb69734c42b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66158 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 21 Mar, 2020 1 commit
-
-
When using the edit popup of SelectMultipleSideBySide editing is related to the items that are active and selected in the element. The old placement of the edit pencil however suggested that it should be possible to edit all (even inactive items, unrelated to the current record) elements. Whenever an editPopup is configured to be shown in a SelectMultipleSideBySide element, the edit pencil is now placed directly next to the active select items. Resolves: #90777 Releases: master Change-Id: Iac8df9dafca455adb4b18d5bca882fa2ab3bd0cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63792 Tested-by:
-
- 18 Dec, 2019 1 commit
-
-
php bin/rector process Releases: master Resolves: #89807 Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448 Tested-by:Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
-
- 04 Sep, 2019 1 commit
-
-
The filter functionality of fields `type = select` with renderType = selectMultipleSideBySide is always enabled now. Resolves: #88907 Releases: master Change-Id: I7332f39abd6444fc164e8b60009690f6af637b73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61428 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- 14 Mar, 2019 1 commit
-
-
This patch splits the FormEngine.js into smaller, logically separated parts. This increases readability and maintainability and has a positive effect on the client's performance as only the required code is loaded. Not every aspect of the FormEngine JavaScript is handled here yet, since other areas, e.g. IRRE, need refactoring as well. Resolves: #87324 Releases: master Change-Id: I6704445254a524f8ed3152ab6b0b7105fb97d65a Reviewed-on: https://review.typo3.org/c/58608 Tested-by:
André Schließer <andy.schliesser@gmail.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
André Schließer <andy.schliesser@gmail.com>
Reviewed-by:
-
- 11 Aug, 2018 1 commit
-
-
Reduce the HTML of a record form by rendering divs of wizards only if those are required. Resolves: #85577 Releases: master Change-Id: I6ca6ad5c3ebd1a1aa949a9a0349bd7894e4532df Reviewed-on: https://review.typo3.org/57614 Reviewed-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
- 18 Jul, 2018 1 commit
-
-
When the site configuration module has been introduced, it came with a custom functionality to show an additional help text when editing site records between the field label and the field input. This useful feature is now changed into a general TCA feature available everywhere: A new field information node expansion / "wizard" is added to all form elements, the inline and flex containers: If the property "description" is set for a TCA column type (same array level as "label", it will show the value as localized string between the field label and the input section. There are three available render types for "wizard a-like" output: * Field information - text between label+field * Field control - buttons next to input sections like the link popup button * Field wizards - clickable stuff below the input section, for example the localization state selector If a field has been set to readOnly=true in TCA, field control and field wizards do not make sense to render since they are meant to act with the field value. The field information node however has only informational character which is useful for readOnly fields, too. Thus, this node expansion type is now the only one that is always rendered, even if a field has been set to readOnly. Note this patch is fully covered by ext:styleguide (master) to have examples for all changed elements now using the description property. Resolves: #85410 Releases: master Change-Id: Idcfacafa19b8208614b653b8fac22ce47bca3b8f Reviewed-on: https://review.typo3.org/57397 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
- 25 Apr, 2018 1 commit
-
-
This commit moves any language file of EXT:lang into a proper destination, which renders EXT:lang obsolete. This change requires an update of typo3/testing-framework, done with this command: composer update typo3/testing-framework Resolves: #84680 Releases: master Change-Id: I7ba59c1a10015121ed444a9c98082bad0348e03d Reviewed-on: https://review.typo3.org/56017 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
- 15 Mar, 2018 1 commit
-
-
If the configuration `['BE']['debug']` is enabled and the current user is an administrator, the value of select, radio and checkbox fields which are generated by the `FormEngine` is appended to its label. Resolves: #83748 Releases: master Change-Id: I735bd3c83b5b12eb3cddcc66d1b92d48cf5e5991 Reviewed-on: https://review.typo3.org/56147 Tested-by:
-
- 12 Feb, 2018 1 commit
-
-
For the default language it was possible to view the field, but on translating the dataset, the following exception is thrown: 'PHP Warning: Invalid argument supplied for foreach() in backend/Classes/Form/Element/SelectMultipleSideBySideElement.php line 66' As the defaultLanguageRow keeps to be "unparsed", the $selectedItems could be a comma separated string within the method TYPO3\CMS\Backend\Form\Element\SelectMultipleSideBySideElement::renderReadOnly if the TCA configuration of a field is set to 'defaultAsReadonly'. Resolves: #77155 Releases: master, 8.7, 7.6 Change-Id: Id9380fe3761e683352166565ed1a7e56f5e64190 Reviewed-on: https://review.typo3.org/55607 Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
- 27 Nov, 2017 1 commit
-
-
The position of the buttons aside the wizard are not correct. Releases: master, 8.7 Resolves: #83072 Change-Id: Ib60a4015b6a51997ee56381ec63fea79605b16c1 Reviewed-on: https://review.typo3.org/54730 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 20 Apr, 2017 1 commit
-
-
Christian Kuhn authored
Resolves: #80913 Releases: master Change-Id: I151fbf7a02df3e4713d623eb1659ac35ae2cb35a Reviewed-on: https://review.typo3.org/52490 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
- 31 Mar, 2017 1 commit
-
-
The two TCA properties itemListStyle and selectedListStyle which have already been dropped in other elements are fully deprecated. The concept of adding CSS at single places in the elements is very limited and does not cope with bigger HTML changes planned for v9. Change-Id: I1d99b724b0caafe5e1feecc0f1f924498da6a354 Resolves: #80614 Releases: master Reviewed-on: https://review.typo3.org/52302 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
- 11 Feb, 2017 1 commit
-
-
Resolves: #79729 Releases: master Change-Id: I689e8ecd0ffa2d005931e6162fb8df5d9694da3d Reviewed-on: https://review.typo3.org/51629 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
- 07 Feb, 2017 1 commit
-
-
This feature introduces a new functionality called "allowLanguageSynchronization" which can be set on a field configuration of a TCA column. This is the successor of "l10n_mode=mergeIfNotBlank" as the old option had several conceptual downsides: 1) "mergeIfNotBlank" took the value of the default record during runtime, but only if the translation field was empty. This means it was not possible to see what the record actually contained without having all fields of the parent at hand. 2) It was not possible to have a value "santa" in the original record but remove the option in a translation (because an empty string "" implicitly triggered the runtime call in the frontend) 3) "mergeIfNotBlank" did not work on relations except for files fetched via the FileRepository API calls, but for no other inline elements. 4) "mergeIfNotBlank" did the overlay functionality in the frontend, but only FormEngine and DataHandler took care of the option. Custom backend modules had to implement the same functionality. 5) In FormEngine, there was an icon in the translation record that if the record kept empty the value of the original language was taken, but this is not optimal in terms of usability. 6) "mergeIfNotBlank" did not take the new l10n_source option into account, where localizations could be made from other records than the default language "0". The new feature can be set on any TCA column setting: $GLOBALS['TCA'][<table-name>]['columns'] [<field-name>]['config']['behaviour'] ['allowLanguageSynchronization'] = true; This brings an option to records with translations (both from l10n_parent and l10n_source) to have the value for all translations synchronized or explictly have a checkbox to use a custom value. The information whether a field is custom filled, or kept in sync from l10n_parent/l10n_source is stored in a separate field called "l10n_state" inside the database. The introduced upgrade wizard and TCA migration to remove "l10n_mode=mergeIfNotBlank" has been modified to migrate to this option and add a l10n_state database field if a TCA table used "mergeIfNotBlank" but did not add the l10n_state field manually via ext_tables.sql yet. New extensions can easily use the new option right away, extensions that need to stay compatible with v7 and v8 can add both options right away to have the same output. The main goals to achieve with this change is now: * Have consistent database values for all records regardless of l10n_mode=mergeIfNotBlank paving the way to fetch translated records without having to overlay (once l10n_mode=exclude is also copying values and relations) * Be more explicit for editors about records that have a different or the same state as their l10n_parent/l10n_source as a benefit for bigger instances with a lot of languages * Avoid hidden magic when retrieving localized records in the TYPO3 Frontend. Resolves: #79658 Related: #79243 Releases: master Change-Id: I6c2dbfeb09b47f958a536c9ab050c24ba4bbcbbd Reviewed-on: https://review.typo3.org/51291 Tested-by:
-
- 26 Jan, 2017 1 commit
-
-
Christian Kuhn authored
The patch introduces a new API on FormEngine element level that substitutes the old "wizards" / renderWizard() API with a more powerful system. Single wizards are now split into one of three categories: * An informational wizard * A control button / icon * A true wizard with additonal functionality Method renderWizards() is still called in elements for compatibility reasons if people added own scrip/popup/userFunc wizards, but all core wizards are migrated. The patch significantly cleans the HTML of single elements, especially HTML stuff that was added by the SingleFieldContainer is now put down to single elements, while main HTML wraps formerly done by renderWizards() is fetched "up" to single elements. This gives single elements full control about the main HTML it is producing, which is a must have preparation in order to further advance in this area and to switch single elements to fluid rendering in one of the next steps. The patch brings a pretty huge list of TCA changes and simplifications, all TCA changes are supported by TCA migration, so existing extensions should benefit out of the box and just get deprecations logged. Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab Resolves: #79440 Resolves: #70032 Releases: master Reviewed-on: https://review.typo3.org/51151 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 03 Jan, 2017 1 commit
-
-
The patch adapts a series of nasty form engine areas to more solid code. The evaluate condition code is rewritten and works much better in flex form scenarios. The suggest wizard and svg tree are much more solid in flex forms. The group element is rewritten towards a better readable and easier to refactor code, dropping method dbFileIcons(). A bunch of issues is resolved along the way. * TCA "default" now works in flex form section container elements * The "displayCond" parser is now strict and throws exceptions on invalid syntax and wrong referenced fields to help debugging faulty display conditions * TCA displayCond on flex fields can now be prefixed with the sheet name and can reference field values from neighbor sheets * TCA displayCond now works with flex section containers * TCA flex section container now throw an exception if select or group fields configure a MM relation - this is not supported * TCA ctrl requestUpdate field is dropped, onChange=reload is now allowed not only on flex form fields, but also on normal columns fields * TCA tree now works as section container element and initializes correctly on new records and new containers * GroupElement rewrite to drop dbFileIcons() * config option maxitems now optional for type=group and type=select and defaults to "many items allowed" * inline now works in "fancy" flex situations with "new" records by handing the final dataStructureIdentifier around * FormEngine no longer loads extJS Change-Id: Id1d081627529cc1502bb198389e5bd69372815cd Resolves: #78899 Resolves: #72307 Resolves: #75646 Resolves: #76637 Resolves: #72106 Resolves: #78824 Resolves: #76793 Resolves: #68247 Resolves: #69715 Related: #78460 Related: #67198 Related: #72294 Releases: master Reviewed-on: https://review.typo3.org/50879 Tested-by:
-
- 01 Dec, 2016 1 commit
-
-
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
-
- 09 Oct, 2016 1 commit
-
-
Resolves: #77819 Releases: master Change-Id: If39540863a1114ce5ce3e57289da54bdfdffc4f2 Reviewed-on: https://review.typo3.org/49764 Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Reviewed-by:
-
- 04 Sep, 2016 1 commit
-
-
If a multiple select has size equals 1, don't add it to the data related field. Resolves: #77782 Releases: master Change-Id: Idfdf9c5edb791b7b401ce72fb1c6476c9084b5b3 Reviewed-on: https://review.typo3.org/49792 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 25 Jul, 2016 1 commit
-
-
This patch removes default record title escaping in resolved DataProvider data and adds proper escaping where html output is generated. Resolves: #76399 Resolves: #76668 Resolves: #76900 Releases: master, 7.6 Change-Id: I03cf41c5200e920088116d1a67a2e342e46142d3 Reviewed-on: https://review.typo3.org/48779 Tested-by:
Susanne Moog <typo3@susannemoog.de> Reviewed-by:
Frederic Gaus <frederic.gaus@flagbit.de> Tested-by:
-
- 10 May, 2016 1 commit
-
-
If a multipleSideBySide form element is not allowed to add the same value multiple times, its selected values are hidden now and it's not possible to add them again unless the values are removed from the selection. Resolves: #76071 Releases: master, 7.6 Change-Id: I99d6c609ca081f4b8cb6f8ad07f74385a23b7a5c Reviewed-on: https://review.typo3.org/48031 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 17 Apr, 2016 1 commit
-
-
In TYPO3 6.2 palette fields have been handled by an individual on-focus DOM events, depending on a particular user setting. During the FormEngine rewrite with TYPO3 CMS 7, these parts have been kept and transported through the system. Since this information is not used anymore, it can be removed without any substitution. Resolves: #75657 Releases: master Change-Id: I7ab55d3f38b8f34e85027cdbbe8d5850f91dddb5 Reviewed-on: https://review.typo3.org/47699 Reviewed-by:
-
- 09 Nov, 2015 1 commit
-
-
php-cs-fixer fix typo3/ --fixers=unused_use Resolves: #71355 Releases: master Change-Id: I81011f145abdbc8d9ba6a4e14fc5c1d4cd23aa43 Reviewed-on: https://review.typo3.org/44560 Reviewed-by:
-
- 05 Nov, 2015 1 commit
-
-
The handling of invalid or non-matching items was handled inconsistently in the different select elements. Determining the invalid items has been moved into the data provider for select boxes so that the invalid values can be correctly determined based on intermediate processing steps. Resolves: #71257 Releases: master Change-Id: I577089b29265a789612c7b3baaf60b66f4339b35 Reviewed-on: https://review.typo3.org/44540 Reviewed-by:
-
- 04 Nov, 2015 1 commit
-
-
Resolves: #71318 Releases: master Change-Id: I8ed8d9a1ecc670f8aed43e02cfc55563b0c681ce Reviewed-on: https://review.typo3.org/44534 Reviewed-by:
-
- 29 Oct, 2015 1 commit
-
-
Remove references to the deprecated renderMode property in comments. Update AbstractNode to check renderType instead of renderMode when converting the validation rules into a JSON object. Resolves: #70589 Releases: master Change-Id: Ia34bab0d74712051f0a728fc383ca57a753d267b Reviewed-on: https://review.typo3.org/44361 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- 19 Oct, 2015 1 commit
-
-
Xavier Perseguers authored
Change-Id: I4ea525317b838452ff6eb166c751fa3c027cfffb Resolves: #70705 Releases: master Reviewed-on: http://review.typo3.org/44061 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- 06 Oct, 2015 1 commit
-
-
This patch initializes a variable globally as an array to prevent a notice when the script tries to implode the variable. Resolves: #70420 Releases: master Change-Id: I0d26a44ce1ff53ef9e0b8ee0086d0a773cec2c5d Reviewed-on: http://review.typo3.org/43835 Reviewed-by:
-
- 15 Sep, 2015 3 commits
-
-
Due to correct concatenation of incompatible datatypes the select element now shows filter boxes again. Resolves: #69830 Releases: master Change-Id: I4a4040b61fac9e6ab6f2784e4ec7ac2b2cc5450a Reviewed-on: http://review.typo3.org/43347 Reviewed-by:
-
Remove the deleted TcaSelectValues form data provider from the configuration. Resolves: #69742 Relates: #69755 Relates: #69761 Releases: master Change-Id: Ib67aa6df851cb3c9973a7070322bd8a64d313662 Reviewed-on: http://review.typo3.org/43319 Reviewed-by:
Thorsten Bringewatt <t.bringewatt@mittwald.de> Tested-by:
-
This patch removes the private property resultArray and merges the function getSingleField_typeSelect_multiple into render. Releases: master Resolves: #69724 Change-Id: Ia0211e004cf0397902c36864e6732ea16d08774f Reviewed-on: http://review.typo3.org/43260 Reviewed-by:
-
- 14 Sep, 2015 1 commit
-
-
Update the handling of human readable fields so that the values are not being set and only the hidden field with the actual value is submitted. This patch also updates the handling for the _list and _mul appendixes as these use the same methods and needed to be changed as well. Resolves: #69672 Releases: master Change-Id: I7a92c924a567621c2f79c736f878af288595c657 Reviewed-on: http://review.typo3.org/43254 Reviewed-by:
-
- 13 Sep, 2015 1 commit
-
-
Resolves: #69736 Releases: master Change-Id: Ia09f202a75ed0f873fa1934bf2b2305ab3653222 Reviewed-on: http://review.typo3.org/43251 Reviewed-by:
-
