- 04 Jan, 2021 1 commit
-
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 21 Dec, 2020 1 commit
-
-
Bootstrap v5 – introduced in #92616 – was added with CCS from beta1 but JavaScript from alpha2. bootstrap.bundle.js was manually wrapped into a AMD closure, and because bootstrap 5.0.0-beta1 contains alot of changes regarding data tags, it couldn't be updated in the initial patch. Bootstrap is now bundled using rollup using the ES6 sources in order to allow for automatic updates through `grunt build`. popperjs – previously bundled into bootstrap distributed files – is now added as dependency. The bootstap ES6 sources, that we now use through rollup, do not bundle this external dependency (for good reasons). Dependency added with: yarn add @popperjs/core Further adaptions contained in this change to ensure beta1 compatibility: a) Carousel "item" to "carousel-item" class migration b) $.fn.modal(options) does no longer imply $.fn.modal('show') c) Fix panels, both JS and CSS (card-group can't be used here) d) All bootstrap data- tags are migrated to data-bs-. (see https://github.com/twbs/bootstrap/pull/31827) Migrated with # renderes a sed substition with the help of a nested sed from all the # data-bs attributes that where changed in the twbs/bootstrap commit git grep -l data- | xargs sed -i $( \ curl -s \ https://patch-diff.githubusercontent.com/raw/twbs/bootstrap/pull/31827.patch | \ sed 's/data-bs-[a-z-]*/\n&\n/g' | grep "data-bs-[a-z-]" | \ sort | uniq | \ sed 's/data-bs-\(.*\)\([^a-z-]\|$\)/ -e s\/data-\1\\\([^a-z-]\\\)\/data-bs-\1\\1\/g -e s\/data('"'"'\1'"'"')\/data('"'"'bs-\1'"'"')\/g/g' \ ) # Revert false positives from the above auto-replacement git checkout -- typo3/sysext/core/Documentation/Changelog/ \ typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php \ Build/Sources/TypeScript/backend/Resources/Public/TypeScript/LiveSearch.ts \ Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineFlexForm.ts \ Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Settings/ExtensionConfiguration.ts \ Build/Sources/Sass/typo3/_element_panel.scss (cd Build && grunt build) Resolves: #93126 Resolves: #93123 Resolves: #93132 Related: #92616 Releases: master Change-Id: Ie194d0f87d2c60df7b9e8a6de4893cfaaea55356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67215 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 20 Dec, 2020 1 commit
-
-
This changes removes the frontend framework Bootstrap 3, and adds Bootstrap 5 beta 1 (we expect Bootstrap 5 final by the time we release TYPO3 v11 LTS). Bootstrap v3 is not supported by the Bootstrap team any longer, so an update is critical for TYPO3 Core. Bootstrap v5 adds a few accessibility improvements as well as flexbox for rendering containers and grids throughout TYPO3 Backend. All JS components are not bound to jQuery anymore, and have been reworked. A lot of HTML/CSS changes happened, which we slowly migrate (and not in a huge change) to TYPO3's templates, in order to keep this change managable. A legacy CSS/SCSS file is added to keep some backwards-compatibility classes to ease the migration for extension developers who have built their own backend modules. Key features of Bootstrap 5: * "rem" instead of "px" is used by default * CSS variables are introduced * Improved bootstrap focus outline styling (buttons / inputs / links) * Simplified grid functionality * use new button color mixin to increase contrast: Primary, Success and Warning Button color is now dark instead of white EXT:styleguide was used as a basis for upgrading to keep compatibility as much as possible, but more changes will be coming in the next few minor releases. Resolves: #92616 Releases: master Change-Id: Iec989f39649b5460b055ec879199faf38e424f2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 19 Dec, 2020 1 commit
-
-
This change removes the &route parameter from all Backend URLs, and changes them to speaking URLs like /typo3/main?token=123123123. For this change, it is necessary to adapt the installations' webserver configuration rewrite rules to enable URL rewriting in TYPO3 Backend. An silent upgrader will automatically update existing webserver configuration files like .htaccess or web.config to adapt to the TYPO3 Backend navigation concepts. Further steps will be using the browsers pushState functionality to update the URL when a module changes, and further deep-linking into TYPO3 Backend. Resolves: #93048 Releases: master Change-Id: Icdccfb4dbba71d2ecd08d619ed17ff49f6225b3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67083 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 20 Nov, 2020 1 commit
-
-
States of checkboxes defined in the TCA with "invertStateDisplay" enabled are announced in the same way as the visual representation. The underlaying checkbox value is inverted instead of just inverting the corresponding visual representation. The CSS class "checkbox-invert" used for styling these checkboxes has been removed. Resolves: #92678 Releases: master Change-Id: Id35d0cc3b3872a8176f30eee6abdf49287a2c44a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66282 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 10 Nov, 2020 1 commit
-
-
The renderType `selectCheckbox` allows for grouping of items, which are rendered as collapsed per default. A new TCA setting now allows to define this behavior for all groups at once. By adding the new setting `expandAll=true`, all groups are initially expanded. If not set or set to FALSE the current behvahiour remains and all groups are collapsed. Releases: master Resolves: #91859 Change-Id: I9db196a7bfa6b1399358afdc785814425a764e80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65081 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 28 Oct, 2020 1 commit
-
-
A couple of not needed assignments throughout the core and a 'too many arguments' fix. Resolves: #92605 Releases: master Change-Id: I883dc2fcc12c72c525bc7a44236cac8311d96f11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66182 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 21 Oct, 2020 1 commit
-
-
Instead of using the shorthand ternary operator use a regular ternary operator to avoid an invalid HTML attribute '1'. Resolves: #92640 Releases: master, 10.4 Change-Id: Ibf14dfaafd34158c71d71c99ddbc70d04795f3d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66229 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 19 Oct, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92579 Change-Id: I488edd51d9af44107969335b8f955cb69734c42b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66158 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 10 Oct, 2020 1 commit
-
-
This patch removes jQuery from a major part of FormEngine components, including elements, field wizards, enhancers and IRRE. Additionally, the argument `optionEl` of the method `FormEngine.setSelectOptionFromExternalSource()` accepts objects of type `HTMLOptionElement` which renders jQuery objects obsolete, which has been deprecated. Resolves: #91911 Releases: master Change-Id: I5b7d2f4c7b9b5993a5bbe8cec016aa74cabbbecd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65009 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 30 Sep, 2020 1 commit
-
-
The "ResourceFactory" class was introduced as a "god class" to build any File/Folder object (from a string, DB row or integer), but is also there for building sys_file_storage (ResourceStorage) objects, so it is mixing a lot of concerns (also driver setup). However, all creation of ResourceStorage objects should be moved into the StorageRepository (which already exists), thus reducing the dependencies towards ResourceFactory. This makes it much easier to not juggle with storage UIDs anymore but actually work with storage objects throughout the internal FAL API. The StorageRepository is not extending from the AbstractRepository anymore, which is breaking. Resolves: #92289 Releases: master Change-Id: Ib367164535550e280a6907f4d4473aa0417c3813 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65184 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
-
- 22 Sep, 2020 1 commit
-
-
The rendertype `InputLinkElement` renders a preview of the link since #28171. If a link to a page contains a fragment, this information has been added to the preview. Resolves: #92366 Releases: master Change-Id: I326fec85aa5bd535f675a435e8ea851fe96c892e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65801 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 20 Sep, 2020 1 commit
-
-
Instead of displaying the JSON value of the `crop` field, which has no value for editors, the otherLanguageContent wizard is replaced with a new wizard which renders cropped thumbnails for other languages by respecting the corresponding cropping configuration. Resolves: #77815 Releases: master, 10.4 Change-Id: I23ed0df13593330b303af1ec71f5a1c49476cf1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65533 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 04 Sep, 2020 1 commit
-
-
Precision of `uniqid()` on Windows systems without passing `$more_entropy=true` has only single-second-resolution which will lead to non-unique ids on subsequent calls. In order to mitigate this issue TYPO3 provides the function `StringUtility::getUniqueId($prefix = '')` which calls `uniqid()` with parameter `$more_entropy` always set to true. Using `uniqid()`, especially with `$more_entropy` set to true, is quite slow, but for the purposes TYPO3 is using it (i.e. creating unique field names for backend forms, path identifiers in some modules etc.) it is good enough and another solution would not provide any measurable benefit. Resolves: #91553 Releases: master, 10.4 Change-Id: Ib4443e72621eee6df2daf5bf23054e1a01325783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64652 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 18 Aug, 2020 1 commit
-
-
Readonly relations to sys_file_reference records should still show the placeholder values which is filled by the meta data coming from sys_file_metadata. Resolves: #91966 Releases: master, 10.4 Change-Id: I88b299bc31fde18239ae0e1680e8d199e93b7b00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65286 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 15 Aug, 2020 1 commit
-
-
The library cropper used in TYPO3 Core is rather old (2.3.x) while version 4.1.x is available, which is abandoned. The cropper library has been split into a core module and a jQuery adapter meanwhile, which makes "cropper" obsolete. Since changing the cropper library is mandatory anyway, this patch makes use of the core library "cropperjs" only. Resolves: #91958 Releases: master Change-Id: I0e961a358aa1d007413d664172db8cd8c48c399c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65228 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 27 Jul, 2020 1 commit
-
-
This patch removes a lot of either unused or superfluous CSS code. Some stuff seems to have travelled in time to stay present, e.g. a star hack for IE or code affecting ExtJS which was removed in v9. The class `form-field-inputlink-explanation` was in use but has been removed nevertheless as it had no effect since we have Bootstrap in place. Resolves: #91867 Releases: master, 10.4 Change-Id: Idc2dd3fa46d393024abce80b46f796f3de867ee2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65112 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 12 May, 2020 1 commit
-
-
Prevent XSS by escaping the shortened placeholder text for various Backend form elements properly. Resolves: #90817 Releases: master, 9.5 Change-Id: I58f61b2d3d902dd3cb07e97acf974156f100a8aa Security-Bulletin: TYPO3-CORE-SA-2020-002 Security-References: CVE-2020-11064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64471 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 13 Apr, 2020 2 commits
-
-
Due to wrong prefixes of TCA type=slug fields for custom records e.g. in ext:news, a new configuration `prefix` is introduced. A `userFunc` can be assigned to the new field which then allows to provide a custom base url based on e.g. the correct detail page. The default behaviour, which is used for pages, is still applied, when no custom base url is given. Resolves: #89573 Releases: master Change-Id: I529ff26ddeba200b56f0c23aca55daa187c3f40d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62270 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 27 Mar, 2020 1 commit
-
-
Disabled input fields now contain the `data-formengine-input-name` attribute. The slug creation is now able to determine disabled fields as well to take them into consideration. Resolves: #90141 Releases: master, 9.5 Change-Id: I153a2d8e3e3e67fd6d865bd4e72691c67ab18c3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63947 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 26 Mar, 2020 1 commit
-
-
This patch fix missing space before calling GeneralUtility::implodeAttributes. Without space, the rendered HTML is not valid. Resolves: #90835 Releases: master, 9.5 Change-Id: Iccd9f0bbeb4d6e12f3bca882f7bba2dc69577bb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63926 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Frank Nägler <frank.naegler@typo3.org>
-
- 23 Mar, 2020 1 commit
-
-
The previous implementation used two typecasts in a row: from bool to string, and from string to bool again. This caused a boolean false to be cast first to null and then to an empty string instead of to "0". Resolves: #89491 Releases: master, 9.5 Change-Id: I4003dfe1e027437fe6366d21cc05453511f85919 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62087 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 21 Mar, 2020 1 commit
-
-
When using the edit popup of SelectMultipleSideBySide editing is related to the items that are active and selected in the element. The old placement of the edit pencil however suggested that it should be possible to edit all (even inactive items, unrelated to the current record) elements. Whenever an editPopup is configured to be shown in a SelectMultipleSideBySide element, the edit pencil is now placed directly next to the active select items. Resolves: #90777 Releases: master Change-Id: Iac8df9dafca455adb4b18d5bca882fa2ab3bd0cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63792 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 18 Mar, 2020 1 commit
-
-
With #86629 the link type "telephone" has been added but it was forgotten to add support for it in the InputLinkElement. Add the support and show a nice icon next to the number. Resolves: #90771 Releases: master Change-Id: Ib2ea37ab07b0ae2fa9a429dc683c6021a8691aae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63760 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Susanne Moog <look@susi.dev> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Susanne Moog <look@susi.dev>
-
- 15 Mar, 2020 2 commits
-
-
When a TCA field of dbType=date / dateTime is rendered, and the field is marked as read-only, the value is not evaluated, as it never ever modified as UNIX timestamp. Resolves: #88450 Resolves: #90413 Releases: master, 9.5 Change-Id: I29c1acda07f11729d84668f51efdfeff4a4d99c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63626 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
If the TCA option "l10n_mode" is set to "exclude", the selected field in localised elements is wrong when using this option in conjunction with "l10n_display" => "defaultAsReadonly" in a select single element. In this case the variable $parameterArray['itemFormElValue'] seems to be a string, not an array as expected in SelectSingleElement.php. This patch adds a check for the array / string, as well as the same behaviour for the checkbox. Resolves: #76785 Resolves: #77257 Resolves: #84997 Resolves: #82843 Releases: master, 9.5 Change-Id: Ied0708dc378d73a8131791b28ebe1c61555c52aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63722 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 10 Mar, 2020 1 commit
-
-
Andreas Fernandez authored
This patch changes the behavior of the FormEngine internal ValueSlider by creating a new instance per occurrence of the slider to solve event stacking issues. Due to the new structure of the module, it's moved into FormEngine/FieldWizard. Resolves: #90673 Releases: master, 9.5 Change-Id: I80f2f2faeb37fb793b19cede7b629d8c415072d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63597 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 08 Mar, 2020 2 commits
-
-
TCA select fields have the capabilities for replacing ###CURRENT_PID### with the parent page ID of the current record. This should always be <table>.pid. In case of pages the wrong ID was used. This was now changed to always use the parent page ID indepentent of the current record. In case there is no parent page row, 0 is given. Resolves: #90645 Releases: master, 9.5 Change-Id: I8bc04891a009011f4c0d7fd9e59ab306d650b4d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63603 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Releases: master Resolves: #90668 Change-Id: I92cc4942f9f06d587a7957a94f006d157143e55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63569 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 06 Mar, 2020 3 commits
-
-
Urls starting with `//` should have a proper fallback to avoid warnings e.g. in InputLinkElement that this type of url is unknown. Resolves: #90171 Releases: master, 9.5 Change-Id: Ic3910f98c3993fb5db523ba1b360eabb49bf0696 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63543 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
Benni Mack authored
Most access to the configuration options are made against AbstractFile objects in FAL, which is now centralized in one place in AbstractFile. This reduces errors when checking for file patterns. Resolves: #90305 Releases: master Change-Id: I7835d877bae1addf830ede3645ff8f1faa113052 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63155 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
This patch removes all occurrences of bootstrap-slider in Core with the native `range` input type. To ensure a consistent styling across all platforms, new CSS is in place. However, we can't recover the same styling as used with the bootstrap-slider either due to inconsistent browser support of selectors or missing features. In the `ValueSlider` module, which is only used by FormEngine, any usage of jQuery has been removed as well. Resolves: #90649 Releases: master Change-Id: Ic2e0cb7aa9305159c33f14130d3fe6e62d2fd1da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63523 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Feb, 2020 1 commit
-
-
Move the info message text to a xlf file and differ between the slug of pages and records. Resolves: #89574 Releases: master, 9.5 Change-Id: I1d68e5b9dcca9cd2559c5e0bdbefc81c79e6b669 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62199 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 30 Jan, 2020 1 commit
-
-
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 25 Jan, 2020 1 commit
-
-
The missing rendering for the fieldControl option for `SelectSingleElements` was added. It is now possible to use the fieldControl option for SelectSingleElements to add nodes and wizards. Resolves: #89032 Releases: master Change-Id: Ie0d3bcb848eba0e068f29c2e659df265f7b25f81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61566 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Susanne Moog <look@susi.dev>
-
- 24 Jan, 2020 1 commit
-
-
Checkboxes that are placed in sections in BE forms have the same HTML identifiers. As a result it is not possible to check one checkbox in one section without affecting the same checkboxes in other sections. The fix makes identifiers unique. Resolves: #87429 Releases: master, 9.5 Change-Id: Ia5cd88aecb2af12a83f40d39a8b450f5cde09060 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60362 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <look@susi.dev>
-
- 30 Dec, 2019 1 commit
-
-
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-