1. 04 Jan, 2022 1 commit
  2. 02 Dec, 2021 1 commit
  3. 24 Sep, 2021 1 commit
  4. 23 Sep, 2021 1 commit
    • Benni Mack's avatar
      [TASK] Do not use custom "getInstance()" methods on Singleton interfaces · cb355fa5
      Benni Mack authored
      There was a time when new code for TYPO3 Core was introduced
      by using "MyClass::getInstance()" to act as a factory for this
      class, which _would_ be OK if these classes are actually prototypes
      and not services (or singleton services), as GeneralUtility::makeInstance()
      or DI via Services.yaml works as well.
      
      This change deprecates all getInstance methods around such code
      with GeneralUtility::makeInstance() calls. At a later point, proper DI
      can be introduced in these cases.
      
      * TYPO3\CMS\Core\Resource\Index\ExtractorRegistry::getInstance()
      * TYPO3\CMS\Core\Resource\Index\FileIndexRepository::getInstance()
      * TYPO3\CMS\Core\Resource\Index\MetaDataRepository::getInstance()
      * TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\OnlineMediaHelperRegistry::getInstance()
      * TYPO3\CMS\Core\Resource\Rendering\RendererRegistry::getInstance()
      * TYPO3\CMS\Core\Resource\TextExtraction\TextExtractorRegistry::getInstance()
      * TYPO3\CMS\Form\Service\TranslationService::getInstance()
      * TYPO3\CMS\T3editor\Registry\AddonRegistry::getInstance()
      * TYPO3\CMS\T3editor\Registry\ModeRegistry::getInstance()
      
      Resolves: #95326
      Releases: master
      Change-Id: Ie3160c67792e115cf5488dc800bd717c0b913ab9
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71178
      
      
      Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
      Tested-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
      Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
      Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      cb355fa5
  5. 01 Jun, 2021 1 commit
  6. 15 Apr, 2020 1 commit
  7. 14 Apr, 2020 1 commit
  8. 12 Jul, 2019 1 commit
  9. 22 Dec, 2018 1 commit
  10. 11 Dec, 2018 1 commit
  11. 29 Jun, 2018 1 commit
  12. 22 Jun, 2018 2 commits
  13. 09 May, 2018 1 commit
  14. 17 Mar, 2018 1 commit
  15. 28 Aug, 2017 1 commit
  16. 15 Aug, 2017 1 commit
  17. 17 Feb, 2017 1 commit
  18. 18 Nov, 2016 1 commit
  19. 21 Oct, 2016 1 commit
  20. 06 Oct, 2016 2 commits
  21. 22 Sep, 2016 1 commit
  22. 30 Aug, 2016 1 commit
  23. 24 Aug, 2016 1 commit
  24. 29 Feb, 2016 1 commit
  25. 21 Nov, 2015 1 commit
  26. 20 Nov, 2015 2 commits
  27. 08 Oct, 2015 1 commit
  28. 03 Oct, 2015 1 commit
  29. 15 Sep, 2015 1 commit