- 04 Jan, 2022 3 commits
-
-
The option "autoplay" only works if "mute" is enabled. See https://developer.chrome.com/blog/autoplay/ for reference. Resolves: #96320 Releases: main, 11.5, 10.4 Change-Id: Ic4e2de0576fe3d1619af8e35274adeb013c72b31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72621 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
The documentation states "case" and "pidonly" are of type boolean. But in the code in_array was used to decide, whether to utilize these options. This is now fixed by checking for the array keys. Some lines above in the first if-branch, this has been already fixed. Resolves: #96454 Releases: main, 11.5 Change-Id: I04c3638620f7a91612bdc0598ff25893325bb801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72830 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
TCA eval config is not required, so it must be checked for existence. Resolves: #96453 Releases: main, 11.5 Change-Id: I95425e3febac70ac2e03478b7385edbaf0c9a601 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72829 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 03 Jan, 2022 7 commits
-
-
Benjamin Franzke authored
A human-readable diff of the applied changes can be inspected on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine.ts https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineValidation.ts Notes: * No major refactoring to keep the diff minimal and prepare behaviour as-is * Map imports to require-style * Added default sections in switch statements * Guard parseInt and Date.parse with typeof/instanceof * Use event.eventTarget instead of this in jQuery event callbacks * Use second method parameter in jQuery.each callbacks * Add @ts-ignore and eslint-disable-next-line where TypeScript adaptions aren't possible without possibly changing behaviour Releases: main Resolves: #82586 Resolves: #82590 Resolves: #96425 Related: #96323 Change-Id: I372c78ae581e2254f150000ad6b75ff4f005916f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Christian Kuhn authored
It seems that symfony >= 5.4.0 has a bug in symfony finder that .gitignore files are no longer always found when the ->in() directive is a non-absolute path with '/../'. This triggers issues with our cgl fixer script in nightly mode. We work around that by using an absolute path instead in the configuration and will report the issue to symfony. Resolves: #96450 Related: #96171 Releases: master, 11.5 Change-Id: Ice865b92c118e26d519fbca7ae49e41fbe4d5110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72828 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
This change reduces the amount of @todos regarding method changes related to strict typing or interface changes for TYPO3 v12.0. Resolves: #96429 Releases: main Change-Id: I072a70e0126f358d188314389dce15e5011d0993 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72799 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Resolves: #96415 Releases: main, 11.5 Change-Id: I4f96cd250b1f1ef27c7232b8fff3214cb555ab32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72827 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
If rendering of spacer pages in an HMENU is explicitly given via SPC = 1, then subpages of pages are now rendered as well. This way, there is no difference between spacers and other page types for submenu rendering anymore. Resolves: #64428 Releases: main, 11.5 Change-Id: Ic4bc2661399498de61af486712ade85815ffa529 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72807 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Resolves: #96443 Releases: main, 11.5 Change-Id: I9f1c951628cf8872473ff20bbd59ffb769ffe279 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72819 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Make sure to pass strings to html formatting methods. Initialize hierarchy array correctly. Resolves: #96448 Releases: main, 11.5 Change-Id: I2b9c28303c1c96d0a2ea1bc3ca971da3b4b3fe7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72824 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Sybille Peters <sypets@gmx.de>
Tested-by:
-
- 30 Dec, 2021 6 commits
-
-
This error occurs when running linkvalidator in scheduler: Undefined array key 1. Resolves: #96439 Releases: main, 11.5 Change-Id: Idbe4b5bf52722a800026fc7af566daba925eaad2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72811 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
This change enables raises Symfony's minimum version to 5.4.0 as this is a LTS version. Resolves: #96171 Releases: main, 11.5 Change-Id: Ia2acbe0bca60e0dbdb96cb2fe2e82a63f9575554 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72434 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
With the changes in #95854, implicit rootPid dbmounts caused duplicated pages in pagetree, because explicit page mounts have been considered multiple times for the pid=0 tree: * First time because of their relationship to pid = 0 * Second time because of their explicit mount (which was sorted into the pid = 0 tree) This happened because #95854 optimized to only use one call to the PageTree repository, which then had the side effect of merging "multiple" pages into one tree, instead of showing "two" separate trees. The patch ensures that multiple page trees are used when the rootPid (0) is included as a webmount. Releases: main, 11.5, 10.4 Resolves: #96367 Related: #95854 Change-Id: I7f421995f2d4aa88bb266fec684565102a4dc080 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72812 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The TCA option "appearance" is an array, with pre-defined configuration keys. The column "custom_stages" of the table "sys_workspace" set a csv value for this option. This does not work. The configuration is now transformed into the correct array format. Resolves: #96437 Releases: main, 11.5, 10.4 Change-Id: I25112d7ea1ce605376d70fa2dabceddd3c121faa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72809 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This is a preparatory update to help migration to ES2020 modules ("ESM"). TypeScript >=4.1.1 fixes it's es2020 module target to allow import.meta, see https://github.com/microsoft/TypeScript/issues/41249 Also related eslint tools are updated and the configuration format is streamlined to json, while we are at it. (not really needed, just drive-by cleanups) Notes: * @types/chrome is removed because of a conflict. It has been added in #82595 but it has actually never been used. This package contains a dependency to @types/filesystem which is currently not TypeScript 4.5 compatible, therefore both packages are removed. * tsconfig.json is adapted to explicitly configure "useDefineForClassFields": false. With our current target ES2017 this defaults to false, but with TypeScript >=4.3 and target ES2020 the default changes to `true`. Lit requires this setting to be false for decorators to work, so we add explicit configuration as recommended by Lit: https://lit.dev/docs/components/decorators/#decorators-typescript * The `true` ("force-reload") parameter of document.location.reload() calls is removed as this flag is non standard an only available in firefox. It is not longer permitted by TypeScript 4.5, also see: https://developer.mozilla.org/en-US/docs/Web/API/Location/reload#location.reload_has_no_parameter * Many compiled files are changed because calls like `foo.bar()` (where `foo` is imported from another module) are now transpiled to `(0, foo).bar()` in order to avoid calling module exports with a `this` value: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html#more-compliant-indirect-calls-for-imported-functions This is to comply with native ES6 Modules and therefore marked as a breaking change in TypeScript, but it only affects names imports and therefore doesn't affect the instances we export via `import =`. (It only affects imports from jquery, moment, lit and function exports) This actually brings us closer to ES6 module compatibility. Commands executed: # Introduces in #82595 and unused since then yarn remove @types/chrome yarn add --dev \ typescript@~4.5.0 \ grunt-eslint@^24.0.0 \ eslint@^8.0.1 \ @typescript-eslint/eslint-plugin@^5.8.0 \ @typescript-eslint/parser@^5.8.0 \ @typescript-eslint/typescript-estree@^5.8.0 yarn build Releases: main Resolves: #96436 Related: #96323 Change-Id: Ia5a7e0408af906ff889e7e9435f7868fb3d0ac34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72806 Tested-by:core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96438 Releases: main, 11.5 Change-Id: Idcb8ca5f889aef8d77c1e3950f5794fe54ed76e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72810 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- 29 Dec, 2021 2 commits
-
-
This option was removed in TYPO3 v9 and is since then always enabled. Also remove usage in Tests along with localizationMode, which does not exist either anymore. Resolves: #96440 Related: #82709 Releases: main Change-Id: Ie3f4c0b6f36b221324241c77496c089c13ac09c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72814 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96441 Releases: main, 11.5 Change-Id: Id3ae6ee43d1db5ef2ee46fedb336561bc8049a72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72815 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 23 Dec, 2021 15 commits
-
-
This change adds test to document the behavior that excludeDoktypes needs to be set to render folders in a menus as well. Resolves: #93924 Releases: main, 11.5 Change-Id: I870e2ef5cd07d5365d93ad04752b74a4edaebd64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72769 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Benni Mack authored
Previously, HMENU.addQueryString, which is only available for special=language, was applied not within the typolink() functionality but before. By sorting out the properties, HMENU with special=language now properly uses typolinks addQueryString. Using the magic property _ADD_GETVARS to activate this option addQueryString but also using the "_PAGES_OVERLAY_REQUESTEDLANGUAGE" allows to fix special=language issues. Resolves: #94713 Releases: main, 11.5 Change-Id: Ic26e702fb97bb878308de5e1710d2a3c4f28552d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72801 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
This only fixes the issue for dedicated record links. Page links with added query arguments can still lead to broken links. Resolves: #87260 Releases: main, 11.5 Change-Id: Ib13aa1925de6463688e2b50612ce7b2820733ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59257 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
The setup should not contain the same settings twice. Moreover, the default paths are always available, no need to configure them. Additionally, remove default paths from constants, we don't need that either. Resolves: #96384 Releases: main, 11.5 Change-Id: I204cc38a952dd7acd097d188d1637ad1b25324fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72703 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Torben Hansen <derhansen@gmail.com> Tested-by:
-
Releases: main Resolves: #96046 Change-Id: I86edaa24b08808b70b92687f83a850ff32a74dc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72007 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
Resolves: #96344 Releases: main, 11.5 Change-Id: I986945e16e0a2adef827fc0532a431be7ab25e03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72770 Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: -
Benni Mack authored
Resolves: #96430 Releases: main, 11.5 Change-Id: I8569537d90ee5dc74157db4f3e583366b82a2e27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72800 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: -
These additional SMTP options are now supported by TYPO3 and can be set in the Install Tool: - transport_smtp_restart_threshold - transport_smtp_restart_threshold_sleep - transport_smtp_ping_threshold It is also possible to define 'transport_smtp_stream_options' as array with stream options in the AdditionalConfiguration.php. Resolves: #94544 Releases: main Change-Id: I258c5493fa4f7815481636c223b7c5368f79a274 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69907 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benjamin Franzke authored
A human-readable diff of the applied changes can be inspected on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72795/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineLinkBrowserAdapter.ts No functional change to keep the diff minimal and prepare behaviour as-is. Releases: main Resolves: #88435 Related: #96425 Related: #96323 Change-Id: I512739d5827e2951ac6a63312de380870bdebd8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72795 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Benni Mack authored
There is a difference between > typolink.linkAccessRestrictedPages = 1 (only a toggle) and > HMENU.showAccessRestrictedPages = [pageId]|NONE HMENU.showAccessRestrictedPages behaves like the global option "config.typolinkLinkAccessRestrictedPages" Basically, if a page is access restricted, link to a different {pageId}. This change explains the behavior: -- https://review.typo3.org/c/Packages/TYPO3.CMS/+/35908/ "typolink.linkAccessRestrictedPages" in contrast still links to the actual disallowed page, which is also nice in case you have a 403 error page in place. This change fixes the behaviour of HMENU to behave EXACTLY like the global config.typolinkLinkAccessRestrictedPages, previously HMENU did some magic PLUS it set "typolink.linkAccessRestrictedPages" With this change, shortcuts to access restricted pages now get properly transformed and linked for menus. Resolves: #60258 Resolves: #65118 Related: #63804 Releases: main, 11.5 Change-Id: Ifd975243fe4b024b3fcbd4e356430d809cc0f429 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72796 Tested-by:core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Resolves: #96377 Releases: main, 11.5 Change-Id: I98dfe39cf04468d54ee979afa34e7dd3bd40acf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72793 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Resolves: #96418 Releases: main, 11.5 Change-Id: I00b77f478c667f59b751c6f13c975d03799086d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72792 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Added the following Composer plugins as allowed/trusted * composer/package-versions-deprecated * typo3/class-alias-loader * typo3/cms-composer-installers Resolves: #96428 Releases: main, 11.5, 10.4 Change-Id: Iabb8f00411279f502bca1d1ba79714cc58d82d3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72797 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
This fixes several issues for the case that an editor only has access to translated pages and not to the default language (L=0). Resolves: #95795 Releases: main, 11.5, 10.4 Change-Id: Ied31c7aa5229d3b8686741dd97005f9b5f16ef16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72616 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Resolves: #93027 Releases: main, 11.5 Change-Id: I65b4b84a12cf4985d14a62217b075e5c421e0ee6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67072 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 22 Dec, 2021 1 commit
-
-
Christian Kuhn authored
With the removal of ControllerContext a view init call had to be moved out of ControllerContext. It was moved to a wrong place in the view setup chain. This is fixed by the patch. Resolves: #96426 Related: #96183 Releases: main Change-Id: I8a49627040a72649c39aa8ace9da0b0a2e1995c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72771 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 21 Dec, 2021 6 commits
-
-
Christian Kuhn authored
To stick to best practice, the patch adapts all f:uri.resource ViewHelper usages to "EXT:" syntax. Resolves: #96423 Related: #96414 Releases: main Change-Id: Icba87d954f939a42ca59fbe78e7c932f0228f11e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72766 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: -
This patch changes the behaviour when building the SchemaDiff on a non-default connection to only fetch tables which are mapped to that connection instead of fetching table details of all tables and discarding the information for unmapped tables later on. This improves the performance and avoids errors for data types unknown to doctrine/dbal in details of unmapped tables. Resolves: #92959 Releases: main, 11.5 Change-Id: Ia4a62d861ea0748995eb0dec4f01e9e65eb3ed46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66949 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This avoids the deprecation notice in PHP 8.1: Passing null to parameter #2 ($string) of type string is deprecated in /var/www/html/public/typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php line 179 Resolves: #96422 Releases: main, 11.5 Change-Id: I9c811bc0d2d4523a78fc6c72ee02be96efbe1bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72764 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96420 Releases: main, 11.5 Change-Id: Ida1b27956bfe759062904ee9d0c8246ea73f0667 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72763 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
When one or more hidden records are referenced in an "Insert records" content element, an "undefined array key" warning was thrown. Resolves: #96419 Releases: main, 11.5 Change-Id: I4f90dc78540bf8c56163cfb8247a13c86869fbe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72762 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Andreas Fernandez authored
If the PageLinkBuilder is invoked with a non-available TSFE as e.g. in the "Redirects" module, generating the URLs to pages with a fragment, e.g. to a referenced content element, works now as we're using the TSFE generated within PageLinkBuilder itself. Resolves: #96101 Releases: main, 11.5 Change-Id: I481b7d8573424dab59df22b0d81a734e03b70575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72323 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
