- 23 Dec, 2021 1 commit
-
-
Resolves: #96377 Releases: main, 11.5 Change-Id: I98dfe39cf04468d54ee979afa34e7dd3bd40acf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72784 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 26 Oct, 2021 1 commit
-
-
Various functions expect string arguments and emit E_DEPRECATED with PHP 8.1 in non strict_types=1 calls. The patch adjusts some null coalescence fallbacks from null to string to satisfy this. Resolves: #95787 Releases: master Change-Id: Ie1b28bc285c33af3509d18eaeb7d0b6013284434 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71983 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 08 Oct, 2021 1 commit
-
-
Prevent access to undefined array keys in content renderer and menu objects. Resolves: #95489 Releases: master Change-Id: I1ec4b046478e7e83176e1178153d57a2890b269e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71454 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 16 Jul, 2021 1 commit
-
-
Add fallback for undefined array keys in EXT:frontend, EXT:indexed_search, EXT:core. This fixes frontend rendering of a basic site package including all available content elements. Resolves: #94546 Releases: master Change-Id: I051f2d6d0b2278394e95af8eb26be11b3f4aa9a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69819 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 04 Jan, 2021 1 commit
-
-
Running a clean installation minimal setup throws a lot of "PHP Notice: Undefined index: " notices. This commit removes the ones from the frontend. Resolves: #91116 Releases: master, 10.4 Change-Id: I1f81150ed48ae170682d68d1169c1de2963e0021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64238 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 05 Dec, 2020 1 commit
-
-
Benni Mack authored
This allows to add the current request into ALL userFunctions, including Extbase, where we can then convert the request into an Extbase Request. Plus, it is injected in all ContentObjects, making it available for subsequent renderings. Resolves: #92984 Releases: master Change-Id: I7ac6872db6ea0ed8838a0d63c18b5fa53407ebed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66080 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 23 Sep, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92109 Change-Id: I475507b4b075c1de5cedd82875e49aefe1a42a79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65464 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 07 Sep, 2020 1 commit
-
-
In some setups the conf array is null and throws an error. This patch adds the ?? operator with an empty array as fallback value. Resolves: #92216 Related: #91657 Related: #91834 Releases: master Change-Id: I95df9ad491f1284867a683a6980dbb1f6c3f3381 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65618 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 21 Jul, 2020 1 commit
-
-
A common way to apply stdWrap is to use the ternary operator to check for existing stdWrap config. This can be replaced by using the $cObj->stdWrapValue method. Not only is it shorter, it is also more robust and less error-prone. To start off all ContentObject classes have been cleaned up. Resolves: #91657 Releases: master Change-Id: I65c28e27c21ae13bdbcb47068bc32b510b8b0dc0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64898 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 27 Nov, 2019 1 commit
-
-
composer require --dev rector/rector:"^0.5.0" This commit introduces the requirement to rector/rector to automatically process code changes by given set of rules. To make this commit more meaningful, a first set "php53" has been processed. Releases: master Resolves: #89785 Change-Id: I6e2ff9654266458ae9fb6800547ff4712b0b66d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62437 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 23 Mar, 2019 1 commit
-
-
HMENU was hardened during v9 via deprecations of GMENU and making most of the properties protected. Therefore, code can now refactored more easily. - The method signatures for HMENU / TMENU are streamlined. - All leftover "RO" (RollOver) functionality is removed (Breaking RST is already done but left-over code was forgotten). - Several GeneralUtility::inList() checks are replaced with in_array() - Some minor strict types for some internal obvious methods - use json_encode() instead of serialize() for cache identifiers - resolve some very very nested if() statements - internal methods with "optional arguments" which are always called with all arguments, are built in a way that they are now non-optional. Resolves: #87907 Releases: master Change-Id: I80536b9b4dbc4609d38476c9ce48532fe71b73d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60244 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 28 Dec, 2018 1 commit
-
-
The TMENU options beforeImg and afterImg have been removed as well, as part of removal of image generation being part of the menu generation. Resolves: #87287 Releases: master Change-Id: I81134ccf3c8af9368ff0521e7b136d457333903e Reviewed-on: https://review.typo3.org/59291 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 23 Dec, 2018 1 commit
-
-
Change-Id: Ie2ee4ea69ff3cdc67155d292bfd3fccbe1d7ad09 Resolves: #87279 Releases: master Reviewed-on: https://review.typo3.org/59280 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
- 29 Aug, 2018 1 commit
-
-
GraphicalMenuContentObject (GMENU/GMENUITEM) and ImageMenuContentObject (IMGMENU/IMGMENUITEM) will be removed in TYPO3 v10.0, and are marked as deprecated. A lot of functionality related to HMENU in general, previously exposed to the public, has been migrated to be internal, now throwing deprecation messages as well when accessed from the public. In addition the following TypoScript properties will be removed in TYPO3 v10.0. TMENU - imgNamePrefix - imgNameNotRandom TMENU Item properties - RO_chBgColor - beforeImg - beforeImgTagParams - beforeImgLink - beforeROImg - RO - afterImg - afterImgTagParams - afterImgLink - afterROImg Removed item states - IFSUBRO - ACTRO - ACTIFSUBRO - CURRO - CURIFSUBRO - USRRO - USERDEF1RO - USERDEF2RO Also deprecated: TSFE->setJS('mouseOver'); Also not needed in TYPO3 v10.0 anymore: Folder typo3temp/assets/menu/ Resolves: #85902 Releases: master Change-Id: I1b5920e4727e97415e6527f5810c9b103c2c6fed Reviewed-on: https://review.typo3.org/57435 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 23 Aug, 2017 1 commit
-
-
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
- 29 Mar, 2017 1 commit
-
-
The method for OptionSplitting in TemplateService is completely isolated from everything else, and creates a very strong dependency to TSFE + TemplateService in various places. Additionally, the TypoScriptService of Extbase is used in several places of the core and has nothing to do with Extbase itself, thus, it can be moved to a central place where these functions are called. Moving this code to it's own service class in the core helps to decouple TSFE, tmpl, Extbase and cObject more. Resolves: #78650 Releases: master Change-Id: I712c77c383171e93053caff0f89af8d1247f6d86 Reviewed-on: https://review.typo3.org/50589 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org>
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
- 08 Aug, 2016 1 commit
-
-
Removes invalid configuration documentation because it's completely outdated. Resolves: #77426 Releases: master Change-Id: I83510ad25b097746123e7ca314041afd6e1dc8dd Reviewed-on: https://review.typo3.org/49411 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Frederic Gaus <frederic.gaus@flagbit.de> Tested-by:
Frederic Gaus <frederic.gaus@flagbit.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
- 20 Nov, 2015 2 commits
-
-
Resolves: #71738 Releases: master Change-Id: I71edcdb8ed1804bf94479237bd7f6c120420f779 Reviewed-on: https://review.typo3.org/44834 Reviewed-by:
Martin Kutschker <martin.kutschker@ymail.com> Tested-by:
Martin Kutschker <martin.kutschker@ymail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Stefan Neufeind authored
Change-Id: I450ef2985bf1086fb8cc247406a94cce8971f061 Resolves: #71714 Releases: master Reviewed-on: https://review.typo3.org/44812 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de>
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
TYPO3 Release Team <typo3cms@typo3.org>
-
- 15 Jul, 2015 1 commit
-
-
@author information can be found in version control. Cluttering our code with these tags does not make much sense and they are outdated by definition or would sum up to impressive lists. As decided on acme 2015, we drop them now. Releases: master Resolves: #68152 Change-Id: Iec1ea0f873b44ab6027c94ba8353a9fdb5477bdd Reviewed-on: http://review.typo3.org/41264 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 22 Jun, 2015 1 commit
-
-
In case the target of a shortcut is not set, it must be ensured that the rendered menu item has valid markup. This is especially important if submenu items are present. Resolves: #67563 Releases: master Change-Id: Ie464658706e6754821849ca7c8e75d0121221272 Reviewed-on: http://review.typo3.org/40364 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
- 19 May, 2015 1 commit
-
-
The option png_to_gif was previously used to minimize the size of generated images. In the current web development png (with the support of all major browsers) has overtaken gif functionality. The option, which was off by default for some versions, has been removed. All calls to the actual "convert" method in GraphicalFunction have been removed, the function itself has been marked for deprecation. Resolves: #66906 Releases: master Change-Id: I1e134812f55ce8026e468b12ec12ec61e4d9d104 Reviewed-on: http://review.typo3.org/39475 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de>
-
- 10 Mar, 2015 1 commit
-
-
Martin Helmich authored
It is ensured that the menu configuration is always an array. The PageRepository::getHash() method is extended to return the raw cache content. This allows to cache empty arrays. Change-Id: If92c80feabb8e68b66497827667b9fd0ab1c214e Resolves: #63550 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/35002 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Reviewed-by:
Benjamin Mack <benni@typo3.org> Reviewed-by:
Arjen Hoekema <arjenhoekema@gmail.com> Tested-by:
Arjen Hoekema <arjenhoekema@gmail.com> Tested-by:
Markus Klein <klein.t3@reelworx.at>
-
- 25 Feb, 2015 1 commit
-
-
Markus Klein authored
Change-Id: Ie911ce6da7fa60babc90104c27a45371c15492b4 Resolves: #64099 Releases: master Reviewed-on: http://review.typo3.org/36584 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Frederic Gaus <gaus@flagbit.de> Tested-by:
Frederic Gaus <gaus@flagbit.de> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at>
-
- 01 Feb, 2015 2 commits
-
-
Anja Leichsenring authored
This reverts commit 2bb692ae. Change-Id: I44fd2457bb39c7302ca9de141c15d3b34a67a936 Reviewed-on: http://review.typo3.org/36583 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Resolves: #64099 Releases: master Change-Id: I99ee03ad11ed65b9fe9df5f20fe1ad7f54df03f4 Reviewed-on: http://review.typo3.org/35764 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 31 Jan, 2015 1 commit
-
-
Clean up the code by moving IM related function from GeneralUtility to GraphicalFunctions class. Change-Id: I714435ad76e542e9aff297cad779964fd543a2c5 Resolves: #46589 Releases: master Reviewed-on: http://review.typo3.org/36367 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 18 Jan, 2015 1 commit
-
-
Markus Klein authored
It is faster to compare a string with === '' to find out if it's empty than to run strlen() on it. The replacement rules are applied as follows: * if (strlen($str)) => if ((string)$str !== '') * if (!is_string($str) || strlen($str) === 0) => if (!is_string($str) || $str === '') * If it can be seen easily that $str is a string, the typecast is omitted. Change-Id: I888d70e42f925bd57ad23b873b72d6a38acb39ef Resolves: #54091 Releases: master Reviewed-on: http://review.typo3.org/27794 Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de>
-
- 13 Dec, 2014 1 commit
-
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org>
-
- 13 Nov, 2014 1 commit
-
-
Xavier Perseguers authored
Since PHP 5.5 is a requirement, calls to GeneralUtility::makeInstance() should use the ::class construct instead of a string argument. Releases: master Resolves: #61788 Change-Id: Ia2efc5a4cb7ecea80b8a1c8e5ff7b5d6fa9a07ce Reviewed-on: http://review.typo3.org/32913 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Xavier Perseguers <xavier@typo3.org>
-
- 08 Nov, 2014 1 commit
-
-
Resolves: #62769 Releases: master Change-Id: If5b0cde8d9d393b498230d3ee87a0f0bddaf9bb2 Reviewed-on: http://review.typo3.org/33866 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 25 Oct, 2014 1 commit
-
-
Wouter Wolters authored
Resolves: #62467 Releases: master Change-Id: I927a16b0fa89c5b859b56a7549548102ac04037f Reviewed-on: http://review.typo3.org/33522 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
Frank Nägler <typo3@naegler.net>
-
- 11 Oct, 2014 1 commit
-
-
Wouter Wolters authored
The "@todo Define visibility" is not very helpful because: * Nobody knows what breaks if changing the visibility * The code is flooded with todos which makes it hard to work with in an IDE During ACME it was decided to remove the @todo again. Resolves: #62168 Related: #61957 Releases: master Change-Id: I301b31617a2272bd991578c065155773b458394d Reviewed-on: http://review.typo3.org/33268 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Markus Klein <klein.t3@reelworx.at>
-
- 25 Jul, 2014 1 commit
-
-
Benni Mack authored
The TemplateService class provides its own wrap() function which is exactly the same as in cObj. The only instances where the wrap() method is used is in the MenuContentObjects - however, they can also access the wrap() function via cObj. The MenuContentObjects are now using the cObj function so the duplicate code in TemplateService can be deprecated. Resolves: #55567 Releases: 6.3 Change-Id: Iaa7055473f814acc73429f31772d1946c66004f9 Reviewed-on: http://review.typo3.org/27244 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org>
-
- 22 Jun, 2014 1 commit
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59782 for further details. Resolves: #59782 Releases: 6.3, 6.2 Change-Id: Idcd11219eb132c8690cfde256950980e9423bafd Reviewed-on: https://review.typo3.org/31027 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Markus Klein Tested-by: Markus Klein
-