- 08 May, 2022 1 commit
-
-
Nikita Hovratov authored
The core utility class ResourceUtility is a leftover from an old FAL implementation. In a refactoring in TYPO3 v7 this class was replaced with a direct implementation and has not been used in the core ever since. Resolves: #97576 Related: #56746 Releases: main Change-Id: I8a7693633573c2e913075754761519cc2330b1f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74548 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de>
-
- 24 Sep, 2021 1 commit
-
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 11 Sep, 2021 1 commit
-
-
Resolves: #94879 Releases: master Change-Id: I4b96ad0ed03f6089c391fb3bd3e967878aaa1ea2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70593 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 06 Aug, 2021 1 commit
-
-
Resolves: #94736 Releases: master Change-Id: I12d1bd3b963ffb77b8b195c4a50e60a254b885b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70278 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com>
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 24 Oct, 2019 1 commit
-
-
Class \PHPUnit\Framework\TestCase provides many assertion methods that can be called statically and dynamically in the context of tests. Sebastian Bergmann states that neither using $this nor self/static is right or wrong. There are two reasons to use self/static however. First of all IDE's like PhpStorm support code inspections that tell you to not call static methods dynamically and therefore make your code look like a christmas tree. Secondly, there is a rule for php-cs-fixer that can take care of the initial change and which helps sticking to one specific format, unifying the code style overall. Releases: master Resolves: #89499 Change-Id: Ib4a43a94a0df220b052b88b3c3e37e716560e996 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62095 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 30 Sep, 2018 1 commit
-
-
Shorten \TYPO3\TestingFramework\Core\Unit\UnitTestCase to UnitTestCase Resolves: #86478 Releases: master Change-Id: I5dc7704fb2776cff26f1bbf89b35e28fecd9a79e Reviewed-on: https://review.typo3.org/58501 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 16 Feb, 2017 1 commit
-
-
Change-Id: Ib8b787980d90c686457155cbb6c15cd3cd7c0d61 Releases: master Resolves: #79851 Reviewed-on: https://review.typo3.org/51715 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 04 Feb, 2017 1 commit
-
-
As the main test case files are now in subfolders, we need to correct the namespaces. Change-Id: Ie06edc099c5d3e42ff842eded03cde1ddf34c0ca Releases: master Resolves: #79629 Reviewed-on: https://review.typo3.org/51535 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 03 Feb, 2017 1 commit
-
-
- Removal of the CMS part from the namespace - Distinguish Classes / Resources For background information see https://decisions.typo3.org/t/testing-framework-extraction-next-steps/50 Change-Id: I3f73baeb16bbef82c9626add063c9edde41b47a6 Resolves: #79518 Releases: master Reviewed-on: https://review.typo3.org/51449 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 22 Dec, 2016 1 commit
-
-
Add testing framework component for independent usage Resolves: #79025 Releases: master Change-Id: I23cfd2ed42108d7d80ec776e778a1ac2d5293e55 Reviewed-on: https://review.typo3.org/50125 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
TYPO3 Release Team <typo3cms@typo3.org>
-
- 05 Jun, 2015 1 commit
-
-
Alexander Opitz authored
File names which only differ in upper/lowercase writing are now sorted stable with uppercase first. Resolves: #65319 Releases: master, 6.2 Change-Id: Ib1b907cb8aed6364aadc4f028cfc9294b5c18884 Reviewed-on: http://review.typo3.org/37250 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
Frank Nägler <typo3@naegler.net>
-
- 31 Jan, 2015 1 commit
-
-
Göran Bodenschatz authored
Resolves: #64690 Releases: master Change-Id: Ia785278f0210416a0075e8e6eed712d97fd7272a Reviewed-on: http://review.typo3.org/36513 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Tested-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Steffen Müller <typo3@t3node.com> Tested-by:
Steffen Müller <typo3@t3node.com>
-
- 16 Dec, 2014 1 commit
-
-
Most of TYPO3's PHP files have an empty line before a class' closing curly brace. This commit adds this empty line (if it is missing) before a class' closing curly brace. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: (}\n)(}) Replace: $1\n$2 Resolves: #63942 Release: master Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7 Reviewed-on: http://review.typo3.org/35527 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 13 Dec, 2014 1 commit
-
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
Benjamin Mack <benni@typo3.org>
-
- 08 Dec, 2014 1 commit
-
-
(miscellaneous) Use name-resolution with ...::class instead of strings where possible. (needs PHP 5.5, which is meanwhile required for master) Change-set Iedbb896607adddce2b23ab67f990fa2296c0d1bb first introduced usage of ::class in master. We now add it in various more places. Resolves: #63477 Releases: master Change-Id: Ifa4022cefef28dcfc4fae18e8aa003f6ade21cb3 Reviewed-on: http://review.typo3.org/35091 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com>
-
- 22 Jun, 2014 1 commit
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59780 for further details. Resolves: #59780 Releases: 6.3, 6.2 Change-Id: I00eff31cdff19774527e3b1bb06e29152928414c Reviewed-on: https://review.typo3.org/31025 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- 13 Jan, 2014 1 commit
-
-
Roland Waldner authored
"textfile" will be replaced by "text file" Resolves: #54893 Releases: 6.2 Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b Reviewed-on: https://review.typo3.org/26736 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- 01 Oct, 2013 1 commit
-
-
Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b Resolves: #52360 Releases: 6.2 Reviewed-on: https://review.typo3.org/24212 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- 04 Jul, 2013 1 commit
-
-
Andreas Wolf authored
The recursive file listing, introduced as part of the public API in the fix for #43249, is currently broken. One problem is that the file information retrieval is incomplete: The filename of files in subfolders also contains the path to this file from the current folder, while the identifier is missing that information. The identifier is thus wrong and the filename contains too much information (more than the filename). Additionally, the method getDirectoryItemList() returns the file list with the filenames as key, which will fail when a file name exists twice in different folders. Therefore, this patch changes the keys to numeric values when a recursive folder list is requested. Change-Id: Iaebd862327d2dfc849044236474f6da2444cd4f5 Resolves: #44910 Releases: 6.1, 6.0 Reviewed-on: https://review.typo3.org/17881 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-