- 21 Dec, 2020 1 commit
-
-
Benni Mack authored
This reverts commit 844f024a due to some unexpected behaviour when cropping and scaling, see #93090 and related issues in https://forge.typo3.org/issues/91855 for details Change-Id: If3f38cfeeb860e1a13648d239f05d2754f2f9102 Resolves: #93139 Revertes: #91855 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67203 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- 17 Nov, 2020 1 commit
-
-
To avoid loss of quality and spawning unnecessary imagemagick processes, cropping and scaling of images is now done with a single imagemagick process. By doing so, the code for SVG processing is streamlined. SVG processing code can further be improved later, by putting it into a dedicated file processing task processor. Releases: master, 10.4 Resolves: #91855 Change-Id: I3bf735e74dd46dec73431405f37616506747ccdf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66672 Tested-by:
-
- 06 Oct, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92277 Change-Id: I56783a73d0bd0932ee26ce208e64fabbdc113699 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66039 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- 04 Sep, 2020 1 commit
-
-
Precision of `uniqid()` on Windows systems without passing `$more_entropy=true` has only single-second-resolution which will lead to non-unique ids on subsequent calls. In order to mitigate this issue TYPO3 provides the function `StringUtility::getUniqueId($prefix = '')` which calls `uniqid()` with parameter `$more_entropy` always set to true. Using `uniqid()`, especially with `$more_entropy` set to true, is quite slow, but for the purposes TYPO3 is using it (i.e. creating unique field names for backend forms, path identifiers in some modules etc.) it is good enough and another solution would not provide any measurable benefit. Resolves: #91553 Releases: master, 10.4 Change-Id: Ib4443e72621eee6df2daf5bf23054e1a01325783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65575 Tested-by:
Tizian Schmidlin <st@cabag.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 30 Dec, 2019 1 commit
-
-
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- 18 Dec, 2019 1 commit
-
-
php bin/rector process Releases: master Resolves: #89807 Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448 Tested-by:Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
-
- 27 Nov, 2019 1 commit
-
-
composer require --dev rector/rector:"^0.5.0" This commit introduces the requirement to rector/rector to automatically process code changes by given set of rules. To make this commit more meaningful, a first set "php53" has been processed. Releases: master Resolves: #89785 Change-Id: I6e2ff9654266458ae9fb6800547ff4712b0b66d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62437 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 07 Oct, 2019 1 commit
-
-
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- 27 Aug, 2019 1 commit
-
-
In order to avoid issues creating proper ClassSchema instances for core classes and in order to have a properly renderable documentation with phpdocumentor/phpdocumentor, this patch introduces a new bamboo job that checks all php doc blocks of classes and their properties and methods. Releases: master Resolves: #89023 Change-Id: I13ec766c3ac7c4cea8de84a89e66382ded6d46ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61557 Tested-by:
-
- 23 Aug, 2019 1 commit
-
-
This patch replaces all usages of `strstr()` and its friends where the existence of a certain substring is checked, but the result isn't used at all with `strpos()`, which uses less memory. Resolves: #88922 Releases: master Change-Id: Ie45589ac9410e22e1b48e82dd8086eadb6d74107 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61445 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
- 05 Jun, 2019 1 commit
-
-
Prevents multiple division by zero errors when scaling images, by checking that the input image size is valid (meaning non-zero) before attempting to calculate the ratio for scaling - because the ratio is based on the input size parameters that must not be zero. Change-Id: I33fd3e49a1b3dcdc319309af736a9d785130af94 Releases: master, 9.5, 8.7 Resolves: #87954 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60299 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 16 May, 2019 1 commit
-
-
Due to some heavy history on the caching framework, all Database caches start with "cf_cache_", which is optimized so they are only called e.g. "cache_pagesection" in the database tables. In addition, the prefix "cache_" (in e.g. "cache_core") is unnecessary, and also there due to legacy reasons, reading $this->getCache('cache_runtime') seems very illogical. The following caches have been renamed: - cache_core => core - cache_hash => hash - cache_pages => pages - cache_pagesection => pagesection - cache_runtime => runtime - cache_rootline => rootline - cache_imagesizes => imagesizes Old identifiers can still be called within PHP, but the caching framework throws a deprecation message on setting up such a cache. A silent upgrade wizard will update one's LocalConfiguration to use the new naming scheme. The result is a cleaner, more readable and more streamlined code base (we have caches like "extbase" or "assets" where there is no prefix) and database structure. The patch is breaking due to the change in the database tables. Resolves: #88366 Releases: master Change-Id: I13dcdb0d1bf78f0899615e850856de081b715358 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59661 Tested-by:
-
- 07 May, 2019 1 commit
-
-
In order to enclose and avoid type guessing done by ImageMagick based on mime-type and internal file content checks, new value object class ImageMagickFile has been introduced as guard for those invocations. Resolves: #87588 Releases: master, 9.5, 8.7 Security-Commit: d4f18684b2b2078b51cc7e93abdb251ea846984a Security-Bulletin: TYPO3-CORE-SA-2019-012 Change-Id: I9a2dd74e8548530d7bc83bd18af2f4f0a8212019 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60705 Tested-by:
-
- 15 Apr, 2019 1 commit
-
-
When combining or scaling images, the quality setting needs to be applied as well. Resolves: #31664 Releases: master, 9.5 Change-Id: Iab4d7247c1ee51483b9ede705f6c61ba11f37589 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60464 Tested-by:
-
- 05 Apr, 2019 1 commit
-
-
Although not used in TYPO3 Core directly, the identify command by ImageMagick now delivers the file extension from IM plus the file type identified by IM as well. This saves some regexp magic, and a foreach() loop, as the "-format" output delivers proper IM results. As this functionality is not actually fixing a core bug, but rather a small improvement and correction in the identified usage, the change is targeted to master-only. Resolves: #23348 Releases: master Change-Id: Ia380ee34dbbef7f9f763ecc088ee0c9b83167ce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60311 Tested-by:
Sebastian Rosskopf <sebastian.rosskopf@gmx.de> Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: Markus Klein <markus.klein@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com>
Reviewed-by:
-
- 15 Mar, 2019 1 commit
-
-
Replace string concatenations like 'abc' . 'def' with 'abcdef'. Resolves: #87004 Releases: master Change-Id: I9c1a610e88dd4bd4e617214989a915b1dafda094 Reviewed-on: https://review.typo3.org/c/60155 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- 17 Jan, 2019 1 commit
-
-
In order to harden CommandUtility API arguments used for invoking system commands are escaped in addition. Since no insecure usages have been identified in the TYPO3 core nor in public third party extensions, this change is handled using a public workflow. | In order to evaluate whether third party extensions open a | potential attack vector, usages of CommandUtility::checkCommand(), | CommandUtility::getCommand() and the registration of custom services | ($GLOBALS[‘T3_SERVICES’]) concerning their ‘exec’ argument have to | be checked. Resolves: #87450 Releases: master, 9.5, 8.7 Security-Advisory: TYPO3-PSA-2019-001 Change-Id: If4f2a63045ac7b2473881992f9731a635a768d37 Reviewed-on: https://review.typo3.org/59448 Tested-by:
-
- 07 Jan, 2019 1 commit
-
-
The fallback in site configuration (during 9.3 and 9.4) with all configuration within the subproperty "site" is now removed. - GraphicalFunctions->init() - AbstractHierarchicalFilesystemDriver()->getCharsetConversion() - FAL: FileExtensionFilter + Indexer - file extension + mimetype guessing - ResourceStorage->dumpFileContents() - AbstractService->devLog() Resolves: #87342 Releases: master Change-Id: I107544a129272ebace234e4e7e3ead0ff05a2e5c Reviewed-on: https://review.typo3.org/59335 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
- 29 Sep, 2018 1 commit
-
-
The phpDoc comment "@internal" is used in most places during the development of TYPO3 v7, TYPO3 v8 and TYPO3 v9 and denotes that this specific method, class or property is not part of the Public API, and does not even need any notice if it is removed. However, we still have/had various places in TYPO3 core where "@access private" was used. This is now migrated to "@internal". "@access public" is not needed and is removed. Resolves: #86446 Releases: master Change-Id: Iaef206b04aee13c280d62b107dd7eac04a38c700 Reviewed-on: https://review.typo3.org/58462 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- 25 Aug, 2018 1 commit
-
-
The init method of GraphicalFunctions/Gifbuilder was used instead of a constructor to set up various internal properties, and is now shifted into a new constructor, making the extra call to init() superfluous. Resolves: #85978 Releases: master Change-Id: I71ee3bc8045f48b1636e46681dddd742ba1f56c4 Reviewed-on: https://review.typo3.org/58023 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 18 Jul, 2018 1 commit
-
-
Resolves: #85293 Releases: master Change-Id: Ifabbb20c1ef4ad482df676fe9999dcbdf18eb704 Reviewed-on: https://review.typo3.org/57249 Tested-by:
Rudy Gnodde <rgn@windinternet.nl> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- 15 Jun, 2018 1 commit
-
-
First batch taking care of "easy" places. Resolves: #85283 Releases: master Change-Id: I68fa5a0559aae6191858aba7690ba72918bdf507 Reviewed-on: https://review.typo3.org/57240 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 12 Jun, 2018 1 commit
-
-
TYPO3 has a bound box calculation workaround due to a PHP bug, which was fixed in PHP 7.0.12 / 7.1, which can now safely be removed. Resolves: #85232 Releases: master Change-Id: I72e9ea925ae7e91eea244b89a20b1bec2408ca78 Reviewed-on: https://review.typo3.org/57196 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- 18 May, 2018 1 commit
-
-
Some digicams like iPhone do not rotate images by default. They add a direction entry into the exif meta data. ImageMagick can read this entry if -auto-orient is set. The patch add the rotation detection to the ImageInfo object and the IM/GD commands that read files. Resolves: #69274 Releases: master Change-Id: I4b1193daf1c321a3d4beb8d76974012ee42470f6 Reviewed-on: https://review.typo3.org/48079 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
- 11 May, 2018 1 commit
-
-
Basename and dirname are locale aware and can damage path and file names if they are used with UTF-8 file/path names while a UTF-8 locale is not loaded. The PathUtility wrappers solve this. Releases: master Resolves: #74806 Change-Id: Ibe113a1632b4e61ea87ed9a7dc8600bf3535acab Reviewed-on: https://review.typo3.org/47169 Reviewed-by:
-
- 23 Apr, 2018 1 commit
-
-
This ensures maximum compatibility with all available graphics commands. Resolves: #78600 Releases: master, 8.7 Change-Id: Id7a95fbdf7782fef59e18de3dc4522d7c68b690a Reviewed-on: https://review.typo3.org/56622 Tested-by:
Florian Weiss <typo3org@leblanc.at> Tested-by:
-
- 29 Mar, 2018 1 commit
-
-
All TYPO3 Core areas where typo3temp/var/ was directly used, the new Environment::getVarPath() API is now used. When running via composer or setting the environment variable "TYPO3_PATH_APP", the folder is $projectRootPath . /var otherwise "typo3temp/var/" as before. Additional changes to the default naming scheme - Cache folders are now named lower-case (Cache/Code becomes cache/code). - Install tool session files are stored within "var/session" instead of "var/InstallToolSessions". - Extension Manager files are now within "var/extensionmanager" in a lower-cased variant - log files are now placed into "var/log" instead of "var/logs" - lock files are now placed into "var/lock" instead of "var/locks" Resolves: #84545 Releases: master Change-Id: Ifa57413cd212243387532ffb3435cfca361a582b Reviewed-on: https://review.typo3.org/56413 Tested-by:
-
- 17 Mar, 2018 1 commit
-
-
If `lineHeight` is set then its value would be taken as line height instead of line height calculated from given text. Resolves: #22399 Releases: master, 8.7 Change-Id: Ibc38559a6c7fc616c2b25b419a3bc6feddf87a61 Reviewed-on: https://review.typo3.org/56327 Tested-by:
-
- 02 Mar, 2018 1 commit
-
-
These parentheses are redundant and may be safely removed. Resolves: #84092 Releases: master Change-Id: I59f2b7454316ecd05f57d28e344f03a65d13e5c5 Reviewed-on: https://review.typo3.org/55952 Reviewed-by:
-
- 01 Mar, 2018 1 commit
-
-
To be sure the image (especialy gif format) is correctly repaged after cropping it the +repage option needs to be added to the full command. This patch adds the option for the LocalCropScaleMaskHelper and the ImageBuilder cropscaling `crs` option. Resolves: #83407 Releases: master, 8.7 Change-Id: I27b471d33acdc76c7af28ca0f114be72de91fcb9 Reviewed-on: https://review.typo3.org/55269 Tested-by:
-
- 04 Feb, 2018 1 commit
-
-
When using filters the colorspace is not always applied. A quickfix is to add the colorspace-setting again before writing the output-image. Multiple colorspace-settings on the commandline will be executed in order. For example the grayscale-filter uses "-colorspace GRAY". The final output-image can then be converted to "-colorspace sRGB" again so the brightness appears correct (not too dark) again. Resolves: #78816 Releases: master, 8.7 Change-Id: I3fcabf8fdbb8d43f15662532b881501ebb43b1dd Reviewed-on: https://review.typo3.org/50791 Reviewed-by:
-
- 13 Jan, 2018 2 commits
-
-
Christian Kuhn authored
Apply a series of CGL whitespace fixes, mostly: * No whitespace after type cast * One space around '=' Change-Id: I6279e083a4bd867bfb70c9567c35b6bab1412043 Resolves: #83557 Releases: master Reviewed-on: https://review.typo3.org/55352 Tested-by:
-
Christian Kuhn authored
Apply various minor indentation CGL fixes, as suggested by scrutinizer-ci, mostly related to places where indentation is done with 1 or 3 spaces instead of 4. Change-Id: Ie3345c7391c0735e8074fd633dd9523616a6b82d Resolves: #83555 Releases: master Reviewed-on: https://review.typo3.org/55350 Reviewed-by:
-
- 09 Dec, 2017 1 commit
-
-
Instead of annotating and type-hinting specific cache frontend implementations, TYPO3 should program to the FrontendInterface instead. This patch corrects that. Change-Id: Ibc8d31cf78459e700ab9fe3448a53cbe83bccc61 Resolves: #81461 References: #81432 Releases: master Reviewed-on: https://review.typo3.org/53116 Tested-by:
-
- 27 Nov, 2017 1 commit
-
-
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
-
- 16 Oct, 2017 1 commit
-
-
Properties which are only accessed inside of GraphicalFunctions and should remain inside are marked as protected, are migrated to arrays (to avoid inList calls instead of in_array()), removed or renamed to remove classic kasper's-style double negation namings. Resolves: #82768 Releases: master Change-Id: If45a9198c3a2979a6fe0a1619a9841bd37a2708e Reviewed-on: https://review.typo3.org/54318 Tested-by:
-
- 05 Oct, 2017 1 commit
-
-
The global configuration "png_truecolor" which ensured that generated PNG images only have 64 colors (instead of the max colors) came from the transition 12 years ago to keep a small file size for PNG images. The option was turned on for new installations and existing installations, and if not explicitly disabled, generated true-color PNG images at any time. The option did not have any effect for FAL-related image resizing at all. In order to generate PNGs with a limited color-space, it is still possible to do so with additional "reduceColors" option, as well as adding additional parameters to ImageMagick when needed. However, having a global option for this feature seems to be not practical these days anymore. Resolves: #82680 Releases: master Change-Id: I3e00cc1c37a5ed8287dcf7cad49d2a2ab10730e6 Reviewed-on: https://review.typo3.org/54277 Reviewed-by:
-
- 03 Oct, 2017 1 commit
-
-
DefaultConfiguration setting is 70 (default since 12 years), but the FactoryConfiguration setting is set to "80" for new installations. This change raises all image quality settings to "85" if not overridden by any installation (= new installation in the last 10 years or not changed via the install tool), as we don't have a big file size issue with JPGs anymore and we don't have duplicates anymore (due to FAL instead of uploads/pics/mypic_13.jpg) and the internet connections got better. Resolves: #82655 Releases: master Change-Id: Ibcb38ece4038a414bfcae103463c727ed3cf65c0 Reviewed-on: https://review.typo3.org/54267 Tested-by:
-
