Skip to content
GitLab
Switch branch/tag
  1. 14 Jan, 2022 1 commit
  3. 13 Jan, 2022 1 commit
  5. 11 Jan, 2022 3 commits
  7. 05 Jan, 2022 6 commits
    • Stefan Bürk's avatar
      [BUGFIX] Provide quoted array to string-list implode support · dc2c9dbd
      Stefan Bürk authored and Christian Kuhn's avatar Christian Kuhn committed 
      With #96393 forward-compatible prepared statement
suport has been added, which lacks support for the
broadly known doctrine/dbal 'PARAM_STR_ARRAY' and
'PARAM_INT_ARRAY' types.

Internal methods as alternatives were introduced
as core internal methods with #92493 in the internal
'QueryHelper' class.

This patch now moves these internal implementations
to the 'QueryBuilder' to provide an forward-compatible
public alternative, which is needed to prepare statements
with 'in()' or 'notIn()' expression with array values,
which can only be used as non-placeholder, which is not
supported by PHP PDO implementation.

Further usage of internal implementation which was
introduced with #92493 are replaced with new public
methods and internal methods in QueryHelper removed.

Resolves: #96434
Related: #96393
Related: #92493
Releases: main, 11.5
Change-Id: I1f7f532eb82a248a28d8d7ec707d678d59a73ec0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72885

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      dc2c9dbd
    • Ingo Fabbri's avatar
      [TASK] Adjust QueryBuilder PHPDoc comments · cdb016b3
      Ingo Fabbri authored and Christian Kuhn's avatar Christian Kuhn committed 
      Some methods have the wrong type declaration.
E.g. string instead of mixed.
Add type-hints for completeness.

Resolves: #96463
Releases: main, 11.5
Change-Id: I415e8fa572ecbe278aa8323fd206494d314c559f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72882

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      cdb016b3
    • Benni Mack's avatar
      [BUGFIX] Mark shortcut pages as active in HMENU · a6593bd9
      Benni Mack authored 
      This change moves the method resolveShortcutPage()
into PageRepository as it is now also used in determining
if a page is marked as active / current.

The method `resolveShortcutPage()` is much more convenient
when working with $page records instead of the properties,
instead of `getPageShortcut()`.

This also allows MenuProcessor to have a proper "active"
and "current" values set properly without any workarounds.

Resolves: #85138
Resolves: #80841
Resolves: #87923
Releases: main, 11.5
Change-Id: Ic401fb42696757199c5974120f24250c467d9b75
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72881

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      a6593bd9
    • Stefan Bürk's avatar
      [BUGFIX] Resolving page slug ending with index and type suffix '.php' · 8b3e6321
      Stefan Bürk authored and Benni Mack's avatar Benni Mack committed 
      If a page slug ends with 'index' and site has a routing
configuration with a PageTypeSuffix with index and suffix
'.php' as default suffix, route resolving cuts 'index.php'
from the uri, ending with a slug without index in it and
thus not resolving the page and displaying 404 page.

The reason for this is the code fragment which strips the
document root from the uri as a cleanup for some systems,
and fixes an issue for calling id/type parameters with
index.php (main entry point), which has been added as a
bugfix in v9 with #88028.

There was a first attempt to fix this page resolving issue
with #94537, which has been a regression and reverted with
issue #94968.

To ensure everything works and regression is covered before
a new patch, there has been two patches with #95096 and #95362.

After the regression there has been a really deep analysis,
to get all puzzle pieces together over the time, which ended
in the pre-patches and finally in this patch.

The stripping of the document root has been implemented to
late in the resolving chain to solve #88028, thus the followup
fixes interferred with the resolving concept. This patch moves
this stripping from the page-resolving point some steps early
to the site-resolving step, and doing the stripping only on
the left site of the uri and avoiding a generall str_replace(),
thus fixing past issues and the current issue in the correct
place.

Furthermore tests for this issue are (re)added with this patch,
as they were removed with the revert.

Resolves: #94905
Related: #95096
Related: #95362
Related: #94537
Related: #94968
Related: #88028
Releases: main, 11.5
Change-Id: I2e10689893047e2d8f19057dfac2fb3b5f0bdcde
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72880

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      8b3e6321
    • Nikita Hovratov's avatar
      [BUGFIX] Add TCA migration for select authMode keywords · dd291132
      Nikita Hovratov authored and Oliver Bartsch's avatar Oliver Bartsch committed 
      With the introduction of itemGroups, the index 3 of
the select items array has been shifted one position
to the right. Before that, the index 3 was used for
descriptions and index 4 for an optional keyword
EXPL_ALLOW or EXPL_DENY. These are used together
with authMode=individual to explicitly allow or deny
single items.

Since descriptions now occupy the index 4, the
former usage of this index needs to be shifted as
well to index 5.

For backwards compatibility reasons, a TCA migration
is added, which will check for these special
keywords and move them one index up.

Resolves: #96444
Related: #91008
Releases: main, 11.5, 10.4
Change-Id: I32a96f5c6377871551ab4ee60a402a585da7eaa0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72877

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
      dd291132
    • Ingo Fabbri's avatar
      [BUGFIX] Add CompositeExpression argument docblock type-hint · 10fff855
      Ingo Fabbri authored and Benni Mack's avatar Benni Mack committed 
      This patch adds missing 'CompositeExpression' as union
type for QueryBuilder methods 'where()', 'andWhere()'
and 'orWhere()' to match the ability of the underlaying
doctrine/dbal QueryBuilder methods.

Resolves: #96457
Releases: main, 11.5, 10.4
Change-Id: Ib9330ffabcdc7680bfd5bb8a991cec60889c9773
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72878

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      10fff855
  9. 04 Jan, 2022 1 commit
  11. 03 Jan, 2022 2 commits
  13. 30 Dec, 2021 1 commit
  15. 23 Dec, 2021 1 commit
  17. 21 Dec, 2021 3 commits
  19. 20 Dec, 2021 3 commits
  21. 18 Dec, 2021 1 commit
  23. 17 Dec, 2021 1 commit
  25. 16 Dec, 2021 3 commits
  27. 15 Dec, 2021 2 commits
  29. 14 Dec, 2021 2 commits
  31. 13 Dec, 2021 2 commits
  33. 12 Dec, 2021 1 commit
    • Helmut Hummel's avatar
      [TASK] Simplify ErrorHandler code · 1167b9fa
      Helmut Hummel authored 
      To decide whether an error should be handled by the ErrorHandler
or not, only three things must be taken into account.

1. The current error_reporting() level
2. Error levels that are ignored by configuration
3. Error level of the error that is just handled

When combining the first two (with logical and),
results in the error level for the errors
that should be handled at all.

When combining this with the error level of the
currently handled error (again with logical and),
we can determine wether the error should be handled or not.

This always works with any PHP version and with suppressed
errors and without.

Therefore the PHP version check becomes obsolete and is removed.

Releases: main, 11.5
Resolves: #96311
Change-Id: I96d440d9db05a3acf1f8a12664787e05a3e31254
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72581

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Helmut Hummel's avatarHelmut Hummel <typo3@helhum.io>
Reviewed-by: Helmut Hummel's avatarHelmut Hummel <typo3@helhum.io>
      1167b9fa
  35. 10 Dec, 2021 2 commits
  37. 09 Dec, 2021 2 commits
  39. 08 Dec, 2021 1 commit
  41. 07 Dec, 2021 1 commit