Commits · ddc5d1f83607335d9231abf1025b51d07349bff5 · typo3 / typo3

14 Jan, 2022 2 commits

[BUGFIX] Avoid undefined array key error when copying record · ddc5d1f8

Chris Müller authored Jan 11, 2022 and

Christian Kuhn committed Jan 14, 2022

This happens when "transOrigPointerField" is not defined in TCA configuration.

Additionally, a PHP 8.1 deprecation is fixed when passing a null to trim().

Resolves: #96514
Releases: main, 11.5
Change-Id: Ic99bd0b0c166397bda23d2e45ca2d4cb766000be
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72981

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

ddc5d1f8

[BUGFIX] Avoid evaluating all regexp redirects if early match found · 77e2740e

Stefan Bürk authored Jan 07, 2022 and

Christian Kuhn committed Jan 14, 2022

ext:redirects middleware collected all possible redirects,
thus evaluating all regexp redirects to find possible matches.
These collected possible redirects are looped afterwards and
checked, if redirect is active, meaning not having any start
and/or end time constraints or if time constrain is in the active
timespan, returning the first feasible redirect. However this
evaluated all regexp redirects, even if flat redirects with query
arguments, flat redirects without query arguments or a regexp
redirect is found.

This patch changes this behaviour and checks early for found subset
of possible redirects to avoid evaluating at least all regexp
redirects even if an early one would be used anyway.

This is a minor performance improvement in case an early redirect
can be matched, without any effect if no match could be found.

Further performance improvements may be possible but should be done
in dedicated follow up patches.

Resolves: #96480
Releases: main, 11.5
Change-Id: I84170a701d578a74a1780fd87a33d4f3a9af43e8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72980

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

77e2740e

13 Jan, 2022 1 commit

[BUGFIX] Streamline typehints of variadic arguments in QueryBuilder · 253e7dc1

Elias Häußler authored Jan 11, 2022 and

Christian Kuhn committed Jan 13, 2022

Doctrine uses mixed type for most of their method arguments in
QueryBuilder. Since TYPO3 core uses variadic arguments for some
methods in the wrapping QueryBuilder, argument types have been
streamlined to match the ones in the concrete QueryBuilder
instance from Doctrine.

Resolves: #96507
Related: #96457
Releases: main, 11.5, 10.4
Change-Id: I834240f764feac7af9fba7db0d45aaf4927abb2e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73009

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

253e7dc1

12 Jan, 2022 3 commits

[BUGFIX] Use optgroup in SelectMultipleSideBySideElement · 25c72dd4

Oliver Bartsch authored Jan 11, 2022

Instead of using multiple "fake" <option> elements with
the same value `--div--`, the SelectMultipleSideBySideElement
does now use proper HTML <optgroup> elements for grouping
of the available options. This is in line with other
select elements, e.g. the SelectSingleElement.

Besides the improved HTML markup, this also improves
the UI, since the <optgroup> element is non-selectable.
It is also no longer considered by the filter, which
previously led to confusion, especially when filtering
and having the "dividers" as only options left.

Resolves: #95137
Releases: main, 11.5
Change-Id: Ia51e2623217eb0c7abd6c0cd2e9c4a742686641d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72992

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72993

25c72dd4

[TASK] ClickEnlargeViewhelper PHP 8.0/8.1 compatibility · 69acbc3a

dev-rke authored Jan 11, 2022 and

Christian Kuhn committed Jan 12, 2022

Fixes 'Undefined array key "crop"' exception in PHP 8.0/8.1
when rendering an image with enabled clickenlarge and defined
cropVariants.

Releases: main, 11.5
Resolves: #96508
Change-Id: I47dfdf4a1a8c2d5f8465e84eb93c06ed4bb292ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72979

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

69acbc3a

[BUGFIX] Make tstemplate respect hidden flags for sys_template records · 312aef24

Benni Mack authored Jan 10, 2022

Previously, the tstemplate Object Browser would wrongly show hidden
typoscript templates, if they were the first one to be found
(which determined by the sorting key).
The hidden flag will now only be ignored, if a hidden template is
explicitly requested by its uid (using the template selector switch).

Resolves: #88507
Releases: main, 11.5
Change-Id: Ibbfeb2de7f8ee79a1e343ff23f9d1064219eb344
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72978

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

312aef24

11 Jan, 2022 9 commits

[BUGFIX] Calculate action menu generation earlier in PageLayoutController · 1af546ff

Oliver Bartsch authored Jan 11, 2022

With #95387 the menu generation of the page module
was moved to the end of the request handling method.

However, the `makeActionMenu()` method does currently
not only create the menu but does also make some sanity
check, whether the currently selected `function` is actually
available.

If not, the `function` is reset to the default ("columns mode").
This e.g. happens when in languages mode and then switching
to another domain / another site, which is single language only.
This then led to the user being unable to work in "columns mode",
since no action menu is generated for such sites.

This is now fixed by executing the mentioned method before the
content gets generated.

Resolves: #96084
Related: #95387
Releases: main, 11.5
Change-Id: Iadb67ece1724b6d34a4724d7782bdd295cece642
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72977

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

1af546ff

[BUGFIX] Do not hsc twice the title in indexed search · 455999e2

Benni Mack authored Jan 08, 2022

The path gets htmlspecialchared with linkPageATagWrap()
and before that it gets treated within getPathFromPageId()
already.

This change removes the double encoding.

Resolves: #90935
Releases: main, 11.5
Change-Id: I7fd9c1afa4462f5d59618ca5ef760356e5d2fa0d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72976

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

455999e2

[BUGFIX] Use proper regexp for Vimeo URLs in online media helper · 95620d0e

Oliver Hader authored Jan 11, 2022 and

Oliver Hader committed Jan 11, 2022

The change for issue #94357 introduced handling for `event/` URLs,
and accidentally modified handling for `video/` URLs as well. As a
result, the `video/` IDs were incorrectly resolved containing a
leading slash.

Resolves: #96509
Releases: main, 11.5, 10.4
Change-Id: I5623ff59dac44a699877e4e5a2e91707f72a407e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72968

Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

95620d0e

[BUGFIX] Keep anchor in legacy link browser for pages · defbd609

Benni Mack authored Jan 09, 2022

This change keeps the anchor when clicking on a page
in the link browser.

Resolves: #93893
Related: #89033
Releases: main, 11.5
Change-Id: I65a876a4fecf508b810e08116810f3cd73e30c19
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72975

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

defbd609

[BUGFIX] Avoid empty entries in scheduler CF garbage collection · b5ad778b

Christian Kuhn authored Jan 11, 2022

When having an extension loaded that specifies a cache
without a specific backend like ext:adminpanel, the caching
framework falls back to default Typo3DatabaseBackend.

The scheduler task "Caching framework garbage collection"
does not reflect this and renders an empty entry when no
specific backend is configured.

Fix this by adding the fallback to the tasks additional
field provider, too.

Resolves: #96504
Releases: main, 11.5
Change-Id: I985ff3b9888723986e7938238be99e45c1999064
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72974

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

b5ad778b

[BUGFIX] Avoid bogus title in new record controller · 546f4c40

Christian Kuhn authored Jan 11, 2022

NewRecordController (+ icon in doc header of list
module) renders "Create a new page" on top. This
is not a link and looks misplaced.

It is a 'section header' for optional content that can
be enabled via pageTS.

mod.wizards.newRecord.pages.show.pageSelectPosition = 1
mod.wizards.newRecord.pages.show.pageInside = 1
mod.wizards.newRecord.pages.show.pageAfter = 1

When at least one of these are enabled, the header
makes sense, but should be avoided otherwise.

Resolves: #96505
Releases: main, 11.5
Change-Id: I6468cda44e719f268f6b59d7e61f240737da6f33
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72973

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

546f4c40

[BUGFIX] Avoid PHP 8 warnings in ext:scheduler · 379679b7

Christian Kuhn authored Jan 11, 2022 and

Oliver Bartsch committed Jan 11, 2022

Scheduler backend module -> Add button -> add some valid
information that makes the form save correctly -> "Save
and new" from docheader save drop down -> boom.

Resolves: #96506
Releases: main, 11.5
Change-Id: I8eacf1f5f958605f3505761a64902a71bcc0c7dd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72972

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

379679b7

[TASK] Set TYPO3 version to 11.5.6-dev · cc428465

Oliver Hader authored Jan 11, 2022 and

Oliver Hader committed Jan 11, 2022

Change-Id: I7acf728adcceb640d21918dcabe77f5cacfa66f1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72959

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

cc428465

[RELEASE] Release of TYPO3 11.5.5 · 45452ea7

Oliver Hader authored Jan 11, 2022 and

Oliver Hader committed Jan 11, 2022

Change-Id: Ia82e7fc67597b331ddb8f7eb35afb0598899a397
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72958

Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

45452ea7

10 Jan, 2022 10 commits

[BUGFIX] Correctly apply config.absRefPrefix to _assets resources · ef4f9a6d

Oliver Hader authored Jan 10, 2022 and

Oliver Hader committed Jan 10, 2022

When using a composer-based installation, public frontend assets
such as JavaScript of stylesheet files are exposed in a dedicated
`_assets/` folder. In those scenarios TypoScript settings for
`config.absRefPrefix` need to be applied as well.

Resolves: #96452
Releases: main, 11.5
Change-Id: I0695850be18c9c152c647883c122a0680e8e734f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72954

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

ef4f9a6d

[BUGFIX] Enforce functional colors package · 69a5ab4b

Andreas Fernandez authored Jan 10, 2022

The maintainer of the `colors` package decided to rampage and released
a bonkers version, see [1] and [2], causing an implosion of the npm eco
system.
Albeit TYPO3 uses this as a transitive dependency only, we're going
to be safe and enforce this package to version 1.4.0, the current known
to-be-stable version.

[1] https://github.com/Marak/colors.js/issues/285
[2] https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/

Resolves: #96499
Releases: main, 11.5, 10.4
Change-Id: Ic8ad9105c9a9bc45bb2519547bb044be672db27c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72951

Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

69a5ab4b

[BUGFIX] Restore sort link in FileList · 3cc1c169

Oliver Bartsch authored Jan 10, 2022 and

Benni Mack committed Jan 10, 2022

This restores the sort link for columns with
"special" label, such as "tstamp" or "crdate".

Resolves: #96489
Releases: main, 11.5
Change-Id: Iae7c9d2056256df5156f6fe8773d6b18e7ba8898
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72927

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

3cc1c169

[TASK] Update CKEditor to v4.17.1 · b3d18486

Oliver Hader authored Jan 10, 2022 and

Oliver Hader committed Jan 10, 2022

Update to CKEditor v4.17.1 which addressed browser compatibility
issues and known security vulnerabilities:

https://ckeditor.com/cke4/release-notes

Commands:
  rm -r typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib
  cd Build
  yarn add 'ckeditor4@^4.17.1'
  yarn build

Resolves: #96494
Releases: main, 11.5, 10.4
Change-Id: I87039f5a5d1fe7488f6d4c5d0c36e90421d4c93e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72929

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

b3d18486

[TASK] Unify TSFE usage consistently in HMENU · 3e6e92bd

Benni Mack authored Jan 09, 2022

Some code in HMENU stems back from TYPO3 v3.x days,
and this code aims to streamline the functionality
given current functionality.

HMENU now has its own sys_page object, which should
be used. In addition, HMENU should fetch TSFE->id
consistently across all its code base.

Resolves: #96492
Releases: main, 11.5
Change-Id: I971a5958417077d51ea5c5070fc4b9ef513cd738
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72928

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

3e6e92bd

[TASK] Update @claviska/jquery-minicolors to v2.3.6 · e0783961

Oliver Hader authored Jan 10, 2022 and

Benjamin Franzke committed Jan 10, 2022

Update to @claviska/jquery-minicolors v2.3.6 which addressed
known security vulnerabilities:

https://security.snyk.io/vuln/SNYK-JS-CLAVISKAJQUERYMINICOLORS-1930824
https://github.com/claviska/jquery-minicolors/releases/tag/2.3.6

Commands:
  cd Build
  yarn add '@claviska/jquery-minicolors@^2.3.6'
  yarn build

Resolves: #96495
Releases: main, 11.5, 10.4
Change-Id: Iaafdd29dd50a18321746fb36702702302078fceb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72926

Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

e0783961

[BUGFIX] Exclude pages from linkvalidator path · 0f50cf35

Oliver Bartsch authored Jan 07, 2022

The linkvalidator module shows the path to the page,
a broken link is on. Since editors might only have access
to a subtree (mount point), the corresponding parent
pages should not be displayed.

This is now fixed by providing the necessary permission
clause to `getRecordPath` in LinkValidatorController.

Resolves: #92539
Releases: main, 11.5
Change-Id: Ibdb54560561dba5d7ad932d89ff5b73fc558f5f2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72941

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

0f50cf35

[BUGFIX] Fix rootlevel check in ListModule fieldControl · 021bc8d9

Oliver Bartsch authored Jan 07, 2022

Resolves: #96481
Releases: main, 11.5
Change-Id: I41eeb4ecf0b90e998875701131b2c8a35bfa3225
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72925

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

021bc8d9

[BUGFIX] Use typolink in EmailViewHelper · 43944c34

Benni Mack authored Jan 07, 2022

This change uses typolink in EmailViewHelper,
allowing to also use typolink hooks or custom
Email Link Builder to be used consistently
across TYPO3 Core (e.g. using the same hooks
for all email link generation in the Frontend).

Resolves: #96483
Releases: main, 11.5
Change-Id: Ia573dc5a7ebb9ca7f0f0b6b35126bd789f86a627
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72924

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

43944c34

[TASK] Clean up Page Link Builder code · 9f562632

Benni Mack authored Jan 07, 2022

During the main work of TYPO3 v9 when Site Handling
was introduced, the Page Link Builder turned into
a single monster-method.

Now, that most bugs are solved and we have a very good
test coverage for this, this change splits several
functionality into smaller methods, allowing for better
readability, extensibility and further refactoring.

Extending PageLinkBuilder now is much easier to replace
a certain part of the existing functionality (also via XCLASS).

Resolves: #96484
Releases: main, 11.5
Change-Id: I231cf3c13ec15dd1ad99f710ca27ce340c0deee2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72923

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

9f562632

08 Jan, 2022 1 commit

[TASK] Switch description of partialRootPaths and layoutRootPaths · 33b6e0a9

Stefan Frömken authored Jan 08, 2022 and

Christian Kuhn committed Jan 08, 2022

Releases: main, 11.5
Resolves: #96488
Change-Id: I0ced03e4d551048414022214b832b3ceeb51400d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72922

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

33b6e0a9

07 Jan, 2022 6 commits

[TASK] Extract inline mn attribute scenario from ext:irre_tutorial · 36edcee3

Anja Leichsenring authored Jan 07, 2022 and

Christian Kuhn committed Jan 07, 2022

The scenario provided by tables tx_irretutorial_mnasym_* gets
its own test extension and gets loaded where needed.

Resolves: #96458
Releases: main, 11.5
Change-Id: I905bc6b7e33c54e343828f9569624fdd60042c2d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72921

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

36edcee3

[BUGFIX] Fix sprintf() PHP warning in FinisherOptionGenerator · 56ac7aa8

Benjamin Franzke authored Jan 07, 2022

User supplied strings must not be concatenated into the format
parameter of sprintf() as sequences like %s, or (more likely) %20S
(which is ' S' url escaped) may be contained and cause warnings
because sprintf() expects additional arguments in that case.

Streamline to always use the static '%s: "%s"' format instead.

Releases: main, 11.5, 10.4
Resolves: #96478
Change-Id: Ic3b09c6e1e7c617e78ea405289680bd78d0aab64
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72920

Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>

56ac7aa8

[BUGFIX] Prevent redirects causing infinite redirect loops · aeba438a

Jörn Wagner authored Dec 28, 2021 and

Benni Mack committed Jan 07, 2022

This patch adds a check to detect self referencing
redirects, thus avoiding them and instead log an error
in the corresponding frontend redirect middleware.

Furthermore, add a bunch of tests along the way to cover
this change and the different constellations, for example
not avoiding redirect with the same path but external host.

Resolves: #96427
Releases: main, 11.5, 10.4
Change-Id: I554ba51b53065dd754068e379f69c2a5dffc3054
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72918

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

aeba438a

[BUGFIX] Prevent undefined array key in PageLinkHandler · 8bfa7b9f

Oliver Bartsch authored Jan 07, 2022

Resolves: #96479
Releases: main, 11.5
Change-Id: I8f054a9dd38e8b25ac606c002f95cb673e4e280c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72919

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

8bfa7b9f

[TASK] Use ORDER BY uid DESC in LiveSearch · d673b7f6

Stefan Froemken authored Dec 15, 2021 and

Christian Kuhn committed Jan 07, 2022

Sorting query results by text columns may require
a filesort on harddisk which is slow. To boost up
the search results of LiveSearch we have added
an ORDER BY uid DESC to always show the newest
created records first. Column "uid" exists in
all TCA tables and as it is PRIMARY INDEX
sorting will happen in memory.

Resolves: #96365
Releases: main, 11.5
Change-Id: Icbf6e8c7717a495aaee995ff09cf2cd882173e65
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72917

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

d673b7f6

[BUGFIX] TypoLink is executed fully without href attribute · 6bda1ea5

Benni Mack authored Jan 06, 2022 and

Oliver Bartsch committed Jan 07, 2022

In #87992 an early return was added to have <a> tags
with just an "id" or "name" attribute. This is all nice,
but when used further typolink settings (such as userFunc
or custom "title"), these options were never run.

This change now uses typolink() natively again and
removes the introduced "resolveAnchorLinK" workaround.

Added tests show that additional attributes are executed
and links without href are actually created (was previously
untested).

Resolves: #96464
Related: #87992
Releases: main, 11.5
Change-Id: I67d4090228684fc89f72bc3d6367109437040ccf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72916

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

6bda1ea5

06 Jan, 2022 7 commits

[TASK] Ensure ATagParams are overridden from global option · 8819a39e

Benni Mack authored Jan 06, 2022

This change mainly adds tests for showing that
the global TypoScript option

  config.ATagParams = tabindex="20"

can be used and any given attributes are actually
overridden if using typolink.ATagParams = tabindex="13".

Resolves: #71703
Releases: main, 11.5
Change-Id: I984d66ecf7c303381e64e447a0cac731f055a567
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72915

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

8819a39e

[BUGFIX] Ensure config.spamProtectEmailAddresses = ascii works for external URLs · d8e25e2c

Benni Mack authored Jan 06, 2022

When having a page of type "External URL", set to
an email address, and config.spamProtectEmailAddresses = ascii
set in TypoScript, the encoding now works properly.

Resolves: #87787
Releases: main, 11.5
Change-Id: I15563f08a8a0007dc292f5d7e1a311e38a55db26
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72914

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

d8e25e2c

[BUGFIX] Mark broken links to hidden page and CEs · 83daec59

Sybille Peters authored Dec 06, 2020 and

Benni Mack committed Jan 06, 2022

Broken links are marked in RTE by using the attribute
data-rte-error in the <a> tag, which results in a
special style and lets the link be visible as broken.

Previously this was not done for links to hidden pages
and links to content elements. These links were however
detected as broken by linkvalidator and displayed in
the list of broken links. Marking them in RTE as well
makes the behaviour consistent.

This patch ensures the consistency between the list
and the visual highlighting in RTE elements for links
to hidden pages and hidden content elements.

Highlighting links to hidden pages/content elements
on hidden pages may be visually relaxed to a notice
instead of an error in a dedicated patch as feature.

One PHP8.0 array key warning is fixed along the way.

Resolves: #93005
Releases: main, 11.5
Change-Id: Ib1ef4b81ab862657950a38e5ee6847dd82abb13f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72913

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

83daec59

[BUGFIX] Use typolink consistently for makelinks functionality · 095b636f

Benni Mack authored Jan 06, 2022

TYPO3's "makelinks" functionality parses for in-text
external URLs and mailto links. This change uses
Typolink under the hood now to consistently check
for invalid content, and have the chance to use
all hooks in typolink for such links as well.

This way, typolink is used, but makelinks is
executed AFTER possible resolved <a> tags
avoiding double-calling parseFunc when <a> tag
processing is configured.

Resolves: #93012
Releases: main, 11.5
Change-Id: I574915e715793f6eccad1bdfc216e82e329179dd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72912

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

095b636f

[BUGFIX] Check for excludeUidList in HMENU of default language · 12fdd9e4

Benni Mack authored Dec 23, 2021

This change now always checks for the actual page ID
in the default language, not of the translated page
to see if the page should be excluded.

Resolves: #94427
Releases: main, 11.5
Change-Id: I89c67b7955ccb69af28accbcf573576156919481
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72891

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

12fdd9e4

[TASK] Extract simple mn attribute scenario from ext:irre_tutorial · 7f6fd46c

Anja Leichsenring authored Jan 06, 2022 and

Christian Kuhn committed Jan 06, 2022

The scenario provided by tables tx_irretutorial_mnattr_* gets
its own test extension and gets loaded where needed.

Resolves: #96459
Releases: main, 11.5
Change-Id: I48b08772f8c4d64f8a3ea930fc307a8d5d3f2189
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72890

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

7f6fd46c

[BUGFIX] Ensure correct test expectation for hierarchicalMenuIsGenerated · c817e35c

Stefan Bürk authored Jan 06, 2022 and

Oliver Bartsch committed Jan 06, 2022

Merging #22190 shortly after #96470 has introduced a invalid
test case expectation, which fails now core ci execution.

This patch adds a missing 'target' expectation for the test
added through #22190 to match introduced expectation with #96470.

Resolves: #96472
Related: #22190
Related: #96470
Releases: main, 11.5
Change-Id: Ia92c71302a8d875b2b8f5c23aac97bfa7e3bfadc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72889

Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

c817e35c

05 Jan, 2022 1 commit

[TASK] Ensure that hidden pages are not rendered as subpages in HMENU · 1072b2a3

Benni Mack authored Jan 05, 2022 and

Oliver Bartsch committed Jan 06, 2022

This change adds tests to a very old issue to ensure
that a page with only hidden subpages is not marked
as IFSUB etc.

MenuProcessor is extended to set a "hasSubpages" flag
when IFSUB, CURIFSUB or ACTIFSUB is set.

Resolves: #22190
Releases: main, 11.5
Change-Id: Ia9b73e8ae1028eafa94ba4fa5ca0dacf2562c074
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72888

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

1072b2a3