- 13 Apr, 2020 1 commit
-
-
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 20 Jul, 2019 1 commit
-
-
Context is stateful as Aspects dependent on the (currently dispatched) request type (frontend/backend/installtool/CLI). Reqest-dependent arguments can not be injected during service creation; therefore the Context class is now created without default aspects and enhanced by the application classes (on demand). Note: The UserAspect constructor is adapted to use an explicit stdClass allocation instead of an immutable array casted to an object for the (fallback) pseudo user. This is to avoid php segmentation faults in functional tests (and also random unit test runs). The segmentation faults would be triggered due to the constructor change in the Context class, which now uses ondemand instead of preemptive Aspect creation. Background: immutable arrays are stored on stack. The cast to an object probably didn't relocate this memory to the heap which then causes segmentations faults when the static memory area (on stack) is exceeded. Releases: master Resolves: #88793 Change-Id: Ib165f85b66b34e8025e28ef483260463f1e2c826 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61274 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- 04 Sep, 2018 1 commit
-
-
Due to refactorings lately in BackendUtility::getPagesTSconfig() with which results in a fatal error when clearing page cache while persisting an extbase object. The patch adds a test without a Backend User, and encapsulates this with a simple if() statement. However, this also shows that some other areas that are touched are not fully notice-free / strict, which are tackled as well. Resolves: #85310 Releases: master Change-Id: I0f1318d395451e704e1783e841d96583efe2a560 Reviewed-on: https://review.typo3.org/58174 Reviewed-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- 30 Aug, 2018 1 commit
-
-
This patch implements the symfony expression language for TypoScript conditions in frontend and backend and is a preparation for the old conditions being deprecated. The existing conditions are available as variables and/or functions. This enables the full power of symfony expression language for TypoScript conditions. Resolves: #85829 Releases: master Change-Id: I7bcb7940ae1c36500eb7dc40fe84c7dd48d674a6 Reviewed-on: https://review.typo3.org/57787 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- 27 Jun, 2018 1 commit
-
-
A new "Context" concept is added which allows to keep the state of common TYPO3 Request Data in form of so-called Aspects. An aspect contains properties which can be fetched, but only the ones that are really necessary, instead of exposing a full object (e.g. BE_USER). The main goal is to centralize some global variables distributed in various places. In the first step the following variables are considered: - $TSFE->showHiddenPages - $TSFE->showHiddenRecords - $TSFE->beUserLogin - $TSFE->gr_list - $TSFE->loginUser - $GLOBALS[SIM_EXEC_TIME] - $GLOBALS['BE_USER']->workspace For now the Context is a singleton object, but should be fetched from a DI container. Sometimes a custom context is necessary, so it is cloned (see usage in TSFE). The difference to the PSR-7 request attributes is that the context is ONLY related to data access (like permissions / visibility) and also independent if TYPO3 is running via HTTP or CLI (thus, can be used in CLI mode as well). Next Steps: - Migrate PageRepository->versioningWorkspaceId - Migrate TSFE->simUserGroup - Use DateTimeAspect everywhere - Introduce Language + Page Aspects - Introduce the context object into ContentObjectRenderer and cObjects - Use Contexts in RestrictionContainers - Use Contexts in TYPO3 Backend - Decouple sys_page behaviour from TSFE where applicable - Ensure TypoScript conditions continue to work / have a documented alternative Resolves: #85389 Releases: master Change-Id: I9e27e581a1632fcd8c3c6a9e0954b76b91f42c52 Reviewed-on: https://review.typo3.org/57104 Tested-by:
Stefan Bürk <stefan.buerk@pure-metal.de> Tested-by:
-
