- 09 Apr, 2021 1 commit
-
-
Benni Mack authored
This change adds a new ModuleTemplateFactory, which is built with the Request in the object, allowing to use the current request of the current action. At the same time, all TYPO3 Core controllers use proper DependencyInjection now, making it easier to spot the dependencies and uses PSR-7 Request where possible. Resolves: #93885 Releases: master Change-Id: Ia6594a1e68c5c27375f34e49bffeda4dcbc980d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68729 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
-
- 10 Dec, 2020 1 commit
-
-
Inline JavaScript produced by BackendUtility:viewOnClick is substituted with markup based instructions and static JavaScript event handlers. // basically delivers window.open(generatedUri) BackendUtility::viewOnClick($pageId, $backPath, $rootLine, $section, $viewUri, $getVars, $switchFocus); can be substituted with e.g. \TYPO3\CMS\Backend\Routing\PreviewUriBuilder::create($pageId, $viewUri) ->withRootLine($rootLine) ->withSection($section) ->withAdditionalQueryParameters($getVars) ->serializeDispatcherAttributes([ PreviewUriBuilder::OPTION_SWITCH_FOCUS => $switchFocus, ]); which results in the following HTML data attributes (data can be retrieved as array of complete element as well) data-dispatch-action="TYPO3.WindowManager.localOpen" data-dispatch-args="["https://...",null,"previewWin"]" Resolves: #91123 Releases: master Change-Id: Iedd9bfe60827977677ee68e2c948c63e359abf84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64243 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 13 Apr, 2020 1 commit
-
-
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 30 Jan, 2020 1 commit
-
-
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
-
- 13 Jul, 2019 1 commit
-
-
The ImportExportController is responsible for exporting and importing data, which is a bit too much. In order to streamline the import/export functionality, the controller has been split into two controllers. Due to this, the route to the ImportExportController has no effect anymore, but is kept for bc reasons. Resolves: #88662 Releases: master Change-Id: If2beb9da8d65b6a054b616832712017df2a9c6b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61202 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
