- 09 Apr, 2021 3 commits
-
-
Benni Mack authored
This change adds a new ModuleTemplateFactory, which is built with the Request in the object, allowing to use the current request of the current action. At the same time, all TYPO3 Core controllers use proper DependencyInjection now, making it easier to spot the dependencies and uses PSR-7 Request where possible. Resolves: #93885 Releases: master Change-Id: Ia6594a1e68c5c27375f34e49bffeda4dcbc980d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68729 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
The lowlevel bindValue() API is re-introduced in a way that supports both Doctrine 3.0 and Doctrine 2.10 (for TYPO3 v10) by checking for the ->getIterator() method on the ForwardCompatibility\Result object. For SQLite support, the use of the positional parameters is needed, as Doctrine DBAL does not support named parameters for manually wired bound values with SQLite3. Resolves: #93852 Related: #93848 Releases: master, 10.4 Change-Id: I7145b8ccd7f43a407ce24cdfea316f563e5410cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68669 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Some cleanup of the SetupModuleController: Remove an unused function for adding Javascript, because it has not been executed since at least 7.6 and there are other ways to add custom Javascript nowadays. For example with an event, introduced in #91132, or directly via PageRenderer. Remove an unused parameter, which has been forgotten in #93093. Remove two superfluous typecasts. Resolves: #93896 Releases: master Change-Id: If4e4eb5352e46936332a687639399b8edeff0abc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68755 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 08 Apr, 2021 2 commits
-
-
Benni Mack authored
This change migrates the ElementBrowser / LinkBrowser HTML Layouts to use the ElementBrowser Layout. In addition, the TypeScript files now work without jQuery. Resolves: #93880 Releases: master Change-Id: Ia9de506ce7a8534fb3ba4757ee6c1980c71c1428 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68725 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Daniel Sattler <sattler@b13.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
This change adds a new Lit-based custom HTML component called "<typo3-backend-navigation-switcher>" which moves the current navigation frame resizable feature in a more flexible re-usable way. All RecordLinkHandlers and ElementBrowsers now have a resizable and collapsible navigation area. In addition, all logic is now decoupled from Viewport.ts All ElementBrowser / RecordHandlers now also define an inline style width to avoid jumping of the navigation area within the modal box. Further optimizations in this area: * Remove the media queries for the CSS classes in the element browser? * The newly introduced LIT element could be built as shadow DOM Resolves: #93857 Releases: master Change-Id: I66724086942e0778e05b9c26dd956bb8417af6d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68692 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 07 Apr, 2021 6 commits
-
-
Migrates backend UI component `LiveSearch` to be based on `lit-html`. In order to avoid string based concatenation which relies on the server side to properly escape html – which might not always work, when HTML is used in different contexts (node vs attributes). Resolves: #93101 Releases: master Change-Id: Idf0d588306ddc666a8ba449f96f58b78566a1c39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67178 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Resolves: #91322 Releases: master, 10.4 Change-Id: Ie03d6e120fcd62f9b14922ca28c61d6cd0dc2854 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68552 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
When regenerating a slug value via form engine in the backend user interface, changed states are not addressed anymore. Corresponding JavaScript `change` event has to be triggered for the element that is used to trigger changes for form engine validation. Resolves: #93874 Releases: master Change-Id: I7e78f36f4434009c122717eeb92bc463b9daa1a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68722 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
This change primarily moves the ModuleTemplate / DocHeader generation out of the DatabaseRecordList class into the actual controller where ModuleTemplate is used. The main controller method is also split up in smaller chunks (such as Clipboard initialization). In addition, several methods and properties are marked as protected if they are only used internally within DatabaseRecordList. Further steps in this area are to separate code from DatabaseRecordList which is not bound to the record listing. Resolves: #93863 Releases: master Change-Id: I901b0acebaec8f53b04426cad93002a3ec74195e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68712 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Usage of real instances in tests avoid the awkward situation that the test might not be useful anymore due to refactoring and reworking over time without anyone noticing. Mocks must only be used if necessary. Resolves: #93866 Releases: master, 10.4 Change-Id: I9095f0f6b0fb9b5c387b5c6150d82a9f5f07170f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68718 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
The correct field name is `ses_permanent` instead of `is_permanent`. Resolves: #93862 Releases: master Change-Id: Ie39d9b4828a963218bd6d84720ec47c6e6abfa3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68716 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 06 Apr, 2021 3 commits
-
-
Removes an additional `>` characters in EXT:dashboard XLIFF files. Resolves: #93859 Relates: #93594 Releases: master, 10.4 Change-Id: I27ef85603d2d389c5a470013c4edc668c7c02236 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68693 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
When a HMAC of a submitted form is invalid, TYPO3 throws a BadRequestException which is logged to sys_log and logfiles. Those invalid HMAC validation errors occur when the values of the hidden fields tx_extension[__trustedProperties] (extbase) or tx_form_formframework[form-id][__state] (ext:form) are manipulated. Since a TYPO3 site owner has no reasonable possibility to prevent tampered form submissions and in order to keep logs clean from errors due to illegal requests, the exceptions are now not logged any more. Resolves: #93667 Related: #90134 Releases: master, 10.4 Change-Id: Icc9b209b29c9624c03e6b4e6689b8242a02ef349 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68196 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Because the original PSR-7 request is now handed into Extbase at any times, the RequestBuilder can now utilize a PSR-7 request and does not need to fall back to global GET/POST or getIndpEnv() methods anymore. The final logic in this part is to handle $_FILES, which needs to be dealt with separately as a feature toggle. Resolves: #93853 Releases: master Change-Id: I60d592e6adcd705397b0f753224ee53fdf16cc0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67519 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 05 Apr, 2021 1 commit
-
-
The search box is currently available in * Page module (docheader) * List module (docheader) * Record Selector / Element Browser All implementations are different but use the same code base: * The outer wrapper functionality is only needed for the doc header * The page module is not using the Fluid-based snippet Additionally, styling is broken due to Bootstrap 5 upgrade. The change reduces CSS and JS initialization by consolidating the rendering of the search box and removing the buggy showLimit functionality since there is no pagination the placeholder is not used. Ideally, this code would be separated into a separate class as it is only related to a fragment of DatabaseRecordList. This is to be handled with a separate patch. Resolves: #93849 Releases: master Change-Id: I20e406f0ed5bf74503fb45c9ad93cf0e6a91f153 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68667 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 04 Apr, 2021 1 commit
-
-
Providing a list of available locales makes it faster and less error prone to setup a site and its languages. Resolves: #93651 Releases: master Change-Id: I2a0ed64f8d5d1e97c06671550e180af238331009 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68186 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 02 Apr, 2021 1 commit
-
-
Benni Mack authored
The Link Picker (RecordLinkHandler) and Element Browser logic has been simplified to avoid jQuery where possible and to reduce HTML rendering. The data-icon information is never evaluated in TypeScript/JavaScript and can be removed from any kind of HTML rendering, making the transferred amount of HTML much smaller. In addition, the insertElement method has been cleaned up to only use the properties that are evaluated. As a small side-effect, the InlineControlContainer does not throw a console.warn if a post message cannot be evaluated (which is typically the case for non-inline references). Resolves: #93850 Releases: master Change-Id: Ie850a3520ba5b448f5a1d0a42aa656b972b8d3a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68668 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 01 Apr, 2021 3 commits
-
-
Benni Mack authored
This change removes some type hints which are invalid with Doctrine DBAL 2.13.0 / 3.0 (builds forward compatibility), and some hard logic to bindValue() functionality which is PDO-specific and not supported anymore, as a Result object is returned instead of a Statement object from DB queries. Resolves: #93848 Releases: master, 10.4 Change-Id: Ibf69d5ba027e54471d2a98772674ef0139548b8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68665 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The DatabaseRecordList class has a few larger methods to compile HTML ready to be rendered. This change cleans up several parts of DatabaseRecordList in order to extract further functionality (such as CSV Export) into an own class: * Remove unused / overridden styling properties * Clean up "More records" button at the bottom of the page list * Rename internal variable $iLimit to $itemsPerPage * Separate the order of tables to list into a separate method "getTablesToRender()" out of the main method "generateList()" * Explicitly state the $table parameter for "listUrl()" methods where applicable * Move processing of columns-to-render per table to "getColumnsToRender()" * Move processing of SQL select fields to query to "getFieldsToSelect()" * Further cleanups regarding types (bool / int) Resolves: #93847 Releases: master Change-Id: Ib2eef99aa534a49c7799f320cd700f150335c36c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68666 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
In #57082 the special=languages option was migrated to the new TCA type "language". The remaining options for "special" are mainly used for be_users and be_groups only and can also be implemented as `itemsProcFunc` functions. This reduces unnecessary complexity for the TCA "select" type. Therefore, this patch migrates all remaining options of the "special" property to dedicated itemsProcFunc's and deprecates the use of this property along with the corresponding `addItemsFromSpecial` method in AbstractItemProvider. Since the remaining options are mainly used internally, the new class, containing the itemsProcFunc's, is marked as internal. Resolves: #93837 Releases: master Change-Id: I32be195c70babf387e1f1b42cbea03f6093dcefb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68622 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 31 Mar, 2021 2 commits
-
-
* The pointer to the first record has been replaced by the current page for the pagination. * The calculation of the first element has been moved to the 'getTable()' method. * The inline javascript has been moved to PageBrowser.js. * The rendering of the paging element has been moved to a fluid template. * The refresh button now reloads the page and does not change the current page any more. * The wrapping 'tr' and 'td' are also moved to the fluid template. Releases: master Resolves: #92234 Change-Id: I8cb73dd7627f9cbb02dcd94f92eb9d206786df15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65643 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Resolves: #93836 Related: #93835 Releases: master, 10.4 Change-Id: I54da5bcb014337c0c0aea11aed1a3fc709ba0998 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68657 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 30 Mar, 2021 5 commits
-
-
Georg Ringer authored
Update the package stylelint to get better validations and to allow more CSS properties. Used commands: > cd Build > yarn add stylelint > grunt build Resolves: #93819 Releases: master Change-Id: Ia6bdaa7f92eea8a5d479f3f6e87587ed941a1d86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68615 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Unused elements in PageLayout view will be displayed as unused elements again. Resolves: #93829 Releases: master, 10.4 Change-Id: Id7980c79e9ea0fd4644098a6a069814a5ba66f00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68626 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
Fix a broken comment mentioning transport_smtp_port, it was never used within TYPO3 core. Introduced way back in 2010, it already documented that the server port has to be written within transport_smtp_server with a colon. Update the line of transport_smtp_server to a proper example by adding colon and port. Releases: master, 10.4 Resolves: #93833 Change-Id: Ifd6e3d9914a67f5ef6a94ec1b1f72b52b327d2cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68655 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
In the 5.2.6 version of symfony/mime which is a requirement of symfony/mailer, the name of the e-mail address is escaped now. The minimum version is now set to this version and the unit tests are adapted to this change. Resolves: #93831 Releases: master, 10.4 Change-Id: I0625aad7581b2e140d6ca621ff5beb6d62c8ed38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68652 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
getText supports whitespaces in its syntax, e.g. `file : 17 : size`. That was not respected when using in combination with file. This has been fixed by using `GeneralUtility::trimExplode()`. Resolves: #93828 Releases: master, 10.4 Change-Id: I96a256113cf7f3154c96f7b84d34b134864646eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68625 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 29 Mar, 2021 6 commits
-
-
When extending the site configuration with an extension and use a select box with multiple choices (selectSingleBox, selectCheckBox, selectMultipleSideBySide), the activated options are stored as an array in the config.yaml file. But to show the activated items in the form again correctly they must be stored as in comma-separated list. Resolves: #92685 Releases: master, 10.4 Change-Id: I5d0713a65e78a52b786b707ab4019c448e360294 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66256 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
Role "img" requires an accessible name. The backend never supplies one, but uses it only on SVG icons within links that must have a link text. Resolves: #93826 Releases: master Change-Id: Ic8793f79a1e783aac51af57aa57712a1972d3252 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68623 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
An extension can provide site configuration to be imported into the TYPO3 instance by providing a file in Initialisation/Site. After the processing has been done, an event is dispatched now. Resolves: #93687 Releases: master, 10.4 Change-Id: Iff932d3855ebfd6532f3a011d3a511015f1226db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68292 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
With #91008 the grouping and sorting feature was introduced to the TCA select type. As a consequence, the select items array key for the help text changed from `3` to `4`. The SelectCheckBox now correctly checks the `4` key for the presence of a description. In v11 the absence of a title value, which is common in this scenario, did furthermore lead to TypeError on rendering the popover. This is fixed by assigning an empty string as default value on initialization of the popover options. Otherwise this option would be initialized as 'undefined' and then trigger the TypeError on sanitizing. Additionally the TCA properties special=table, special=exclude and special=custom are adjusted to add the correct value as help text to the items array. The value is now added directly as string, as there is no need to define the array while only providing the description. As a drive-by-change, the itemsProcFuncs of the dashboard and the MFA component do now also add the description for their access list field. This is done because the dashboard initially defined the description already but had to remove it again due to this bug, see: #91152. The MFA component also just hadn't added it because the bug hadn't been resolved at that time. Resolves: #93331 Resolves: #92383 Releases: master, 10.4 Change-Id: Ie96bcabea88b377490c24b0e60cfca8337e9ec52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68616 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Julian Mair <julian.mair94@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
Elements, having -1 set as sys_language_uid, can not be translated. Therefore, they have to be eliminated when collecting possible untranslated elements for a column in the page module. Resolves: #93822 Releases: master, 10.4 Change-Id: Ib4d106ca1447b1440bf13a0e0a623893af64ff72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68621 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
When TCA type="text" has no "cols" setting, the width of the element is artifically restricted to some arbitrary max width. The patch loosens this restriction: textareas now extends to the available width defined by an outer container. Resolves: #93821 Releases: master Change-Id: Ib7e5f7c388a48ee0d4728d63e6fed289a84bbbaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68618 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 28 Mar, 2021 1 commit
-
-
This patch ensures that DataHandler does not try to localize inline records that already have a translation for the given language. With the change, no confusing error message is shown to the editor when the "Localize all records" or "Synchronize with original language" action is used in inline elements. Resolves: #88844 Releases: master, 10.4 Change-Id: I6573aa233b4ce9dbe010d944fc1d461cf68e57cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 26 Mar, 2021 6 commits
-
-
If a form upload is configured to save files within "1:/user_upload/test/" (saveToFileMount: '1:/user_upload/test/'), an upload will be saved within "1:/user_upload/test/form_<random>/file.png". Lateron, the DeleteUploadsFinisher delete "1:/user_upload/test/form_<random>/file.png". If "1:/user_upload/test/form_<random>/" is emty, this folder will be deleted too. This patch prevents the DeleteUploadsFinisher from trying to delete the top level upload folder "1:/user_upload/test/". Resolves: #93805 Releases: master, 10.4, 9.5 Change-Id: Ifd2fbf7cf7d5c94186ca27684d1baa92c898ba0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68562 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
This adds another safeguard to prevent running TYPO3 on unsupported PHP versions. Resolves: #93246 Releases: master, 10.4 Change-Id: I9069c2a125a9950fe679b742759b5a59086bcb21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67365 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Richard Haeser authored
When a page is within a mountpoint, the normal behaviour is to generate a link within the mountpoint. As the content is shown from another page, the url of the target page is necessary as a canonical to avoid duplicate content. To do this, we temporarily remove the mountpoint information while creating the canonical link which results in the link to the target page. Resolves: #93300 Releases: master, 10.4 Change-Id: Ie97c9e323d6faae5e928d6206d72a2082106c949 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68469 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Franz Kugelmann <franz.kugelmann@elementare-teilchen.de> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
To simplify testing and screenshotting, each table listed in the list module gets a unique id. Resolves: #93775 Releases: master, 10.4 Change-Id: If8fbf0701e74f3900e19c22c2d8d21f5f46147e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68516 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
The TOTP provider is now only treated as active in case the active flag is set and the shared secret exists. It's actually really unlikely that no shared secret exists, while the active flag is set, because this can not be manipulated by a user, but only by an admin with direct database access. However, since the TOTP provider will never work without a shared secret, this property is now also checked, to prevent unnecessary errors. The corresponding tests are adjusted to check both properties independently. Resolves: #93776 Releases: master Change-Id: I9fd85bd82d945db827ea29626e63752c553a4180 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68517 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Records in language "All" are not translatable by definition. Therefore this language must not be allowed as a source language for translations in UI. This fix removes language "All" from the translation wizard. Resolves: #92757 Releases: master, 10.4 Change-Id: Ibdc83401df7f84dcc33df02be998590b70fa9093 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68522 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-