Skip to content
GitLab
Switch branch/tag
  1. 07 May, 2022 1 commit
  3. 04 Apr, 2022 1 commit
  5. 15 Apr, 2020 1 commit
  7. 14 Apr, 2020 1 commit
  9. 17 Jun, 2019 1 commit
    • Alexander Schnitzler's avatar
      [!!!][TASK] Do not magically register validators · 7f21ba47
      Alexander Schnitzler authored and Benni Mack's avatar Benni Mack committed 
      This patch removes the automatical registration of two types
of validators.

- model validators
- type validators

Model validators are those validators that follow a specific
namespace and class naming derived from domain models.

Given a model \Vendor\Extension\Domain\Model\Foo, extbase searched
for a valiator \Vendor\Extension\Domain\Validator\FooValidator.

If it existed, it had been registered automatically and could not
be disabled at all.

Type validators are similiar to model validators. Given a non
model action parameter or model property like int, string, float,
DateTime and such, extbase searched for validators in the
namespace TYPO3\CMS\Extbase\Validation\Validator.

There is a TYPO3\CMS\Extbase\Validation\Validator\StringValidator
for example which had been registered for string type params and
properties.

Said validators could not be disabled at all.

There are several reasons why the automatic registration has been
removed:

- First of all, this behaviour led to an unknown amount of actual
  registered validators. Developers that are new or simply not
  familiar with the concept of validation magic could easily
  become frustrated.

- Then there is the problem that validation takes place, no matter
  if it was needed or wanted. A domain validator, which looked
  quite handy in the first place, had to be reduced to the
  validation logic that would fit all cases where according
  objects had been passed into methods. No matter the context.
  The context however matters a lot. One might want to have
  different validation rules depending on if objects are
  created, updated or deleted. This distinction was impossible
  and therefore model validators could be a burden.

- Last but not least, the automatic registration is a problem
  when introducing validation groups. Validation groups cover
  the context aspect mentioned earlier. By grouping validations
  one can create and register different validators and apply
  them given by contexts like create, update, delete and such.

Releases: master
Resolves: #87957
Change-Id: If8f590a1bedb428c8884cd61828d8cc671ee92e1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60298

Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: Stefan Froemken's avatarStefan Froemken <froemken@gmail.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Stefan Froemken's avatarStefan Froemken <froemken@gmail.com>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      7f21ba47
  11. 01 Oct, 2018 1 commit
  13. 02 Sep, 2018 1 commit
  15. 22 May, 2018 1 commit
  17. 15 Mar, 2018 1 commit
  19. 30 Aug, 2016 1 commit
  21. 20 Nov, 2015 1 commit
  23. 08 Oct, 2015 1 commit
  25. 16 Dec, 2014 1 commit
  27. 13 Dec, 2014 1 commit
  29. 08 Nov, 2014 1 commit
  31. 22 Jun, 2014 1 commit
    • Michael Schams's avatar
      [TASK] Re-work/simplify copyright header in PHP files - Part 3 · 601b20ed
      Michael Schams authored 
      This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59779 for further details.

Resolves: #59779
Releases: 6.3, 6.2
Change-Id: I30ad23ccfccd86ba9e98a3b46b11836c1628f499
Reviewed-on: https://review.typo3.org/31024
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
      601b20ed
  33. 13 Jan, 2014 1 commit
  35. 01 Oct, 2013 1 commit
  37. 21 Apr, 2013 1 commit
  39. 12 Apr, 2013 1 commit
  41. 19 Mar, 2013 1 commit
    • Wouter Wolters's avatar
      [TASK] Update copyright year to 2013 · 4d463976
      Wouter Wolters authored and Christian Kuhn's avatar Christian Kuhn committed 
      In this patch are also some fixes for files containing
a interface. Due the namespace change all interfaces
have the curly bracket not on the same line as the
interface name.

Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
Resolves: #46370
Releases: 6.1
Reviewed-on: https://review.typo3.org/18984
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
      4d463976
  43. 10 Feb, 2013 1 commit
    • Anja Leichsenring's avatar
      [FEATURE] Introduce ClassNamingUtility · 185d0e60
      Anja Leichsenring authored and Andreas Wolf's avatar Andreas Wolf committed 
      Introduce a utility class for several naming issues like
converting class names from Model to Repository and
vice versa and exploding controllerObjectNames into used parts.

Thanks to Alexander Schnitzler for the initial patch.

Releases: 6.1
Fixes: #43052
Change-Id: I2e056498cb7ce4e193f71d7c3fea908418f5de7c
Reviewed-on: https://review.typo3.org/16518
Reviewed-by: Markus Günther
Tested-by: Markus Günther
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
      185d0e60