- 16 Sep, 2022 1 commit
-
-
The doc comments for some functions in `\TYPO3\CMS\Core\Database\Connection` state, that table expressions and columns are not escaped. This is actually not true and it seems those doc comments have been adopted directly from `doctrine/dbal` back in 2016, when Doctrine DBAL was introduced to TYPO3. Resolves: #98318 Releases: main, 11.5, 10.4 Change-Id: If23d568b23ef1b3c6f40efd50e907af54c349b3d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75650 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 08 Jul, 2022 1 commit
-
-
Escaping SQL `LIKE` wildcards is only provided via `QueryBuilder::escapeLikeWildcards()`, but would be useful as `Connection::escapeLikeWildcards()` as well (without having the demand to create another `QueryBuilder` instance). With this patch, both methods are available: * `QueryBuilder::escapeLikeWildcards()`, and * `Connection::escapeLikeWildcards()` Resolves: #97878 Releases: main, 11.5, 10.4 Change-Id: Ia8968dee944300949c6bb2be5b15e2d02a589d25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75061 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- 29 Jul, 2021 1 commit
-
-
In order to have developers use the new API in their IDEs, the type hints for QueryBuilder->execute() and Connection->select() are adapted to also use the API calls as in TYPO3 v11 / Doctrine 2.13. Resolves: #93951 Releases: 10.4 Change-Id: I5f597e25dead7547d353db4a1fcbd5e1f4ee0349 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70131 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 15 Apr, 2021 1 commit
-
-
If an OUTER JOIN is requested, the "disabled" rows of the joined table must be filtered before the join is executed. Therefore the enableFields conditions must be applied in the ON condition of the join. Resolves: #88919 Releases: master, 10.4, 9.5 Change-Id: I996fe4929b2ca9a5dbaa8c5907a4ad6141bd8853 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68740 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- 01 Apr, 2021 1 commit
-
-
Benni Mack authored
This change removes some type hints which are invalid with Doctrine DBAL 2.13.0 / 3.0 (builds forward compatibility), and some hard logic to bindValue() functionality which is PDO-specific and not supported anymore, as a Result object is returned instead of a Statement object from DB queries. Resolves: #93848 Releases: master, 10.4 Change-Id: Ibf69d5ba027e54471d2a98772674ef0139548b8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68675 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 16 Apr, 2020 1 commit
-
-
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/core/Classes bin/rector process --set=php53 typo3/sysext/core/Tests Resolves: #91054 Releases: master Change-Id: Ie27503980812581103a5d12581a80a7e8fe474f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64192 Tested-by:Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 13 Apr, 2020 1 commit
-
-
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 04 Nov, 2019 1 commit
-
-
The `$data` array can contain column-value pairs or just the values. The `$columns` array only contains the column names. Resolves: #89538 Releases: master, 9.5 Change-Id: Ieb24407321f6899d5271975430d72a1f8b92335e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62177 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- 07 Oct, 2019 1 commit
-
-
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- 06 Sep, 2018 1 commit
-
-
This patch ensures a connection can be established multiple times and is initialized correctly using the init commands on each fresh connection call. Resolves: #86154 Releases: master, 8.7 Change-Id: Ief2fb0855715333b124e8315c5f794008a5fb3d5 Reviewed-on: https://review.typo3.org/58189 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- 03 Sep, 2018 1 commit
-
-
Resolves: #86088 Releases: master Change-Id: Ia011b8ca85b8665edd80a093844b5a60a5fe2e29 Reviewed-on: https://review.typo3.org/58129 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 22 Jul, 2018 1 commit
-
-
Christian Kuhn authored
Executing functional tests on mssql has been disabled a while ago since the daemon crashed frequently: The server can not run on tmpfs volumes that we usually use to speed up database operations. sql server uses O_DIRECT i/o system calls which tmpfs does not support. Find details at https://github.com/Microsoft/mssql-docker/issues/12 We now run mssql tests on hard disks again, but enable them only as nightly since they are too slow as pre-merge tests. Change-Id: Iefc61670dcf74012fcdaada8e5b771538e7cf8c3 Resolves: #85614 Releases: master Reviewed-on: https://review.typo3.org/57641 Tested-by:
-
- 18 Mar, 2018 1 commit
-
-
To prevent race conditions etc. the custom type init which was moved in patch https://review.typo3.org/#/c/54512/ gets reverted. To fix the issue with the pageUnavailable_handling the method TyposriptFrontendController::connectToDB handles the error correctly via try catch block. Change-Id: I4f410d82e54c182d7b032a8ab4486d5b3b859382 Releases: master, 8.7 Resolves: #83577 Related: #82795 Reviewed-on: https://review.typo3.org/55379 Tested-by:
-
- 04 Feb, 2018 1 commit
-
-
This patch moves the execution of configured initCommands to the end of connect function. This prevents a database connection from being opened by default due to the execution of commands right after class initialization and still ensures a connection is configured properly before first command execution. Furthermore this patch adds a new functional test for the ErrorHandler. The test uses some predefined initCommands to enforce the strict mode of MySQL database to be set. Due to the predefined initCommands the test failed before as the connection was forced to be opened. For further information see the referenced forge ticket. Resolves: #83770 Releases: master, 8.7 Change-Id: I2287600959b3ec06d338e26373562850307ce0b1 Reviewed-on: https://review.typo3.org/55548 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- 13 Jan, 2018 1 commit
-
-
This cosmetical CGL change just substitutes all declare(strict_types=1); with declare(strict_types = 1); to be in line with the general 'spaces around =' rule. While that is cosmetical, it makes scrutinizer-ci a bit more happy and prevents it from creating auto-patches for these cases. Change-Id: Ic754b3fd2a0f06624909e6188ed270bd2797745c Resolves: #83554 Releases: master Reviewed-on: https://review.typo3.org/55349 Tested-by:
-
- 31 Oct, 2017 1 commit
-
-
The event and custom type initalization of doctrine is moved to an overwritten connect() method in the Connection class. This prevents a premature establishment of a database connection by calls to getDatabasePlatform(). This fixes the page unavailable during the connectToDB() in the Frontend request handling. Change-Id: Id6087002c7cbb9ed3938c4627d63b77515a7108f Releases: master, 8.7 Resolves: #82795 Reviewed-on: https://review.typo3.org/54432 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 18 Sep, 2017 1 commit
-
-
The function GeneralUtility::sysLog() is deprecated and all calls are replaced with direct calls to according Logging API methods. The usual configuration options of the Logging API allows to define all sorts of destinations for log entries, including the syslog facility as well as file targets. Resolves: #82430 Releases: master Change-Id: Ief3f3f14fd10a3ae90b9df4a5e4e7456c2f7619c Reviewed-on: https://review.typo3.org/54090 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
- 15 Feb, 2017 1 commit
-
-
Code cleanup based on the static analyser Psalm. https://github.com/vimeo/psalm Resolves: #79815 Releases: master Change-Id: I67dd33a79564b81931515f210644e980f83d3b7b Reviewed-on: https://review.typo3.org/51679 Reviewed-by:
-
- 23 Dec, 2016 1 commit
-
-
Set PDO attributes to ensure that BLOB fields are returned as strings to PHP, the way MySQL does. Update INSERT/UPDATE statements that deal with BLOB field to declare the proper parameter type so that the driver can do the required encoding/escaping when sending the data to the DBMS. Releases: master Resolves: #78884 Change-Id: I1618da9130549bd95ce0410420ecdee40cc3632d Reviewed-on: https://review.typo3.org/50883 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
- 03 Sep, 2016 1 commit
-
-
Databases that use sequences for auto increment columns need to have information about the table name to select the correct sequence to return information from. Change-Id: I5a4ff882d2237c86030b41a921843afdb95b9789 Resolves: #77833 Releases: master Reviewed-on: https://review.typo3.org/49843 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
-
- 31 Aug, 2016 1 commit
-
-
Morton Jonuschat authored
Implement a SQL schema migration service based on an actual parser for CREATE TABLE statements that are mapped to Doctrine Table objects. This enables the use of the Doctrine DBAL SchemaManager for all schema modifications. The new Schema migration service is fully aware of multiple database connections and normalizes MySQL specific data types to standard compliant types. This mostly affects the TINYINT data type which gets converted to a SMALLINT. Resolves: #77643 Resolves: #77369 Resolves: #76508 Resolves: #76641 Resolves: #75205 Resolves: #71645 Resolves: #44991 Releases: master Change-Id: Ic56941c2ae9717836d89bce74261d11424da340b Reviewed-on: https://review.typo3.org/49593 Tested-by:
-
- 30 Aug, 2016 1 commit
-
-
Resolves: #77701 Releases: master Change-Id: Id5f32eb76ac3adddd834160bc79828fefd0ce63c Reviewed-on: https://review.typo3.org/49665 Tested-by:
-
- 03 Jun, 2016 1 commit
-
-
Helmut Hummel authored
To make the set of restrictions that are in effect when creating queries with the QueryBuilder becomes more understandable, we need to remove the QueryContext and the magic applied to that and replace it with the following behavior: delete, hidden, starttime, endtime restrictions are always enabled and need to be removed if needed. Other restrictions need to be provided manually depending on the desired result. Resolves: #76167 Resolves: #76264 Releases: master Change-Id: Iaf0cb08475ed44966838c3fbdd5756d3ba6ebcc1 Reviewed-on: https://review.typo3.org/48049 Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 12 Apr, 2016 1 commit
-
-
The Doctrine DBAL library is added as a composer dependency as a foundation to replace the current DatabaseConnection class, EXT:dbal and EXT:adodb. Doctrine DBAL is encapsulated within a ConnectionPool class that manages the connections to all defined database connections. The main parts of the patch consist of the connection management, convenience methods for simple SQL queries, a QueryBuilder to build complex queries in a database platform independent way and a QueryRestriction Builder that aims to replace deleteClause and BEenableFields in the backend context as well as enableFields in frontend context. Documentation and an example implementation of using the API will follow in separate patches. Releases: master Resolves: #75454 Change-Id: I47837d9e77331132807bbb7fb956c359031b4f16 Reviewed-on: https://review.typo3.org/47111 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
