- 04 Jan, 2021 1 commit
-
-
Running a clean installation minimal setup throws a lot of "PHP Notice: Undefined index: " notices. This commit removes the ones from the frontend. Resolves: #91116 Releases: master, 10.4 Change-Id: I1f81150ed48ae170682d68d1169c1de2963e0021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64238 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 17 Apr, 2020 1 commit
-
-
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/backend/Classes bin/rector process --set=php53 typo3/sysext/backend/Tests Releases: master Resolves: #91064 Change-Id: I9e91882ab233b0e34bc991fd348fceba197a91ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64187 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 28 Mar, 2020 1 commit
-
-
To allow the dashboard to be positioned out of the "Web" main module, we rebuilt the module menu to allow direct top level modules. Additionally, the styling for the module menu was adjusted to allow mobile and keyboard friendly navigation and layout. Resolves: #90862 Releases: master Change-Id: I1005bac37a214530fb9e304fec2406799fe92240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63718 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- 19 Mar, 2020 1 commit
-
-
Hide the module menu, if it doesn't contain any modules (If the editor has no access to any module, that is placed in the module container). Also disable the toggle icons for module menu / list module in this case. Resolves: #67725 Releases: master Change-Id: I680ef0bd1d4de8c7b71d393ea14429d55f740de8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63697 Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 30 Dec, 2019 1 commit
-
-
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:
-
- 19 Sep, 2019 1 commit
-
-
Executed tasks: cd Build yarn add -D @typo3/icons@1.10.0 yarn build Resolves: #89206 Releases: master Change-Id: I47ae87e522acdce57e07804c46e3b8b8f29bc848 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61759 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 19 Aug, 2019 1 commit
-
-
The module menu now contains its state whether either the menu itself, or its module groups are expanded or collapsed. This information is now taken into account when the markup of the backend viewport is rendered. With this patch, some AJAX requests done after the backend is initialized can bre dropped, improving the backend UX since the state of the menus is correctly handled on render time. Resolves: #88935 Releases: master, 9.5 Change-Id: I3f3765926d9d3f406af0ee0bc29993d547771853 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61477 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- 02 Sep, 2018 1 commit
-
-
Resolves: #86084 Releases: master Change-Id: I6ebbe0756d799a3c04386c854f6e5e385eeac54f Reviewed-on: https://review.typo3.org/58124 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 13 May, 2018 1 commit
-
-
The patch deprecates BackendUserAuthentication->getTSConfigVal() and ->getTSConfigProp() and adapts usages to rely on getTSConfig() without arguments. The array nesting is done directly within consuming code and is combined with ?? to a fallback value. Advantages: * Expensive and recursive string operations within getTSConfig() are not used anymore. * The weird 'value' / 'property' based sub array juggling is gone. * Full TSconfig path including fallback can be easily seen within consuming code * Notice free array access using null coalescence operator Change-Id: I6d5777ebd533dcfdc6018e0226bfb3e513cfa652 Resolves: #84993 Related: #84982 Releases: master Reviewed-on: https://review.typo3.org/56953 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 02 Mar, 2018 1 commit
-
-
These parentheses are redundant and may be safely removed. Resolves: #84092 Releases: master Change-Id: I59f2b7454316ecd05f57d28e344f03a65d13e5c5 Reviewed-on: https://review.typo3.org/55952 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- 07 Jan, 2018 1 commit
-
-
Prevent warnings and notices if $GLOBALS['TBE_MODULES_EXT'] is not set, which can be the case if no extensions are installed. Change-Id: I72f513329790ee3b71fd30054574b79f41a6dcf8 Resolves: #83479 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/55274 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 27 Dec, 2017 1 commit
-
-
Some PHP classes still contain unused use statements. They have been removed. Thanks to @cd on his initial patch https://review.typo3.org/52014/ Resolves: 83432 Releases: master Change-Id: I9020f505a826c40fcf11f75f87245293e7c6154f Reviewed-on: https://review.typo3.org/55217 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- 30 Nov, 2017 1 commit
-
-
The new PSR-7-based solution since TYPO3 v7 should be used everywhere instead of "BackendUtility::getModuleUrl()". This is possible because modules can be addressed via the "route" GET parameter instead of the "M" parameter since a few months. The patch changes all occurrences within TYPO3 Core to use the new API. Resolves: #83172 Releases: master Change-Id: Iec40e8ae00f1d900d7479b84a3a62827ddba653b Reviewed-on: https://review.typo3.org/54755 Reviewed-by:
-
- 27 Nov, 2017 1 commit
-
-
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
-
- 23 Aug, 2017 1 commit
-
-
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 05 Mar, 2016 1 commit
-
-
Already translated module labels were previously resolved and stored within $GLOBALS[LANG]. Several checks and calls were then made to ModuleLoader and $LANG. All information about the module, as well as all labels are now stored within ModuleLoader, a addLabelsForModule() method and a getLabelsForModule() method are placed within that method, where labels are stored (but not resolved to the language yet). The language service then is only used when outputting the labels in various places. The method $LANG->addModuleLabels() and the public property $LANG->moduleLabels were deprecated. Resolves: #72340 Releases: master Change-Id: I82f01e7641b1395d81895d246ef22f11206d927d Reviewed-on: https://review.typo3.org/46702 Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
- 03 Mar, 2016 1 commit
-
-
Change-Id: Ie0b546d6baf962ee4d80f5fb08aeaadf54ca1a66 Reviewed-on: https://review.typo3.org/47019 Reviewed-by:
-
- 09 Feb, 2016 1 commit
-
-
The Icon API with icon identifiers is now used throughout the core when rendering module icons. This avoids some additional custom code on several places to identify backpaths etc. Resolves: #73186 Releases: master Change-Id: Ic146017a25e5872d0f835e7aae5ff6f00755926c Reviewed-on: https://review.typo3.org/46174 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- 23 Jan, 2016 1 commit
-
-
Somehow on earth, regular (non-extbase) modules register their module icons via [labels][tabs_images][tab] when using addModule(). The icon is not related to the labels at all, and can be simplified. All icons registered are available via the module configuration option "icon" and old formats are migrated automatically (with a deprecation warning), and always stored in an absolute format. Using "icon" now in the available places makes it easier and is unified in ModuleLoader, FormEngine, EXT:about and the Module Menu. Resolves: #72827 Releases: master Change-Id: Ie5770539bcb94921a9319a1d8d53d981c49fbcd8 Reviewed-on: https://review.typo3.org/46100 Reviewed-by:
-
- 31 Dec, 2015 1 commit
-
-
As BACK_PATH is empty at any time now the option is removed from the core. However, the backPath variable is still needed when accessing typo3/index.php for getting proper images, solving this will be part of another issue. Resolves: #72491 Releases: master Change-Id: I9c31de8ac38e986b6d820b7c89cab99eef52022c Reviewed-on: https://review.typo3.org/45525 Reviewed-by:
-
- 20 Nov, 2015 2 commits
-
-
Scalar types should always be written in the same form. "int", not "integer"; "bool", not "boolean"; "float", not "real" or "double". Resolves: #71746 Releases: master Change-Id: I47d43e5b68187cd07301d277875ba333325e29c7 Reviewed-on: https://review.typo3.org/44844 Reviewed-by:
-
Resolves: #71726 Releases: master Change-Id: I4a356c8da668acee555149eee9cf56ccdb4dc0ee Reviewed-on: https://review.typo3.org/44822 Reviewed-by:
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- 18 Sep, 2015 1 commit
-
-
Resolves: #69931 Releases: master Change-Id: I2f8941ddfe82b4be474e91dc643d6cce8c9ba1c4 Reviewed-on: http://review.typo3.org/43410 Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
- 10 Sep, 2015 1 commit
-
-
Xavier Perseguers authored
Change-Id: I3f039e12d9bdb46ae85ec159603a8f3031da0dde Releases: master Resolves: #69583 Reviewed-on: http://review.typo3.org/43088 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- 25 Aug, 2015 1 commit
-
-
http://review.typo3.org/38004 removed the typo3/mod directory with the main modules and their configuration and added the configuration to `$GLOBALS['TBE_MODULES']`directly. However for that a sub array key `configuration` was used, which is inconsistent with all our current API and its usages across other modules, leading to the situation that this configuration was basically ignored. On top of that, http://review.typo3.org/39316 introduced the possibility to use sprite icons as module icons, which used the configuration key `icon` in the above mentioned sub array key `configuration`, making this key the only option evaluated in the sub array. This change removes this sub array and moves the sprite icon configuration on top for consistency. For that the key must be changed to 'iconIdentifier' as 'icon' was already taken for Extbase module icon configuration. Resolves: #69291 Releases: master Change-Id: I282841fdb09c9c2773ca6e5518fdda863f9f8ef5 Reviewed-on: http://review.typo3.org/42854 Reviewed-by:
-
- 24 Aug, 2015 1 commit
-
-
http://review.typo3.org/37611 made the navigation frame dispatched. For this it leveraged the addNavigationComponent API, which was introduced only for ExtJS tree components. Since we want to get rid of ExtJS (and this API specifically), we need to introduce a different way to make modules or routes navigation components. This change reverts the above changes to the API and instead uses the `navigationFrameModule` option which was introduced in https://review.typo3.org/#/c/30593 To make this option work with top level modules and inheritance of the navigation frame, the evaluation of the option is moved to the module loader, which has the benefit to have the code only in one place while it needed to be in two places before. Resolves: #69270 Releases: master Change-Id: I7cb2ca2ee6d04001af424c88a1db828d1712caa1 Reviewed-on: http://review.typo3.org/42856 Reviewed-by:
-
- 15 Jul, 2015 1 commit
-
-
@author information can be found in version control. Cluttering our code with these tags does not make much sense and they are outdated by definition or would sum up to impressive lists. As decided on acme 2015, we drop them now. Releases: master Resolves: #68152 Change-Id: Iec1ea0f873b44ab6027c94ba8353a9fdb5477bdd Reviewed-on: http://review.typo3.org/41264 Reviewed-by:
-
- 04 Jul, 2015 1 commit
-
-
Replace occurences of count() with matching empty() pendants. Resolves: #67774 Releases: master Change-Id: Ie75551a9410affe8840b521e15a0daf68655ba2a Reviewed-on: http://review.typo3.org/40683 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Sommer <markussom@posteo.de> Tested-by:
-
- 09 May, 2015 1 commit
-
-
In the course of the 7.x development, the main modules (web / file etc.) have received a hard-coded list of fontawesome sprite icons. This way it is not (easily) possible to override the icons and to give a custom main module its own custom sprite icon. A new property in the module configuration "icon" allows now to hand in a sprite icon instead of a path to png/gif file. At the same time the property handling for the "icon" property inside the module menu is now simplified as a string instead of an array with all additional information as everything is already compiled together in the BackendModuleRepository. All main modules shipped with the core now have proper icons mapped inside ext_tables.php in the core. Resolves: #66822 Releases: master Change-Id: If1a62528d9de56034a0330c0051dfcb66e59469c Reviewed-on: http://review.typo3.org/39316 Reviewed-by:
-
- 30 Apr, 2015 1 commit
-
-
Extension backend is done with this patch except FormEngine classes. Resolves: #66115 Releases: master Change-Id: I0dc335b0193566b9d14e4b8fdafc116a81e0f5cc Reviewed-on: http://review.typo3.org/38324 Reviewed-by:
-
- 09 Apr, 2015 1 commit
-
-
Michael Oehlhof authored
Do not show the module group if it does not contain any sub modules. Resolves: #66232 Releases: master Change-Id: I2187f6edede1a430f75f6390105947bc1b33156c Reviewed-on: http://review.typo3.org/38496 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Andreas Fernandez <andreas.fernandez@aspedia.de> Tested-by:
-
- 01 Apr, 2015 1 commit
-
-
Wouter Wolters authored
Use dispatching for dummy.php Resolves: #65290 Releases: master Change-Id: I4ead54c227ab4713143617782b93a3eda256bd92 Reviewed-on: http://review.typo3.org/38378 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
- 16 Dec, 2014 1 commit
-
-
Most of TYPO3's PHP files have an empty line before a class' closing curly brace. This commit adds this empty line (if it is missing) before a class' closing curly brace. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: (}\n)(}) Replace: $1\n$2 Resolves: #63942 Release: master Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7 Reviewed-on: http://review.typo3.org/35527 Reviewed-by:
-
- 13 Dec, 2014 1 commit
-
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
