- 03 Jun, 2020 1 commit
-
-
It is possible for values returned by stdWrap to be of type int. RequestHandler->generateMetaTagHtml() expects meta tag values to be of type string. In order to avoid php errors, return values are now casted to strings. Resolves: #91533 Releases: master, 10.4, 9.5 Change-Id: I642d5fe0189955e26689a6cf65cdbe23255356a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64636 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- 16 Apr, 2020 1 commit
-
-
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/frontend/Classes bin/rector process --set=php53 typo3/sysext/frontend/Tests Releases: master Resolves: #91063 Change-Id: Ia6a547ec40c1da2c80cabb8a3e0581d628f51c92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64200 Tested-by:Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 14 Apr, 2020 2 commits
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Benni Mack authored
PSR-15 and Request/Response handling has been proven to be a worthy replacement for most logic related for outputting content in the TYPO3 Frontend. In order to thin out TSFE in future TYPO3 versions, various hooks have been deprecated as they can also be used with proper PSR-15 middlewares. * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['pageIndexing'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['isOutputting'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-contentStrReplace'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-output'] The following methods are marked as deprecated as well: * $TSFE->isOutputting() * $TSFE->processContentForOutput() Resolves: #91012 Releases: master Change-Id: I455f110f7f3e774de9d8ccd4adfcbd1ed5538cec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64118 Tested-by:
-
- 13 Apr, 2020 1 commit
-
-
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 24 Mar, 2020 1 commit
-
-
Gzip encoding inline CSS does not work and we should not do that. Therefor setting `inline = 1` now also implies `disableCompression` (same way as it is done for concatenation). Resolves: #90820 Releases: master, 9.5 Change-Id: I85c70bba9dd850fe9b03086dc6c51f7064c60ba7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63884 Tested-by:
Timo Poppinga <timo.poppinga@zdrei.com> Tested-by:
-
- 08 Mar, 2020 1 commit
-
-
Releases: master Resolves: #90668 Change-Id: I92cc4942f9f06d587a7957a94f006d157143e55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63569 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 29 Feb, 2020 1 commit
-
-
Since AssetCollector needs to be serialized, or to be more precise its state need to be cached as string, we must avoid that state is stored that isn't serializable. Therefore we adapt the API to reflect this and change the API calls to not add non serializable objects. With this change we also revert the previous USER_INT fix that bound the AssetCollector unnecessarily to PageRenderer and store it serialized in cache (the deserialization was already part of the code of the commit that introduced the AssetCollector). Reverts: #90537 Resolves: #90565 Releases: master Change-Id: I59f10b608e5f270aaacde63bcd347116910aac7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63488 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- 27 Feb, 2020 1 commit
-
-
Passing a non object variable or non null value as third argument "$ref" into method GeneralUtility::callUserFunction has been deprecated. As of TYPO3 version 11.0 said method argument must be either null or of type object. Releases: master Resolves: #90377 Change-Id: I83d75c1c78d1d41d94b6e497b04644e704b902db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63075 Tested-by:
-
- 10 Jan, 2020 1 commit
-
-
Using Class constants instead of constants that are defined during runtime has the following benefits: - Naming can be made more consistent (and separated) - Speeding up requests where the constants are not needed - Benefit from Opcaching of class loading instead of dynamic runtime definition - Testing framework has less "bootstrap" to do This affects the following constants: - TYPO3_copyright_year - TYPO3_URL_GENERAL - TYPO3_URL_LICENSE - TYPO3_URL_EXCEPTION - TYPO3_URL_DONATE - TYPO3_URL_WIKI_OPCODECACHE The constants are now deprecated. In addition, the "Typo3Copyright" class is now called "TYPO3Information". Resolves: #89866 Releases: master Change-Id: I607c90cb281179bda9875504d258daefd3471868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62624 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 11 Dec, 2019 1 commit
-
-
A PSR-14 event is introduced to make it possible to control the hreflang tags that will be rendered. Additionally the class HrefLangGenerator is migrated to be a listener to the new event. Resolves: #86614 Releases: master Change-Id: I51a5a79da6996148e62301c793b0ad257aada102 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59059 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
- 13 Nov, 2019 1 commit
-
-
This patch streamlines the execution code when a base page is generated by moving all logic into a few smaller methods to separate the actual "cacheable page" logic from the PageRenderer population process, and also adds more documentation to the methods. In addition, some minor adjustments (site language is now always available in v10) can be made, as some unnecessary code execution (e.g. divSection assigment and unsetting "JScode" explicitly) are made Resolves: #89663 Releases: master Change-Id: Ic2ac15a9767f452a89bace0d95fdc6f7f09af922 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62313 Tested-by:
-
- 12 Nov, 2019 2 commits
-
-
A few places in TYPO3 Core do manual checks if there are non-cacheables on a page, which could be simplified by just using the $TSFE->isINTincScript() method. In addition, a safer check for a NON-empty INTincScript value is used, instead of just a typecheck of array. Resolves: #89652 Releases: master Change-Id: I24b2b55b3705927720e36181926cf6e752bf0f66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62303 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
In order to centralize USER_INT ("non-cacheables") into TSFE logic, some functionality is moved into TSFE regarding headerData, JS and CSS inclusions. Resolves: #89651 Releases: master Change-Id: Ib0f6daa2306f6cba90f27db6baff5bae38403842 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62302 Tested-by:Daniel Gorges <daniel.gorges@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 09 Nov, 2019 1 commit
-
-
Add the property 'nomodule="nomodule"' to JavaScript files via TypoScript page.includeJSlibs.<array>.nomodule = 1 This patch affects the TypoScript PAGE properties * includeJSlibs * includeJSFooterlibs * includeJS * includeJSFooter Resolves: #86759 Releases: master Change-Id: I88db40ac973c17148a87504998f1070eba8d74af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58908 Tested-by:
-
- 23 Oct, 2019 1 commit
-
-
With the introduction of sites the wrong siteLanguage attribute was taken to generate the HTML tag lang attribute. This patch changes this behavior and uses now the getHreflang getter to fetch the correct value from the siteLanguage. Resolves: #89484 Releases: master, 9.5 Change-Id: I5f2abf1d209993442141aa5f4638b4905c8cdf98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62081 Tested-by:
David Gurk <dgbox+typo3org@pm.me> Tested-by:
-
- 07 Oct, 2019 1 commit
-
-
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- 09 Sep, 2019 1 commit
-
-
To avoid possible conflicts with JS minification, the commenting style is changed. Resolves: #89093 Releases: master, 9.5 Change-Id: I1afce194b89eeb64988f48c37b6ba1107d21f61b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61647 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- 16 Jul, 2019 1 commit
-
-
HTML5 defines that <script tags do not need "type=text/javascript" as additional attribute. TYPO3 Backend is fully HTML5, so all parts can be removed there. For Frontend, when having config.doctype = html5 (or empty), then the attributes do not get added anymore as well. If necessary, for Frontend rendering the attribute can be added in HTML5 by specifying includeJS.myfile.type = text/javascript in TypoScript. As this modifies Frontend output, it is considered breaking. Also see W3C specification: https://www.w3.org/TR/html52/semantics-scripting.html#element-attrdef-script-type Resolves: #88772 Releases: master Change-Id: I26ca4361e84cae680eedbf6855e209a6311c33da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61300 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- 13 Jun, 2019 3 commits
-
-
Benni Mack authored
The two TypoScript options * config.htmlTag_langKey * config.htmlTag_dir have been removed, as they have no effect anymore in TYPO3 v10, which only works with Site Handling. Site Handlings "direction" and "twoLetterIsoCode" are already in place and used when Site Handling is active. Resolves: #88560 Releases: master Change-Id: I8ef2a8b8ccd9c790fd7db940e908e8a362ec4ca3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61003 Tested-by:
-
Various documentation in TSFE is updated, in addition to having $TSFE->setAbsRefPrefix() to be set within the postProcessing to overcome issues when the call is forgotten in custom TSFE instances. Resolves: #88555 Releases: master Change-Id: Ib3ce22db1e6ce7b0985d486d584c26f25755efa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60998 Tested-by:
-
For further TSFE-related changes, the frontend request workflow now stores user-/session-related information in the middleware. This is a first step in order to reduce the dependencies of TSFE + FrontendUserAuthentication. This patch is breaking as certain hooks (like EOFE) do not have session data stored anymore. Related: #88540 Resolves: #88541 Releases: master Change-Id: I1e9a66b759d6edfd4c0e5a8ede02aa7a73b65b0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60939 Tested-by:
-
- 08 Jun, 2019 1 commit
-
-
This patch removes unused variables: $GLOBALS['TYPO3_MISC']['microtime_BE_USER_start'] $GLOBALS['TYPO3_MISC']['microtime_BE_USER_end'] $GLOBALS['TYPO3_MISC']['microtime_end'] $GLOBALS['TYPO3_MISC']['microtime_start'] are replaced by properly using - TimeTracker->start() - TimeTracker->finish() (new method) to encapsulate the logic into the main method. Resolves: #88498 Releases: master Change-Id: I158e4b3aed002f688f117488cb0300c6523e791f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60769 Tested-by:
-
- 07 May, 2019 1 commit
-
-
This reverts commit 3139b560. "[BUGFIX] Do not cache content with different status code than 200" At the same time we convert a plugin action to uncached, in case a redirect is issued. Resolves: #88178 Releases: 8.7, 9.5, master Change-Id: Icaa8038d1fa4bf1c74dfb505c2b8fc97963ca4be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60518 Tested-by:
-
- 12 Apr, 2019 1 commit
-
-
Benni Mack authored
If page.includeCSS.myfile.import = 1 is used, but no "media" is set, a TypeError is thrown, which is now caught and properly checked. Resolves: #88059 Releases: master, 9.5 Change-Id: I0951688bb9ee779329ebe5c7fad698862d73f6c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60420 Tested-by:
Julian Geils <j_geils@web.de> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
- 07 Feb, 2019 1 commit
-
-
All PSR-15 middlewares now do not set the $GLOBALS['TYPO3_REQUEST'] object anymore. Instead, the RequestHandlers are using them for all other logic (e.g. GP etc) where the request object or any other attribute has not been handed in yet. It is now safe to say that PSR-7 request/response objects have to be used within middlewares to access or manipulate GET/POST data. Also, the safety net for overriding GET/POST again is still in place for FE (data = GP:id) in order for existing TypoScript to work still, until all other code gets global-free. There are still places in TYPO3 Core where $TYPO3_REQUEST is necessary (TypoScriptConditionMatcher, Error Handling) which are added accordingly. Resolves: #87661 Releases: master Change-Id: Ibe499b6fda86ccd3abefcb3c8be294a7cb765d74 Reviewed-on: https://review.typo3.org/59490 Reviewed-by:
-
- 28 Jan, 2019 1 commit
-
-
Remove the old concept of priority-based HTTP request handlers, and use statically configured PSR-15 middlewares instead. Tranform the priority based request handlers into a set of chained middlewares. In case none of the middlewares handles the request a NotFoundRequestHandler returns a 404 response (replacing the previous exception that was thrown in that case). This scheme of using a 404 handler as "last" request handler is not new, it is also used in zend expressive (a PSR-15 framework). The TYPO3 RequestHandlerInterface is marked @internal and was set to be removed in v9, therefore we drop it now and also remove its implementation from the frontend and backend request handlers. Releases: master Resolves: #87516 Change-Id: Ibbd6a0e6c4ff8aa55b4367c9e4c07e279595dbfb Reviewed-on: https://review.typo3.org/59541 Tested-by:
-
- 20 Dec, 2018 1 commit
-
-
The following code related to TSFE has been removed: PHP classes: * TYPO3\CMS\Core\PageTitle\AltPageTitleProvider * TYPO3\CMS\Frontend\Page\ExternalPageUrlHandler * TYPO3\CMS\Frontend\Page\PageGenerator * TYPO3\CMS\Frontend\Page\EidUtility PHP interfaces: * TYPO3\CMS\Frontend\Http\UrlHandlerInterface Methods that have been marked as protected * tempPageCacheContent() * realPageCacheContent() * setPageCacheContent() * clearPageCacheContent_pidList() * setSysLastChanged() * contentStrReplace() Dropped TSFE methods * mergingWithGetVars() * connectToDB() * initFEuser() * checkAlternativeIdMethods() * initializeBackendUser() * getPageShortcut() * pageUnavailableAndExit() * pageNotFoundAndExit() * checkPageUnavailableHandler() * pageUnavailableHandler() * pageNotFoundHandler() * pageErrorHandler() * makeCacheHash() * initTemplate() * handleDataSubmission() * initializeRedirectUrlHandlers() * redirectToExternalUrl() * checkPageForMountpointRedirect() * checkPageForShortcutRedirect() * redirectToCurrentPage() * processOutput() * sendCacheHeaders() * sendHttpHeadersDirectly() * storeSessionData() * previewInfo() * hook_eofe() * addTempContentHttpHeaders() * setCSS() * getUniqueId() * readLLfile() * getLLL() * initLLvars() * convPOSTCharset() * convertCharsetRecursivelyToUtf8() * domainNameMatchesCurrentRequest() * getDomainDataForPid() * getDomainNameForPid() Dropped TSFE properties * activeUrlHandlers * page_cache_reg1 * siteScript * loginUser * gr_list * beUserLogin * workspacePreview * ADMCMD_preview_BEUSER_uid * showHiddenPage * showHiddenRecords * debug * MP_defaults * sys_language_uid * sys_language_mode * sys_language_content * sys_language_contentOL * altPageTitle * lang TSFE Properties now marked as protected * loginAllowedInBranch * loginAllowedInBranch_mode * cacheTimeOutDefault * cacheContentFlag * cacheExpires * isClientCachable * no_cacheBeforePageGen * tempContent * pagesTSconfig * pageCacheTags * uniqueCounter * uniqueString * pageAccessFailureHistory TSFE Method Signature changes * calculateLinkVars now 1st parameter is required * preparePageContentGeneration now 1st parameter is required 4th Parameter of TSFE->__construct() now unused Removed TypoScript * config.typolinkCheckRootline * config.titleTagFunction * config.USERUID_substToken * config.USERNAME_substToken Hooks $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-PostProc'] Database fields: * index_phash.data_page_reg1 Resolves: #87235 Releases: master Change-Id: Id95bb0ccb30852fd115fb9da7754fa2e64374a41 Reviewed-on: https://review.typo3.org/59226 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
- 19 Dec, 2018 1 commit
-
-
The following hooks have been removed: - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preBeUser'] - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['checkAlternativeIdMethods-PostProc'] - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['checkDataSubmission'] - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preprocessRequest'] - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['connectToDB'] - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_previewInfo'] The class EidRequestHandler has been removed. eID targets cannot include a scriptpath anymore: - $GLOBALS['TYPO3_CONF_VARS']['FE']['eID_include']['my_eID'] = 'EXT:benni/Scripts/download.php'; Instead, they must contain a target (callable, class/method, function). The various hooks are still in place in deprecated methods within TSFE which will be removed in the next patch. Also, now hardly usable PSR-15 middlewares will be cleaned up separately as well. Resolves: #87220 Releases: master Change-Id: Ic54af83c97f2e6d2fba4346e382240d0fac6a2dc Reviewed-on: https://review.typo3.org/59217 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 07 Dec, 2018 1 commit
-
-
Resolves: #53123 Releases: master, 8.7 Change-Id: I8030e434a27ae2f2c5934706eec6f64e64e31cd3 Reviewed-on: https://review.typo3.org/58867 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 03 Dec, 2018 1 commit
-
-
Benni Mack authored
The new Site handling functionality should ideally avoid TypoScript conditions as much as possible. However, if someone wanted to add attributes via config.htmlTag_setParams all language-dependant properties (e.g. dir and lang) which are generated by the site configuration are gone, leading to the way of having to workaround this issue by using stdWrap or conditions) In order to re-implement this functionality but also build on a more flexible level, a new TypoScript property "config.htmlTag.attributes." is added, which is an array for setting attributes to the <html> tag dynamically. This superseds the previous config.htmlTag_setParams option by providing a more flexible API to add attributes. `config.htmlTag.attributes.class = no-js` It is even possible to add attributes without a value: `config.htmlTag.attributes.amp = ` would render `<html lang="en" amp>` - keeping the existing parameters that are set by other TypoScript anyways. Resolves: #87033 Releases: master Change-Id: I6a18671fffbf97aab8d3dda938dc261706e4e6fd Reviewed-on: https://review.typo3.org/58976 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- 24 Oct, 2018 1 commit
-
-
Resolves: #86731 Releases: master Change-Id: Ia48925cf98637d7c7b2ecfb071bc935508032dec Reviewed-on: https://review.typo3.org/58682 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
-
- 10 Oct, 2018 1 commit
-
-
Resolves: #83755 Releases: master, 8.7, 7.6 Change-Id: I6e13133f221137c63283ec1575fc405a38668b1a Reviewed-on: https://review.typo3.org/58582 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- 30 Sep, 2018 2 commits
-
-
This patch streamlines all deprecation messages and follow the following rules. 1. All @deprecated should contain @deprecated since TYPO3 xx, will be removed in TYPO3 v10.0 (not "core v10" or just "v10" 2. trigger_error() - All trigger_error() messages MUST end with a "." (dot). - Never use "This method" but the method name (enjoy the logs otherwise) - "has been deprecated" can be spared - we KNOW it's deprecated once its in the deprecation log. Instead "Will be removed in TYPO3 v10.0" SHOULD be in the log file. - Do not use "__METHOD__" or some other "magic". Resolves: #86488 Releases: master Change-Id: I6a34593ff89ecafe649366d60d725daa3aa6676c Reviewed-on: https://review.typo3.org/58494 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
HTTP Headers are added to the PSR-7 response object now within TSFE. They are then sent at the very end of the request process. A bw compat layer is added as well. Resolves: #86486 Releases: master Change-Id: Ifdeaab26868d0cf60dd87d52046a2565c4971488 Reviewed-on: https://review.typo3.org/58499 Reviewed-by:
-
- 29 Sep, 2018 2 commits
-
-
When hooks modify _GET or _POST parameters, it is important that these changes reflect the PSR-7 request for now, as long as TYPO3 access the _GET/_POST parameters via GeneralUtility::_GP(). In order to move away from global access, we still want to avoid places where it is unclear to use $_GET/$_POST vs. $GLOBALS['TYPO3_REQUEST'] until all parts are completely "global-scope free" for GET/POST parameters. The change adds the initial GET/POST parameters to the request object in the very first middleware of the frontend. If these have been modified when the RequestHandler builds up the content, they are added on top of the PSR-7 request object. Additionally, if the PSR-7 request object has been modified, these changes are put back in the global scope to reliably use _GPmerged within Extbase and Additionally, if _GET/_POST have been modified, a warning will be shown in the TimeTracker to find out that there have been modifications. Until then, it is safe to continue to access _GET/_POST within Hooks and Frontend, however it is highly discouraged to *modify* _GET/_POST directly as this functionality will be breaking in TYPO3 v10.0. Bottom line: This safety net can now trigger deprecation warnings if _GET/_POST have been modified during PSR-15 middleware hooks. Bottom line 2: If these have been modified, they are put inside the current request object. Bottom line 3: If the request object has been modified, global state will be modified ONCE in one place to ensure that we work with the same object during the request phase. Bottom line 4: We cannot get away from the current state of running a TYPO3 Frontend Request from another source, and we try to maintain compatibilty for legacy scripts for now. However, this will be breaking in TYPO3 v10.0. Resolves: #86458 Releases: master Change-Id: Ic8f4f123bb5ea0d660e500494cf06a965dea03c4 Reviewed-on: https://review.typo3.org/58443 Reviewed-by:
-
Benni Mack authored
Instead of explicitly call loadJQuery() this should be handled by requireJS or - even better - use vanilla JavaScript instead. Resolves: #86438 Releases: master Change-Id: Iecc2ceb7fa01578b00a63262f393bd1b92fa13e1 Reviewed-on: https://review.typo3.org/58455 Reviewed-by:
-
- 31 Aug, 2018 1 commit
-
-
The following public methods within TSFE now get a PSR-7 request object handed in to fetch the GET / POST variables. - $TSFE->preparePageContentGeneration(ServerRequestInterface $request) - $TSFE->calculateLinkVars(array $queryParams) - $TSFE->makeCacheHash() Note: If a hook modified _GET and preparePageContentGeneration is called from Core, the state of _GET and $request->getQueryParams() will differ. This COULD be overcome by using GeneralUtility::_GETset() which TYPO3 Core and extensions like realurl already use. Resolves: #86046 Releases: master Change-Id: Iecb333d1b501c0d14abf4d16d930e715e9bd8d2e Reviewed-on: https://review.typo3.org/58093 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
- 30 Aug, 2018 1 commit
-
-
Benni Mack authored
Due to some refactorings while achieving notice-free tests, the check for adding html-tag attributes was changed. Resolves: #86009 Related: #85849 Releases: master Change-Id: Ic64c7e8c709d7a7f4d72aef52a9f84ed30660005 Reviewed-on: https://review.typo3.org/58075 Tested-by:
-
