- 11 May, 2022 1 commit
-
-
Georg Ringer authored
The field `resizeTextareas_MaxHeight` with the label "Maximum height of text areas in pixels* is removed because of low impact and to simplify the settings module. Resolves: #97605 Releases: main Change-Id: I2a73a4ea99bc5e8fc91d5ccfaf7d1b5975c7ad16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74601 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 21 Apr, 2022 1 commit
-
-
Oliver Bartsch authored
Some improvements, based on latest <input> element patches, are now added to the related TextElement as well. Those are for example the use of a custom (JavaScript) element and the removal of duplicate encoding. Resolves: #97433 Releases: main Change-Id: I02bbbb8e0ac73f0ec15fb37b410e394d2345e6e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74360 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 18 Apr, 2022 1 commit
-
-
This patch replaces the "eval=null" option with the direct option "nullable". The goal is to further thin out "eval" and even remove it from some types completely. The TCA types password, datetime, link, number and color now don't have the TCA option "eval" anymore. A lot of code can now be simplified due to the removed lookup into the eval list. Resolves: #97384 Releases: main Change-Id: I48c98a3aa18c69fe9b6ae0501ce40f3571cfd216 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74319 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 22 Mar, 2022 1 commit
-
-
Oliver Bartsch authored
This removes the import of OnFieldChangeTrait from all FormEngine elements, extending AbstractFormElement, since the abstract class already imports the trait. Resolves: #97219 Releases: main Change-Id: I685b3cd771a826edab2cc34f1d54bb8aa48e3e72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74003 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 15 Mar, 2022 1 commit
-
-
Oliver Bartsch authored
$disabled is initialized as empty string and never updated, before being added to the markup, thus has no effect. $placeholder is initialized with "0" and never updated, thus the value can be set in the markup directly. Additionally, this replaces a strlen() check with an empty string comparison. Resolves: #97166 Releases: main Change-Id: I265514f32d66f48348f18860c36e2d5bd064d742 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73894 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 16 Feb, 2022 1 commit
-
-
Switch from TYPO3/CMS/ExtName/ to @typo3/ext-name/ module namespace in all TypoScript modules in order to use the common "scoped package" syntax as known from npmjs. This will allow TYPO3 TypeScript declarations to be published to @typo3/* packages on npmjs.com at some point, allowing extension authors to require these as npm/yarn dependencies to be able to use TypeScript type declarations when developing against the TYPO3 JavaScript API. While at it, the naming convention of JavaScript modules is also switched to use lowercase-dashed form. This is to adhere to the common used naming convention in the npm-world. Also @typo3/core/ajax/ajax-request.js simply looks better than a mixed form @typo3/core/Ajax/AjaxRequest.js would be. All existing RequireJS module identifiers are mapped to the new naming syntax in the requirejs-to-es6 bridge: For example a requirejs call to TYPO3/CMS/T3editor/Element/CodeMirrorElement will transparently be transformed to the new sc...
-
- 15 Feb, 2022 1 commit
-
-
All static RequireJS calls (static string argument) are migrated to native ES6 modules. Excluded is CodeMirrorElement which still needs RequireJS to be available for loading CodeMirror and it's modules. CodeMirror migration to ES6 will be a separate step by upgrading from v5 to v6. Manual modifications in Form/Element/AbstractFormElement.php to keep JavaScriptModule flags for registerCustomEvaluation call-conversions. Also JavaScriptRenderer.php to is patched always include the EXT:core importmap whenever the JavaScriptItemHandler is used (required for the dependency to "JavaScriptItemProcessor.js"). All other changes have been performed with the following commands: git grep -l "loadRequireJsModule('TYPO3/CMS" | \ grep -v /Documentation/Changelog | \ grep -v ActionMenuViewHelper.php | \ xargs sed -i '/CodeMirrorElement/!'"s/->loadRequireJsModule('\\(TYPO3\/CMS\/[^']*\\)')/->loadJavaScriptModule('\\1.js')/g" git grep -l "JavaScriptModuleInstruction::forRequireJS('TYPO3/CMS" | \ grep -v /Documentation/Changelog | \ grep -v JavaScriptRendererTest.php | \ xargs sed -i '/CodeMirrorElement/!'"s/JavaScriptModuleInstruction::forRequireJS('\\(TYPO3\/CMS\/[^']*\\)'/JavaScriptModuleInstruction::create('\\1.js'/g" git grep -l "JavaScriptModuleInstruction::forRequireJS($" | \ grep -v /Documentation/Changelog | \ grep -v Form/Element/AbstractFormElement.php | \ xargs sed -i -e '/CodeMirrorElement/!s/::forRequireJS/::create/' -e "s/^\([ ]*\)'\\(TYPO3\/CMS\/[^']*\\)'/\\1'\\2.js'/g" sed -i "s/'\\(TYPO3\/CMS\/[^']*\\)'/'\\1.js'/g" typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php # Same migration as already started in #96607 git grep -l includeRequireJsModules= | \ grep -v /Documentation/Changelog/ | \ grep -v PageRendererViewHelper.php | \ xargs sed -i \ -e 's/includeRequireJsModules=/includeJavaScriptModules=/' \ -e "s/\\([0-9]: *'TYPO3\\/CMS\\/.*\\)'/\\1.js'/g" Resolves: #96570 Related: #96323 Related: #96607 Releases: main Change-Id: Idc81d6b4d58168f0bfafc3e9e4ad46fa1e5f27e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73027 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 05 Feb, 2022 1 commit
-
-
Many classes in TYPO3 have a function called getBackendUser() or getBackendUserAuthentication(). The function definition is not always equal and some functions have a return type or doc comment and others do not. This patch streamlines the functions as following: * They must always use a return type declaration * They must not contain a doc comment header Also, some superfluous override of getBackendUser() have been removed. Additionally the parameter type declaration for $backendUserAuthentication in * BeforeHistoryRollbackStartEvent * AfterHistoryRollbackFinishedEvent * RecordHistoryRollback have been adapted to be nullable. Resolves: #96752 Releases: main Change-Id: Id7eec1bc5d0d602ccab95de75149053f7223a86c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73304 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 02 Feb, 2022 1 commit
-
-
Many classes in TYPO3 have a function called getLanguageService(). The function definition is not always equal and some functions have a return type or doc comment and others do not. This patch streamlines the function as following: * It must always use a return type declaration * It must not contain a doc comment header Also, the superfluous override of getLanguageService() in some subclasses extending AbstractFormElement has been removed. Resolves: #96732 Releases: main Change-Id: Ie4e7fc19b2e84dee78496b4eec674a215a81c00c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73261 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 10 Nov, 2021 2 commits
-
-
TextElement::render() calls strlen() to determine length of form elemet item value. It may be that item value is null instead of a string at this place and feed null to strlen() emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95930 Releases: master Change-Id: Ib7f073d59e4bbc39fb070d86bbfe3a5b69d3bef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72107 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
TextElement::render() calls htmlspecialchars() to output the item value. It may be that $itemValue is null instead of a string at this place and feed null to htmlspecialchars() emits a E_DEPRECATED PHP 8.1 error. Sanitize call. Resolves: #95931 Releases: master Change-Id: I0b2066e7161b2e12e3a4b39d3f9669938a04c9bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72108 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 04 Nov, 2021 1 commit
-
-
Because of normal selectSingle fields having the css property "width: auto", very long text forces those fields to span the whole width of the text. To fix this problem, the entire table layout has to fall. FormEngine fields have now a solid grid layout. This allows us more control over the layout. With this in place the fix is pretty straight forward: "overflow: hidden" for the wrapping div of the select field. In addition, some cleanup has been done in GroupElement: Empty aside divs are no longer rendered. Resolves: #94688 Releases: master Change-Id: I01a14dd2b2294d3260a90c1efecc402f742fabfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71798 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 01 Oct, 2021 1 commit
-
-
To reduce arbitrary inline JavaScript, requireJS callbacks used in FormEngine are streamlined to be more explicit - allowed instructions are `load` (module), `invoke` (a method), (create a new) `instance`. This change is an intermediate preparation for delegating loading, assignment and invocation directly to JavaScript processes. Relevant parts have been extracted from corresponding client-side handling in https://review.typo3.org/c/Packages/TYPO3.CMS/+/64123 The possibility to load and append arbitrary inline JavaScript to FormEngine segment `requireJsModules` is deprecated. Instructions need to be declared using new `JavaScriptModuleInstruction`. Resolves: #95200 Releases: master Change-Id: Ic93ffc7b478dea44dfa5cffe9606f81eea2e64b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71044 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 24 Sep, 2021 2 commits
-
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Previously, `fieldChangeFunc` items have been declared as string and were forwarded as plain inline JavaScript to the client application using HTML attrs `onchange` and `onclick`. This change introduces semantic objects for those `fieldChangeFunc` items that either can be used as structured configuration (JSON) or still "serialized" to inline JavaScript for legacy applications. New `OnFieldChangeInterface` provides a hybrid component that is backward compatible and still supports inline JavaScript as fallback. Using scalar (string) instructions for `fieldChangeFunc` will trigger PHP deprecation errors. Resolves: #91787 Releases: master Change-Id: I691ea8d12accfcf1568c34e178ce2087fd6ef609 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71072 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 14 May, 2021 1 commit
-
-
PHP 8 promotes a lot of notices (previously ignored) to warnings. That means they can no longer be ignored. Resolves: #94057 Releases: master Change-Id: I37de1b7e8e31eb2be78b8e90af015bc88e121791 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 13 May, 2021 1 commit
-
-
Andreas Fernandez authored
TCA's value picker uses a lot inline JavaScript for its picker handling, therefore, the handling has been moved into a dedicated web component. As a side-effect a bug in TextElement and InputTextElement is fixed. Both elements previously used exactly the opposite insert mode. Resolves: #94112 Releases: master Change-Id: Ib3a1f9697477cab4b9a00c606fcd0bd6524450b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69108 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 29 Mar, 2021 1 commit
-
-
When TCA type="text" has no "cols" setting, the width of the element is artifically restricted to some arbitrary max width. The patch loosens this restriction: textareas now extends to the available width defined by an outer container. Resolves: #93821 Releases: master Change-Id: Ib7e5f7c388a48ee0d4728d63e6fed289a84bbbaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68618 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 19 Jan, 2021 1 commit
-
-
This change uses Twitter Bootstrap 5 usages across TYPO3 Backend, and fixes the toggle / icon toggle switch. Now the bootstrap-5 based toggle (form-switch) is used, and can be modified easily with a custom SVG later-on, but is kept as is for now, in order to make sure it is used consistently everywhere. Resolves: #93310 Releases: master Change-Id: If52d06932e1ee087d9c7d76cfb7d0f0c0e92276a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67461 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 04 Jan, 2021 1 commit
-
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- 19 Oct, 2020 1 commit
-
-
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92579 Change-Id: I488edd51d9af44107969335b8f955cb69734c42b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66158 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 07 Oct, 2019 1 commit
-
-
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 14 Mar, 2019 1 commit
-
-
This patch splits the FormEngine.js into smaller, logically separated parts. This increases readability and maintainability and has a positive effect on the client's performance as only the required code is loaded. Not every aspect of the FormEngine JavaScript is handled here yet, since other areas, e.g. IRRE, need refactoring as well. Resolves: #87324 Releases: master Change-Id: I6704445254a524f8ed3152ab6b0b7105fb97d65a Reviewed-on: https://review.typo3.org/c/58608 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
André Schließer <andy.schliesser@gmail.com> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
André Schließer <andy.schliesser@gmail.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org>
-
- 11 Aug, 2018 1 commit
-
-
Reduce the HTML of a record form by rendering divs of wizards only if those are required. Resolves: #85577 Releases: master Change-Id: I6ca6ad5c3ebd1a1aa949a9a0349bd7894e4532df Reviewed-on: https://review.typo3.org/57614 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 18 Jul, 2018 1 commit
-
-
When the site configuration module has been introduced, it came with a custom functionality to show an additional help text when editing site records between the field label and the field input. This useful feature is now changed into a general TCA feature available everywhere: A new field information node expansion / "wizard" is added to all form elements, the inline and flex containers: If the property "description" is set for a TCA column type (same array level as "label", it will show the value as localized string between the field label and the input section. There are three available render types for "wizard a-like" output: * Field information - text between label+field * Field control - buttons next to input sections like the link popup button * Field wizards - clickable stuff below the input section, for example the localization state selector If a field has been set to readOnly=true in TCA, field control and field wizards do not make sense to render since they are meant to act with the field value. The field information node however has only informational character which is useful for readOnly fields, too. Thus, this node expansion type is now the only one that is always rendered, even if a field has been set to readOnly. Note this patch is fully covered by ext:styleguide (master) to have examples for all changed elements now using the description property. Resolves: #85410 Releases: master Change-Id: Idcfacafa19b8208614b653b8fac22ce47bca3b8f Reviewed-on: https://review.typo3.org/57397 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org>
-
- 17 May, 2018 1 commit
-
-
When useOrOverridePlaceholder mode is used for TCA input type, use opt-in for the checkbox when placeholder is empty. In some cases, the placeholder can be empty. Especially when the placeholder uses data from another field. When information is added to the corresponding field, the input field does not take this in account because the override checkbox is set by default. This can lead to problems for title and alternative fields in the sys_file_metadata table. When adding a file reference and setting the title or alternative field afterwards in the original file, the reference is still using the empty override from file reference. Resolves: #84563 Releases: master, 8.7 Change-Id: I84a37d55a48464b6249fc8bcee405a7cd909016a Reviewed-on: https://review.typo3.org/56486 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
- 25 Apr, 2018 1 commit
-
-
This commit moves any language file of EXT:lang into a proper destination, which renders EXT:lang obsolete. This change requires an update of typo3/testing-framework, done with this command: composer update typo3/testing-framework Resolves: #84680 Releases: master Change-Id: I7ba59c1a10015121ed444a9c98082bad0348e03d Reviewed-on: https://review.typo3.org/56017 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 01 Apr, 2018 1 commit
-
-
Show the description as a placeholder when an image is added as a reference. Resolves: #81235 Releases: master, 8.7 Change-Id: I75363f74ba72bf4fd95b2a2e9a2a061ad250f825 Reviewed-on: https://review.typo3.org/56438 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org>
-
- 22 Nov, 2017 1 commit
-
-
Add for/id so clicking the label toggles the checkbox. Resolves: #83040 Releases: master, 8.7, 7.6 Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326 Reviewed-on: https://review.typo3.org/54715 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org>
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 20 Apr, 2017 1 commit
-
-
Christian Kuhn authored
Resolves: #80913 Releases: master Change-Id: I151fbf7a02df3e4713d623eb1659ac35ae2cb35a Reviewed-on: https://review.typo3.org/52490 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
Henrik Elsner <helsner@dfau.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 11 Feb, 2017 1 commit
-
-
Resolves: #79729 Releases: master Change-Id: I689e8ecd0ffa2d005931e6162fb8df5d9694da3d Reviewed-on: https://review.typo3.org/51629 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
- 07 Feb, 2017 1 commit
-
-
This feature introduces a new functionality called "allowLanguageSynchronization" which can be set on a field configuration of a TCA column. This is the successor of "l10n_mode=mergeIfNotBlank" as the old option had several conceptual downsides: 1) "mergeIfNotBlank" took the value of the default record during runtime, but only if the translation field was empty. This means it was not possible to see what the record actually contained without having all fields of the parent at hand. 2) It was not possible to have a value "santa" in the original record but remove the option in a translation (because an empty string "" implicitly triggered the runtime call in the frontend) 3) "mergeIfNotBlank" did not work on relations except for files fetched via the FileRepository API calls, but for no other inline elements. 4) "mergeIfNotBlank" did the overlay functionality in the frontend, but only FormEngine and DataHandler took care of the option. Custom backend modules had to implement the same functionality. 5) In FormEngine, there was an icon in the translation record that if the record kept empty the value of the original language was taken, but this is not optimal in terms of usability. 6) "mergeIfNotBlank" did not take the new l10n_source option into account, where localizations could be made from other records than the default language "0". The new feature can be set on any TCA column setting: $GLOBALS['TCA'][<table-name>]['columns'] [<field-name>]['config']['behaviour'] ['allowLanguageSynchronization'] = true; This brings an option to records with translations (both from l10n_parent and l10n_source) to have the value for all translations synchronized or explictly have a checkbox to use a custom value. The information whether a field is custom filled, or kept in sync from l10n_parent/l10n_source is stored in a separate field called "l10n_state" inside the database. The introduced upgrade wizard and TCA migration to remove "l10n_mode=mergeIfNotBlank" has been modified to migrate to this option and add a l10n_state database field if a TCA table used "mergeIfNotBlank" but did not add the l10n_state field manually via ext_tables.sql yet. New extensions can easily use the new option right away, extensions that need to stay compatible with v7 and v8 can add both options right away to have the same output. The main goals to achieve with this change is now: * Have consistent database values for all records regardless of l10n_mode=mergeIfNotBlank paving the way to fetch translated records without having to overlay (once l10n_mode=exclude is also copying values and relations) * Be more explicit for editors about records that have a different or the same state as their l10n_parent/l10n_source as a benefit for bigger instances with a lot of languages * Avoid hidden magic when retrieving localized records in the TYPO3 Frontend. Resolves: #79658 Related: #79243 Releases: master Change-Id: I6c2dbfeb09b47f958a536c9ab050c24ba4bbcbbd Reviewed-on: https://review.typo3.org/51291 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 31 Jan, 2017 1 commit
-
-
Remove additional lines around the actual content of a textarea. Resolves: #79573 Releases: master Change-Id: I636afb0ec63d34d4a209caeaa1369bc65727665d Reviewed-on: https://review.typo3.org/51490 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org>
-
- 26 Jan, 2017 1 commit
-
-
Christian Kuhn authored
The patch introduces a new API on FormEngine element level that substitutes the old "wizards" / renderWizard() API with a more powerful system. Single wizards are now split into one of three categories: * An informational wizard * A control button / icon * A true wizard with additonal functionality Method renderWizards() is still called in elements for compatibility reasons if people added own scrip/popup/userFunc wizards, but all core wizards are migrated. The patch significantly cleans the HTML of single elements, especially HTML stuff that was added by the SingleFieldContainer is now put down to single elements, while main HTML wraps formerly done by renderWizards() is fetched "up" to single elements. This gives single elements full control about the main HTML it is producing, which is a must have preparation in order to further advance in this area and to switch single elements to fluid rendering in one of the next steps. The patch brings a pretty huge list of TCA changes and simplifications, all TCA changes are supported by TCA migration, so existing extensions should benefit out of the box and just get deprecations logged. Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab Resolves: #79440 Resolves: #70032 Releases: master Reviewed-on: https://review.typo3.org/51151 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 01 Dec, 2016 1 commit
-
-
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Jan Helke <typo3@helke.de>
-
- 09 Oct, 2016 1 commit
-
-
Resolves: #77819 Releases: master Change-Id: If39540863a1114ce5ce3e57289da54bdfdffc4f2 Reviewed-on: https://review.typo3.org/49764 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-