- 23 Dec, 2021 1 commit
-
-
Resolves: #96418 Releases: main, 11.5 Change-Id: I00b77f478c667f59b751c6f13c975d03799086d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72783 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org> Reviewed-by:
-
- 19 Dec, 2021 1 commit
-
-
This patch ensures that the getQuery() function only uses the minus operator to negate the $storagePid variable, if the variable can be interpreted as an integer. Resolves: #96321 Releases: main, 11.5 Change-Id: Idacd43fd6639218fc1126bffcd43e78338f18e0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72714 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 16 Dec, 2021 1 commit
-
-
Benni Mack authored
Resolves: #96310 Releases: main, 11.5 Change-Id: Ie12ca1683b3d8668deafbd37af03437f047c0ac4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72685 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 15 Dec, 2021 1 commit
-
-
The following deprecation occurred in PHP 8.1: PHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated. This happens in various places: * Using stdWrap_field() or in stdWrap() places * BackendUtility (e.g. new IRRE elements) * ExtensionManager Resolves: #96354 Releases: main, 11.5 Change-Id: Ie5c721784b51ed5493c8d9e1d557b08611263f6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72677 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 07 Dec, 2021 1 commit
-
-
Benni Mack authored
The past changes of migrating to Doctrine DBAL 3.x had some flaws: * Not all changes from Doctrine DBAL 3.x was applied * core relies on various invalid interfaces and classes, so the return types were wrong (also Tests used the old Statement class) * No explicit ->execute() and ->iterateAssociative() calls and fetchColumn() vs. fetchOne() * added executeQuery() and executeStatement() to QueryBuilder decorator class This change adapts most places to help in migrating to Doctrine DBAL 3.x for TYPO3 v12, but also avoids some unneeded deprecations for now. Resolves: #96247 Releases: main, 11.5 Change-Id: I60e99511efc4f9ec6d8d651c63becff028de4cf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72430 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 03 Dec, 2021 1 commit
-
-
Resolves: #96217 Releases: main, 11.5 Change-Id: Ic4320b60d730cac8ca0f9c0acb4d4483f12b5c40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72423 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 27 Nov, 2021 1 commit
-
-
The method getVal now always returns an array with a string at index 0 and an array at index 1. Resolves: #96001 Releases: master, 11.5 Change-Id: Ia1b321694767fa01b1de9176b87470522511d150 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72311 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- 24 Nov, 2021 1 commit
-
-
Benni Mack authored
This change makes some FE calls easier for testing in extensions, such as EXT:solr. Resolves: #96050 Releases: master, 11.5 Change-Id: I3482ac0abe4e813ff5cba795da9b730ee0efbdee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72264 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 23 Nov, 2021 1 commit
-
-
The ContentObjectRenderer throws a warning under certain circumstances in PHP8. The warning is generated by code, which is unused. This patch removes the unused code in ContentObjectRenderer. Resolves: #95921 Releases: master, 11.5 Change-Id: Ifb6f3557434626ec71f37d92181a5b156f6b39e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72260 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
-
- 17 Nov, 2021 1 commit
-
-
Helmut Hummel authored
Fatal error can occur, when the file variable isn't a string, which only happens, when file processing failed or the resolved file isn't an image. Nevertheless the fatal error should be avoided. Also clean up some variable usage to not change the type of variable and remove some not needed isset() check for better readability. Resolves: #91681 Releases: master, 10.4 Change-Id: Ibde8e1105fa7c0e233656b5dd49e083b6c7259ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64908 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io> Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by:
-
- 16 Nov, 2021 1 commit
-
-
Resolves: #95993 Releases: master Change-Id: I8eb6e779ae1d0f02bf8ef0fe3fb5dd02b751cb47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72190 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
-
- 11 Nov, 2021 1 commit
-
-
Benni Mack authored
This reverts commit 48e4e495 as this has some side-effects with absolute paths. Change-Id: Ieb696908e5226d57eedeef7cb5fa8cd7b7ec4ea6 Reverts: #95379 Resolves: #95959 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72114 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 10 Nov, 2021 3 commits
-
-
Text cropping on texts with way more than 1000 characters triggers regular expression compilation errors. The sweet spot was determined to a value of max 962 characters, thus leading to internal 'preg_match' error state and throwing 'Compilation failed: regular expression is too large' warning. The patch crops text in multiple chunks and reassembles the chunks until crop position was reached to avoid this internal error exceeding the max regular expression pattern length. Further tests are added to cover this scenario. Resolves: #77642 Releases: master, 10.4 Change-Id: I15b778370df0d0a3d3087a0b199c3e16f7a46add Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72048 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #95926 Releases: master Change-Id: I67de7575d4c6b75062cb21e558402f15dfeb70a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72104 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
CropViewHelper::renderStatic() calls ContentObjectRenderer::cropHTML() with result from children closure, which may be null. Feeding null to preg_split(null) emits a E_DEPRECATED PHP 8.1 error. This patch casts the value to string in the ViewHelper, but also add a string sanitize to the cropHTML() method to avoid this the E_DEPRECATED error. Added @todo to add strict types to the signature in v12. Resolves: #95934 Releases: master Change-Id: I2882163bda9bab9012241f11daf65a0a3191041d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72111 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 09 Nov, 2021 1 commit
-
-
When using a text content element with a table inside bodytext, you will have a PHP warning: Undefined array key "1." in typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php This was only a notice with PHP v7 but it's an error with PHP v8. This bugfix corrects the usage of undefined array keys. Resolves: #95858 Releases: master Change-Id: Ie70fb6bdd66eee895e0c290a9bcc662c9f734d2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72058 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 05 Nov, 2021 1 commit
-
-
PHP functions strftime() and gmstrftime() have been deprecated in PHP 8.1 and will be removed in PHP 9.0. Currently, there is no way to replace this seamlessly as no drop-in replacement is available. Official PHP 8.1 deprecation RFC: https://wiki.php.net/rfc/deprecations_php_8_1#strftime_and_gmstrftime strftime() has been used in several places in the core, and even concrete wrapper like TypoScript 'stdWrap_strftime' or support in fluid viewhelper 'f:date'. Besides this, some places used it to format date or locale datetimes, which may be replaceable. As we cannot provide drop-in replacement which would be breaking, or adding a hard requirement of the optional php extension intl, this patch suppresses deprecation warnings on calls of strftime() and gmstrftime(), using the '@' error control operator. Further, corresponding @todo's are added along the way to replace the occurrences in v12. Resolves: #95875 Related: #95872 Releases: master Change-Id: Ieb152ab5822f0d2e720a102873f51f4972e3784c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72055 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- 26 Oct, 2021 2 commits
-
-
getData() may emit E_WARNING accessing $tsfe->page and $config. Sanitize that by null coalescing to empty string. Releases: master Resolves: #95782 Change-Id: I3093e07f6e3b47a4a792a6a2d66534c829d76d5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71982 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Various functions expect string arguments and emit E_DEPRECATED with PHP 8.1 in non strict_types=1 calls. The patch adjusts some null coalescence fallbacks from null to string to satisfy this. Resolves: #95787 Releases: master Change-Id: Ie1b28bc285c33af3509d18eaeb7d0b6013284434 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71983 Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Jochen <rothjochen@gmail.com>
Reviewed-by:
-
- 25 Oct, 2021 2 commits
-
-
Christian Kuhn authored
Calling trim() with something else than a string emits a E_DEPRECATED error with PHP 8.1. Some ContentObjectRenderer->stdWrap_*() are affected by this and sanitized with explicit string casts. This is a bit of an artificial thing that mostly only happens in tests since in TypoScript usually everything is a string anyways. However, depending on how stdWrap_* methods are fed and used code-wise, it could also be a db return, which might be int or null. We thus can't simply change the method signature to 'string $content' and need to go with casts instead. Resolves: #95774 Releases: master Change-Id: Ifbb90170c4561e1570444c0c3d818aa32e58c827 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71972 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
Calling str_replace() with second argument non-string is deprecated as of PHP 8.1. Sanitize stdWrap_brTag() in ContentObjectRenderer to avoid a case found by unit tests. Resolves: #95775 Releases: master Change-Id: I9353ec28d23ec3b0ef50b8ecf48053ce27f5645e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71973 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 21 Oct, 2021 2 commits
-
-
In CLI context the full path to the temporary generated file by the GIFBUILDER can't be resolved. Because of this inconsistency, absolute file paths are used from now on. Resolves: #95379 Releases: master, 10.4 Change-Id: I6d2a489eee84843fc001ac405f69a15403598388 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71335 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
$GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['dependencies'] keeps a list of language fallbacks for labels which are now considered in stdwrap.lang. Resolves: #91721 Releases: master, 10.4 Change-Id: I56c63a3a2f51553ff8d93511e2e10d5ab88095ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64945 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Christoph Lehmann <christoph.lehmann@networkteam.com> Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by:
-
- 14 Oct, 2021 1 commit
-
-
And another set of warning fixes in ContentObjectRenderer found by functional tests, this time in encaps_lineSplit(). Resolves: #95653 Releases: master Change-Id: I9d1c7e0ea2f205d790f10211672c5834f4081add Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71774 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 13 Oct, 2021 2 commits
-
-
Christian Kuhn authored
A set of fixes for partially incomplete test setup in functional tests and a series of undefined array index warnings in system under test code. Resolves: #95630 Releases: master Change-Id: Ia628eb93912c85bee1e472367e2f209abec1abe3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71628 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
TypoScriptFrontendController has not been injected to a ContentObjectRenderer instance in a test, thus failing with disabled error handler. TypoScriptFrontendController dependency is based on needed access to initialized TypoScript configurations. This patch checks if tsfe is available before accessing properties and methods in ContentObjectRenderer to mitigate this warning instead of mocking an uninitialized TSFE instance in the test. Resolves: #95610 Releases: master Change-Id: Id3e8c2b7029ee0932da242c47ffb1a3837897bd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71600 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- 12 Oct, 2021 4 commits
-
-
The Format/HtmlViewHelper is designed to run in backend without TSFE. The HtmlViewHelperTest with disabled error suppression reveals ContentObjectRenderer does not always properly check for instances of TypoScriptFrontentController. Resolves: #95584 Releases: master Change-Id: Ia0ac6870d7ffc6405b12c5cbb483617808db856e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71558 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Christian Kuhn authored
As found by ext:fluid TypolinkViewHelperTest with disabled error suppression, ContentObjectRenderer does not properly check an array key access in a helper method of typolink(). Change-Id: I8c4410473f89473a623461123d99bada8ba8ee14 Resolves: #95583 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71557 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
These warnings have been fixed by adding a proper fallback where needed. Resolves: #95563 Releases: master Change-Id: I13b42cdc7c910f75de0adc093549438da44d734b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71534 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The (ugly) statement strpos($haystack, 'needle') !== false can be safely replaced with str_contains($haystack, 'needle'). This is possible, as a symfony polyfill for php 8.0 functions is in place. Resolves: #95466 Releases: master Change-Id: I313f47832a254c23c6815b6b44557a01019e59e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71429 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- 11 Oct, 2021 1 commit
-
-
Public property $cObj for plugins has been deprecated in v11 with #94956 and setContentObjectRenderer() method has been introduced as replacement. If this method is missing, a deprecation message is triggered. This patch inserts the class name of the plugin into the message, to make it easier to determine where the new method is missing. Resolves: #95554 Releases: master Change-Id: Iffae1fcbd2f59bd4fe353e585dd5f41914bcc760 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71524 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by:
-
- 08 Oct, 2021 2 commits
-
-
Prevent access to undefined array keys in content renderer and menu objects. Resolves: #95489 Releases: master Change-Id: I1ec4b046478e7e83176e1178153d57a2890b269e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71454 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
TypoScript options config.spamProtectEmailAddresses_atSubst and config.spamProtectEmailAddresses_lastDotSubst may not be set. Use null coalescing operator to sanitize access. Link/EmailViewHelperTest stumbles here and also needs a proper initialization of $GLOBALS['BE_USER']. Resolves: #95532 Releases: master Change-Id: I8169229c1a31c1243cf2c4fc4321d015f532dc12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71494 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 05 Oct, 2021 1 commit
-
-
Benni Mack authored
For historical reasons, HMENU created links to external URLs by calling typolink() twice. This is because HMENU did not always use the official typolink() method in the past (TYPO3 4.x/TYPO3 6.x). Because typolink() now provides much more information, the additional round-trip around typolink() can be removed as typolink() already provides this information directly now. Resolves: #95434 Releases: master Change-Id: I72f29220752ce61ebcbb039efbf33796396ba4a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71404 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 30 Sep, 2021 1 commit
-
-
Multiple undefined array key warnings occurred when following a page redirect in the frontend. This is fixed by adding the necessary checks. Resolves: #95393 Releases: master Change-Id: I169cb92352c56f0f2251e977a0a5240e256f09af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71346 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 24 Sep, 2021 2 commits
-
-
In some cases it can improve performance too. Resolves: #95210 Releases: master Change-Id: I4915bb1391ec99ff891248545080640965c8f62a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70204 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:core-ci <typo3@b13.com>
Tested-by:
-
- 22 Sep, 2021 3 commits
-
-
The import was removed shortly before https://review.typo3.org/c/Packages/TYPO3.CMS/+/71032 was merged so it's added again. Resolves: #95321 Related: #95189 Related: #95190 Releases: master Change-Id: If44ba57ab6a390fac07c1ee12bbd8f36d2e7539f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71191 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
A new function StringUtility::multibyteStringPad() is introduced to handle multibyte strings instead of str_pad() which will not pad strings with multibyte characters correctly. The new function is now used for: - Fluid ViewHelper format.padding - TypoScript stdWrap.strPad Resolves: #95189 Resolves: #95190 Releases: master Change-Id: I4b8bf4b42e049b17754b260003ac064fbbb6246a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71032 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The parseFunc.sword functionality wraps HTML (usually a span tag) around RTE-based content if: * GET parameter ?sword[]=search-word is set * no_cache=1 is set via GET parameter or TypoScript This feature only works in non-cached environments due to the actual problem that the search term should never be cached. This happens if a result page in indexed search is clicked, which then receives a no_cache=1 argument. This feature is highly discouraged due to the possible server load that is created, and thus removed. The existing solution is far from optimal and should rather be handled in third-party extensions (such as EXT:solr does it via a HighlightViewHelper). Resolves: #95318 Releases: master Change-Id: If74247bad14a87c55d092322f0a609c3663f2e67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71176 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
core-ci <typo3@b13.com>
Tested-by:
-
