- 23 Dec, 2021 4 commits
-
-
Resolves: #96418 Releases: main, 11.5 Change-Id: I00b77f478c667f59b751c6f13c975d03799086d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72783 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org> Reviewed-by:
-
Resolves: #96377 Releases: main, 11.5 Change-Id: I98dfe39cf04468d54ee979afa34e7dd3bd40acf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72784 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #93027 Releases: main, 11.5 Change-Id: I65b4b84a12cf4985d14a62217b075e5c421e0ee6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72780 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This fixes several issues for the case that an editor only has access to translated pages and not to the default language (L=0). Resolves: #95795 Releases: main, 11.5, 10.4 Change-Id: Ied31c7aa5229d3b8686741dd97005f9b5f16ef16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72620 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 21 Dec, 2021 12 commits
-
-
This avoids the deprecation notice in PHP 8.1: Passing null to parameter #2 ($string) of type string is deprecated in /var/www/html/public/typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php line 179 Resolves: #96422 Releases: main, 11.5 Change-Id: I9c811bc0d2d4523a78fc6c72ee02be96efbe1bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72779 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This patch changes the behaviour when building the SchemaDiff on a non-default connection to only fetch tables which are mapped to that connection instead of fetching table details of all tables and discarding the information for unmapped tables later on. This improves the performance and avoids errors for data types unknown to doctrine/dbal in details of unmapped tables. Resolves: #92959 Releases: main, 11.5 Change-Id: Ia4a62d861ea0748995eb0dec4f01e9e65eb3ed46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72765 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96420 Releases: main, 11.5 Change-Id: Ida1b27956bfe759062904ee9d0c8246ea73f0667 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72763 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72778 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
When one or more hidden records are referenced in an "Insert records" content element, an "undefined array key" warning was thrown. Resolves: #96419 Releases: main, 11.5 Change-Id: I4f90dc78540bf8c56163cfb8247a13c86869fbe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72777 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Andreas Fernandez authored
If the PageLinkBuilder is invoked with a non-available TSFE as e.g. in the "Redirects" module, generating the URLs to pages with a fragment, e.g. to a referenced content element, works now as we're using the TSFE generated within PageLinkBuilder itself. Resolves: #96101 Releases: main, 11.5 Change-Id: I481b7d8573424dab59df22b0d81a734e03b70575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72776 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Kuhn authored
f:uri.resource is frequently used to load CSS and JavaScript resources. It is the only ViewHelper that does not understand the general "EXT:" syntax that is usually available when extension resource files are referenced. This is now added to improve consistency and documented as best practice in VH documentation. Change-Id: I504c79eef349b1ea6cc70cc0d7753319e1f356d9 Resolves: #96414 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72760 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Andreas Fernandez authored
The category starting points introduced with #95037 were designed to allow comma-separated values in its configuration. Due to improper tests, this specific notation was not discovered as being broken right now. If the incoming configuration is a string, GeneralUtility::intExplode() is applied to remove any non-integer value. Afterwards, a new CSV string is generated. Resolves: #96397 Related: #95037 Releases: main, 11.5 Change-Id: I0759d8093bb4665b7709f4e20539307467f246df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72775 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benjamin Franzke authored
RecordExportButton.js has been introduced in #94622 by accident (probably a left-over from a previous patchset re-added due to grunt watch). The TypeScript source for Enum/Viewport/TopbarIdentifiers.js has been removed with #78760, it is unused since then and therefore removed. Releases: main, 11.5 Resolves: #96411 Resolves: #96412 Related: #94545 Related: #78760 Related: #96323 Change-Id: I226d51fc87ab8012e917e7d219688fca21eda364 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72773 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types it is only allowed to use "string|null" and not "?string" Resolves: #96407 Releases: main, 11.5 Change-Id: I4e9ec53d05feb5cfffc4eebc29de447d6225ab66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72774 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
Currently, HMENU generates the direct destination for a shortcut URL, but typolink does not. This is an inconsistency, and since HMENU is actually using typolink now as well (in 4.x this was different), the resolving of shortcuts can now be moved into the typolink/link building functionality. Page Shortcuts are now resolved (recursively!) at a single point for all links, except for RANDOM_SUBPAGE variants, as this is sorted out during runtime when hitting the RANDOM_SUBPAGE shortcut page. Resolves: #80113 Resolves: #95947 Releases: main, 11.5 Change-Id: Ib6204ff1b0ecb699ec87f5154dc18c974676e65c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72772 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The core version service now uses the new entry point of the REST API available via https://get.typo3.org/api. The old entry point is still available but should not be longer used. For more information see `https://get.typo3.org/api/doc <https://get.typo3.org/api/doc>`_ and `https://github.com/TYPO3/get.typo3.org/pull/272 <https://github.com/TYPO3/get.typo3.org/pull/272>`_. Resolves: #92020 Releases: main, 11.5, 10.4 Change-Id: I2c92554e9ba212827b6412d4a88ac5c92e26aa17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72756 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
The dev dependency friendsofphp/php-cs-fixer now has a minimum requirement to 3.4, which comes with PHP8.1 support. This allows TYPO3 to run PHP-CS Fixer with PHP 8.1 in the CI pipeline. Testing configuration is not adjusted with this patch, but allows using corresponding runTests.sh testsuites cgl and cglGit: Build/Scripts/runTests.sh -p 8.1 -s cglGit -n Build/Scripts/runTests.sh -p 8.1 -s cgl -n Used command: composer req friendsofphp/php-cs-fixer:^3.4 --dev Resolves: #96398 Releases: main, 11.5 Change-Id: I6a4eaec0294829afcdf84b7b32303eaafbaa72bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72718 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 20 Dec, 2021 5 commits
-
-
The function `idn_to_ascii()` will return either `false` or a string, the former one is returned on errors. In #93900, the result was cast to string, making the check for `false` useless. As `idn_to_ascii()` can return both, the string cast is removed to make the check for `false` functional again. Resolves: #96399 Related: #93900 Releases: main, 11.5 Change-Id: Ib5327766fc545a75feb7389d18358aa85b76e5db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72720 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
doctrine/dbal:^3.2 changed return type of result for QueryBuilder execute methods, no longer have used prepared statement accessible for further query execution with other placeholder values. To raise doctrine/dbal:^3.2 two places have been changed to reuse the QueryBuilder instance itself instead of prepared statement with the corresponding patch #96287, thus given up the performance gain through reusable query execution plan in corresponding dbms systems. This patch adds support for prepared statements to TYPO3's QueryBuilder facade as this was not publicly available yet for TYPO3 users to be forward-compatible with Doctrine DBAL 3. Resolves: #96393 Related: #96287 Releases: main Change-Id: I814670ebf9920ed3162a31f98ad9efd4031f47c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72716 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
theChar is not initialized and therefore pollutes global scope. (It is assigned to window.theChar in the FormEngine iframe). Currently not an error (we are not using strict mode in RequireJS), just bad style, but once we switch to strict mode (type="module"), this will fail without proper declaration. Releases: main, 11.5 Resolves: #96395 Related: #96323 Change-Id: Ie82da6a1b664e4010179cccaabb07e7d87b19038 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72717 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
doctrine/dbal deprecated quite some methods to cleanup their codebase and provided replacements with more speaking method names. Most deprecated method usages have been replaced in the core, but we missed some. The patch replaces the deprecated method 'executeUpdate()' with the corresponding 'executeStatement()' method in several places to clean this up. This can be done also in 11.5 too, the required minimum version of doctrine/dbal provides these new methods as upwards compatible layer. Resolves: #96389 Releases: main, 11.5 Change-Id: Ibf8f49a27a1c8c4b34bda88a20f4fba6afe45cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72715 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Helmut Hummel authored
Instead of relying on a hard coded extension install path, now the real extension path is used provided by the package manager Releases: main, 11.5 Resolves: #96375 Change-Id: Ic2e4d71413416a5271420e939e5f74fa28cbaca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72691 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 19 Dec, 2021 1 commit
-
-
This patch ensures that the getQuery() function only uses the minus operator to negate the $storagePid variable, if the variable can be interpreted as an integer. Resolves: #96321 Releases: main, 11.5 Change-Id: Idacd43fd6639218fc1126bffcd43e78338f18e0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72714 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 18 Dec, 2021 1 commit
-
-
Helmut Hummel authored
A "type" does not need to be set in a composer.json, so the checks for package type must account for the type being null, to not trigger a warning in PHP 8 Releases: 11.5, main Resolves: #96372 Change-Id: Ic607c3dbb16dfcf4a28b0417b8340be36bcafa87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72712 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 17 Dec, 2021 3 commits
-
-
RTE yaml configuration can be incomplete/wrong or empty. Do not access configuration settings without a safeguard. Resolves: #96383 Releases: main, 11.5 Change-Id: Ie0888402e64a669816edd200d2d54e401e0c399f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72713 Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de> -
Oliver Bartsch authored
The RecordListGetTable hook allows to add an additional where clause to the recordlist query. Since the sanitized result was wrapped in an array before being passed to $queryBuilder->andWhere(), this led to an exception. This is now fixed by passing the sanitized clause as string to `addWhere()`. Resolves: #96378 Related: #92065 Releases: main, 11.5 Change-Id: I99fa184f49f9db9f7edf061d4137e1e6c275446e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72689 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Helmut Hummel authored
Get rid of the select query entirely, which optimises the task to only require one update query instead of one select and possibly multiple update queries and gets rid of doctrine version related incompatibilities with fetching the select result. Resolves: #96369 Related: #87162 Releases: main, 11.5, 10.4 Change-Id: I87b570f5efa3d77ed5f2c5fc0074e84bef4675a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72690 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 16 Dec, 2021 6 commits
-
-
The FinisherOptionGenerator of the form extension generates the data structure for the form setting overrides on the fly. By doing so, it didn't make a distinction between normal TCA fields and flexform specific sections/containers and added the wrapper "TCEforms" to sections as well, which broke the validation in DataHandler for the fields inside the container (E.g. the email field). The patch checks if section is set to "true" and adds the "TCEforms" key only for normal TCA field configurations. Unit tests have been added for the DataHandler checkValue_flex_procInData_travDS method, which show cases with and without the "TCEforms" key. Also, since this works now, a PHP 8 warning appeared. This is fixed now, too. Resolves: #95441 Releases: main, 11.5 Change-Id: Ib12a0484bcbdc827664181ca6af89edfadee13d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72688 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
Resolves: #96310 Releases: main, 11.5 Change-Id: Ie12ca1683b3d8668deafbd37af03437f047c0ac4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72685 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96358 Releases: main, 11.5 Change-Id: I36b7ddc31eb3e240c86f3a550d068d7577099f6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72686 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Fix PHP8 warning issue if $_SERVER['PATH_INFO'] is not set. Resolves: #96373 Releases: main, 11.4 Change-Id: I427aee39c6f6389e418f27474c01cbfd973355e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72687 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
HMENU special="directory" and special="updated" did not use PageRepository directly, which led to duplicate entries with workspaces. This change does not use "$cObj->exec_..." anymore and fixes all problems. composer req --dev typo3/testing-framework:^6.15.2 Resolves: #96226 Releases: main, 11.5 Change-Id: I595ac05981d03246eb7671c9ae072f499bff5188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72684 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
ext:extensionmanager has a couple of view helpers that extend ActionViewHelper for no apparent reason. Change those to extend AbstractTagBasedViewHelper instead. Resolves: #96361 Releases: main, 11.5 Change-Id: Iedab908a30df0418a7c86d073d97a47548a87ab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72683 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 15 Dec, 2021 8 commits
-
-
Resolves: #96308 Releases: main, 11.5, 10.4 Change-Id: Ibcbda7fd97a338d721cf00b38026727e941c72ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72680 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
If EXT:workspaces is not installed, the workspace information should also be skipped in the logging module. This makes it easier to read and less bloated. Resolves: #96314 Releases: main, 11.5 Change-Id: I22277ca681cc877d57686e02f36fe54e630d2f9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72679 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
Resolves: #94308 Releases: main, 11.5 Change-Id: I84836ba46e3b8e3fa8d4ac915efb5a6a7afbdca7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72678 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The following deprecation occurred in PHP 8.1: PHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated. This happens in various places: * Using stdWrap_field() or in stdWrap() places * BackendUtility (e.g. new IRRE elements) * ExtensionManager Resolves: #96354 Releases: main, 11.5 Change-Id: Ie5c721784b51ed5493c8d9e1d557b08611263f6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72677 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The routes added via ExtensionManagementUtility::addModule() are missing when the UriBuilder/Router is used prior to ext_localconf loading. Also for this particular case, multiple instances of the Router class were created, as UriBuilder is loaded from the failsafe installtool container instead of using an instance from the symfony container (as created by LateBootService n loadExtLocalconfDatabaseAndExtTables). This resulted in multiple routers being loaded with different sets of routes. This patch ensures that the routes are loaded from a UriBuilder/Router instance that is fully populated with information from ext_localconf. Therefore GeneralUtility::makeInstance() is avoided and UriBuilder is fetched from the late booted container instead. Resolves: #95806 Releases: main, 11.5 Change-Id: Id57bf09fb7798eac26dbdbc6ed89228c54fbafb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72675 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96350 Releases: main, 11.5 Change-Id: I67e9fd68de038b84c83f7f12a465e6e37f918568 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72676 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
If a language in the SiteConfig is set to the fallbackType free and there is no translated page for this language, then there is now no generated hreflang. Previously, a link was always generated with default language slug, which lead to 404 page not found. Resolves: #94270 Releases: main, 11.5, 10.4 Change-Id: Ifb261cf388fccbaabbf2bcae9ac805b143c9b42f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72673 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Releases: main, 11.5 Resolves: #96346 Change-Id: Ie64e82e84c63142f86b4e0f3e5072514b516aa33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72672 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Lina Wolf <112@linawolf.de> Reviewed-by:
-
