Skip to content
GitLab
  1. 02 Aug, 2016 1 commit
  3. 22 Apr, 2016 1 commit
  5. 20 Nov, 2015 1 commit
  7. 08 Oct, 2015 1 commit
  9. 11 Aug, 2015 1 commit
  11. 05 Aug, 2015 2 commits
  13. 14 Jul, 2015 1 commit
  15. 03 Jul, 2015 1 commit
  17. 21 Jun, 2015 1 commit
  19. 11 Jun, 2015 1 commit
  21. 07 May, 2015 1 commit
  23. 18 Jan, 2015 1 commit
  25. 16 Dec, 2014 1 commit
  27. 13 Dec, 2014 1 commit
  29. 02 Dec, 2014 1 commit
  31. 21 Nov, 2014 1 commit
  33. 14 Nov, 2014 1 commit
  35. 28 Oct, 2014 1 commit
  37. 25 Oct, 2014 2 commits
  39. 18 Sep, 2014 1 commit
  41. 30 Jul, 2014 1 commit
  43. 29 Jun, 2014 1 commit
  45. 22 Jun, 2014 1 commit
    • Michael Schams's avatar
      [TASK] Re-work/simplify copyright header in PHP files - Part 7 · 47a9bb03
      Michael Schams authored 
      This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59783 for further details.

Resolves: #59783
Releases: 6.3, 6.2
Change-Id: I0e2f68990217f7442abe5b940fd769250c37aec0
Reviewed-on: https://review.typo3.org/31028
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
      47a9bb03
  47. 25 Mar, 2014 1 commit
    • Markus Klein's avatar
      [CLEANUP] Extbase persistence classes · e636910f
      Markus Klein authored 
      The classes contain wrong type hints and miss a lot of
checks whether the correct object is present.

Resolves: #57031
Releases: 6.2
Change-Id: I3d03c838b05529daf0da444119dd7f8dba6d5b8a
Reviewed-on: https://review.typo3.org/28489
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
      e636910f
  49. 03 Mar, 2014 1 commit
    • Helmut Hummel's avatar
      [BUGFIX] Always fetch related objects if relation set by child · 04f66dba
      Helmut Hummel authored and Marc Bastian Heinrichs's avatar Marc Bastian Heinrichs committed 
      If the DataMapper shall map a 1:N relation for
a property of a domain object and the element
type of this property is another domain object
and not a storage type, the data mapper must
always fetch the related elements from persistence
and cannot rely on the persistence session lookup.

This is the case because the relation to the parent
is set on the child side and not the other way around.
The column in the parent row is useless in that case
and does not hold the id of the child.

We can also not rely on the persistence session
because we do not know the identifier of the child
until we fetched it.

Resolves: #56442
Releases: 6.2, 6.1
Change-Id: Icc3ebf9b825f6380691c60839621f01ca9875e4e
Reviewed-on: https://review.typo3.org/27949
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
      04f66dba
  51. 23 Feb, 2014 2 commits
  53. 18 Feb, 2014 1 commit
    • Nico de Haen's avatar
      [BUGFIX] Check identity map for existing objects · faa6e8a6
      Nico de Haen authored 
      The DataMapper should check if an object is already in the identityMap
before calling fetchRelated, since otherwise the object will be retrieved
from the database again.

Resolves: #53514
Releases: 6.1,6.2
Change-Id: I24e262322f1f0ba3c346fa01c50fa9063866aef7
Reviewed-on: https://review.typo3.org/25252
Reviewed-by: Nico de Haen
Reviewed-by: Fabien Udriot
Tested-by: Wouter Wolters
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
      faa6e8a6
  55. 14 Feb, 2014 1 commit
    • Michiel Roos's avatar
      [BUGFIX] rdndt getClassSchema() in thawProperties( · 744702ed
      Michiel Roos authored 
      getClassSchema() is being called within a foreach loop while the
$className never changes for that call.

Change-Id: I699a1a0ab34d784b7463244f218f4e8a0c0b7a0c
Resolves: #55991
Releases: 6.2
Reviewed-on: https://review.typo3.org/27633
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
      744702ed
  57. 01 Feb, 2014 1 commit
    • Jo Hasenau's avatar
      [TASK] Use (int) instead of intval() or (integer) · 9646d26b
      Jo Hasenau authored 
      This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014

Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
      9646d26b
  59. 29 Jan, 2014 1 commit
    • Helmut Hummel's avatar
      [BUGFIX] Prevent strings from being autoloaded · b15348a4
      Helmut Hummel authored 
      The introduction of a TypeConverter for Enumaration
types in #52762 added is_subclass() calls to
getPlainValue() in the DatabaseBackends. These methods
are meant to convert objects to simply types but are
regularly called with simple types, in particular strings.

Since is_subclass() also works with strings,
The class loader is triggered when these methods
are called with a table name like "tx_ext_domain_model_foo".

This triggers an issue #55418 in the class loader especially
on case insensitive filesystems.

Instead of is_subclass we now use instanceof to make sure
we only check for conversion if the value is an object.

Additionally this change fixes a wrong case statement which
also was introduced in #52762

Resolves: #54275
Change-Id: If1b2a28a2623e49dfb47720641935c6f24447c19
Reviewed-on: https://review.typo3.org/27079
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
      b15348a4
  61. 13 Jan, 2014 1 commit
  63. 15 Oct, 2013 1 commit
    • Sascha Egerer's avatar
      [TASK] Add type converter for core types like Enumeration · 28dbbbf9
      Sascha Egerer authored 
      * Fixed a major bug in Enumeration in the isValid function
  to prevent PHP typeloose comparison hell and added Tests
* Added a CoreTypeInterface that can be used in the extbase
  data mapper to map properties to new core types like
  the enumeration

Resolves: #52762
Releases: 6.2
Change-Id: I966c64ae8a82d13bdcb47c41917da98c48f0b475
Reviewed-on: https://review.typo3.org/24708
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Sascha Egerer
Reviewed-by: Stefan Neufeind
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
      28dbbbf9
  65. 01 Oct, 2013 1 commit
  67. 08 Jul, 2013 1 commit
    • Alexander Schnitzler's avatar
      [TASK] Replace inject methods with @inject · e83fa716
      Alexander Schnitzler authored and Anja Leichsenring's avatar Anja Leichsenring committed 
      Currently we are using inject methods like:

/*
 * @param $foo Foo
 */
public function injectFoo(Foo $foo) {
	$this->foo = $foo;
}

This patch removes these methods and introduces
property annotations:

/**
 * @var Foo
 * @inject
 */
protected $foo;

Change-Id: I5b6f1aae29f95c31b9dd69629f05d8451fe30261
Releases: 6.2
Resolves: #46598
Reviewed-on: https://review.typo3.org/22006
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
      e83fa716
  69. 06 Jul, 2013 3 commits