- 09 Jun, 2020 3 commits
-
-
Benni Mack authored
Change-Id: Iee9c54c415d56a51b74073c6d060ef756432a9fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64847 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
Change-Id: I53a1ee728a4c05f422ae8a8aa855d5cc94abbd24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64846 Tested-by:
-
Overriding route requirements with `.+` allows to have slashes in route parameters. This is different to Symfony's default behavior not allowing slashes here at all. However, when having multiple route parameters it can lead to resolving false-positive routes like shown in the following example: routePath: '{first}/{second}' URI: https://example.com/first/second/third resolves to parameters + first: 'first/second' + second: 'third' This change passes existing TYPO3 route `requirements` and uses pattern `.+` only for those parameters not having a definition - both applies to parameters using `aspects` only. Besides that tests in `EnhancerLinkGeneratorTest` mixed internal argument values with URL parameters (`100` <=> `hundred`) are were "wrong" before. Resolves: #91246 Releases: master, 10.4, 9.5 Change-Id: Ic1fe15790cc16dd52c624cd3be9ed060ae9b9d69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64842 Tested-by:Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 08 Jun, 2020 2 commits
-
-
Setting up backend layouts with colPos not set will show the content of column 0 because of an excplicit cast of the colPos. This patch checks if colPos is set and if not skips the assignment of records. Resolves: #91176 Releases: master, 10.4 Change-Id: I75d9818c4330bb8a4d9a7a60130a547167a83e58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64853 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Direct hash comparison is replaced by cryptographic-safe `hash_equals`. Changes in this patch set basically don't have much impact regarding security aspects. This is a preparation for starting with RIPS scanner. Resolves: #91565 Releases: master, 10.4, 9.5 Change-Id: I5666e586b6b6b462f7864a597139763fd2cd2f98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64775 Tested-by:
-
- 07 Jun, 2020 1 commit
-
-
Use only the body and the content-type header of the internal sub-request. Everything else of the sub-request can be discarded. Resolves: #91582 Related: #81644 Releases: master, 10.4 Change-Id: I393acb340c04b3c7aa0cde1e1de1df9fcc92ca7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64852 Tested-by:
-
- 05 Jun, 2020 4 commits
-
-
In order to reduce the amount of accessing globals in the future, and especially TYPO3_REQUEST which was born because of missing structure of TYPO3 Core, the currrent request object is now handed in (optionally) to methods, to work directly with them in TSFE context. Resolves: #91568 Releases: master, 10.4 Change-Id: I760dbd70c9748d69c669bc6f65d65d20dd8ab530 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64799 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Internal components using `unserialize` are enforced to disallow classes in their internal state representation. This is a preparation for starting with RIPS scanner. Resolves: #91571 Releases: master, 10.4, 9.5 Change-Id: I3a5026e34a381e79817b46025d81083b2bc5b290 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64779 Tested-by:
-
Resolves: #91550 Releases: master, 10.4, 9.5 Change-Id: I1de1eadbac4b4973250bba2dbf887efb19df872d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64797 Tested-by:
-
This patch ensures the linkText is returned and used if the target page is not available in the current language. Resolves: #90182 Releases: master, 10.4 Change-Id: Ifed1921ff42746582dd5abab93fafe7a29c12233 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64796 Tested-by:
-
- 04 Jun, 2020 3 commits
-
-
This is a preparation for starting with RIPS scanner. Resolves: #91566 Releases: master, 10.4, 9.5 Change-Id: I6f994cec9c977242c278963c8aa55cb138bdabe2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64794 Tested-by:
-
This fixes encoding issues in paths with URL-encoded spaces and other characters when indexed_search translates indexable file URLs into local paths. Resolves: #91586 Releases: master, 10.4, 9.5 Change-Id: Id20034137556f5705ee34b3adcca6250c77d83f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64792 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Benni Mack authored
Common URLs like typo3.org, tools.ietf.org or php.net are nowadays available as HTTPS, however some places in TYPO3 still use http:// as reference. This should be streamlined to resemble https:// everywhere. Resolves: #91581 Releases: master, 10.4 Change-Id: I76b5211f7e14cab0c6d190059d2be761bc664b53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64752 Tested-by:
-
- 03 Jun, 2020 4 commits
-
-
Filter out pages user has no access to on query time in page tree. This patch reintroduce a change which was reverted with https://review.typo3.org/c/Packages/TYPO3.CMS/+/64369 Resolves: #91221 Related: #90880 Related: #91348 Releases: master, 10.4, 9.5 Change-Id: Id90752c331bc6fc12b0d3a7d047adacf08cb7804 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64639 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
The plugin configuration of felogin is moved to the common used "Plugin" tab, to unify the position through the core. Resolves: #91416 Releases: master, 10.4 Change-Id: Ibbf26be6787795021e7ba6a0d3138bbf18121087 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64638 Tested-by:
-
It is possible for values returned by stdWrap to be of type int. RequestHandler->generateMetaTagHtml() expects meta tag values to be of type string. In order to avoid php errors, return values are now casted to strings. Resolves: #91533 Releases: master, 10.4, 9.5 Change-Id: I642d5fe0189955e26689a6cf65cdbe23255356a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64636 Tested-by:
-
Benni Mack authored
PageRepository->fixVersioningPid() needs "t3ver_wsid" and "t3ver_oid" to resolve a version, otherwise previewing in workspace context takes another SQL query per page slug candidate. Resolves: #91556 Releases: master, 10.4, 9.5 Change-Id: Ie95365fe76cd2e6e502324c5dbe145651795cff1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64635 Tested-by:
-
- 02 Jun, 2020 4 commits
-
-
Benni Mack authored
In change https://git.typo3.org/Packages/TYPO3.CMS.git/commit/e6e40cd214acc8581729ef9f6e98c5d9324ec11c of bugfix #90656 the title attribute of the result was changed to always be added, which should only be added when the title is not empty. Resolves: #91506 Related: #90656 Releases: master, 10.4 Change-Id: Ie267f89b5ae82daeb036c820391099f06bfccbaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64634 Tested-by:
-
Benni Mack authored
All code that is using the constant TYPO3_MODE is hard to test, as this needs to be encapsulated into various places. All testing framework places run with TYPO3_MODE=FE which makes it impossible to even consider making parts of the testing framework compatible running a pure Frontend-based request in the future. On top, the constant covers up cross-dependency between core dependencies (whereas $GLOBALS[TSFE]->fe_user is actually a dependency to EXT:frontend). Another testing-helper in Extbase's EnvironmentService allows to switch within Extbase to simulate Frontend behaviour. Resolves: #91521 Releases: master, 10.4 Change-Id: I85a34029e399b40d0780f907480f9059bfdb0edb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64633 Tested-by:
-
The acceptance tests folder 'InstallTool' holds tests that ensure the proper display of options in the stand alone Install Tool. A brand new test suite takes care of execution. Resolves: #89489 Releases: master, 10.4 Change-Id: Iaeedfd5a2db26d4ba111855dc3137f2e8ca8fa27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64547 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Scalar values sent via HTTP query parameters to FileSystemNavigationFrameController are using `json_encode` instead of `unserialize`. The parameter stream is still secured with an HMAC before being deserialized. Resolves: #91548 Releases: master, 10.4, 9.5 Change-Id: I57be68aac1787bdc27f2bbae40f8d71b1b33f79f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64625 Tested-by:
-
- 01 Jun, 2020 1 commit
-
-
When a live record that is hidden, but gets unhidden in a workspace version, the record should also be resolved within move placeholder resolving. Resolves: #88054 Releases: master, 10.4, 9.5 Change-Id: Ia5396c6d0cc6b6a915ac8af21008ff5c592c1fe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64632 Tested-by:
-
- 31 May, 2020 2 commits
-
-
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. * moves inline JavaScript for avatar handling to new SetupModule * avoids using configuration options `onClick`, `onClickLabels` and `confirmData.jsCodeAfterOk` which contain inline JavaScript * introduces configuration options `conformationData.eventName` and `clickData.eventName` to substitute mentioned deprecations * adds PSR-14 `AddJavaScriptModulesEvent` which allows to apply custom RequireJS modules to handle mentioned new custom events Resolves: #91132 Releases: master, 10.4 Change-Id: Ia68d0c473db862e0381671604347bd15ec89be35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64627 Tested-by:
-
eot, otf and ttf font formats were used to support very old browsers like <= IE8. Since TYPO3 v10 does only support modern browsers, these formats can be safely removed. Used commands: >yarn remove npm-font-source-sans-pro >yarn add source-sans-pro >grunt build Resolves: #90904 Releases: master, 10.4 Change-Id: I0676bcdb2bc70454f73027e8e216bb889c419a57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64551 Tested-by:
-
- 30 May, 2020 2 commits
-
-
This patch rephrases the notifications rendered in the Admin Tools. Some notifications now contain a better description of their respective meaning or what the consequences of certain actions are. Additionally, useless rendering of notifications that are never available in some responses have been removed. Resolves: #91461 Releases: master, 10.4 Change-Id: I94be58c4ecba2f7c0639866aef830168d2459dba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64550 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Scalar values sent via HTTP query parameters to ShowImageController are using `json_encode` instead of `unserialize`. The parameter stream is still secured with an HMAC before being deserialized. Resolves: #91509 Releases: master, 10.4, 9.5 Change-Id: I81b8d5a10a79536592b105c838470238e14b7dca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64608 Tested-by:
-
- 29 May, 2020 2 commits
-
-
Resolves: #91510 Releases: master, 10.4, 9.5 Change-Id: I5bfda8310342718dc696b182fd87b1954a6cdc39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64549 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Resolves: #91501 Releases: master, 10.4, 9.5 Change-Id: I7b77a3ee8aceac2cbdb6f3d4e0a02930b66eb863 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64546 Tested-by:
-
- 26 May, 2020 1 commit
-
-
In order to avoid accidentally committing a FIRST_INSTALL for developers starting to contribute to TYPO3 Core and using Core git repository for its basis local development setup, the FIRST_INSTALL file is ignored from git. Resolves: #91119 Releases: master, 10.4, 9.5 Change-Id: Iad459240bbc8a68892f03adf547373bc608f6a90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64544 Tested-by:
-
- 25 May, 2020 4 commits
-
-
Resolves: #91472 Releases: 10.4 Change-Id: I1a28d8a1f3d42bcc4e6fbbf0c328cd712927bb72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64576 Tested-by:
-
Resolves: #91471 Releases: master, 10.4, 9.5 Change-Id: Ib008a46cc2edb368fed3fc937858f1f3870938b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64542 Tested-by:
-
Tymoteusz Motylewski authored
Also fix misleading comment about permissions. Resolves: #91454 Releases: 9.5, master Change-Id: I1a399f1be613f007440bf542441bee60f53e49e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64557 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Deleting an extension in Extension Manager doesn't make much sense in a Composer-based installation. For this reason, the removal of extensions is prohibited now. Resolves: #91456 Releases: master, 9.5 Change-Id: Ia96cf2741fd749d9f50540366351c8b576cac96b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64568 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 22 May, 2020 7 commits
-
-
The PSR-14 event "AfterFileCopiedEvent" in FAL now also has the possibility to return the newly created file and the identifier. Resolves: #91373 Releases: master Change-Id: I08a01a0424e37fe2f010d2894d41a14628bdc950 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64478 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
If the TypoScript variable `plugin.tx_felogin_pi1.replyTo` was set to an email address, it triggered the following error: `Symfony\\Component\\Mime\\Exception\\InvalidArgumentException: An address can be an instance of Address or a string (\"array\") given)` Releases: master Resolves: #91458 Change-Id: I4179d42025d0373cd1d7c0938a83ec0c90e25465 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64559 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Git converts CRLF to LF when plaintext files are staged. The existing copies of the rte_ckeditor Contrib/* sources have therefore already been converted to LF by git [1]. Initially these files had been copied as CRLF from the ckeditor4 sources in node_modules by grunt npmcopy. Now, when `yarn build` is executed, the copy operation is performed again, which means the files are reverted back to CRLF. Git therefore needs to perform the CRLF to LF conversion again. (Which itself needs to be triggered by the developer by staging the changed files) We do now mimic git`s autocrlf behaviour and replace CRLF by LF in the files copied from ckeditor Contrib/* folders to prevent the files from clobbering the `git status` or `git diff` output. By passing `encoding: null` to the grunt.file.copy options we ensure that binary files will be copied as is. Also configure *.svg files to be checked out as LF on all platforms (namely windows) like we do for other plaintext files as well. This ensures svg files do not show up (in windows) as changed because their original from node_modules was stored as LF. *.patch is added as patching jquery on windows would fail otherwise. [1] https://git-scm.com/docs/gitattributes#_end_of_line_conversion Resolves: #91374 Releases: master, 9.5 Change-Id: I2977a6d44f96f6593152bfe698ba5d35f32b131f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64481 Tested-by:
-
The point of repeatable update wizards is that they are not marked executed and thus always checked for possible updates. They therefore must not be marked executed during installation. Resolves: #91211 Releases: master, 9.5 Change-Id: Ic4e98b95711433705f77899d664cc7cf2c7a42ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64326 Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
-
Activating "showHiddenFilesAndFolders" in BE User settings shows hidden files and folders also when navigating through the files in filelist module. Resolves: #91309 Releases: master, 9.5 Change-Id: I8f04b43a2cc0df93b6e77290caed2b33c6951e44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64424 Tested-by:
-
Resolves: #91457 Releases: master Change-Id: I29009a9498b050942e34a27815acdf996e6f0539 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64558 Tested-by:
-
Resolves: #91459 Relates: #91302 Releases: master Change-Id: Ic4af3247d7557a6c12a8d538e85795c507eab69a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64561 Tested-by:
-
