- 17 Nov, 2020 1 commit
-
-
To avoid loss of quality and spawning unnecessary imagemagick processes, cropping and scaling of images is now done with a single imagemagick process. By doing so, the code for SVG processing is streamlined. SVG processing code can further be improved later, by putting it into a dedicated file processing task processor. Releases: master, 10.4 Resolves: #91855 Change-Id: I3bf735e74dd46dec73431405f37616506747ccdf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65187 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- 22 Aug, 2020 2 commits
-
-
Helmut Hummel authored
Due to the fact that configurable processors weren't present when online media handling was introduced, a lot of code needed to be duplicated to make the processing work in a pre process event. Since we have configurable processors now, the code should is moved to a processor and the code duplication removed. This change is also a prerequisite to make deferred image processing work more smoothly, because the online media preview processing should be handled after a deferred image processor but before regular local image processing. Resolves: #92024 Releases: master, 10.4 Change-Id: Ifbc1159a0e98d2e42fedf6a57764778293b6035d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65346 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Helmut Hummel authored
Instead of spreading (similar) code that handles SVG files in multiple classes with conditional code branching, processing SVG files (mostly calculating new width and height according to the configuration) is now placed in an own file processor. Cropping SVGs is still done like before using IM/GM and resulting in an png image. In this case the new processor is skipped and the file is passed to the existing LocalImageProcessor. A new class is introduced, which calculates resulting image dimension from an original dimension and a given processing task. Releases: master, 10.4 Resolves: #92014 Change-Id: I5799c09b06d32a495a917da523506a6cc1f8e45d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65339 Tested-by:
Tim Schreiner <schreiner.tim@gmail.com> Reviewed-by:
-
- 29 Jun, 2020 1 commit
-
-
If a "fileExtension" is given in the Image Processing of FAL (e.g. via Fluid ViewHelper setting "fileExtension='png'"), then a SVG image is now converted to the target file extension as well. This might be important for various use cases when dealing with SVGs Resolves: #75191 Releases: master, 10.4 Change-Id: I82fd2e7cccf15f845a7624a8dc9135bb06eaf145 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63611 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- 16 Apr, 2020 1 commit
-
-
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/core/Classes bin/rector process --set=php53 typo3/sysext/core/Tests Resolves: #91054 Releases: master Change-Id: Ie27503980812581103a5d12581a80a7e8fe474f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64192 Tested-by:Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 30 Dec, 2019 1 commit
-
-
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:
-
- 25 Sep, 2019 1 commit
-
-
Allow registration of additional file processors. Resolves: #88602 Releases: master Change-Id: Iff5594ce07750e557f2dc316f3e8aacd90cf5c81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61088 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
- 14 Apr, 2019 1 commit
-
-
There is a copy/paste typo in LocalCropScaleMaskHelper, which was introduced in TYPO3 v8. The setting $TYPO3_CONF_VARS[GFX][processor_stripColorProfileCommand] is the correct one. Resolves: #87548 Releases: master, 9.5 Change-Id: I4f9e4f3f62e1b577a986c96a31d4438da1bc7f74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60465 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- 25 Aug, 2018 1 commit
-
-
The init method of GraphicalFunctions/Gifbuilder was used instead of a constructor to set up various internal properties, and is now shifted into a new constructor, making the extra call to init() superfluous. Resolves: #85978 Releases: master Change-Id: I71ee3bc8045f48b1636e46681dddd742ba1f56c4 Reviewed-on: https://review.typo3.org/58023 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 15 Jun, 2018 1 commit
-
-
First batch taking care of "easy" places. Resolves: #85283 Releases: master Change-Id: I68fa5a0559aae6191858aba7690ba72918bdf507 Reviewed-on: https://review.typo3.org/57240 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 10 May, 2018 1 commit
-
-
LocalCropScaleMaskHelper generates thumbnails with imageMagickConvert and custom crop parameters. This will overwrite the default settings. Append the GFX/jpg_quality parameter to the convert command. Resolves: #81796 Releases: master Change-Id: Iaa09e8b9134659c9ffba1c2984ef06d2c8250580 Reviewed-on: https://review.typo3.org/56779 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Bernhard Kraft <kraftb@think-open.at> Reviewed-by:
Alessandro <alessandro.filira@pallino.it> Reviewed-by:
-
- 01 Mar, 2018 1 commit
-
-
To be sure the image (especialy gif format) is correctly repaged after cropping it the +repage option needs to be added to the full command. This patch adds the option for the LocalCropScaleMaskHelper and the ImageBuilder cropscaling `crs` option. Resolves: #83407 Releases: master, 8.7 Change-Id: I27b471d33acdc76c7af28ca0f114be72de91fcb9 Reviewed-on: https://review.typo3.org/55269 Tested-by:
-
- 27 Nov, 2017 1 commit
-
-
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 16 Oct, 2017 1 commit
-
-
Properties which are only accessed inside of GraphicalFunctions and should remain inside are marked as protected, are migrated to arrays (to avoid inList calls instead of in_array()), removed or renamed to remove classic kasper's-style double negation namings. Resolves: #82768 Releases: master Change-Id: If45a9198c3a2979a6fe0a1619a9841bd37a2708e Reviewed-on: https://review.typo3.org/54318 Tested-by:
-
- 23 Aug, 2017 1 commit
-
-
Change a series of cgl details after update of php-cs-fixer from 1.0 to 1.4. Change-Id: Iba289f530e2df2c6fc73e5f5b705a673b4b3db0f Resolves: #82171 Related: #82164 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53776 Tested-by:
-
- 28 Mar, 2017 1 commit
-
-
The short-hand functionality within GraphicalFunctions to create a sub directory inside the hard-coded tempPath is a simple wrapper of GeneralUtility::mkdir_deep(). The according change deprecates both the property $tempPath and the method createTempSubDir(). Resolves: #80514 Releases: master Change-Id: Ie0f0ac017e979ab67820182d16d7a4ebbc2fd4e4 Reviewed-on: https://review.typo3.org/52212 Tested-by:
-
- 12 Mar, 2017 1 commit
-
-
Resolves: #79903 Releases: master Change-Id: I159286a17bbb7dbab9d5ef696608e0e4d8558e7d Reviewed-on: https://review.typo3.org/51751 Tested-by:
Anders Kostending <aha@systime.dk> Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Reviewed-by:
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 15 Jan, 2016 1 commit
-
-
Rename GFX settings to more generic names that do not refer to ImageMagick or no longer supported versions of ImageMagick in their name. The values for the setting of the graphics processor have been changed to refer to the tools by name and not by acronym. The Install Tool has been extended to perform a silent migration of the affected settings. Resolves: #43085 Releases: master Change-Id: I41450eafbadb5782a55f876a87f2bc0ff0704d62 Reviewed-on: https://review.typo3.org/42385 Reviewed-by:
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- 17 Sep, 2015 1 commit
-
-
When using the new image crop functionality in the backend the LocalCropScaleMaskHelper crops the image using gdlib functions. Those functions load the whole image into memory and can lead to fatal errors because of memory limits in case of large images. This fix replaces the gdlib functions with according ImageMagick/ GraphicsMagick functions which crop the image outside of PHP's memory. Resolves: #68484 Releases: master Change-Id: I390264838ebfd89701f860302a07b3f5895d46ac Reviewed-on: http://review.typo3.org/43389 Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Andreas Bouche <andreas.bouche@flagbit.de> Reviewed-by:
-
- 06 Jul, 2015 1 commit
-
-
Replace usages of "use TYPO3\CMS\Core\Utility;" with use-statements of the utility classes to be used. Change-Id: I6360790b41196387b6d411926cf120aa77d8b4f9 Resolves: #67908 Releases: master Reviewed-on: http://review.typo3.org/40919 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by:
-
- 15 Apr, 2015 1 commit
-
-
Frans Saris authored
TCA type image_manipulation brings a image manipulation wizard to the core. This first version brings image cropping with the possibility to set a certain aspect ratio for the cropped area. The sys_file_reference.crop property is extended and can now also hold a json string to describe the image manipulation. The LocalCropScaleMaskHelper that is used by the core to create adjusted images is also adjusted to handle the new format. Overriding TCA by TSConfig will be done in a followup. Resolves: #65585 Releases: master Change-Id: I58dee33e0f884ba2907259e8b03254c43f4c9186 Reviewed-on: http://review.typo3.org/37622 Reviewed-by:
Benjamin Kott <info@bk2k.info> Tested-by:
Andreas Fernandez <andreas.fernandez@aspedia.de> Tested-by:
-
- 09 Apr, 2015 1 commit
-
-
Added rendering support for SVG images. When a SVG image is scaled there is no processed file created but only a sys_file_processedfile record with the calculated new dimensions. When a mask or explicit cropping is set for an SVG image a processed file is created like for all other images. An extra fallback is added to ImageInfo to determine SVG dimensions when IM/GM fails. Resolves: #50136 Releases: master Change-Id: I9d4e298f0329059e83783a94209c80558ed83e27 Reviewed-on: http://review.typo3.org/38422 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Reviewed-by:
-
- 13 Mar, 2015 1 commit
-
-
This patch adds the "infrastructure" for single image cropping: * Extends LocalCropScaleMaskHelper to support the new crop setting * Adjusts the ViewHelpers to support the crop setting * Extends typoscript imgResource to support the crop setting * Adds a new db field for sys_file_reference to hold the crop settings The GUI will be added in a follow up #65585 Resolves: #65584 Releases: master Change-Id: I76c6ccd1f3f38e3a47f830115c7748ea4a6b10cd Reviewed-on: http://review.typo3.org/34277 Reviewed-by:
Mateusz Wojtuła <matw88@gmail.com> Tested-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
- 01 Feb, 2015 1 commit
-
-
Resolves: #64718 Releases: master Change-Id: I2ab9a4194f236ece9035d15dd4aa33ef9aa5371a Reviewed-on: http://review.typo3.org/36571 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 16 Dec, 2014 1 commit
-
-
Most of TYPO3's PHP files have an empty line before a class' closing curly brace. This commit adds this empty line (if it is missing) before a class' closing curly brace. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: (}\n)(}) Replace: $1\n$2 Resolves: #63942 Release: master Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7 Reviewed-on: http://review.typo3.org/35527 Reviewed-by:
-
- 13 Dec, 2014 1 commit
-
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
- 13 Nov, 2014 1 commit
-
-
Xavier Perseguers authored
Since PHP 5.5 is a requirement, calls to GeneralUtility::makeInstance() should use the ::class construct instead of a string argument. Releases: master Resolves: #61788 Change-Id: Ia2efc5a4cb7ecea80b8a1c8e5ff7b5d6fa9a07ce Reviewed-on: http://review.typo3.org/32913 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
- 28 Jun, 2014 1 commit
-
-
Stefan Neufeind authored
Mask-functionality is broken since the introduction of FAL. Change-Id: Iff28d9561e10f7581041bcc35bd56dfc972954b3 Resolves: #59392 Releases: 6.3, 6.2, 6.1 Reviewed-on: https://review.typo3.org/30610 Reviewed-by: Andreas Wolf Tested-by: Andreas Wolf Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- 22 Jun, 2014 1 commit
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59779 for further details. Resolves: #59779 Releases: 6.3, 6.2 Change-Id: I30ad23ccfccd86ba9e98a3b46b11836c1628f499 Reviewed-on: https://review.typo3.org/31024 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk
-
- 21 Jan, 2014 1 commit
-
-
Helmut Hummel authored
To make GifBuilder and GraphicalFunctions work in backend context, it is needed to set the absolute path prefix for processed images to document root. It works in FE context, because the current working directory of PHP is document root, but fails in BE context, as the CWD can be anything, depending on the location of the executing script. Set absPrefix to PATH_site in FAL crop scale mask helper so that the FAL file processing can be used in BE context. Resolves: #51804 Releases: 6.0, 6.1, 6.2 Change-Id: I824333dc6f6cff4286d9eefb20c045e5bb207658 Reviewed-on: https://review.typo3.org/23652 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- 13 Jan, 2014 1 commit
-
-
Roland Waldner authored
"textfile" will be replaced by "text file" Resolves: #54893 Releases: 6.2 Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b Reviewed-on: https://review.typo3.org/26736 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- 01 Oct, 2013 1 commit
-
-
Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b Resolves: #52360 Releases: 6.2 Reviewed-on: https://review.typo3.org/24212 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- 25 Sep, 2013 1 commit
-
-
Christian Kuhn authored
There are two very weird settings is GFX array that previously decided on how "masks" are applied to images if combining multiple images. GFX/im_negate_mask and GFX/im_imvMaskState are also manipulated during boostrap and depend on each other. Fiddling with those settings in ImageMagick 6 and GraphicsMagick with its supported versions, it turns out that they are obsolete and can be removed completly. The patch does this. Change-Id: Ic24c877287382f9e718974a0df3577dad2eeaac9 Resolves: #52088 Releases: 6.2 Reviewed-on: https://review.typo3.org/23880 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- 16 Sep, 2013 1 commit
-
-
im_mask_temp_ext_noloss setting is a bugfix for a no longer supported Image Magick 5 version. It can be removed. Change-Id: I1001c3fc8fa924ec16e24a9e790a0decf2771bcc Resolves: #52012 Releases: 6.2 Reviewed-on: https://review.typo3.org/23837 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- 01 Apr, 2013 1 commit
-
-
A ProcessedFile is used to generate a preview or crop-scaled version of a File. Actually a Task implementing the TaskInterface defines the basics and an accordant Helper object takes care of the modifications to that file. There are pre-process and post-process signals that seem to be useless in modifying the scope of a particular task, however. Imagine a file shall be pre-processed (e.g. color profile transformation) and that result shall be used for resizing. The current task implementation is using the original file directly, however the task actually shall define which is the source (the original file) the modifications shall be based on. This change modifies the TaskInterface with a getSourceFile() method to overcome this limitation. Change-Id: I280ea9a0bf056f9eee0a06995ab809fdafb8a11a Fixes: #46795 Releases: 6.0, 6.1 Reviewed-on: https://review.typo3.org/19438 Reviewed-by: Stefan Neufeind Tested-by: Steffen Ritter Reviewed-by: Steffen Ritter Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
- 28 Mar, 2013 1 commit
-
-
The following scenario is given: * resize a 300dpi TIFF image to PNG using stdWrap/cObj * the 'fileExtension' configuration is not set * the processed file csm_... has the file extension PNG * but the file content type is still TIFF, so the file was just renamed, but not converted to PNG Since the processing task determines the accordant filename and file extension of the processed file, the image processor (e.g. ImageMagick) needs to know about that fact as well. This change modifies the TaskInterface which is rarely to not at all used in custom extensions implementing individual tasks to process files. Change-Id: I089edc01a39663ac91b1b9df168f659c32954fcb Fixes: #46530 Releases: 6.0, 6.1 Reviewed-on: https://review.typo3.org/19169 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
