- 04 Jan, 2022 7 commits
-
-
The scenario provided by tables tx_irretutorial_mn_sym_* gets its own test extension and gets loaded where needed. Resolves: #96445 Releases: main, 11.5 Change-Id: I55a9c3ba1a5e1d238279a641f4e5380d936c23c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72876 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benjamin Franzke authored
With the changes in #95854, database mounts are no longer sorted by the order they are defined in the group/user settings, but undefined by the order the database returns. DB mounts aren't sorted against each other, that means sorting values are not meaningful anyway, and results in uncontrolable orderings. Explicitly preserve the order using usort(). Also revert groupAndSortPages() to the state prior to #95854, as the forcePid parameter would now be unused. Releases: main, 11.5, 10.4 Resolves: #96359 Related: #95854 Change-Id: I64b8d90c68246cc0ac01abcbf3678aa1055189e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72875 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
The frontend preview aspect may be set from the admin panel or the frontend extension or even from a third-party extension in a middleware. The previous implementation overwrote the preview settings on every initialisation, resulting in lost preview information. Instead of overwriting the setting, this change takes the current preview value into account - if the preview was enabled by a previous instance this is kept. Additionally, the logic to set the preview flag in both frontend and admin panel has been streamlined. Resolves: #91225 Releases: main, 11.5 Change-Id: I9f642bca1928638cac5eb5c1468710f5fad28137 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72872 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
The busybox variant as packaged with the test images based on alpine of mktemp needs six 'X' as template in cglFixMyCommit.sh. It otherwise emits a warning executing the command: > Build/Scripts/runTests.sh -s cglGit Resolves: #96432 Releases: main, 11.5, 10.4 Change-Id: I1c1853aabe79186694161c21f5fe0341e1bd2e75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72873 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The option "autoplay" only works if "mute" is enabled. See https://developer.chrome.com/blog/autoplay/ for reference. Resolves: #96320 Releases: main, 11.5, 10.4 Change-Id: Ic4e2de0576fe3d1619af8e35274adeb013c72b31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72845 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The documentation states "case" and "pidonly" are of type boolean. But in the code in_array was used to decide, whether to utilize these options. This is now fixed by checking for the array keys. Some lines above in the first if-branch, this has been already fixed. Resolves: #96454 Releases: main, 11.5 Change-Id: I04c3638620f7a91612bdc0598ff25893325bb801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72844 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
TCA eval config is not required, so it must be checked for existence. Resolves: #96453 Releases: main, 11.5 Change-Id: I95425e3febac70ac2e03478b7385edbaf0c9a601 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72843 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 03 Jan, 2022 7 commits
-
-
This change enables raises Symfony's minimum version to 5.4.0 as this is a LTS version. Resolves: #96171 Releases: main, 11.5 Change-Id: Ia2acbe0bca60e0dbdb96cb2fe2e82a63f9575554 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72836 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Resolves: #96415 Releases: main, 11.5 Change-Id: I4f96cd250b1f1ef27c7232b8fff3214cb555ab32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72841 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Johannes Seipelt <johannes.seipelt@3m5.de> Reviewed-by:
-
Added the following Composer plugins as allowed/trusted * composer/package-versions-deprecated * typo3/class-alias-loader * typo3/cms-composer-installers Resolves: #96428 Releases: main, 11.5, 10.4 Change-Id: Iabb8f00411279f502bca1d1ba79714cc58d82d3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72781 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
It seems that symfony >= 5.4.0 has a bug in symfony finder that .gitignore files are no longer always found when the ->in() directive is a non-absolute path with '/../'. This triggers issues with our cgl fixer script in nightly mode. We work around that by using an absolute path instead in the configuration and will report the issue to symfony. Resolves: #96450 Related: #96171 Releases: master, 11.5 Change-Id: Ice865b92c118e26d519fbca7ae49e41fbe4d5110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72842 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
If rendering of spacer pages in an HMENU is explicitly given via SPC = 1, then subpages of pages are now rendered as well. This way, there is no difference between spacers and other page types for submenu rendering anymore. Resolves: #64428 Releases: main, 11.5 Change-Id: Ic4bc2661399498de61af486712ade85815ffa529 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72840 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Resolves: #96443 Releases: main, 11.5 Change-Id: I9f1c951628cf8872473ff20bbd59ffb769ffe279 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72839 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Make sure to pass strings to html formatting methods. Initialize hierarchy array correctly. Resolves: #96448 Releases: main, 11.5 Change-Id: I2b9c28303c1c96d0a2ea1bc3ca971da3b4b3fe7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72838 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 30 Dec, 2021 4 commits
-
-
This error occurs when running linkvalidator in scheduler: Undefined array key 1. Resolves: #96439 Releases: main, 11.5 Change-Id: Idbe4b5bf52722a800026fc7af566daba925eaad2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72837 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
With the changes in #95854, implicit rootPid dbmounts caused duplicated pages in pagetree, because explicit page mounts have been considered multiple times for the pid=0 tree: * First time because of their relationship to pid = 0 * Second time because of their explicit mount (which was sorted into the pid = 0 tree) This happened because #95854 optimized to only use one call to the PageTree repository, which then had the side effect of merging "multiple" pages into one tree, instead of showing "two" separate trees. The patch ensures that multiple page trees are used when the rootPid (0) is included as a webmount. Releases: main, 11.5, 10.4 Resolves: #96367 Related: #95854 Change-Id: I7f421995f2d4aa88bb266fec684565102a4dc080 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72835 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The TCA option "appearance" is an array, with pre-defined configuration keys. The column "custom_stages" of the table "sys_workspace" set a csv value for this option. This does not work. The configuration is now transformed into the correct array format. Resolves: #96437 Releases: main, 11.5, 10.4 Change-Id: I25112d7ea1ce605376d70fa2dabceddd3c121faa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72833 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96438 Releases: main, 11.5 Change-Id: Idcb8ca5f889aef8d77c1e3950f5794fe54ed76e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72832 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 29 Dec, 2021 1 commit
-
-
Resolves: #96441 Releases: main, 11.5 Change-Id: Id3ae6ee43d1db5ef2ee46fedb336561bc8049a72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72791 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 28 Dec, 2021 1 commit
-
-
The setup should not contain the same settings twice. Moreover, the default paths are always available, no need to configure them. Additionally, remove default paths from constants, we don't need that either. Resolves: #96384 Releases: main, 11.5 Change-Id: I204cc38a952dd7acd097d188d1637ad1b25324fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72719 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
- 23 Dec, 2021 10 commits
-
-
This change adds test to document the behavior that excludeDoktypes needs to be set to render folders in a menus as well. Resolves: #93924 Releases: main, 11.5 Change-Id: I870e2ef5cd07d5365d93ad04752b74a4edaebd64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72790 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
This only fixes the issue for dedicated record links. Page links with added query arguments can still lead to broken links. Resolves: #87260 Releases: main, 11.5 Change-Id: Ib13aa1925de6463688e2b50612ce7b2820733ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72788 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
Previously, HMENU.addQueryString, which is only available for special=language, was applied not within the typolink() functionality but before. By sorting out the properties, HMENU with special=language now properly uses typolinks addQueryString. Using the magic property _ADD_GETVARS to activate this option addQueryString but also using the "_PAGES_OVERLAY_REQUESTEDLANGUAGE" allows to fix special=language issues. Resolves: #94713 Releases: main, 11.5 Change-Id: Ic26e702fb97bb878308de5e1710d2a3c4f28552d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72789 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
Resolves: #96344 Releases: main, 11.5 Change-Id: I986945e16e0a2adef827fc0532a431be7ab25e03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72787 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
Resolves: #96430 Releases: main, 11.5 Change-Id: I8569537d90ee5dc74157db4f3e583366b82a2e27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72786 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
There is a difference between > typolink.linkAccessRestrictedPages = 1 (only a toggle) and > HMENU.showAccessRestrictedPages = [pageId]|NONE HMENU.showAccessRestrictedPages behaves like the global option "config.typolinkLinkAccessRestrictedPages" Basically, if a page is access restricted, link to a different {pageId}. This change explains the behavior: -- https://review.typo3.org/c/Packages/TYPO3.CMS/+/35908/ "typolink.linkAccessRestrictedPages" in contrast still links to the actual disallowed page, which is also nice in case you have a 403 error page in place. This change fixes the behaviour of HMENU to behave EXACTLY like the global config.typolinkLinkAccessRestrictedPages, previously HMENU did some magic PLUS it set "typolink.linkAccessRestrictedPages" With this change, shortcuts to access restricted pages now get properly transformed and linked for menus. Resolves: #60258 Resolves: #65118 Related: #63804 Releases: main, 11.5 Change-Id: Ifd975243fe4b024b3fcbd4e356430d809cc0f429 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72785 Tested-by:core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96418 Releases: main, 11.5 Change-Id: I00b77f478c667f59b751c6f13c975d03799086d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72783 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96377 Releases: main, 11.5 Change-Id: I98dfe39cf04468d54ee979afa34e7dd3bd40acf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72784 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #93027 Releases: main, 11.5 Change-Id: I65b4b84a12cf4985d14a62217b075e5c421e0ee6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72780 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This fixes several issues for the case that an editor only has access to translated pages and not to the default language (L=0). Resolves: #95795 Releases: main, 11.5, 10.4 Change-Id: Ied31c7aa5229d3b8686741dd97005f9b5f16ef16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72620 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 21 Dec, 2021 10 commits
-
-
This avoids the deprecation notice in PHP 8.1: Passing null to parameter #2 ($string) of type string is deprecated in /var/www/html/public/typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php line 179 Resolves: #96422 Releases: main, 11.5 Change-Id: I9c811bc0d2d4523a78fc6c72ee02be96efbe1bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72779 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This patch changes the behaviour when building the SchemaDiff on a non-default connection to only fetch tables which are mapped to that connection instead of fetching table details of all tables and discarding the information for unmapped tables later on. This improves the performance and avoids errors for data types unknown to doctrine/dbal in details of unmapped tables. Resolves: #92959 Releases: main, 11.5 Change-Id: Ia4a62d861ea0748995eb0dec4f01e9e65eb3ed46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72765 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #96420 Releases: main, 11.5 Change-Id: Ida1b27956bfe759062904ee9d0c8246ea73f0667 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72763 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72778 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
When one or more hidden records are referenced in an "Insert records" content element, an "undefined array key" warning was thrown. Resolves: #96419 Releases: main, 11.5 Change-Id: I4f90dc78540bf8c56163cfb8247a13c86869fbe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72777 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Andreas Fernandez authored
If the PageLinkBuilder is invoked with a non-available TSFE as e.g. in the "Redirects" module, generating the URLs to pages with a fragment, e.g. to a referenced content element, works now as we're using the TSFE generated within PageLinkBuilder itself. Resolves: #96101 Releases: main, 11.5 Change-Id: I481b7d8573424dab59df22b0d81a734e03b70575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72776 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
f:uri.resource is frequently used to load CSS and JavaScript resources. It is the only ViewHelper that does not understand the general "EXT:" syntax that is usually available when extension resource files are referenced. This is now added to improve consistency and documented as best practice in VH documentation. Change-Id: I504c79eef349b1ea6cc70cc0d7753319e1f356d9 Resolves: #96414 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72760 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Andreas Fernandez authored
The category starting points introduced with #95037 were designed to allow comma-separated values in its configuration. Due to improper tests, this specific notation was not discovered as being broken right now. If the incoming configuration is a string, GeneralUtility::intExplode() is applied to remove any non-integer value. Afterwards, a new CSV string is generated. Resolves: #96397 Related: #95037 Releases: main, 11.5 Change-Id: I0759d8093bb4665b7709f4e20539307467f246df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72775 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benjamin Franzke authored
RecordExportButton.js has been introduced in #94622 by accident (probably a left-over from a previous patchset re-added due to grunt watch). The TypeScript source for Enum/Viewport/TopbarIdentifiers.js has been removed with #78760, it is unused since then and therefore removed. Releases: main, 11.5 Resolves: #96411 Resolves: #96412 Related: #94545 Related: #78760 Related: #96323 Change-Id: I226d51fc87ab8012e917e7d219688fca21eda364 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72773 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types it is only allowed to use "string|null" and not "?string" Resolves: #96407 Releases: main, 11.5 Change-Id: I4e9ec53d05feb5cfffc4eebc29de447d6225ab66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72774 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
Currently, HMENU generates the direct destination for a shortcut URL, but typolink does not. This is an inconsistency, and since HMENU is actually using typolink now as well (in 4.x this was different), the resolving of shortcuts can now be moved into the typolink/link building functionality. Page Shortcuts are now resolved (recursively!) at a single point for all links, except for RANDOM_SUBPAGE variants, as this is sorted out during runtime when hitting the RANDOM_SUBPAGE shortcut page. Resolves: #80113 Resolves: #95947 Releases: main, 11.5 Change-Id: Ib6204ff1b0ecb699ec87f5154dc18c974676e65c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72772 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
