Skip to content
GitLab
Switch branch/tag
  1. 07 May, 2022 1 commit
  3. 30 Nov, 2021 1 commit
  5. 24 Sep, 2021 1 commit
  7. 11 Sep, 2021 1 commit
  9. 12 Aug, 2021 1 commit
  11. 06 Aug, 2021 1 commit
  13. 15 Apr, 2020 1 commit
  15. 14 Apr, 2020 1 commit
  17. 29 Feb, 2020 1 commit
  19. 24 Oct, 2019 1 commit
  21. 30 Sep, 2018 1 commit
  23. 11 Jun, 2018 1 commit
  25. 10 Feb, 2018 1 commit
  27. 16 Feb, 2017 1 commit
  29. 04 Feb, 2017 1 commit
  31. 03 Feb, 2017 1 commit
  33. 22 Dec, 2016 1 commit
  35. 30 Aug, 2016 1 commit
  37. 08 Oct, 2015 1 commit
  39. 15 Jul, 2015 1 commit
  41. 30 Jan, 2015 1 commit
  43. 13 Dec, 2014 1 commit
  45. 23 Sep, 2014 1 commit
  47. 22 Jun, 2014 1 commit
    • Michael Schams's avatar
      [TASK] Re-work/simplify copyright header in PHP files - Part 4 · 60eb4f47
      Michael Schams authored 
      This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59780 for further details.

Resolves: #59780
Releases: 6.3, 6.2
Change-Id: I00eff31cdff19774527e3b1bb06e29152928414c
Reviewed-on: https://review.typo3.org/31025
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein
      60eb4f47
  49. 05 Apr, 2014 1 commit
  51. 10 Feb, 2014 1 commit
    • Christian Kuhn's avatar
      [TASK] Reduce memory footprint of unit tests · 2d05837d
      Christian Kuhn authored 
      Running the whole unit test suite on cli can eat up a significant
amount of memory. Most of that can not be mitigated due to phpunit
itself, but we can at least hint the PHP garbage collection by
unsetting test class properties in tearDown().

The patch introduces a generic tearDown() method that reflects the
test class and unsets all temporary properties of the class. In
effect, tests do not need to take care of unsetting properties.

The patch removes all tearDown() methods that only unset() stuff
and keeps others that do additional things but adds a call to
parent::tearDown(). Private properties are changed to protected,
so parent::tearDown can reach them. The additional computing
effort of the reflection is insignificant, the suite is nearly as
fast as before.

Results:
php 5.3: 1056MB -> 851MB
php 5.4: 870MB -> 670MB
php 5.5.: 876MB -> 674MB

Resolves: #55850
Related: #51436
Releases: 6.2
Change-Id: Ie665c53a3ab35e4808677e483d2099e0511c393f
Reviewed-on: https://review.typo3.org/27528
Reviewed-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
      2d05837d
  53. 01 Oct, 2013 1 commit
  55. 29 Jul, 2013 1 commit
  57. 19 May, 2013 1 commit
    • Philipp Gampe's avatar
      [BUGFIX] MailUtility::parseAddresses() returns @localhost on empty string · 3ecec354
      Philipp Gampe authored 
      parseAddresses should return an array of email addresses ready to be
feed into swiftmailer.
If an empty string is passed to the function, then it returns
"@localhost", which is not a valid email.
Swiftmailer will throw an exception "Address in mailbox given
[@localhost] does not comply with RFC 2822, 3.6.2."
This happens in ContentObjectRenderer->sendNotifyEmail() which is in
turn used by the frontend login forgotten passwort form.

Skip any addresses without a mailbox given.

Resolves: #48247
Releases: 6.2, 6.1
Change-Id: If8724416b3451417db7729dc81abdbd068dc8b10
Reviewed-on: https://review.typo3.org/20839
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
      3ecec354
  59. 19 Mar, 2013 1 commit
    • Wouter Wolters's avatar
      [TASK] Update copyright year to 2013 · 4d463976
      Wouter Wolters authored and Christian Kuhn's avatar Christian Kuhn committed 
      In this patch are also some fixes for files containing
a interface. Due the namespace change all interfaces
have the curly bracket not on the same line as the
interface name.

Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
Resolves: #46370
Releases: 6.1
Reviewed-on: https://review.typo3.org/18984
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
      4d463976
  61. 16 Nov, 2012 1 commit
  63. 22 Sep, 2012 1 commit
    • Markus Klein's avatar
      [TASK] Introduce base class for PHPUnit tests · 538a04a8
      Markus Klein authored and Christian Kuhn's avatar Christian Kuhn committed 
      Previously all core unit tests extended from the
Tx_PhpUnit_TestCase. This turned out to be problematic
because the core tests relied on the behaviour of that
class and we could not easily change behaviour centrally
for the core tests.
Because of that, we introduced several own base test classes
which added functionality for specific test cases.

With introducing a new base test case class which is
extended by all core test, we can consolidate helper
functions and specific wanted behaviour like blacklisting
TYPO3_DB globals for all tests.

Additionally all tests will benefit from
future enhancements in the base class.

Resolves: #41171
Releases: 6.0

Change-Id: Ic9e5c4b128ffb81cc9228e080a9d4a7909ee9dcd
Reviewed-on: http://review.typo3.org/14836
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
      538a04a8
  65. 16 Sep, 2012 1 commit
    • Arvid Jakobsson's avatar
      [TASK] Remove superfluous parenthesis in sysext core · 015f697c
      Arvid Jakobsson authored 
      Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I818d55a2f00b549fef8377f1c6766c293edd021c
Resolves: #40880
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14565
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
      015f697c
  67. 09 Sep, 2012 2 commits
    • Christian Kuhn's avatar
      [TASK] Fix for unit tests to change singletons and reset again · 4fd6bfa2
      Christian Kuhn authored 
      TYPO3\CMS\Core\Utility\GeneralUtility::setSingletonInstance() is a method
for unit tests to inject singleton mocks for classes that are
instantiated with makeInstance. purgeInstances() can be used to reset all
registered singletons, so makeInstance() creates new objects after that.
purgeInstances() can change the behaviour of tests that are executed
afterwards, because *all* registered singletons are reset. Currently the
helper methods for singletons around makeInstance() are not able to get
the list of registered singletons, and reset them to the previous list.

The patch introduces method getSingletonInstances() that returns a list
of all registered singletons (used in setUp()), and method
resetSingletonInstances() that resets registered singletons to a given
stored list (used in tearDown()). This way it is possible to fiddle in
tests with purgeInstances() without introducing side effects to other
tests.

All unit tests that used purgeInstances() are adapted to take care
of re constitution of changed objects this way.

Change-Id: I19dc869423a537226bb019e227d84b6f74fe9afc
Resolves: #40780
Releases: 6.0
Reviewed-on: http://review.typo3.org/14487
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
      4fd6bfa2
    • Wouter Wolters's avatar
      [TASK] Namespace and move t3lib unit tests - 5 · 1721a490
      Wouter Wolters authored and Christian Kuhn's avatar Christian Kuhn committed 
      This patch moves most unit tests of the tests/Unit/t3lib/*
directory to the core extension, following the new name scheme.

Change-Id: Ia08a3c0251c577676e3920dc880bb54e1651e5c2
Resolves: #40620
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14339
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
      1721a490
  69. 24 Aug, 2012 1 commit
  71. 14 May, 2012 1 commit
    • Roland Waldner's avatar
      [BUGFIX] CGL:ArrayBracketSpacingSpaceBeforeBracket · 7657736f
      Roland Waldner authored 
      on metrics.typo3.org the violations drilldown
says that are 2 violations against
"ArrayBracketSpacingSpaceBeforeBracket" in
tests/Unit/t3lib/utility/
class.t3lib_utility_mailTest.php.

this should be fixed.

after that i guess this coding guidline sniff
could be activated in the CI-server jobs?

Change-Id: I6fb7c6b67611ebac903466b28c7c473b3d36ee51
Fixes: #37141
Releases: 6.0
Reviewed-on: http://review.typo3.org/11159
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
      7657736f
  73. 06 May, 2012 1 commit
  75. 05 May, 2012 1 commit
  77. 12 Apr, 2012 1 commit
    • Oliver Klee's avatar
      [BUGFIX] Fix the unit tests to work with PHPUnit 3.6 · e2ddce00
      Oliver Klee authored and Christian Kuhn's avatar Christian Kuhn committed 
      Phpunit 3.6 is no longer able to test for a generic Exception
class. The main part of this patch changes generic Exceptions to
better detailed subclasses to give more information on the error.

Change-Id: I2197b88fae4e90d8c5ceaa0f983f43ef1388ed02
Fixes: #35202
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10187
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
      e2ddce00