- 30 Aug, 2018 21 commits
-
-
This patch implements the symfony expression language for TypoScript conditions in frontend and backend and is a preparation for the old conditions being deprecated. The existing conditions are available as variables and/or functions. This enables the full power of symfony expression language for TypoScript conditions. Resolves: #85829 Releases: master Change-Id: I7bcb7940ae1c36500eb7dc40fe84c7dd48d674a6 Reviewed-on: https://review.typo3.org/57787 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Check the current site language and use TS as fallback in the LocalizationUtility Resolves: #85644 Releases: master Change-Id: If0e92dc7d8f12755251fc4b8cceb6db155dbf3e2 Reviewed-on: https://review.typo3.org/57697 Tested-by:
Rudy Gnodde <rgn@windinternet.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Daniel Lorenz <daniel.lorenz@extco.de> Tested-by:
-
At the point where TSFE creates a Redirect URL for shortcuts, $type should be used from the normalized $tsfe->type property and not from the GET variable directly, as this could have been modified by a hook already. Resolves: #86040 Releases: master Change-Id: I87503570ca257d10ebca3a9056213ae5a5354764 Reviewed-on: https://review.typo3.org/58087 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Daniel Sattler <sattler@b13.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
The parent::init call was removed in a code cleanup and has been re-added as it is necessary for initialization. Resolves: #86043 Releases: master Change-Id: Ic0f5d9de30f6a83385850375d5f381cac5f5f941 Reviewed-on: https://review.typo3.org/58091 Tested-by:
-
The Page Router checks for all pages that are available by using the FrontendRestrictionContainer for database queries. This leads to side-effects in the future. Instead, - because all page slugs in one site are unique per language+workspace - the Page Router should only check for deleted+current workspace, not wondering about any other restriction, as this is done when all pages in the rootline are checked later-on anyway. This way, frontend previews should be available again. Resolves: #86037 Releases: master Change-Id: Ic11a66a958f9391de9084fad86b5d59109bd21c3 Reviewed-on: https://review.typo3.org/58084 Tested-by:
-
The new @import TypoScript syntax only works if there is an empty line before, so this should be added - to be exactly in line with the <INCLUDE_TYPOSCRIPT> syntax. Resolves: #85867 Releases: master Change-Id: I20fd9ba12b19baedfe4e4522811dfaebb51773fa Reviewed-on: https://review.typo3.org/58090 Tested-by:
-
Benni Mack authored
When a site (language) has "/en" as base, then the page router does not kick in, as the PageRouter receives a "/" at the very beginning of the $routePathTail, which needs to be removed. Resolves: #86044 Releases: master Change-Id: I770911bc1157cfb8a217b5e16dc303859f63cedd Reviewed-on: https://review.typo3.org/58092 Tested-by:
-
Enabling future enhancements for the adminpanel without having to make breaking changes for existing module providers is a key ingredient for providing a future proof extensible solution. Using single big interfaces that need to change on updates break backwards compatibility and do not provide sufficient feature encapsulation. The adminpanel APIs have been refactored to use a composition pattern to allow modules more flexibility. Modules can now only implement the interfaces they need instead of implementing all functionality. For example an adminpanel module that only provides page related settings does no longer have to implement the getContent method. Small interfaces have been provided as building blocks for modules with rich functionality. Easy addition of new interfaces that _can_ (not must) be implemented allow future improvements. Additionally the API has been modified to allow a more object-oriented approach using simple DTOs instead of associative arrays for better type-hinting and a better developer experience. Storing and rendering data have been separated in two steps allowing to completely disconnect the rendered adminpanel from the current page. This is a preparation for a standalone adminpanel that can be implemented separately. Resolves: #86003 Releases: master Change-Id: I88236a86e612dee9085b9f6ad7da34f90770d5ed Reviewed-on: https://review.typo3.org/57987 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Enable the functionality again to have a site with three languages to work in fallback mode (sys_language_mode = content_fallback) Resolves: #86031 Releases: master Change-Id: Id1a8897de057fb3d5a3244b3842f8dee377a4df6 Reviewed-on: https://review.typo3.org/58077 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Fix three cases in the display condition of url segment: * Show 'slug' if a new page in default language is added * Resolve correct pid to positive int if a new page is created 'after' another one (incoming pid is negative) * Always show slug if a new page below root (pid 0) is added that resolves to a NullSite Change-Id: Id34021eb923ddde80920152a92aa76466a6e72ab Releases: master Resolves: #86036 Related: #85955 Reviewed-on: https://review.typo3.org/58082 Reviewed-by:
-
* 1:1 inline relation csv (Post->additonalName) * 1:1 inline relation foreign_field (Post->additonalInfo) * 1:n inline relation csv (Post->additionalComments) * n:1 group relation (Post->secondAuthor) It also makes Person model translatable. Resolves: #85974 Releases: master Change-Id: I75a8e6c070e9a6bdfba0772b102a13bc94f7556f Reviewed-on: https://review.typo3.org/58032 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
During the cleanup of https://review.typo3.org/#/c/58022/ a wrong change was done, this actually introduces a regression showing that the scheme part is never evaluated, removing the superfluos check now completely. Resolves: #86042 Related: #85964 Releases: master Change-Id: I0e5a6f5d90141a86e34b4950ace36d620bee813f Reviewed-on: https://review.typo3.org/58089 Tested-by:
-
Resolves: #86041 Releases: master Change-Id: Id5802bc40a6070ddcd21c76e2417d438cefa9efd Reviewed-on: https://review.typo3.org/58088 Tested-by:
-
In order to centralize usages regarding global magic ($_GET/$_POST) within TypoScriptFrontendController, the method initializeSearchWordData() is renamed to something useful, and is now handed in the variable from GeneralUtility::_GP() and also gets some unit tests, making this method also notice-free, as a side-effect. This pre-patch allows to inject something else (PSR-7 request) in the future without ever touching this method. Resolves: #86035 Releases: master Change-Id: I3db94dd3ce23de8d2f8772067ec15d38d0f7cf64 Reviewed-on: https://review.typo3.org/58081 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
When adding a content element, EditDocumentController expects the id for fetching being a positive page ID. This is however edgy as a record (like tt_content) being added after another record receives the negative ID of the previous record. So this needs to be resolved. Resolves: #86010 Releases: master Change-Id: I80d722a1603b8fa1d6ccb2fc2bb9c914ee38ee42 Reviewed-on: https://review.typo3.org/58074 Reviewed-by:
-
* Use module template view helpers to render the module layout * Remove obsolete methods and inheritance * Make compare view bookmarkable * Remove obsolete returnUrl view variables * Use xml syntax for Fluid namespace registration Also move all module template related view helpers to backend extension Resolves: #85532 Releases: master Change-Id: I3f8e63f57ac9cc5b8981dba23fe5652ea4adc3f1 Reviewed-on: https://review.typo3.org/51091 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Resolves: #86034 Releases: master Change-Id: I42f09774a08b69dc0cb2b5dc2cff6f25cf89f98d Reviewed-on: https://review.typo3.org/58080 Tested-by:
-
Benni Mack authored
Due to some refactorings while achieving notice-free tests, the check for adding html-tag attributes was changed. Resolves: #86009 Related: #85849 Releases: master Change-Id: Ic64c7e8c709d7a7f4d72aef52a9f84ed30660005 Reviewed-on: https://review.typo3.org/58075 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
Minor issue in exception messages. Resolves: #86033 Releases: master Change-Id: I0e133bb3a609dda611757fb5a92465295b3a377d Reviewed-on: https://review.typo3.org/58079 Reviewed-by:
-
A content element can once again be pasted directly at a specific position with the help of the paste button when in the "languages" mode. Releases: master, 8.7 Resolves: #85911 Change-Id: I08e48361b45c4cffaf83c4b7b92f70303ab8babf Reviewed-on: https://review.typo3.org/57971 Reviewed-by:
-
Slug handling does now work if using pseudo sites. The patch adds a display condition to form engine to hide the field if the edited page is within page tree that resolves to a pseudo site. Additionally, the 'alias' pages db field is a poor-man redirect solution that should be outphased in v9. It is currently not resolved if using configured sites at all. The patch turns the display condition around for that to hide the field if a page that resolves to a proper site object is edited. A change in InputSlugElement that leads to wrongly resolved languages if editing pages is fixed along the way. Resolves: #85955 Releases: master Change-Id: I9cc65331beb5f00edffffbe78ffcc8b50550a645 Reviewed-on: https://review.typo3.org/58013 Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
-
- 29 Aug, 2018 8 commits
-
-
While working with Site Handling API, it's more than obvious that we should utilize the UriInterface, to integrate PSR-7 more natively. The Interface changes, however, as it was only introduced recently, this should not be an issue. Resolves: #86027 Releases: master Change-Id: Id06ccbcf2bbced8408342866d295edc3f11a376a Reviewed-on: https://review.typo3.org/58070 Reviewed-by:
-
Resolves: #86017 Releases: master Change-Id: Ic7315dfa4b287c42c88ff80e4040e1185273bd7c Reviewed-on: https://review.typo3.org/58068 Tested-by:
Tobias Wollender <tliegl@gmail.com> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Andreas Fernandez authored
Resolves: #86030 Related: #86013 Releases: master Change-Id: I337861f5dac4e3c7e7babd056e87630c22ec1f3e Reviewed-on: https://review.typo3.org/58073 Tested-by:
-
Resolves: #86029 Releases: master, 8.7 Change-Id: I75c5bf23537a987fbe16c9a6fb2464a853d12135 Reviewed-on: https://review.typo3.org/58071 Reviewed-by:
-
Resolves: #86019 Releases: master Change-Id: Ia9951730c1d1eb8b1238b92907bfa243b9518c7d Reviewed-on: https://review.typo3.org/58066 Tested-by:
-
Currently, the site resolver checks for a valid site, and if so, checks for valid page slugs. The latter is now moved to the "PageResolver" middleware where the actual root line within TSFE is resolved, and is now decoupled. On top, a new "RouteResult" Array Access object is added which is attached to the PSR-7 request as attribute "routing", which will later be used for extensions to add their own custom mappings. The RouteResult object is now returned from the SiteMatcher and PageRouter in order to encapsulate symfony/routing API even more and to work with objects instead of array with magic properties like "next" - which was actually renamed to "tail". Fixes with this change: - Proper and defined 307 redirect from a site (like www.domain.com) to the default language (www.domain.com/en/) - Proper and defined 307 redirect when a site/language is defined without a trailing slash but accessed with a trailing slash and vice versa - Proper and defined 307 redirect when a page slug is defined without a trailing slash but accessed with a trailing slash and vice versa Tests for SiteResolving have been streamlined and tests for PageResolver have been added. Please note: The hook for checkAlternativeIdMethods() is now only called for Frontend Requests without site handling. Resolves: #86013 Releases: master Change-Id: I9309d4092d007d555b37d575539ecf42303628de Reviewed-on: https://review.typo3.org/58062 Tested-by:
-
GraphicalMenuContentObject (GMENU/GMENUITEM) and ImageMenuContentObject (IMGMENU/IMGMENUITEM) will be removed in TYPO3 v10.0, and are marked as deprecated. A lot of functionality related to HMENU in general, previously exposed to the public, has been migrated to be internal, now throwing deprecation messages as well when accessed from the public. In addition the following TypoScript properties will be removed in TYPO3 v10.0. TMENU - imgNamePrefix - imgNameNotRandom TMENU Item properties - RO_chBgColor - beforeImg - beforeImgTagParams - beforeImgLink - beforeROImg - RO - afterImg - afterImgTagParams - afterImgLink - afterROImg Removed item states - IFSUBRO - ACTRO - ACTIFSUBRO - CURRO - CURIFSUBRO - USRRO - USERDEF1RO - USERDEF2RO Also deprecated: TSFE->setJS('mouseOver'); Also not needed in TYPO3 v10.0 anymore: Folder typo3temp/assets/menu/ Resolves: #85902 Releases: master Change-Id: I1b5920e4727e97415e6527f5810c9b103c2c6fed Reviewed-on: https://review.typo3.org/57435 Tested-by: -
PharStreamWrapper has been released as standalone package under the MIT license: https://github.com/TYPO3/phar-stream-wrapper Stream invocation is handled by the new composer package, previous classes PharStreamWrapper and PharStreamWrapperException have been removed from the TYPO3 core but are still kept in class alias maps for compatibility reasons. Since the standalone package is now independent from TYPO3 constraints, the TYPO3 specific logic to intercept Phar invocations has been moved to the new class PharStreamWrapperInterceptor. Resolves: #85984 Releases: master Change-Id: I66692c3e75cfd174125e1923a2a9cb7fbbd78217 Reviewed-on: https://review.typo3.org/58042 Tested-by:
-
- 28 Aug, 2018 6 commits
-
-
ContentObjectRenderer has some minor flaws. Also the functional tests have some unused code. Resolves: #86015 Releases: master Change-Id: I9ed00b32f4c00de7b667ad72052a0b7032901313 Reviewed-on: https://review.typo3.org/58065 Tested-by:
-
The Extbase command controller from Extension Manager is the only CommandController used in TYPO3 Core (apart from extbase:help), all others have been migrated to symfony/console commands. This however is now only possible due to the recent migration to define these commands as "non-schedulable" so they do not show up in the scheduler as a possible command to be called repeatedly. For the "extensionmanager:extension:dumpclassloadinginformation" call, the functionality is moved to EXT:core as this is not related to any functionality in ExtensionManager, as it does not need any information of this. This command has been made available under "dumpautoload" to get closer on the naming scheme of native composer. "install" and "uninstall" however rely on the DI concept of Extbase and Extensionmanager to inject necessary components and is tightly intertwined. These are now provided as "extension:activate" and "extension:deactivate" respectively to convey their purpose and especially show that the latter does not remove any data or code. Releases: master Resolves: #85996 Change-Id: I8025d8ba8f577c46815996bd3c7d13d17dec268a Reviewed-on: https://review.typo3.org/58055 Tested-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Site Languages which are not shown in the frontend should be displayed in the Backend module however this is a bug that Fluid accesses only enabled languages, but needs to use "getAllLanguages()" instead. Resolves: #86011 Releases: master Change-Id: I24880604675b7d0bb5ced8169a2e3f461afa8dfb Reviewed-on: https://review.typo3.org/58061 Tested-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Both methods within "ContentObjectRenderer->editPanel()" and "ContentObjectRenderer->editIcons()" were built to have "FrontendEditingController" resolve the editing panel (EXT:feedit) which is not needed, so ContentObjectRenderer is calling the extensions itself. For that use, the FrontendBackendUserAuthentication gains functionality for checking if a record can be edited. Resolves: #85972 Releases: master Change-Id: Ic8405fde4cdf5b6d1336fd0925cd0553bae6cf5f Reviewed-on: https://review.typo3.org/58030 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Instantiating TypoScriptFrontendController with the fourth parameter set (except null) will now trigger a deprecation message, as it is recommended to use the method `set_no_cache` instead. Resolves: #86002 Releases: master Change-Id: I6d8bbdd79d6b6169d358b5d17b036006d3c3205e Reviewed-on: https://review.typo3.org/58034 Tested-by:
-
Benni Mack authored
The previously available scheduler tasks for auto-publishing and cleaning up preview links have been moved to a symfony/command, allowing them to be scheduled, but also triggered manually on the command line without having to create a task record in scheduler. The old tasks have been deprecated, as there is the possibility to create tasks out of symfony commands as well. The AutoPublishService, which only acted as a wrapper, but had a major design flaw has been deprecated as well. The scheduler tasks will be removed in TYPO3 v10. For TYPO3 v9, their labels have been updated, and they will trigger a deprecation notice. Resolves: #86001 Releases: master Change-Id: I9c1f1e31b6ff59d02b20ffc2df805e645bb3f675 Reviewed-on: https://review.typo3.org/58056 Tested-by:
-
- 27 Aug, 2018 5 commits
-
-
Tymoteusz Motylewski authored
The last place which was missed when porting the extension to namespaces, is now fixed. Also slash sign has to be escaped in SQL. Resolves: #85999 Releases: master, 8.7 Change-Id: I844b59b209ef1434298575b57fc7dc861ecab643 Reviewed-on: https://review.typo3.org/58052 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
The patch fixes a fatal php scenario if a page is created on root level. The data handler now flushes site caches if that happens and unsets the SiteMatcher singleton so it is forced to be recalculated if re-used in current request. Change-Id: Ie54f70b1bbfaaf1f6302f4e6b14abcf6af4c310f Resolves: #85985 Releases: master Reviewed-on: https://review.typo3.org/58017 Tested-by:
-
Remove toggle function from root node and set expanded on true if there is only one node on depth 0. If there is more then 1 (e.g. when using DB Mounts) then keep toggle option. Releases: master Resolves: #85809 Change-Id: I94f9e20d048760e3a35ba1e8ed170521406a92d3 Reviewed-on: https://review.typo3.org/57911 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
A series of unused and dead code places are fixed with the patch: * Switch + return + break -> the break is obsolete * A couple of 'too many arguments' when calling methods * Various assignments of variables that are never used Change-Id: I8472597f73a739bce053cf6de772c111ae7044d7 Resolves: #85993 Releases: master Reviewed-on: https://review.typo3.org/58047 Reviewed-by:
-
When registering a Symfony Command, it is now possible to define a new option `schedulable` which can explicitly set to false, in order to have e.g. EXT:scheduler not show some. This implements the functionality previously only available for Extbase's CommandControllers. Resolves: #85991 Releases: master Change-Id: Ie2d8d3cc71d04263984a928debd257ecb88184e8 Reviewed-on: https://review.typo3.org/58046 Reviewed-by:
-
