- 04 Jun, 2020 2 commits
-
-
This fixes encoding issues in paths with URL-encoded spaces and other characters when indexed_search translates indexable file URLs into local paths. Resolves: #91586 Releases: master, 10.4, 9.5 Change-Id: Id20034137556f5705ee34b3adcca6250c77d83f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64792 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Common URLs like typo3.org, tools.ietf.org or php.net are nowadays available as HTTPS, however some places in TYPO3 still use http:// as reference. This should be streamlined to resemble https:// everywhere. Resolves: #91581 Releases: master, 10.4 Change-Id: I76b5211f7e14cab0c6d190059d2be761bc664b53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64752 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 12 May, 2020 1 commit
-
-
HTML entities being used in link tags created with `typolink` have to be encoded correctly again after entities have been decoded for internal processing. Resolves: #91161 Releases: master, 9.5 Change-Id: Ifc4d2da669aab01f2b3041bb32c0a24a727634b4 Security-Bulletin: TYPO3-CORE-SA-2020-003 Security-References: CVE-2020-11065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64467 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 27 Apr, 2020 1 commit
-
-
Replace the usage of `GeneralUtility::milliseconds` in Indexer class which has been deprecated with 91001. Resolves: #91192 Releases: master Change-Id: I2057ecec038195d67acab10946d4542b1fba9646 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64316 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 17 Apr, 2020 1 commit
-
-
This patch has been created with rector and php-cs-fixer Releases: master Resolves: #91092 Change-Id: I80956bc210237169034acd86ef26c1e8f9725ddb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64212 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 12 Apr, 2020 1 commit
-
-
Some methods in GeneralUtility nowadays are wrappers to native PHP methods. We encourage people to use the PHP API directly. * GeneralUtility::IPv6Hex2Bin() * GeneralUtility::IPv6Bin2Hex() * GeneralUtility::compressIPv6() * GeneralUtility::milliseconds() In addition, these methods are unused by Core * GeneralUtility::linkThisUrl() * GeneralUtility::flushDirectory() Reasoning: In order to make our code less coupled, TYPO3 Core should use native PHP where it makes sense, instead of relying on GeneralUtility in all places. Resolves: #91001 Releases: master Change-Id: I9e3a2f4a4bb42facad2d79f959b36482dba23ec8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64091 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 06 Apr, 2020 1 commit
-
-
In times of PSR-7, TYPO3's RequestFactory API and the underlying Guzzle HTTP library, the wrapper method GeneralUtility::getUrl() is merely a lazy short-hand method for fetching the contents. It is recommended to use TYPO3's RequestFactory API for fetching remote URLs. For now, however, the additional arguments (sending alternative headers, only fetching HEAD requests and return headers or headers + content, fetching a report of what happened) are deprecated, as they have proven to be inflexible nowadays. Resolves: #90956 Releases: master Change-Id: Ic7631ccf61000d0853007cf9278db6e1bab09335 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64012 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 03 Apr, 2020 1 commit
-
-
Benni Mack authored
This is a pre-patch to separate crawler-specific implementation from the actual indexing configuration. This first patch unifies the configuration creation for the indexer, and places the configuration in each respective logic (see TSFE hook), where as the Indexer does not know about TSFE or "called from Backend" anymore, making the indexer just doing its work. The next iteration will then separate all indexing logic into smaller chunks again. Resolves: #90920 Releases: master Change-Id: I631ddd0839ee8f03d0a6c3c86d302b935e599a5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64039 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 27 Mar, 2020 1 commit
-
-
Releases: master Resolves: #90802 Change-Id: I84da713c7b8c68ae67b6b9c33ad66dcbac8d72bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63810 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 08 Mar, 2020 1 commit
-
-
Releases: master Resolves: #90668 Change-Id: I92cc4942f9f06d587a7957a94f006d157143e55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63569 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 06 Mar, 2020 1 commit
-
-
phpstan identified a bunch of possibly undefined variables which is fixed with this patch. Releases: master Resolves: #90581 Change-Id: If41bee3dcd972d26f8eff18dbcbc61ad1fe79e7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63483 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 27 Feb, 2020 1 commit
-
-
When 'Index Records immediately when saved?' is enabled in indexing configurations for records, then on saving the record the string 'null' is used for this indexingconfiguration and passed to SearchController::preparePageLink(), which expects an array and therefore throws an exception. This commit fixes this by checking if $this->conf['staticPageArguments'] is an array and only then json_decode that, else it sets the value to null. Resolves: #89816 Related: #86994 Releases: master, 9.5 Change-Id: I96d3fb963ecb508bc536967afece064ad12bb989 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63414 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 15 Feb, 2020 1 commit
-
-
This patch only pleases phpstan. The refactoring of the indexer which includes the removal of the direct dependency to 3rd-party classes is taken care of in the following issue. https://forge.typo3.org/issues/83603 Releases: master Resolves: #90384 Change-Id: Ia1ee984f692dce7f8293077cbea3359d6843cb46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63261 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 14 Jan, 2020 1 commit
-
-
If either the options `minAge` or `maxAge` are an empty string, the corresponding multiplication will fail and a PHP warning is triggered. As a quick win, the values are casted to integers. Resolves: #90087 Releases: master, 9.5, 8.7 Change-Id: Ia6861434231e7e338384c3e919a09466b39d425f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62846 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 30 Dec, 2019 1 commit
-
-
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 18 Dec, 2019 2 commits
-
-
The usage of implode(array, string) has been marked as deprecated by PHP and triggers PHP Deprecation warnings by using PHP 7.4. Resolves: #89987 Releases: master, 9.5 Change-Id: I4094744bd067203856dc305bb7e1651797d0c959 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62741 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Markus Klösges <mkloesges@gmx.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
php bin/rector process Releases: master Resolves: #89807 Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 07 Oct, 2019 1 commit
-
-
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 23 Aug, 2019 1 commit
-
-
This patch replaces all usages of `strstr()` and its friends where the existence of a certain substring is checked, but the result isn't used at all with `strpos()`, which uses less memory. Resolves: #88922 Releases: master Change-Id: Ie45589ac9410e22e1b48e82dd8086eadb6d74107 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61445 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org>
-
- 13 Jul, 2019 1 commit
-
-
cHash is now added automatically when a URL is generated. The relevant query parameters when indexing are stored in "static_page_arguments", which allows to remove the database field "cHashParams". Therefor it is not necessary anymore to configure if cHash should be taken into account when creating a configuration for indexed search. Instead, when linking to a page on a search result, the page arguments are added. In addition, when pages are indexed, only the static page arguments are evaluated. Debug Information when indexing is also adding data more sensibly via json_encode/decode. Effectively, this means that specific handling for cHash resolving is fully removed from EXT:indexed_search. Related: #87193 Resolves: #88741 Releases: master Change-Id: I84738612d42615a3ac24d271c5509b52467d81af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61284 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 11 Jul, 2019 1 commit
-
-
Benni Mack authored
The global state array "T3_VAR" for keeping some legacy functionality has been removed. It is not in used by TYPO3 Core anymore, the last occurrence for "injecting" some data into Indexed Search indexing has been removed, as SingletonInterface, hooks and the possibility to provide ones' own indexer for custom download extensions should be used instead. Resolves: #88660 Releases: master Change-Id: I5a587271983c6bb4ae6709c0140e818c4c1eb572 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61197 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 01 Mar, 2019 1 commit
-
-
Because of pages using route enhancers do not use cHash in most cases, it is necessary to add the static arguments of the page to generate the phash values used by indexed_search. For administration of the indexed pages, the static arguments of the page are stored in the index_phash table as well, which makes enhancing inevitable. Resolves: #86994 Releases: master, 9.5 Change-Id: I2e0f09a782481b024ef3fdb6efd81c22fb2fddc3 Reviewed-on: https://review.typo3.org/c/58983 Tested-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Hendrik Helmken <h.helmken@atlantismedia.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Alexander Grein <alexander.grein@gmail.com> Reviewed-by:
Hendrik Helmken <h.helmken@atlantismedia.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 30 Dec, 2018 1 commit
-
-
Resolves: #87308 Releases: master Change-Id: I02a1d3ef914a9618a91f70a6c3a53d5e3bfe9f79 Reviewed-on: https://review.typo3.org/59307 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 20 Dec, 2018 1 commit
-
-
The following code related to TSFE has been removed: PHP classes: * TYPO3\CMS\Core\PageTitle\AltPageTitleProvider * TYPO3\CMS\Frontend\Page\ExternalPageUrlHandler * TYPO3\CMS\Frontend\Page\PageGenerator * TYPO3\CMS\Frontend\Page\EidUtility PHP interfaces: * TYPO3\CMS\Frontend\Http\UrlHandlerInterface Methods that have been marked as protected * tempPageCacheContent() * realPageCacheContent() * setPageCacheContent() * clearPageCacheContent_pidList() * setSysLastChanged() * contentStrReplace() Dropped TSFE methods * mergingWithGetVars() * connectToDB() * initFEuser() * checkAlternativeIdMethods() * initializeBackendUser() * getPageShortcut() * pageUnavailableAndExit() * pageNotFoundAndExit() * checkPageUnavailableHandler() * pageUnavailableHandler() * pageNotFoundHandler() * pageErrorHandler() * makeCacheHash() * initTemplate() * handleDataSubmission() * initializeRedirectUrlHandlers() * redirectToExternalUrl() * checkPageForMountpointRedirect() * checkPageForShortcutRedirect() * redirectToCurrentPage() * processOutput() * sendCacheHeaders() * sendHttpHeadersDirectly() * storeSessionData() * previewInfo() * hook_eofe() * addTempContentHttpHeaders() * setCSS() * getUniqueId() * readLLfile() * getLLL() * initLLvars() * convPOSTCharset() * convertCharsetRecursivelyToUtf8() * domainNameMatchesCurrentRequest() * getDomainDataForPid() * getDomainNameForPid() Dropped TSFE properties * activeUrlHandlers * page_cache_reg1 * siteScript * loginUser * gr_list * beUserLogin * workspacePreview * ADMCMD_preview_BEUSER_uid * showHiddenPage * showHiddenRecords * debug * MP_defaults * sys_language_uid * sys_language_mode * sys_language_content * sys_language_contentOL * altPageTitle * lang TSFE Properties now marked as protected * loginAllowedInBranch * loginAllowedInBranch_mode * cacheTimeOutDefault * cacheContentFlag * cacheExpires * isClientCachable * no_cacheBeforePageGen * tempContent * pagesTSconfig * pageCacheTags * uniqueCounter * uniqueString * pageAccessFailureHistory TSFE Method Signature changes * calculateLinkVars now 1st parameter is required * preparePageContentGeneration now 1st parameter is required 4th Parameter of TSFE->__construct() now unused Removed TypoScript * config.typolinkCheckRootline * config.titleTagFunction * config.USERUID_substToken * config.USERNAME_substToken Hooks $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-PostProc'] Database fields: * index_phash.data_page_reg1 Resolves: #87235 Releases: master Change-Id: Id95bb0ccb30852fd115fb9da7754fa2e64374a41 Reviewed-on: https://review.typo3.org/59226 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 05 Nov, 2018 1 commit
-
-
Adds a new method HttpUtility::buildQueryString() using http_build_query() instead of reimplementing the encoding-process like the old method GeneralUtility::implodeArrayForUrl() did. As the parameter $rawurlencodeParamName of implodeArrayForUrl() was set to "false" by default and used in several places without manually setting it to "true" using that method could lead to potentially unsafe non-encoded parameter names. Some unit-tests had wrong URLs with non-encoded braces [...], which were adapted to be properly escaped as well. Resolves: #83334 Releases: master Change-Id: Ifbaad912f0d658671356dc7bdf1579dacff272df Reviewed-on: https://review.typo3.org/55079 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 30 Sep, 2018 1 commit
-
-
This patch streamlines all deprecation messages and follow the following rules. 1. All @deprecated should contain @deprecated since TYPO3 xx, will be removed in TYPO3 v10.0 (not "core v10" or just "v10" 2. trigger_error() - All trigger_error() messages MUST end with a "." (dot). - Never use "This method" but the method name (enjoy the logs otherwise) - "has been deprecated" can be spared - we KNOW it's deprecated once its in the deprecation log. Instead "Will be removed in TYPO3 v10.0" SHOULD be in the log file. - Do not use "__METHOD__" or some other "magic". Resolves: #86488 Releases: master Change-Id: I6a34593ff89ecafe649366d60d725daa3aa6676c Reviewed-on: https://review.typo3.org/58494 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com>
-
- 29 Sep, 2018 2 commits
-
-
The phpDoc comment "@internal" is used in most places during the development of TYPO3 v7, TYPO3 v8 and TYPO3 v9 and denotes that this specific method, class or property is not part of the Public API, and does not even need any notice if it is removed. However, we still have/had various places in TYPO3 core where "@access private" was used. This is now migrated to "@internal". "@access public" is not needed and is removed. Resolves: #86446 Releases: master Change-Id: Iaef206b04aee13c280d62b107dd7eac04a38c700 Reviewed-on: https://review.typo3.org/58462 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
As the core uses American English, 'analyze' should be spelled with a `z`. This looked especially strange in the install tool, where both spellings were mixed on one card. Resolves: #86447 Releases: master Change-Id: I484f75a05d3cf988baaebf91df30cd936f454eac Reviewed-on: https://review.typo3.org/58454 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
- 02 Sep, 2018 2 commits
-
-
Resolves: #86084 Releases: master Change-Id: I6ebbe0756d799a3c04386c854f6e5e385eeac54f Reviewed-on: https://review.typo3.org/58124 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
strpos will use only CPU resources, substr also needs memory allocation. Resolves: #85477 Releases: master Change-Id: Ic25c99986f7e2e7237c10acaa75be8d0f6289f13 Reviewed-on: https://review.typo3.org/57466 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 14 Aug, 2018 1 commit
-
-
Resolves: #85845 Releases: master Change-Id: Id72acfdf7c880f1d0b63a62b912301c724ed500d Reviewed-on: https://review.typo3.org/57895 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
-
- 13 Jul, 2018 1 commit
-
-
This change adds a new Aspect called "Language" which bundles most existing TypoScript options on frontend language fetching. A factory allows to migrate the logic from TSFE. Major / Important Changes: - RootlineUtility is decoupled from PageRepository - TSFE->sys_language_mode is not necessary anymore - TSFE->sys_language_contentOL can be substituted by "overlayType" of Aspect - A new PageRepository->getLanguageOverlay() bundles all other methods - A lot of common public properties in TSFE are now deprecated Next steps: - Isolate calls from RootlineUtility/PageRepository more from each other and from TSFE - Migrate PageRepository "-1" parameters to "null" - Migrate usages PageRepository->getRootline() to RootlineUtility::__construct() - Then deprecate PageRepository->getRootLine() - Migrate Extbase QuerySettings to Contexts Resolves: #85543 Releases: master Change-Id: I8d177222a244a8d1fd66a884e9fc50b107f27e20 Reviewed-on: https://review.typo3.org/57424 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 27 Jun, 2018 1 commit
-
-
A new "Context" concept is added which allows to keep the state of common TYPO3 Request Data in form of so-called Aspects. An aspect contains properties which can be fetched, but only the ones that are really necessary, instead of exposing a full object (e.g. BE_USER). The main goal is to centralize some global variables distributed in various places. In the first step the following variables are considered: - $TSFE->showHiddenPages - $TSFE->showHiddenRecords - $TSFE->beUserLogin - $TSFE->gr_list - $TSFE->loginUser - $GLOBALS[SIM_EXEC_TIME] - $GLOBALS['BE_USER']->workspace For now the Context is a singleton object, but should be fetched from a DI container. Sometimes a custom context is necessary, so it is cloned (see usage in TSFE). The difference to the PSR-7 request attributes is that the context is ONLY related to data access (like permissions / visibility) and also independent if TYPO3 is running via HTTP or CLI (thus, can be used in CLI mode as well). Next Steps: - Migrate PageRepository->versioningWorkspaceId - Migrate TSFE->simUserGroup - Use DateTimeAspect everywhere - Introduce Language + Page Aspects - Introduce the context object into ContentObjectRenderer and cObjects - Use Contexts in RestrictionContainers - Use Contexts in TYPO3 Backend - Decouple sys_page behaviour from TSFE where applicable - Ensure TypoScript conditions continue to work / have a documented alternative Resolves: #85389 Releases: master Change-Id: I9e27e581a1632fcd8c3c6a9e0954b76b91f42c52 Reviewed-on: https://review.typo3.org/57104 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Stefan Bürk <stefan.buerk@pure-metal.de> Tested-by:
Stefan Bürk <stefan.buerk@pure-metal.de> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 15 Jun, 2018 1 commit
-
-
Resolves: #85273 Releases: master Change-Id: If2a643843532d14f2b7263c66b22ad1bc0402c33 Reviewed-on: https://review.typo3.org/57231 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Jan Helke <typo3@helke.de>
-
- 10 Jun, 2018 1 commit
-
-
Static method variables are even more pita than static class variables, especially if their state is created from db rows or path information: It is nearly impossible to get rid of this state at a later point again, even reflection does not help here. The patch abandons all 'static $foo' method variables from the system, using these strategies: * Remove some entirely which were used as first level cache and only cache-away simple non db related code structures. * Switch some to use cache framework cache_runtime instead which can be evicted easily. * Use class properties in some cases instead. Change-Id: Ic699846a2c6ec661ee1124ace50df1aa04a1954b Resolves: #85206 Releases: master Reviewed-on: https://review.typo3.org/57167 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- 30 May, 2018 1 commit
-
-
CharsetConverter is still instantiated in some places and not needed at all times. The following places have CharsetConverter completely removed (as internal property): - PageRenderer - SearchController - Indexer The AbstractHierarchicalFilesystemDriver's shorthand method getCharsetConversion() has been deprecated, as drivers should instantiate the CharsetConversion themself. Indexed Search's Lexer has a public property "csObj" which has been switched to protected, where a deprecation message will be thrown. Resolves: #85125 Releases: master Change-Id: I48fd110ecd25bb6a4225a3d2141edc5fc3b92673 Reviewed-on: https://review.typo3.org/57097 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
- 11 May, 2018 1 commit
-
-
Basename and dirname are locale aware and can damage path and file names if they are used with UTF-8 file/path names while a UTF-8 locale is not loaded. The PathUtility wrappers solve this. Releases: master Resolves: #74806 Change-Id: Ibe113a1632b4e61ea87ed9a7dc8600bf3535acab Reviewed-on: https://review.typo3.org/47169 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
- 16 Feb, 2018 1 commit
-
-
Christian Kuhn authored
Property page_cache_reg1 is a poor man limited way to manipulate page cache tagging. It has been of very little use and is deprecated now. The usage in indexed_search (which always only added the default "0" to database) is dropped along the way. Change-Id: I9ea129fc6d20adb7a35a719f3d9d630aa663952f Resolves: #83905 Releases: master Reviewed-on: https://review.typo3.org/55723 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-