- 12 May, 2020 1 commit
-
-
Prevent XSS by escaping the shortened placeholder text for various Backend form elements properly. Resolves: #90817 Releases: master, 9.5 Change-Id: I58f61b2d3d902dd3cb07e97acf974156f100a8aa Security-Bulletin: TYPO3-CORE-SA-2020-002 Security-References: CVE-2020-11064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64471 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 26 Mar, 2020 1 commit
-
-
This patch fix missing space before calling GeneralUtility::implodeAttributes. Without space, the rendered HTML is not valid. Resolves: #90835 Releases: master, 9.5 Change-Id: Iccd9f0bbeb4d6e12f3bca882f7bba2dc69577bb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63926 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
- 18 Mar, 2020 1 commit
-
-
With #86629 the link type "telephone" has been added but it was forgotten to add support for it in the InputLinkElement. Add the support and show a nice icon next to the number. Resolves: #90771 Releases: master Change-Id: Ib2ea37ab07b0ae2fa9a429dc683c6021a8691aae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63760 Reviewed-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- 06 Mar, 2020 1 commit
-
-
Urls starting with `//` should have a proper fallback to avoid warnings e.g. in InputLinkElement that this type of url is unknown. Resolves: #90171 Releases: master, 9.5 Change-Id: Ic3910f98c3993fb5db523ba1b360eabb49bf0696 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63543 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- 30 Dec, 2019 1 commit
-
-
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- 09 Nov, 2019 1 commit
-
-
Dynamically fetching/applying additional data for the link explanation seems to be overdone, so we simply deactivate the toggle button and remove the icon after selection/modification of the link target. After persisting the record, the updated link explanation will be visible. Resolves: #88737 Releases: master, 9.5 Change-Id: I679abb2178aedfc8a29cccace99950a3a8acaab6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61422 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 07 Oct, 2019 1 commit
-
-
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- 14 Mar, 2019 1 commit
-
-
This patch splits the FormEngine.js into smaller, logically separated parts. This increases readability and maintainability and has a positive effect on the client's performance as only the required code is loaded. Not every aspect of the FormEngine JavaScript is handled here yet, since other areas, e.g. IRRE, need refactoring as well. Resolves: #87324 Releases: master Change-Id: I6704445254a524f8ed3152ab6b0b7105fb97d65a Reviewed-on: https://review.typo3.org/c/58608 Tested-by:
André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by:
-
- 27 Aug, 2018 1 commit
-
-
A series of unused and dead code places are fixed with the patch: * Switch + return + break -> the break is obsolete * A couple of 'too many arguments' when calling methods * Various assignments of variables that are never used Change-Id: I8472597f73a739bce053cf6de772c111ae7044d7 Resolves: #85993 Releases: master Reviewed-on: https://review.typo3.org/58047 Reviewed-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 11 Aug, 2018 1 commit
-
-
Reduce the HTML of a record form by rendering divs of wizards only if those are required. Resolves: #85577 Releases: master Change-Id: I6ca6ad5c3ebd1a1aa949a9a0349bd7894e4532df Reviewed-on: https://review.typo3.org/57614 Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 18 Jul, 2018 1 commit
-
-
When the site configuration module has been introduced, it came with a custom functionality to show an additional help text when editing site records between the field label and the field input. This useful feature is now changed into a general TCA feature available everywhere: A new field information node expansion / "wizard" is added to all form elements, the inline and flex containers: If the property "description" is set for a TCA column type (same array level as "label", it will show the value as localized string between the field label and the input section. There are three available render types for "wizard a-like" output: * Field information - text between label+field * Field control - buttons next to input sections like the link popup button * Field wizards - clickable stuff below the input section, for example the localization state selector If a field has been set to readOnly=true in TCA, field control and field wizards do not make sense to render since they are meant to act with the field value. The field information node however has only informational character which is useful for readOnly fields, too. Thus, this node expansion type is now the only one that is always rendered, even if a field has been set to readOnly. Note this patch is fully covered by ext:styleguide (master) to have examples for all changed elements now using the description property. Resolves: #85410 Releases: master Change-Id: Idcfacafa19b8208614b653b8fac22ce47bca3b8f Reviewed-on: https://review.typo3.org/57397 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
- 17 May, 2018 1 commit
-
-
When useOrOverridePlaceholder mode is used for TCA input type, use opt-in for the checkbox when placeholder is empty. In some cases, the placeholder can be empty. Especially when the placeholder uses data from another field. When information is added to the corresponding field, the input field does not take this in account because the override checkbox is set by default. This can lead to problems for title and alternative fields in the sys_file_metadata table. When adding a file reference and setting the title or alternative field afterwards in the original file, the reference is still using the empty override from file reference. Resolves: #84563 Releases: master, 8.7 Change-Id: I84a37d55a48464b6249fc8bcee405a7cd909016a Reviewed-on: https://review.typo3.org/56486 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- 25 Apr, 2018 1 commit
-
-
This commit moves any language file of EXT:lang into a proper destination, which renders EXT:lang obsolete. This change requires an update of typo3/testing-framework, done with this command: composer update typo3/testing-framework Resolves: #84680 Releases: master Change-Id: I7ba59c1a10015121ed444a9c98082bad0348e03d Reviewed-on: https://review.typo3.org/56017 Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
- 18 Feb, 2018 1 commit
-
-
If the linked record wasn't found (wrong uid, removed from database) we check before trying to gather an icon for the non-existing record. Resolves: #81804 Releases: master, 8.7 Change-Id: Ie06ec8a614650d8147f143cda8d8e6a9cb3e98e9 Reviewed-on: https://review.typo3.org/55751 Reviewed-by:
-
- 27 Dec, 2017 1 commit
-
-
Catch invalid links in FE & BE to keep a working website. Resolves: #83283 Releases: master, 8.7 Change-Id: Id9e42dc9be896f3777210843c651f9726dc94552 Reviewed-on: https://review.typo3.org/55024 Reviewed-by:
-
- 22 Nov, 2017 1 commit
-
-
Add for/id so clicking the label toggles the checkbox. Resolves: #83040 Releases: master, 8.7, 7.6 Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326 Reviewed-on: https://review.typo3.org/54715 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- 30 Oct, 2017 1 commit
-
-
Catch another exception to avoid a breaking backend. Resolves: #82850 Releases: master, 8.7 Change-Id: I349aae21932beb5d45c1cec1b1211d3400d1d969 Reviewed-on: https://review.typo3.org/54469 Reviewed-by:
-
- 12 May, 2017 1 commit
-
-
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- 20 Apr, 2017 1 commit
-
-
Christian Kuhn authored
Resolves: #80913 Releases: master Change-Id: I151fbf7a02df3e4713d623eb1659ac35ae2cb35a Reviewed-on: https://review.typo3.org/52490 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
- 02 Apr, 2017 1 commit
-
-
This patch extracts TypoLink generation into separate classes based on the link type calculated via the LinkService functionality. Via the configuration $TYPO3_CONF_VARS[FE][typolinkBuilder][$linkType] new types can be added or existing implementations can be overriden. Resolves: #80619 Releases: master Change-Id: Id1dc028cb306ac50352302b8a5c9725ab7f04b31 Reviewed-on: https://review.typo3.org/52264 Tested-by:
-
- 30 Mar, 2017 1 commit
-
-
Resolves: #79670 Release: master Change-Id: I63e0edc5785b1bb81fcaeb9009b0844056c922f0 Reviewed-on: https://review.typo3.org/52144 Reviewed-by:
-
- 10 Mar, 2017 1 commit
-
-
Christian Kuhn authored
Change-Id: If3eb8c6d2b0fef265b3030fc1c2ed7ec8958564f Resolves: #80233 Releases: master Reviewed-on: https://review.typo3.org/52000 Tested-by:
-
- 04 Mar, 2017 1 commit
-
-
Georg Ringer authored
If a file is linked which does not exist anymore, the UI must not break. Resolves: #80086 Releases: master Change-Id: If95af9bf4b1e6e723e26e412ce7a29d8214fe411 Reviewed-on: https://review.typo3.org/51922 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- 22 Feb, 2017 1 commit
-
-
- Use a div instead of an input field to avoid issues like tooltip not shown because of the disabled attribute. - Trigger onchange from LinkBrowser popup - If no value found, show the input field, which makes it easier to e.g. enter an external url. - Show helpful title for toggle button on hover Resolves: #79667 Related: #79670 Releases: master Change-Id: If00d892d0ae7aebe0dfc5f17f5d43af16d0ee730 Reviewed-on: https://review.typo3.org/51592 Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
- 12 Feb, 2017 1 commit
-
-
The itemValue of a field might be null, which is not accepted by getLinkExplanation(). Add a check to ensure we always pass a string. Resolves: #79749 Releases: master Change-Id: Ic1b80faf1e2cc8c4e4119238225c6480a66c4cdc Reviewed-on: https://review.typo3.org/51628 Reviewed-by:
Dominique Kreemers <dominique.kreemers@icloud.com> Tested-by:
-
- 11 Feb, 2017 1 commit
-
-
Resolves: #79729 Releases: master Change-Id: I689e8ecd0ffa2d005931e6162fb8df5d9694da3d Reviewed-on: https://review.typo3.org/51629 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
- 07 Feb, 2017 2 commits
-
-
Enable linking to any record by migrating the code of EXT:linkhandler into the core. Resolves: #66373 Resolves: #66374 Releases: master Change-Id: I749103e201d387ae826575c6acb3cdcdf639e966 Reviewed-on: https://review.typo3.org/51526 Reviewed-by:
-
This feature introduces a new functionality called "allowLanguageSynchronization" which can be set on a field configuration of a TCA column. This is the successor of "l10n_mode=mergeIfNotBlank" as the old option had several conceptual downsides: 1) "mergeIfNotBlank" took the value of the default record during runtime, but only if the translation field was empty. This means it was not possible to see what the record actually contained without having all fields of the parent at hand. 2) It was not possible to have a value "santa" in the original record but remove the option in a translation (because an empty string "" implicitly triggered the runtime call in the frontend) 3) "mergeIfNotBlank" did not work on relations except for files fetched via the FileRepository API calls, but for no other inline elements. 4) "mergeIfNotBlank" did the overlay functionality in the frontend, but only FormEngine and DataHandler took care of the option. Custom backend modules had to implement the same functionality. 5) In FormEngine, there was an icon in the translation record that if the record kept empty the value of the original language was taken, but this is not optimal in terms of usability. 6) "mergeIfNotBlank" did not take the new l10n_source option into account, where localizations could be made from other records than the default language "0". The new feature can be set on any TCA column setting: $GLOBALS['TCA'][<table-name>]['columns'] [<field-name>]['config']['behaviour'] ['allowLanguageSynchronization'] = true; This brings an option to records with translations (both from l10n_parent and l10n_source) to have the value for all translations synchronized or explictly have a checkbox to use a custom value. The information whether a field is custom filled, or kept in sync from l10n_parent/l10n_source is stored in a separate field called "l10n_state" inside the database. The introduced upgrade wizard and TCA migration to remove "l10n_mode=mergeIfNotBlank" has been modified to migrate to this option and add a l10n_state database field if a TCA table used "mergeIfNotBlank" but did not add the l10n_state field manually via ext_tables.sql yet. New extensions can easily use the new option right away, extensions that need to stay compatible with v7 and v8 can add both options right away to have the same output. The main goals to achieve with this change is now: * Have consistent database values for all records regardless of l10n_mode=mergeIfNotBlank paving the way to fetch translated records without having to overlay (once l10n_mode=exclude is also copying values and relations) * Be more explicit for editors about records that have a different or the same state as their l10n_parent/l10n_source as a benefit for bigger instances with a lot of languages * Avoid hidden magic when retrieving localized records in the TYPO3 Frontend. Resolves: #79658 Related: #79243 Releases: master Change-Id: I6c2dbfeb09b47f958a536c9ab050c24ba4bbcbbd Reviewed-on: https://review.typo3.org/51291 Tested-by:
-
- 06 Feb, 2017 1 commit
-
-
Render link information below a link field to help editors. Instead of 't3://page?uid=92 _top "a class" "a title"' the user will get relevant information. Resolves: #28171 Releases: master Change-Id: Ic285a10e1de67bf60dd5235885a8d0037792999a Reviewed-on: https://review.typo3.org/51479 Reviewed-by:
-
- 26 Jan, 2017 1 commit
-
-
Christian Kuhn authored
The patch introduces a new API on FormEngine element level that substitutes the old "wizards" / renderWizard() API with a more powerful system. Single wizards are now split into one of three categories: * An informational wizard * A control button / icon * A true wizard with additonal functionality Method renderWizards() is still called in elements for compatibility reasons if people added own scrip/popup/userFunc wizards, but all core wizards are migrated. The patch significantly cleans the HTML of single elements, especially HTML stuff that was added by the SingleFieldContainer is now put down to single elements, while main HTML wraps formerly done by renderWizards() is fetched "up" to single elements. This gives single elements full control about the main HTML it is producing, which is a must have preparation in order to further advance in this area and to switch single elements to fluid rendering in one of the next steps. The patch brings a pretty huge list of TCA changes and simplifications, all TCA changes are supported by TCA migration, so existing extensions should benefit out of the box and just get deprecations logged. Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab Resolves: #79440 Resolves: #70032 Releases: master Reviewed-on: https://review.typo3.org/51151 Tested-by:
-
