1. 26 Mar, 2015 1 commit
  2. 15 Mar, 2015 1 commit
  3. 01 Mar, 2015 1 commit
  4. 28 Feb, 2015 1 commit
    • Christian Kuhn's avatar
      [!!!][TASK] Improve FormEngine and sub classes separation · 212b9dbf
      Christian Kuhn authored and Anja Leichsenring's avatar Anja Leichsenring committed
      This patch improves the separation of FormEngine and its sub
      classes. Currently, all sub classes like single element and wizard
      classes get an instance of the parent object to call various methods
      and properties on them. This is very hard to refactor and the mesh
      of call trees must be simplified to ease further refactoring and
      improve maintainability of code.
      This patch follows a divide & conquer approach:
      * Methods only used by sub elements are moved to AbstractFormElement
      * Properties FormEngine "knows" that are needed by element classes
        are given down in a data array during element instatiation to have
        a clear definition of what element classes know.
      * Methods used by both FormEngine and sub classes that do not need
        an instance of FormEngine are moved to a static helper for now to
        reduce the amount of code in FormEngine and to mark certain areas
        as stateless.
      * Class instances are not created on a global level anymore but
        created only in the scope where they are used
      * Class instances injected by outer code are created internally
        for enabling the using code to be moved around.
      All in all, this patch is mostly a preparation of defining a
      fully separated structure with defined concerns for every sub class.
      Most methods are moved around "as is" without changing functionality.
      The only area that is refactored codewise is renderWizards().
      There is still a nasty circular dependency between FormEngine,
      FlexFormElement and InlineElement. This is not resolved by the patch,
      but the surrounding code is now separated enough that this structure
      could be refactored to a tree. This may follow with other patches.
      This patch evolved on catharsis in branch formengine with 53 single
      patches. Details can be looked up there, all single patches are
      prefixed with [FormEngine].
      Change-Id: I332ad51f5e94c09555480099e3a8a0257bed378f
      Releases: master
      Resolves: #65357
      Resolves: #63848
      Resolves: #63849
      Resolves: #63851
      Resolves: #63853
      Resolves: #63855
      Resolves: #63857
      Resolves: #63867
      Resolves: #63868
      Resolves: #63869
      Resolves: #63870
      Resolves: #63871
      Resolves: #63872
      Resolves: #63873
      Resolves: #63874
      Resolves: #63875
      Resolves: #63877
      Resolves: #63879
      Resolves: #63880
      Resolves: #63884
      Resolves: #63885
      Resolves: #63886
      Resolves: #63887
      Resolves: #63888
      Resolves: #63890
      Resolves: #63892
      Reviewed-on: http://review.typo3.org/37265
      Reviewed-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Tested-by: Anja Leichsenring's avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
      Reviewed-by: Wouter Wolters's avatarWouter Wolters <typo3@wouterwolters.nl>
      Reviewed-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
      Tested-by: Benni Mack's avatarBenjamin Mack <benni@typo3.org>
  5. 10 Feb, 2015 1 commit
  6. 04 Feb, 2015 1 commit
  7. 02 Feb, 2015 1 commit
  8. 31 Jan, 2015 1 commit
  9. 27 Jan, 2015 1 commit
  10. 01 Jan, 2015 1 commit
  11. 14 Dec, 2014 1 commit
  12. 13 Dec, 2014 3 commits
  13. 06 Dec, 2014 1 commit
  14. 04 Dec, 2014 1 commit
    • Benni Mack's avatar
      [DB][FEATURE] Add ISO 639-1 keys to sys_language · f1e399f3
      Benni Mack authored and Georg Ringer's avatar Georg Ringer committed
      The language handling of records in TYPO3
      is solely based on UIDs of the sys_language DB table,
      but no reference to the real language used.
      The ISO 639-1 defines the language identifiers
      (ISO language code) completely (182 entries).
      If the real language key was needed before in
      TYPO3, one could install static_info_tables
      which takes a field ("static_lang_isocode") in the
      various places of the TYPO3 Core and fetches
      the isocode via separate SQL-Queries.
      The change introduces the ISO language
      two-letter-keys natively in the core in order to
      1. use less SQL queries in FE and BE if
      static_info_tables was installed
      2. remove hard coded dependencies of
      3. and always ensure that the core
      includes the ISO code
      Additionally one can now use the
      $TSFE->sys_language_isocode all the time for
      working with the ISO code instead of the
      UID parameter, meaning that isocode can now be
      set with a TypoScript parameter as well.
      A Migration Wizard moves values put in the old
      DB field (which is a UID reference to
      static_languages) to the new DB field "language_isocode".
      The old field is deprecated to use without the
      new properly filled field "language_isocode".
      In TYPO3 CMS 8 the static_lang_isocode field
      will be removed within the CMS core (but could
      still be included in static_info_tables).
      Releases: master
      Resolves: #61542
      Change-Id: Ia017af52af354ac204ffac11635d99df120b029a
      Reviewed-on: http://review.typo3.org/32884
      Reviewed-by: default avatarMarkus Klein <klein.t3@reelworx.at>
      Tested-by: default avatarMarkus Klein <klein.t3@reelworx.at>
      Reviewed-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
      Tested-by: Georg Ringer's avatarGeorg Ringer <georg.ringer@gmail.com>
  15. 29 Nov, 2014 1 commit
  16. 23 Nov, 2014 1 commit
  17. 15 Nov, 2014 2 commits
  18. 13 Nov, 2014 2 commits
  19. 03 Nov, 2014 1 commit
  20. 25 Oct, 2014 1 commit
  21. 15 Oct, 2014 1 commit
  22. 11 Oct, 2014 1 commit
  23. 29 Sep, 2014 1 commit
  24. 14 Sep, 2014 1 commit
  25. 12 Sep, 2014 1 commit
  26. 10 Sep, 2014 1 commit
  27. 07 Sep, 2014 1 commit
  28. 29 Jun, 2014 2 commits
    • Christian Kuhn's avatar
      Revert "[TASK] Rebuild the calcAge functionality" · 63740f31
      Christian Kuhn authored
      This change was considered to need some more work during
      mrge post review:
      * 6.2 version adds not allowed deprecations to a released branch
      * It adds two arbitrary (public) constants CEIL and FLOOR
      * Method names need improvement
      * Violation of single responsibility
      * The static utility class has dependencies
      * The patch adds another "always loaded" file to main bootstrap
      * Undocumented (minor) breaking changes
      * (Minor) code style issues
      Reverted: #20016
      Releases: 6.3, 6.2
      This reverts commit 98c0ff71
      Change-Id: I7b07f2176eae78f6000db685c0f54164d5040202
      Reviewed-on: https://review.typo3.org/31236
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
    • Alexander Opitz's avatar
      [TASK] Rebuild the calcAge functionality · 98c0ff71
      Alexander Opitz authored
      We have two calcAge functions with same functionality and same issues.
      So this is moved to a new DateTimeUtility class and deprecated in the
      the original classes. Also time functions from GeneralUtility are moved
      to the new class.
      Following issues are resolved:
      * Age calculation does not respect leap years.
      * Age calculation may round up so something seams older than it is.
      * Between days and years there are months missing, so we get now 2 months
        instead of 60 days.
      Resolves: #20016
      Releases: 6.3, 6.2
      Change-Id: Ie323f30b1fb97b68f89d43605ccda67f219a965a
      Reviewed-on: https://review.typo3.org/24635
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
  29. 22 Jun, 2014 1 commit
    • Michael Schams's avatar
      [TASK] Re-work/simplify copyright header in PHP files - Part 6 · 526c060f
      Michael Schams authored
      This patch replaces the copyright/license header in PHP files with a
      new, simplified one. The new header does not show the year figure, nor
      an author name, and refers to the LICENSE.txt file for the full
      copyright information. License is: GPL2 or any later version.
      This is a multi-part commit due to the huge number of changed files.
      See issue #59782 for further details.
      Resolves: #59782
      Releases: 6.3, 6.2
      Change-Id: Idcd11219eb132c8690cfde256950980e9423bafd
      Reviewed-on: https://review.typo3.org/31027
      Reviewed-by: Krzysztof Adamczyk
      Tested-by: Krzysztof Adamczyk
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
  30. 31 Mar, 2014 1 commit
  31. 24 Mar, 2014 1 commit
    • Nicole Cordes's avatar
      [TASK] Make show_rechis.php mod.php dispatched · 91187e10
      Nicole Cordes authored
      The patch adds a new module for the record history view. All calls to
      the show_rechis.php script are rewritten to use
      BackendUtility::getModuleUrl() to ensure CSRF protection.
      Resolves: #56632
      Releases: 6.2
      Change-Id: I2466c1b08afdd7d987ef38a29500f02641156c07
      Reviewed-on: https://review.typo3.org/28205
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
  32. 08 Mar, 2014 1 commit
    • Benni Mack's avatar
      [CLEANUP] Cleanup jumpToUrl() and unused JS in Backend · 166331c2
      Benni Mack authored and Anja Leichsenring's avatar Anja Leichsenring committed
      The jumpToUrl() is defined in every
      second module as inline JS. As the
      duplicated code is erroneous and
      can be shimmed completely, the
      function is added to every doc-template
      code by default, but can be overriden and
      removed completely - which is still the case
      in some existing modules.
      Additionally the variable "script_ended"
      is not used at all anymore, and was removed
      as well.
      Releases: 6.2
      Resolves: #56667
      Change-Id: I716611bffce402c5f423c3d64c763d6675a79d14
      Reviewed-on: https://review.typo3.org/28180
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
  33. 05 Mar, 2014 1 commit
  34. 03 Mar, 2014 1 commit
    • Helmut Hummel's avatar
      [TASK] Remove condensed mode leftovers · a36c5550
      Helmut Hummel authored and Wouter Wolters's avatar Wouter Wolters committed
      The condensed mode user setting has been removed
      three years ago with #24585
      Now also remove the leftover parts.
      Keep the language labels to not interfere
      with older versions.
      Resolves: #56479
      Releases: 6.2
      Change-Id: I8cb3ebc5aac162357ce1d343eed1031156ccd749
      Reviewed-on: https://review.typo3.org/27980
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
  35. 07 Feb, 2014 1 commit
    • Michiel Roos's avatar
      [CLEANUP] $LANG->JScharCode() => quoteJSvalue() · 006a2e1f
      Michiel Roos authored
      Replace JscharCode() with GeneralUtility::quoteJSvalue()
      Instead of making JavaScript use a String.fromCharCode, it will now use
      a sanitized quoted string.
      Change-Id: Idf81d5524d4bbb60b515670aa13648aa52064905
      Resolves: #55009
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/27380
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Michiel Roos
      Tested-by: Michiel Roos
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind