- 13 Jun, 2022 2 commits
-
-
Oliver Bartsch authoredTYPO3's Mailer implementation does now dispatch two new PSR-14 events. The `BeforeMailerSentMessageEvent` can be used to manipulate the message and the envelope before being sent. The `AfterMailerSentMessageEvent` can be used to add further processing after the message has been sent. Resolves: #93689 Releases: main Change-Id: I02ec5ad5b7a18f9f6f4f7146b676f7ce773d3b29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74825 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: 
André Buchmann <andy.schliesser@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> -
The package guzzlehttp/guzzle has been updated to version 7.4.4 and 6.5.7 which both fix the security issues [1] and [2]. Since TYPO3 is not affected by the issues by default, this is handled as a public bugfix. 3rd party extensions may however be affected by the vulnerabilities if `Authorization` or `Cookie` headers are used. Executed commands: composer require \ guzzlehttp/guzzle:^7.4.4 \ -W composer require \ -d typo3/sysext/core \ guzzlehttp/guzzle:^7.4.4 \ --no-update [1] https://github.com/guzzle/guzzle/security/advisories/GHSA-w248-ffj2-4v5q [2] https://github.com/guzzle/guzzle/security/advisories/GHSA-f2wf-25xc-69c9 Resolves: #97759 Releases: main, 11.5, 10.4 Change-Id: I6ed48f2b03e5e0ca82a9aa493499a5eaf65b184c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74876 Tested-by:core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 11 Jun, 2022 2 commits
-
-
Currently the clearFilterReloadsPageTreeWithoutFilterApplied randomly fails due to a still existing element. This seems to be caused by performance issues in CI. This is now solved by waiting for the element to actually disappear. Resolves: #97749 Releases: main, 11.5 Change-Id: Ib417fc97dcff6ddf0f3c1370ffa419a79f21eba6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74858 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Stefan Bürk authored
This change adds the ability to clean rendered documentation folder and files in all system extension folders in one go. Mentioned folders are `typo3/sysext/*/Documentation-GENERATED-temp`. Added command/testsuite: * `Build/Scripts/runTests.sh -s cleanRenderedDocumentation` Additionally the already combined cleaning command `-s clean` is extended to delete rendered documentation in the same run. Resolves: #97673 Releases: main, 11.5, 10.4 Change-Id: I344f897769cd5f475d43db67dd1b27693f49a658 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74717 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 10 Jun, 2022 6 commits
-
-
Stefan Bürk authored
This patch adds the ability to run commands with PHP8.2 using `Build/Scripts/runTests.sh`. Support is added early to check which issues may raise up with new major PHP version. Help text of script is adopted to state the possibility of the new PHP version with proper example commands. Additionally, a note and check for currently not supported xdebug with PHP8.2 is added. Resolves: #97755 Releases: main, 11.5 Change-Id: I9df13d35278793fba8c5475c8abd602bd1c27896 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74869 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
PHP 8.1.7 introduced a bug that it considers the month number 100 to be valid, which breaks one of our tests. As it is not relevant for the test whether the invalid month is exactly 100 or 99, we now are using a number that does not trigger the PHP bug. https://github.com/php/php-src/issues/8749 Resolves: #97756 Releases: main, 11.5 Change-Id: I2ca2b90a2c1e46f16cfeddda29d80e6a83779b1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74871 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
A dialog trying to prevent overriding existing files in the filelist module shows an incorrect modification date of files that are existing on the server-side. When using regular unix timestamps (instead of micro-timestamps), dedicated `moment.unix` function has to be used. Resolves: #97724 Releases: main, 11.5, 10.4 Change-Id: Ieb5a00aaf87410e9721e39d91b9e0da13a109bc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74805 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Resolves: #97612 Releases: main, 11.5 Change-Id: Ia23a15f0beb864a8b53c568ed27642ec7ac8c7b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74818 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
By making the modal's primary button a submit button and binding it to the form, the user can now use the ENTER key to submit the password. Resolves: #97746 Releases: main, 11.5 Change-Id: Icc380057259a0c44511098d640bdd8c4ca395a55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74831 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com> Tested-by:
Rudy Gnodde <rudy@famouswolf.com> Tested-by:
-
Resolves: #97741 Releases: main Change-Id: Ic346680b2f3fcaf8ffef5f9b9bd1cb903da61e0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74826 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 09 Jun, 2022 2 commits
-
-
The MailerAdapterInterface, related to SwiftMailer is removed, since it is unused in core since v7. Resolves: #97752 Releases: main Change-Id: Ibb0a97dd17a06cb7b4d43d8d9aa4326194f550f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74860 Tested-by:
-
More code paths identified as dead by PHPStan, or that PHPStan isn't understanding correctly. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97649 Releases: main, 11.5 Change-Id: I8ff67b7ebda5d64624d4e42a9775e4709bff3f08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74677 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Joey Bouten <joey.bouten@beech.it> Reviewed-by:
-
- 08 Jun, 2022 3 commits
-
-
Resolves: #97745 Releases: main Change-Id: I903f04c8eba97e7e4fb148041288da843ea1647d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74830 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Markus Klein <markus.klein@typo3.org> Tested-by:
-
Some default fields (e.g. tt_content.bodytext) can contain null values. TYPO3 first fetches the data in the default language and then overlays the rows data with the translation values. The overlay method inspects each array item with the php isset() function. This validates not only the existence of the array key, but also the values. null and false values evaluated as false. Empty strings evaluate as true. This leads to inconsistent output in the frontend. The overlay now valides only the array key existence and applies also empty values. Resolves: #97616 Releases: main, 11.5, 10.4 Change-Id: I4b01c52e9ac7adde786b3395bce870bc0a354b58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74632 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
This helps avoid breakage when GeneralUtility will switch to strict mode. This change also prevents a whole bunch of possible invalid array access warnings. Resolves: #97581 Releases: main Change-Id: Ie167d05a9d8e4c231eec5d86336405627deceb2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74599 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 07 Jun, 2022 5 commits
-
-
Searched for "/** @var " and went through all results manually. Skipped results where GeneralUtility::makeInstance is called with a variable. This reduces the PHPStan baseline further. Imported some namespaces on the go. Run commands: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline > Build/Scripts/runTests.sh -s cglGit Resolves: #97705 Releases: main,11.5 Change-Id: I700ba596234af8cd3d32507fb03d77cfe30c678a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74785 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Andreas Fernandez authored
Executed commands: cd Build yarn add --dev typescript@~4.7.0 Resolves: #97698 Releases: main, 11.5 Change-Id: I1b8d2134b6403f1f9672325beabe62436d8b8901 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74774 Tested-by:core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
This change introduces three new PSR-14 Events in favor of the following hooks: * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['determineId-PreProcessing'] replaced by "BeforePageIsResolvedEvent" * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['fetchPageId-PostProcessing'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['settingLanguage_preProcess'] replaced by "AfterPageWithRootLineIsResolvedEvent" * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['determineId-PostProc'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['settingLanguage_postProcess'] replaced by "AfterPageAndLanguageIsResolvedEvent" Due to the restructuring of TSFE in the past versions, it became obvious that several hooks are called right after each other, making them superfluous. For this reason, they have been unified. The new PSR-14 Events are more powerful as they also contain the current request. In addition TSFE->determineId() can now intercept the process by properly returning a Response object. Resolves: #97737 Releases: main Change-Id: I9f82ba79c89826208a1131663a1b8b5e2e2781c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74516 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Releases: main Resolves: #97735 Change-Id: I703595777f4bb7727cc72b7ab92cb2446f3cf30e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74820 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Guard invalid argument type exception by using null coalescing operator in `\TYPO3\CMS\Form\Domain\Finishers\FinisherVariableProvider`. Resolves: #97699 Releases: main, 11.5 Change-Id: I6312fb35d52857004e0467a20e215fc4095e0037 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74775 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: crell <larry@garfieldtech.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 06 Jun, 2022 5 commits
-
-
Also add some (indirect) basic tests for GifBuilder::calculateValue. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97690 Releases: main, 11.5 Change-Id: I836db8570f64ecb2729c1707fcfe9fc1af672151 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74743 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Sometimes it happens that the page tree is not updated within a certain amount of time resulting in failing tests. This patch will add a timeout and makes sure that the page tree is updated. Resolves: #97714 Releases: main, 11.5 Change-Id: Id28d955ccda6838701aea63e6aa97b5ee9c602b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74793 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Resolves: #97658 Releases: main, 11.5 Change-Id: Ic4e18d64849e64404dca0eef240060d882476526 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74817 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
In CLI context the full path to the temporary generated file by the GIFBUILDER can't be resolved. Because of this inconsistency, absolute file paths are used from now on. Resolves: #95379 Releases: main Change-Id: If3a8613ed8e8d11a1b8a474fa564f947ef8a5c0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73932 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This is now covered by the annotations using generics in the testing framework base class, and hence not needed anymore. (Removing it also helps get consistent behavior from PhpStorm's static type analysis.) Resolves: #97736 Releases: main, 11.5, 10.4 Change-Id: Ia7d7e790bb92eaf1c9b7ffa4f9d97b2b0a50dee3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74822 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 04 Jun, 2022 3 commits
-
-
For translating / synchronizing (inline) records, the DataHandler dispatches the data map to the DataMapProcessor. This components' implementation of the translation prefix however differed from the one in DataHandler, leading to inconsistency, as some fields still got the "Translate to:" prefix added, while others did not. This is now fixed by aligning the functionality with the one used in the DataHandler. Resolves: #97721 Releases: main, 11.5 Change-Id: I425ca172f2c66cf43613fb62be0e35fa1dff76fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74815 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The pagination links of the redirects module must respect a given ordering. Resolves: #97645 Releases: main, 11.5 Change-Id: Iaa65b8e365e9014796c463118504182f66b49ccb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74673 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
For empty storages, we need to avoid accessing inexistent array elements. Resolves: #97417 Relates: #97554 Releases: main, 11.5 Change-Id: Ieee36b4c0ede9726ce936030f631a3322e3813a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74342 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 03 Jun, 2022 8 commits
-
-
The placeholder replacement in the yaml import method must receive the current configuration context to be able to replace placeholders with values that are already configured instead of the subvalues of the import statement. Resolves: #92956 Releases: main, 11.5 Change-Id: I4766bf1e6d268bb4c1bdd24e638c9b5056e600b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66946 Tested-by:
Daniel Goerz <daniel.goerz@b13.com> Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
In preparation for patchset https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/, functional tests are introduced to test the caching behavior of EXT:form. Resolves: #97049 Related: #93887 Releases: main Change-Id: Ief1c8d90371d6003512f88a064c2d82e51502590 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73722 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Even if the property 'crop' is not explicit set in the TypoScript code provide expected values to the stdWrap method (which expects a string and not NULL). Resolves: #97720 Releases: main, 11.5 Change-Id: Id8039ea5e379aa9a3ed81499f90160a5af8546f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74799 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jan Helke <jh@f7.de> Tested-by:
-
Instead of checking for the array key `enablecolumns` the check must be done on the field `disabled` itself. Resolves: #97728 Releases: main, 11.5 Change-Id: I411b37d4d63eb1ad52592cd887a95c2552ab7bfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74810 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
In #87380, it was recommended to use the `SiteLanguageAwareInterface` instead of the `SiteLanguageAwareTrait` for marking classes as site language aware. The usage of the trait for this was never properly deprecated - it was only marked as "at any time after TYPO3 v11", which is not specific enough. The proper deprecation is now done so the check for the trait can be removed for TYPO3 v13. Resolves: #97435 Related: #87380 Releases: main Change-Id: I6e8d130b295d4dc3f69639b4fa0e13d6b73f1040 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74361 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Andreas Fernandez authored
Resolves: #97730 Releases: main Change-Id: I78aa8d10dfdd045405316c25d8ce39d353b9e9d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74812 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
+ npm package moment up to v2.29.2 contained a vulnerability (https://github.com/advisories/GHSA-8hfj-j24r-96c4) which only affected npm server users - in order to avoid confusion concerning security aspects, the package version is raised + npm package moment-timezone was upgraded to recent timezone data "IANA TZDB 2021" Executed commands: cd Build; \ nvm use; \ yarn upgrade moment moment-timezone; \ yarn exec grunt clear-build; \ yarn exec grunt build Resolves: #97723 Releases: main, 11.5, 10.4 Change-Id: I84ea9ca6b696d74aab70cfa45e6d41a95ae0159d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74802 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
If TCA with a file upload is used within IRRE (e.g. as done by EXT:news), creating a new record or opening an existing record now sets up the drag uploader. As the DragUploader module is loaded independently from the FormEngine main module, loading order may vary, rendering an event-based solution unstable. To solve this issue without any major refactorings, a MutationObserver is installed by the DragUploader module. Resolves: #97676 Releases: main, 11.5 Change-Id: I36a3922999842f4d0bddfc7e4b148ec39880d9df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74748 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 02 Jun, 2022 3 commits
-
-
Resolves: #97726 Releases: main Change-Id: I7139dc9431aa5bf117d2aa3d4cf4586e5bf74b8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74807 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Also add a missing type cast. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97426 Releases: main, 11.5 Change-Id: I5a48c0737833792f99652cc54a90db9bcbe798b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74351 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
composer req --dev composer/composer:^2.2.12 Resolves: #97722 Releases: main, 11.5 Change-Id: I526de4c62b5f9bc03230a8794cd42082e9f00560 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74800 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 31 May, 2022 1 commit
-
-
Oliver Bartsch authored
The scheduler module contains a special task, which allows to select schedulable symfony commands. The corresponding field provider therefore adds the commands' configured arguments and options. Due to insufficient prefixing, it was not possible to display arguments and options with the same name. Additionally, using "action" as name always overwrote the "select schedulable commands" field. This is now resolved by adding proper prefixes. Resolves: #97691 Releases: main, 11.5 Change-Id: I0e2c958fc699065cad6c53c0876e2c9ef14fc1f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74745 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Torben Hansen <derhansen@gmail.com> Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
-
