Skip to content
GitLab
Switch branch/tag
  1. 13 Jan, 2022 1 commit
  3. 12 Jan, 2022 1 commit
    • Christian Kuhn's avatar
      [TASK] Simplify Templating Bootstrap in BE Controllers · 37ac299f
      Christian Kuhn authored 
      This patch introduces a new EXT:fluid view class
"BackendTemplateView" to be used as main view for
backend-related non-Extbase views.

This class is the base of a new non-Extbase and
non-request dependent backend view. The class is for
now marked @internal and experimental since we'll
probably add a factory to configure backend template
overrides for any backend view later-on.

A few ViewHelpers are changed to work without
accessing the request if enough VH arguments are provided.

This is the first patch in a series of patches that will
switch from StandaloneView usages in backend
controllers to this new BackendTemplateView.

Basic strategy:
* $view->getRequest()->setControllerExtensionName('SysNote')
  is removed. This is Extbase-specific and not needed nor
  wanted for common non-Extbase controllers.
* Instantiate the View (for now with makeInstance, will be
  replaced with a factory later-on)
* Set the needed paths via ->setTemplateRootPaths() etc.
  For these, we *always* use the main extension's entry
  templating paths, for instance
  'EXT:sys_note/Resources/Private/Templates' or
  'EXT:sys_note/Resources/Private/Partials'.
  We do *not* use sub directories here to clear up path
  logic.
* ->assign() / ->assignMultiple() whatever is needed.
* ->render('SubDirectory/TemplateName') the actual
  action / template, no '.html' suffix.

As a demo, EXT:sys_note is adapted accordingly which hands
over arguments to the above mentioned VH's in a way so
these don't access the request object anymore. The sys_note
code gets a couple of additional changes so the hooks can
prepare request dependent arguments and set them as
template variables (here: returnUrl).

This patch triggers a hidden gem: Since ViewHelpers no
longer receive an Extbase request, they also don't trigger
Extbase magic anymore. The casual victim here is
f:translate, which has already been prepared to not trigger
Extbase's frontend TypoScript parsing if there is no
Extbase request. This often improves backend view performance
by 25% or more, depending on the amount of frontend
TypoScript to parse.

Further patches will adapt other core backend routes and will
relate to this patch for reference.

Change-Id: I4fec3ad690452a00e731c9f6928273048397dd89
Resolves: #96513
Related: #96473
Releases: main
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72966

Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Tested-by: Oliver Bartsch's avatarOliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      37ac299f
  5. 30 Nov, 2021 1 commit
  7. 27 Nov, 2021 3 commits
  9. 18 Nov, 2021 1 commit
  11. 16 Nov, 2021 2 commits
  13. 10 Nov, 2021 1 commit
  15. 02 Nov, 2021 2 commits
  17. 12 Oct, 2021 2 commits
  19. 05 Oct, 2021 2 commits
  21. 28 Sep, 2021 1 commit
  23. 24 Sep, 2021 1 commit
  25. 22 Sep, 2021 1 commit
  27. 11 Sep, 2021 1 commit
  29. 07 Sep, 2021 2 commits
  31. 26 Aug, 2021 1 commit
  33. 24 Aug, 2021 2 commits
  35. 10 Aug, 2021 1 commit
  37. 08 Aug, 2021 1 commit
  39. 28 Jul, 2021 1 commit
  41. 26 Jul, 2021 1 commit
  43. 13 Jul, 2021 2 commits
  45. 28 Jun, 2021 1 commit
  47. 17 Jun, 2021 1 commit
  49. 14 May, 2021 1 commit
  51. 04 May, 2021 2 commits
  53. 24 Mar, 2021 1 commit
  55. 23 Feb, 2021 2 commits
  57. 22 Dec, 2020 1 commit