Skip to content
GitLab
Switch branch/tag
  1. 10 May, 2022 1 commit
    • Christian Kuhn's avatar
      [TASK] Refactor ext:tstemplate controllers · 5399ea63
      Christian Kuhn authored 
      With the refactoring of the '3rd level' backend module
API, we can finally clean up the Template related
backend controllers.

Notable UI changes:
* There was a rather hidden functionality in the template
  module: The "Template record overview" that lists all
  pages that have sys_template records, is only rendered
  when the root page "Page zero" is selected. This can be
  hard to find and is contrary to all other backend modules
  where sub-functionality is selected using the drop down
  in the doc header. The patch changes this: The template
  record overview is now always shown as 5th element in the
  drop down. It currently renders the same output on all
  pages, but could be made page-aware later.
* The TypoScript Object Browser has a detail view to edit
  single properties, which then write to a sys_template
  record. This view also allows to add the edited path to
  an "Object List" if it has sub properties. This is
  remembered for the given user. The user can then select
  this path in the object browser tree view to limit the
  view to this section of the tree. All in all, this is a
  rather hidden and pretty much unknown detail functionality
  of limited use. This functionality has been removed.

Patch overview:
* Implement the "Template record overview" as new
  controller.
* Resolve "controller extends controller" inheritance and
  introduce an abstract controller with common methods of
  client classes. Methods don't add class state.
* Heavily reduce class state to a minimum.
* Improve separation of controller and view concerns.
* Split some templates to partials.
* Leverage dependency incjection correctly: Abstract uses
  inject* methods, client classes use constructor DI.
* Remove user access checks since the entire Template
  module is 'admin only', which is checked by middlewares.
* Various general clean ups, variable renamings, better
  structured methods.

Change-Id: I64cb7ea6275af491233ff7ee525c9260e5da6627
Resolves: #97591
Related: #97135
Releases: main
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74550

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Tested-by: Jochen's avatarJochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk's avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: Jochen's avatarJochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      5399ea63
  3. 21 Apr, 2022 1 commit
  5. 07 Apr, 2022 1 commit
  7. 07 Dec, 2021 1 commit
  9. 24 Sep, 2021 1 commit
  11. 11 Sep, 2021 1 commit
  13. 25 Aug, 2021 1 commit
  15. 11 Aug, 2021 1 commit
  17. 05 Aug, 2021 1 commit
  19. 29 Jun, 2021 1 commit
    • Oliver Bartsch's avatar
      [TASK] Avoid usages of sys_language in site configuration · da9c6df5
      Oliver Bartsch authored and Benni Mack's avatar Benni Mack committed 
      This patch removes the last remains of sys_language in the
site configurations' TCA.

Therefore, the TCA of `site` and `site_langauge` is changed
to always retrieve possible site languages via an itemsProcFunc,
instead of using a relation to sys_language.

As new site languages now have to be created in the module
directly, a new internal TCA type "siteLanguage" is introduced.
The new type behaves similar to type "inline", but contains some
necessary features, e.g. unique record selector box next to a
"create new" button, which are not available in type "inline".
Also some not needed functionality is omitted.

Instead of the sys_language records, all available site languages
from all existing site configurations are now presented in the
selector box. On selecting one of them, a new site language record
is created, with most of the fields pre filled.

Resolves: #94399
Releases: master
Change-Id: I60ac5b4259aa3c9d90a4aba9881bc1dc2341b464
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69188

Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      da9c6df5
  21. 12 Jun, 2021 1 commit
  23. 08 Sep, 2020 1 commit
  25. 18 Aug, 2020 1 commit
  27. 17 Aug, 2020 1 commit
  29. 16 Aug, 2020 1 commit
  31. 15 Apr, 2020 1 commit
  33. 14 Apr, 2020 1 commit
  35. 13 Apr, 2020 1 commit
  37. 24 Sep, 2019 1 commit
  39. 19 Dec, 2018 1 commit
  41. 20 Sep, 2018 1 commit