- 10 May, 2022 3 commits
-
-
Christian Kuhn authored
With the refactoring of the '3rd level' backend module API, we can finally clean up the Template related backend controllers. Notable UI changes: * There was a rather hidden functionality in the template module: The "Template record overview" that lists all pages that have sys_template records, is only rendered when the root page "Page zero" is selected. This can be hard to find and is contrary to all other backend modules where sub-functionality is selected using the drop down in the doc header. The patch changes this: The template record overview is now always shown as 5th element in the drop down. It currently renders the same output on all pages, but could be made page-aware later. * The TypoScript Object Browser has a detail view to edit single properties, which then write to a sys_template record. This view also allows to add the edited path to an "Object List" if it has sub properties. This is remembered for the given user. The user can then select this path in the object browser tree view to limit the view to this section of the tree. All in all, this is a rather hidden and pretty much unknown detail functionality of limited use. This functionality has been removed. Patch overview: * Implement the "Template record overview" as new controller. * Resolve "controller extends controller" inheritance and introduce an abstract controller with common methods of client classes. Methods don't add class state. * Heavily reduce class state to a minimum. * Improve separation of controller and view concerns. * Split some templates to partials. * Leverage dependency incjection correctly: Abstract uses inject* methods, client classes use constructor DI. * Remove user access checks since the entire Template module is 'admin only', which is checked by middlewares. * Various general clean ups, variable renamings, better structured methods. Change-Id: I64cb7ea6275af491233ff7ee525c9260e5da6627 Resolves: #97591 Related: #97135 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74550 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by:
Jochen <rothjochen@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com>
Reviewed-by: -
If a TypoScript sub-template is missing, because it is disabled, it is necessary to check for the existence. Resolves: #97601 Releases: main, 11.5 Change-Id: Iaca27df294f4c3c3ea890defc4ccd3b5b6feb671 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74598 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> -
In #97373 the makeDiffDisplay() method of DiffUtility got type hinted. However, since the corresponding usages were not adjusted, this now led to type errors. This is now fixed by applying proper typecasts. Resolves: #97598 Related: #97373 Releases: main Change-Id: I1593228df561e156cb8426db5743f1a63b2304f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74586 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 09 May, 2022 9 commits
-
-
Stefan Bürk authored
Along some minor changes, TF frontend requests now directly submit the InternalRequest to the core's application chain without explicitly transitioning them to a ServerRequestInterface since TF InternalRequest now directly extends core's ServerRequest. This simplifies the class chain and is the general way to go. * tests are adjusted to test against adjusted sync between 'body' and 'parsedBody' * tests added for request uri query arguments and request queryParams syncronization in different constellations See: https://github.com/TYPO3/testing-framework/pull/355 Used commands: > composer u typo3/testing-framework Resolves: #97256 Releases: main Change-Id: I21f573933f3b853eeeda9d7b00b5702bf9c6ac3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73990 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
We restricted the default retry of single jobs a while ago to do that only for acceptance test related jobs. This does not work out well: There are simply to many things that occassionally false-negative due to network, timing or other issues. The patch adds general retry:1 for all jobs for mental sanity. Resolves: #97597 Related: #96999 Releases: main, 11.5 Change-Id: I408b7ef1b6c6145dc1b5b12bc4550c00dfdaa930 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74584 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The following palettes of the table pages are not in use since a long time and can be removed: - 1 - 2 - 3 - 5 - 6 - 7 - 8 Resolves: #97589 Releases: main Change-Id: Ibb2a8ddef2ee6c96eaae1b886094f8ce3fd6e23e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74579 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
- Remove it for tables using adminOnly - Replace with true if set to 1 Resolves: #97575 Releases: main Change-Id: I216ea31edc0c8621890a348a239e7d128154370d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74578 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
The bootstrap_package related installer acceptance tests are disabled for quite some while already since that package does not keep up with current core development. It does not make sense to keep them anymore, so we drop the according files. Change-Id: I7ead6edde604c74f784d143b3ec44e46e18912e6 Resolves: #97594 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74581 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Christian Kuhn authored
When we fiddled in #97056 with Acceptance/Install.suite.yml, we broke the yml by removing an env: too much. codeception did not fail on this, but only raised a warning, which went through not noticed, but effectively, the installer tests were not executed in main branch anymore since then. Change-Id: I879c400feebe67acf864e583687826e4a9df4b1f Resolves: #97593 Related: #97056 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74580 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Not all tables have tstamp defined in their ctrl section. Resolves: #97588 Releases: main, 11.5 Change-Id: Ibddaab2e313bc2511b1f9aa903ed312d3cf7f9bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74577 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
This helps avoid breakage when GeneralUtility will switch to strict mode. Resolves: #97579 Relates: #97578 Releases: main, 11.5 Change-Id: I813075a74805b72781a493278e45aa1e9a1e2cc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74573 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
During the refactoring of the backend templates with #96745 the rendering of some flash messages has stopped. This change adds the output of flash messages again. Resolves: #97569 Related: #96745 Releases: main Change-Id: Ibf78c349e3971befbada7dea44cc50d9321d8ab2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74539 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 08 May, 2022 3 commits
-
-
Nikita Hovratov authored
The core utility class ResourceUtility is a leftover from an old FAL implementation. In a refactoring in TYPO3 v7 this class was replaced with a direct implementation and has not been used in the core ever since. Resolves: #97576 Related: #56746 Releases: main Change-Id: I8a7693633573c2e913075754761519cc2330b1f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74548 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Releases: main, 11.5 Resolves: #97577 Change-Id: I68f6433a4ae38eb05e24b997cdfcba8b2eb60115 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74549 Tested-by:
-
In tests for `GeneralUtility` that explicitly violate the contract (and test the correct error handling in those cases), PHPStan errors about the contract violation are not helpful and rather clutter the PHPStan baseline. So these errors are now silenced with an annotation in the corresponding tests, allowing us to focus on PHPStan errors about actual issues. Note: We only use this annotation in tests, not in production code, to avoid silencing errors about actual problems. Resolves: #97574 Releases: main, 11.5 Change-Id: I2586dd77a4e3f9d801e24af68ab29984ad8d02c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74547 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 07 May, 2022 7 commits
-
-
And remove phpstan exceptions along the way. Resolves: #97377 Related: #97210 Related: #97372 Releases: main Change-Id: I7769527eaf8e39150928402037e68b95c2be9cc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74290 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
The PHPStan baseline file has several entries for this error. This patch resolves them by adjusting the code so the issue is not relevant. Resolves: #97458 Releases: main, 11.5 Change-Id: Ida192b1168dbf9c9cc3ba7f2ca9e635187137a05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74378 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by: -
Avoid a postgresql error when previewing a page from the backend which has an access protection by a fe_group due to PreviewSimulator faking a fe_user with uid PHP_INT_MAX and sql failure to update the is_online status of this fake user in PostgreSQL as column fe_users.uid is of type integer and thus has max value of 2147483647 instead of PHP_INT_MAX. Releases: main, 11.5, 10.4 Resolves: #97564 Change-Id: I16c866c368a9b3f5ac6bdfacf2c6660a7046df5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74529 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
The argument `$funcName` is now annotated as `non-empty-string|\Closure` to reflect the actual allowed input types. Additionally corresponding test in `GeneralUtilityTest.php` is also annotated properly. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97568 Releases: main, 11.5 Change-Id: I7ce640d3565f099e6dc5ba62c59e5616dc4dc6e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74535 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by: -
Also gets rid of some phpstan exceptions. Resolves: #97374 Related: #97372 Related: #97210 Releases: main Change-Id: I71083a58013f0747a9969fb15d4462bee0c595d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74288 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
This was probably forgotten when adding native types to this class. Resolves: #97572 Related: #97205 Releases: main Change-Id: I6c11ba669bb152f731f81e245eb05ef8c88da867 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74545 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
phpstan parallel execution is limited to a maximum of 5 processes to be a nice neighbor when executed during core CI runs. This however leads to longer execution times when executed on local developer machines with many available CPU's. This patch introduces two separated phpstan config file entrypoints, one for local and one for CI. They are automatically selected in runTests.sh based on existence of a CI env variable. Resolves: #97571 Releases: main, 11.5 Change-Id: I14bf13412de7a2471703e7982dad4030ae6ba735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74536 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 06 May, 2022 10 commits
-
-
Latest docker:20.10-dind (currently 20.10.15) triggers an error on CI: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: unable to apply cgroup configuration: mkdir /sys/fs/cgroup/rdma/docker: permission denied: unknown The image is the 'sub-container' in CI on runner hosts, that runs all the test images like the php and database images. This error *may* have to do with sysbox, which is a security layer on runner hosts to separate CI jobs from each other. We however currently don't know exactly what is going on. For the time being, we pin the dind image to its previous verion docker:20.10.14-dind Change-Id: Ie59be69680e1f444c115f2249ca8709bbfdd1e3e Releases: main, 11.5, 10.4 Resolves: #97570 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74541 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This patch is cleaning up a lot of loose ends in the svg tree component. It aims to make the component look more clean and polished. - Unify focus styling with selected, hover and versioning - Ensure the whole node looks focused instead of only some text - Replace expand icon to match core icon styling - Hide expand icon if page tree is stopped - Move trigger to enter stopped pagetree to the front - Remove blurry lines for background borders - Make the edit input fields use as much space as is available - Load common icons always on setup to avoid node refresh on initial loads - Reposition the locked icon (another editor is editing) - Correct keyboard navigation behaviour and focus setting - Keep focus after leaving the edit mode without changes - Adjust positioning to rely on calculation instead of hardcoded values - Align drag delete target - Make drag positions more visible to the user when moving a page - Improve styling of tooltips when dragging elements - Add border to select tree component to make scroll boundaries visible Affected Areas: - PageTree - FileTree - SelectTree Releases: main Resolves: #97344 Change-Id: I6034e0cbc1079b93b24c5c1a99e0299946874b2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74203 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Stefan Bürk authored
'doctrine/dbal' 3.x deprecated the 'getSchemaManager()' method in favour of the 'createSchemaManager()' method on connections. This has been aligned in core with the doctrine/dbal raise in #96287. However, two occurances with corresponding todo comments has been overseen. This patch replace the calls and solves the comments of the left-overs. Additionally, unrelated wrapper method in ext:install database checks has aligned to the same name to avoid confusion when looking for the deprecated method. Resolves: #97552 Related: #96287 Releases: main Change-Id: If73e9439acdcbf89db968ba1e6db1c4d60513861 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74524 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org> Tested-by:
-
Also, first class callable syntax is added for the csvValues method. Resolves: #97207 Related: #97210 Related: #97372 Releases: main Change-Id: Ib37a497c8df38fa9ef2f071c10439de4d269b25c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74286 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Nikita Hovratov authored
In order to fix select fields overflowing into each other when they have very long option titles, the CSS rule "overflow: hidden" has been added. As it seems, this wasn't even necessary as the rule "min-width: 120px" already does the trick. The CSS rule "overflow: hidden" is now removed, which enables the accessibility box-shadows from bootstrap 5 again. Resolves: #97565 Related: #94688 Releases: main, 11.5 Change-Id: Ifd8495430ecdc404fa1dbebe9633ef5f401a6af6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74530 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Also, clean up related tests' doc blocks. Resolves: #97382 Related: #97210 Related: #97372 Releases: main Change-Id: I5f9a99f35bf2e1afbbdeeec1cc1de98157e581ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74316 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This change adapts ExtendedFileUtility logs to use interpolation from PSR-3 instead of %s to identify variables in log_details properly later-on. This makes all log messages from ExtendedFileUtility PSR-3 compliant. In addition, details_nr is not in use anymore since TYPO3 v6, so the arbitrary ID is removed when logging. Also, all messages do not contain a "!" at the end anymore, as there is no need to emphasize errors through the log message itself (that's why there is type "Error" for logging). Same goes for "." in order to be consistent. Resolves: #97558 Releases: main Change-Id: I39d474b7c7edd3707d9959b5e750c64f23bcb1ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74527 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Also, a little cleanup in DefaultFunctionsProvider. The method getCompatVersionFunction() was calling convertVersionNumberToInteger() with an inconsistent type as a result of TypoScript parsing. We therefore need to force-cast it to a string, which is what convertVersionNumberToInteger() wants. Resolves: #97383 Related: #97210 Related: #97372 Releases: main Change-Id: Id47e42fd70d8ec89f6255616a26e6666c461efe7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74317 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Adds type declarations to DebugUtility. Fixes some calls to these methods to avoid spurious nulls. Improves documentation in renderDump() to explain why certain parameters are nullable. Resolves: #97208 Related: #97210 Related: #97372 Releases: main Change-Id: Iecad6ef3e7432cf1f4123a4cdb1da15f14d04394 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73991 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by: -
Nikita Hovratov authored
This adds two recently merged utility classes with changed method signatures to the breaking rst file. Resolves: #97567 Related: #97378 Related: #97381 Releases: main Change-Id: Id50f4806346e4fdd1786f3d93a09d05ebc1e1790 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74532 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 05 May, 2022 7 commits
-
-
Document https://review.typo3.org/c/Packages/TYPO3.CMS/+/73048 in the extensions manual Resolves: #97404 Releases: main Change-Id: If241f826fcc8972877eb9b4f6c7281a814b65ef9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74331 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by: Annett Jähnichen <mcmietz@web.de> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
This change deprecates the following properties: ContentObjectRenderer->lastTypoLinkUrl ContentObjectRenderer->lastTypoLinkTarget ContentObjectRenderer->lastTypoLinkLD (LD stands for "LinkData") All this information is available in the newly introduced LinkResultInterface, that can be built with the LinkFactory directly, or via ContentObjectRenderer->createLink(). Resolves: #97549 Releases: main Change-Id: I80b21d54e75714ecc148cece35e064720a57df44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74510 Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: -
Currently, a user can reset their password, but never gets the information what their username is. Many users forget their login username and reset their password using their email address. This patch adds the username in brackets after the first and last name to the salutation in the recovery email. Resolves: #96705 Releases: main, 11.5 Change-Id: Idb18e13e453edbab8645b079b7573e91191e479b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74256 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This change adapts DataHandler logs to use interpolation from PSR-3 instead of %s to identify variables in log_details properly later-on. This makes all log messages from DataHandler and Workspaces PSR-3 compliant. In addition, all messages do not contain a "!" at the end anymore, as there is no need to emphasize errors through the log message itself (that's why there is type "Error" for logging). Same goes for "." in order to be consistent. Resolves: #97556 Releases: main Change-Id: Ia509b6e121be64cf89d111bdc260332d343b164c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74526 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
a || (b && !a) can be simplified to a || b (because the second sub-condition is only evaluated if a is false). Resolves: #97421 Releases: main, 11.5 Change-Id: I04d62fd46736bb4a0b9dfce54851aaa8f99d20e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74345 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Stefan Bürk authored
Raise phpstan to newest release, which find more things in a proper way. This includes some opcache and autoloading fixes which may hopefully help with lately occurrence of long-running phpstan ci runs. Used commands: > composer req --dev phpstan/phpstan:^1.6.7 > Build/Scripts/runTests.sh -s clean > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97551 Releases: main, 11.5 Change-Id: If7493bc4138e99ff173047cba358d3be43cf2357 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74523 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Benni Mack authored
This option is obsolete nowadays, as PSR-7 is setting the headers at the end of the script / when emitting a Response, this way the header can be modified at any time. Resolves: #97550 Releases: main Change-Id: I0602e4fd0a20461d49a554f66f36442894e96fd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74518 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 04 May, 2022 1 commit
-
-
"AbstractOEmbedHelper::getOEmbedData()" requests data and decode it as json. json_decode() may fail and thus having a invalid type decoded. In the complete chain this lead to a "access array offset on value type bool" warning. This patch checks the decoded value before returning, thus ensure valid return type is "array" or "null". Furthermore this avoids a signature change of the corresponding method "AbstractOEmbedHelper::getOEmbedData()". Additionally this paves the way for adding proper return type in a dedicated patch. Streamline usage in VimeoHelper along the way. Resolves: #97428 Releases: main, 11.5 Change-Id: Icda6b2baa88ddcbf070ceae75eafcb2e9ccb41f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74353 Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by:
-
