- 08 Jun, 2020 1 commit
-
-
Direct hash comparison is replaced by cryptographic-safe `hash_equals`. Changes in this patch set basically don't have much impact regarding security aspects. This is a preparation for starting with RIPS scanner. Resolves: #91565 Releases: master, 10.4, 9.5 Change-Id: I5666e586b6b6b462f7864a597139763fd2cd2f98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64775 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- 17 Apr, 2020 1 commit
-
-
This patch has been created with rector and php-cs-fixer Releases: master Resolves: #91092 Change-Id: I80956bc210237169034acd86ef26c1e8f9725ddb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64212 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- 15 Apr, 2020 1 commit
-
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 23 Nov, 2019 1 commit
-
-
This patch mainly: - Does use statements in all EM code - Removes unused fields "sponsorlink", "sponsorlogo" and "sponsorname" of mirrors XML - Removes unused methods in internal classes It is time to clean up... First one is to get an overview of what is still needed. Resolves: #89751 Releases: master Change-Id: Ie30f05f413afc259fdef6064c363fff47483b331 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62391 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- 27 Aug, 2019 1 commit
-
-
In order to avoid issues creating proper ClassSchema instances for core classes and in order to have a properly renderable documentation with phpdocumentor/phpdocumentor, this patch introduces a new bamboo job that checks all php doc blocks of classes and their properties and methods. Releases: master Resolves: #89023 Change-Id: I13ec766c3ac7c4cea8de84a89e66382ded6d46ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61557 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- 15 Mar, 2019 1 commit
-
-
Replace string concatenations like 'abc' . 'def' with 'abcdef'. Resolves: #87004 Releases: master Change-Id: I9c1a610e88dd4bd4e617214989a915b1dafda094 Reviewed-on: https://review.typo3.org/c/60155 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- 01 Oct, 2018 1 commit
-
-
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:core - EXT:extensionmanager - EXT:install All @api annotations have been removed. Resolves: #86517 Releases: master Change-Id: I7869d8e3b6e8a4365529cc7c98b99cde7ca1495f Reviewed-on: https://review.typo3.org/58532 Reviewed-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 05 Jul, 2018 1 commit
-
-
In order to harden the deserialization of scalar and array values in extension manager unserialize() calls are hardened further to disallow object reconstitution. The information is retrieved from the TYPO3 extension repository (TER) where according countermeasures are in place to protect object injections - that's why this change is considered as hardening and not as security issue. Resolves: #85466 Releases: master, 8.7 Change-Id: I65b61d61e08d0c50b27ae9102d7ba4c4518a8788 Reviewed-on: https://review.typo3.org/57458 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- 07 Mar, 2018 1 commit
-
-
A new class Environment is added, which is initialized right at the very beginning of any TYPO3-based request. The class contains a static list of properties commonly used throughout the core to access paths, constants or global variables. The class also contains methods that are relevant for ALL kind of PHP requests, CLI and web requests. In order to avoid constants, and global variables, this is centralized in one place, which allows to "re-define" values for testing purposes, making functional tests a lot simpler. This would better be stored in a dependency injection container and injected as dependency/parameter into the respective classes that need the information. We're not at that point to use dependency injection for every class, therefore this class provides a static interface as a long-term interim solution. Additionally, it adds a new functionality, basically finally allowing to move code outside of the PATH_site constant with a proper API. If the environment variable "TYPO3_PATH_APP" is set, this acts as a root path for the project, which can be the same as PATH_site, or (usually) one level up. All typical new composer-based installations have this folder structure set up automatically. Non-composer mode installations can set this environment variable to make TYPO3 aware of non-public-accessable folders. The following changes apply (with further patches): - When TYPO3_PATH_APP is set, all logs / sessions / cache files are moved into $PROJECT_ROOT/var/. - Same applies to typo3conf/l10n/, effectively moving this into a semi-writable place, the same place where logs should be placed. - LocalConfiguration.php, PackageStates.php and AdditionalConfiguration.php are now located at $PROJECT_ROOT/config/ The folder typo3conf then only contains code related to extensions. The long-term goal until 9 LTS is that TYPO3 Core does not use any constants anymore, which have been superseded by this class right now. Resolves: #84153 Releases: master Change-Id: I7ca35f752493d7e0d1c21c83a9ffbfb6a40eb463 Reviewed-on: https://review.typo3.org/55960 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- 08 Dec, 2017 1 commit
-
-
With #82254 LocalConfiguration serialized array EXT/extConf has been changed to a not serialized array in EXTENSIONS. This patch follows up on this task an finishes various tasks: * An install tool silent upgrader upmerges given EXT/extConf settings to EXTENSIONS array. The resulting EXTENSIONS array does not contain dots for sub paths in its array key anymore and is accessible with a new ExtensionConfiguration->get() API to fetch values and whole extension config. * A new API is introduced to get() and set() extension specific configuration, is documented and used throughout the core to not unserialize old EXT/extConf anymore. Setting values updates legacy EXT/extConf to new values including compatible 'dot' ending on nested array configurations. * If extensions come with new configuration items in ext_conf_template.txt a silent upgrader of the install tool synchronizes these to the EXTENSIONS and old extConf array. Extension authors can rely on that and always fetch new keys from the new ExtensionConfiguration->get() API right away. The synchronization is also triggered when new extensions are loaded or extensions are updated via the extension manager. * Core usages are adapted to the new API. * Next to the main get() / set() API, the extension configuration form is extracted from the extension manager and put into the install tool as a new card in "Settings". The code below is streamlined and encapsulated with just a couple of public methods in class 'ExtensionConfigurationService' as internal class for use in install tool and extension manager. Resolves: #82368 Related: #82254 Releases: master Change-Id: I88568fa355f8f6fd5acc9850dcdd718fdd9a1b2e Reviewed-on: https://review.typo3.org/54034 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
- 01 Feb, 2017 1 commit
-
-
Change string comparison for string checks. Checks which could lead to false positives like comparing with '0' or '' are excluded. RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+') Resolves: #79540 Resolves: master Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9 Reviewed-on: https://review.typo3.org/51462 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- 09 Jul, 2016 1 commit
-
-
In favor of CharsetConverter and the native implementation, the following methods of GeneralUtility have been deprecated: - strtolower - strtoupper Resolves: #76804 Releases: master Change-Id: I9516c6ec3aebb0a7fd07266d4b4491e4794edbd8 Reviewed-on: https://review.typo3.org/48832 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- 31 Mar, 2016 1 commit
-
-
Benni Mack authored
The Guzzle library is added as a composer dependency instead of HttpRequest to request urls from TYPO3. Guzzle is encapsulated inside a RequestFactory to do requests and return PSR-7 compliant Response objects to deal with content. In the future, Guzzle can also be used to do HTTP requests asynchronously but there is no API for that yet as there is no current need for that in the TYPO3 Core. GeneralUtility::getUrl() now uses Guzzle under the hood, thus adding headers like the TYPO3 User Agent by default. A lot of existing TYPO3_CONF_VARS options are now removed or merged into Guzzle compliant options which are independant of the implementation (cURL, stream wrappers, fopen etc). Resolves: #70056 Releases: master Change-Id: Ibd14bba944b1590bae1b12c10f26365f20576475 Reviewed-on: https://review.typo3.org/43508 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
-
- 14 Oct, 2015 1 commit
-
-
Nicole Cordes authored
If the composer mode is activated, the Extension Manager is set to offline mode. Downloading extensions from TER and uploading extension files is disabled. Resolves: #70605 Releases: master Change-Id: Idb116d7b4b0b9cafa625116e9caadd4c7c37b922 Reviewed-on: http://review.typo3.org/44025 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de> Tested-by:
Daniel Maier <dani-maier@gmx.de> Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- 06 Aug, 2015 1 commit
-
-
Because of performance reasons we replace the @inject annotations back to inject methods. Resolves: #68786 Related: #54605 Releases: master Change-Id: Ifc9960c9ca279c05b4120c806147e49c1084c8d5 Reviewed-on: http://review.typo3.org/42310 Reviewed-by:
-
- 18 Jul, 2015 1 commit
-
-
Since #66597 the EM can be set offline. The value is checked in TerUtility and Helper, but in TerUtility it's done wrong and leads to a misleading error "Extension Manager is in offline mode" which is not true Resolves: #68331 Releases: master Change-Id: Iee55c95a3d43250f43c8fef506a6884b75674504 Reviewed-on: http://review.typo3.org/41657 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
- 17 Jul, 2015 1 commit
-
-
Currently it isn't possible to use the extension manager without any internet connection. This patch adds an option in the extension manager settings to switch to an offline mode. This means, that the navigation in EM is limited to the list view. Download of extensions and distributions is disabled. Furthermore fetching the extension list from TER isn't possible anymore. Resolves: #66597 Releases: master Change-Id: I68477f2289912765aa8ae558bb7df6e550f4f813 Reviewed-on: http://review.typo3.org/40428 Reviewed-by:
Oliver Eglseder <oliver.eglseder@in2code.de> Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
- 15 Jul, 2015 1 commit
-
-
@author information can be found in version control. Cluttering our code with these tags does not make much sense and they are outdated by definition or would sum up to impressive lists. As decided on acme 2015, we drop them now. Releases: master Resolves: #68152 Change-Id: Iec1ea0f873b44ab6027c94ba8353a9fdb5477bdd Reviewed-on: http://review.typo3.org/41264 Reviewed-by:
-
- 20 Apr, 2015 1 commit
-
-
Exception messages are independent from a specific context and thus should not contain HTML code. Resolves: #66344 Releases: master Change-Id: I8bfab2d1da3fc3baf344d833eaaec8b267732baf Reviewed-on: http://review.typo3.org/38609 Reviewed-by:
Andreas Fernandez <andreas.fernandez@aspedia.de> Tested-by:
-
- 13 Dec, 2014 2 commits
-
-
At the moment in some classes you can find an empty line between the copyright comment and the first use statement. In some (far less) other classes there is no such empty line. This commit adds an empty line between those comments if there is no empty line. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: ( \* The TYPO3 project - inspiring people to share!\n \*/\n)(use ) Replace: $1\n$2 Resolves: #63829 Releases: master Change-Id: I4b28a1cfcfc727016ac5d89b3988d236270f37e2 Reviewed-on: http://review.typo3.org/35391 Reviewed-by:
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
- 22 Jun, 2014 1 commit
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59785 for further details. Resolves: #59785 Releases: 6.3, 6.2 Change-Id: If6a4795e7f2841474241d236d8ed33baceee0d2e Reviewed-on: https://review.typo3.org/31030 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- 30 Apr, 2014 1 commit
-
-
Markus Klein authored
* Add missing annotations * Shorten unnecessary namespace annotations Resolves: #57861 Releases: 6.2 Change-Id: Ic8e24e76e3ccc09122dc0a288f1e0b538685c478 Reviewed-on: https://review.typo3.org/29431 Reviewed-by: Oliver Klee Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- 25 Mar, 2014 1 commit
-
-
Helmut Hummel authored
During unpacking of an extension in the installation process it can happen that the extension data contains folders in the file list. These folders need to be removed from the list in order to avoid warnings when trying to write directories as files. Also remove duplicates from folders before creating them. Besides fix some (non related) comparisons to strict comparisons on the go. Resolves: #57261 Releases: 6.2 Change-Id: Ib6821a0a438ebc9441b8fa2ee3fbd7869f23ec7f Reviewed-on: https://review.typo3.org/28731 Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
- 13 Jan, 2014 1 commit
-
-
Roland Waldner authored
"textfile" will be replaced by "text file" Resolves: #54893 Releases: 6.2 Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b Reviewed-on: https://review.typo3.org/26736 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- 01 Oct, 2013 1 commit
-
-
Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b Resolves: #52360 Releases: 6.2 Reviewed-on: https://review.typo3.org/24212 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- 19 Mar, 2013 1 commit
-
-
In this patch are also some fixes for files containing a interface. Due the namespace change all interfaces have the curly bracket not on the same line as the interface name. Change-Id: I64ba45de73693452d681ce7f018965968b11d2af Resolves: #46370 Releases: 6.1 Reviewed-on: https://review.typo3.org/18984 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- 16 Nov, 2012 1 commit
-
-
Christian Kuhn authored
With namespaces the @package and @subpackage annotations do not have a real benefit anymore and can be removed. Change-Id: Id8f4718db0c1c51ae5143a3353dd5efb42dadf70 Resolves: #43019 Releases: 6.0 Reviewed-on: http://review.typo3.org/16474 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- 17 Sep, 2012 1 commit
-
-
Arvid Jakobsson authored
Removes superfluous parenthesis in sysexts "css_styled_content", "extensionmanager", "extra_page_cm_options" and "feedit". Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool. Change-Id: I9ec62d6b2782e349cef447c7a9c87f4a4fbc2585 Resolves: #40964 Related: #40095 Reviewed-on: http://review.typo3.org/14623 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
- 23 Aug, 2012 1 commit
-
-
Change-Id: Id49218118087244bcd063b730631ee69b2820670 Resolves: #40096 Related: #40095 Releases: 6.0 Reviewed-on: http://review.typo3.org/14015 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
