- 14 Jan, 2022 14 commits
-
-
Since TYPO3 v8.7 the new `.typoscript` syntax is used. See #78161 - Since then, we had ext_typoscript_constants.typoscript ext_typoscript_setup.typoscript ext_typoscript_constants.txt ext_typoscript_setup.txt supported. TYPO3 v12 will not include the .txt suffixes automatically anymore. Resolves: #96518 Releases: main Change-Id: I51f65b6cd1db3a438660dc2abc0fed58251485ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72994 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Our Modal implementation already provides a couple of actions, executed when the modal is confirmed. However, previously it was not possible to submit a form - execute a POST request. All available options (e.g. "href" or "data-uri") always executed a GET request. To improve the Modal, especially for operations, e.g. "delete", which should always be executed via POST, the Modal component is extended for corresponding functionality. Therefore, the Modal does now automatically submits the closest form (if one exists), in case the trigger has type=submit set. In case a button with type=submit is the trigger but is not inside a form element, the "form" attribute can be used on the button, to submit an arbitrary form in the current document. Alternatively, it's also possible to set the "data-target-form" attribute on the trigger element, which does not have to be a button, to an arbitrary form identifier in the current document. The new functionality is added at the end to prevent any side effect for existing functionality. As demo, the ext:sys_note "Delete this note" button is adapted to execute POST requests to delete a note. Resolves: #96542 Releases: main Change-Id: I528dc8543e644ee7a0cdb2c8f1918d2ce2951af8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72998 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
This change adds a new centralized place in TYPO3\CMS\Core\Configuration\PageTsConfig to load and parse (and match) PageTsConfig for Frontend and Backend. This way, the class can now be injected into various places and reduce the usages to "BackendUtility::getPagesTSconfig()" Once all usages have been reduced, the main BackendUtility method can be deprecated. Resolves: #96546 Releases: main Change-Id: I7311ca7cf535bb885fadc6b0b59f6ecd85f9444d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73011 Reviewed-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
The page module provides ModifyPageLayoutContentEvent to add content before and/or after the main module content. Extensions like ext:sys_note can use this to render own content. Unfortunately, this content is *within* the default page module form tag, which prevents extension content to create own POST forms. The patch changes the page module HTML slightly to not encapsulate the event content within the form tag. The same situation appears in info module "page information" with "drawFooterHook". The situation here is worse, since the main form tag is rendered by InfoModuleController and not PageInformationController. This "module function" construct in info module is still an ugly mess and really needs an overhaul. For now, the patch adds a hack in PageInformationController to close the outside form, then adds the hook content, then opens another form for valid HTML. Resolves: #96543 Related: #96542 Related: #96526 Releases: main Change-Id: I9eba97b85284cfbd5c1874bbef8c00a533cb4bff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73018 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org> Tested-by:
-
This happens when "transOrigPointerField" is not defined in TCA configuration. Additionally, a PHP 8.1 deprecation is fixed when passing a null to trim(). Resolves: #96514 Releases: main, 11.5 Change-Id: Ic99bd0b0c166397bda23d2e45ca2d4cb766000be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72970 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
A series of ext:backend related controllers and views are cleaned up. Some of them need more work, especially LoginController, BackendController and NewRecordController. This can be done with further patches, but for now: * Use BackendTemplateView * Hand over template to render as view->render('MyTemplate') * Use DI in related controllers and ToolbarItems * Declare strict_types=1 * Return and property types in PHP classes * PageRenderer JS module loading via fluid, not PHP * f:translate with full LLL: keys Change-Id: I191c4799d90d6effa890e71c27eefabc26530213 Resolves: #96545 Related: #96513 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73020 Tested-by:core-ci <typo3@b13.com>
Tested-by: -
When setting "HMENU.1.NO.ATagParams" then "ATagParams" called in cObj->ATagParams is now processed once by setting the option in typolink(). This way, any hooks in ATagParams are added within the context of the typolink function, also receiving all information in the LinkResult object. This is now possible with TYPO3 v11. Some workarounds are needed and document on how to clean this functionality up in TYPO3 v12+. Resolves: #96486 Releases: main Change-Id: I5804931ec623035247baf34a226fe70e44736a72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72909 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
When a page is hit in TYPO3 v12.0, the page translation is automatically applied nowadays. Before, this was only possible if TypoScript was applied (finding out the config.sys_language_uid TypoScript setting etc). For this reason, the functionality can be removed. Same applies for determineOriginalShortcutPage() which is not needed anymore since "pages_language_overlay" is migrated into "pages" and "allowLanguageSynchronization" is active. Resolves: #96540 Releases: main Change-Id: I5158dc62dc5a404e14b0685f4d177fb47723cd82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72864 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
ExtendedTemplateService->ext_getObjTree() has unused properties. Since "ExtendedTemplateService" is marked as internal, these methods can be removed. Resolves: #96539 Releases: main Change-Id: If5328a790ce167156750cb26a097c257cdb368cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73017 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
ext:redirects middleware collected all possible redirects, thus evaluating all regexp redirects to find possible matches. These collected possible redirects are looped afterwards and checked, if redirect is active, meaning not having any start and/or end time constraints or if time constrain is in the active timespan, returning the first feasible redirect. However this evaluated all regexp redirects, even if flat redirects with query arguments, flat redirects without query arguments or a regexp redirect is found. This patch changes this behaviour and checks early for found subset of possible redirects to avoid evaluating at least all regexp redirects even if an early one would be used anyway. This is a minor performance improvement in case an early redirect can be matched, without any effect if no match could be found. Further performance improvements may be possible but should be done in dedicated follow up patches. Resolves: #96480 Releases: main, 11.5 Change-Id: I84170a701d578a74a1780fd87a33d4f3a9af43e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72904 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
* Rename mainAction() to handleRequest() * Use BackendTemplateView * Hand over template to render as view->render('MyTemplate') * Return and property types in PHP classes * PageRenderer JS module loading via fluid, not PHP * f:translate with full LLL: keys * FlashMesage rendering via ModuleTemplate Change-Id: Ib6d37d7e752405274b099f0f2255b1e2c7b9f0d3 Resolves: #96538 Related: #96513 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73012 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Benni Mack authored
A new PSR-14 event is added, where the old hook is removed to modify links to generated Page Links. Resolves: #87616 Releases: main Change-Id: Iee7c078078fe1f7af6365774162dd2cc7cab321a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72948 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: 
Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
While the ManagementController does only feature one action - overviewAction - the handleRequest() made a couple of unnecessary calls, especially to the mentioned action. This is now simplified together with a couple of further cleanups, e.g. removal of unnecessary class properties / methods. Additionally, the new BackendTemplateView is now used instead of StandaloneView, which required a few changes in the template. Resolves: #96534 Releases: main Change-Id: I5a5d81ad98b87083504444eb7c2bf8420227b159 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73016 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
While the RecyclerModuleController does only feature one action - indexAction - the handleRequest() method still contained corresponding logic to dynamically forward the request to another action. This is now simplified together with a couple of further cleanups, e.g. removal of unnecessary class properties / methods and adding strict types. Additionally, the new BackendTemplateView is now used instead of StandaloneView. Resolves: #96533 Related: #96513 Releases: main Change-Id: I0d4a2f1aae47cdfce9bec92f2f768ee64bc64357 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73015 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 13 Jan, 2022 11 commits
-
-
The option "config.disablePageExternalUrl", which allowed to bypass the External URL linking (used for special jumpurl-like functionality and sys_stat) is removed in favor of custom implementations for middlewares. In addition, if a page with external URL cannot be resolved properly, an error response is now triggered (pageNotFound) Resolves: #96522 Releases: main Change-Id: I2ce1bcfac0a2ed10adf32171ad6dbcd4372bf640 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72953 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
* Use BackendTemplateView * Hand over template to render as view->render('MyTemplate') * Move shortcut templates to Toolbar sub folder * Move LiveSearch JS to Toolbar sub folder * Shortcut delete and edit are POST only * Use DI in related controllers and ToolbarItems * Declare strict_types=1 * Return and property types in PHP classes * PageRenderer JS module loading via fluid, not PHP * f:translate with full LLL: keys Change-Id: Ia8b5ecb312dd83b924955f44f53fb7b3c8415ba3 Resolves: #96519 Related: #96513 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72996 Tested-by:core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
This is a partial refactoring of ext:lowlevel. There are some loose ends like HTML in the searchAction() and some other details. Those might be target of a bigger refactoring. However, the patch cleans up controller and view and improves separation of concerns already: * Rename mainAction() to handleRequest() * Use BackendTemplateView * Hand over template to render as view->render('MyTemplate') * Use DI in related controllers * Switch from a ServiceProvider.php to casual Services.yaml * Declare strict_types=1 * Return and property types in PHP classes * PageRenderer JS module loading via fluid, not PHP * f:translate with full LLL: keys Change-Id: I0afe0938990f145e77aedd131f366226142382f3 Resolves: #96530 Related: #96513 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73007 Tested-by:core-ci <typo3@b13.com>
Tested-by: -
Doctrine uses mixed type for most of their method arguments in QueryBuilder. Since TYPO3 core uses variadic arguments for some methods in the wrapping QueryBuilder, argument types have been streamlined to match the ones in the concrete QueryBuilder instance from Doctrine. Resolves: #96507 Related: #96457 Releases: main, 11.5, 10.4 Change-Id: I834240f764feac7af9fba7db0d45aaf4927abb2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72964 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Christian Kuhn authored
* Use BackendTemplateView and ->render('MyTemplate') * f:translate with full LLL: keys * No extbase-only f:form VH usages Resolves: #96527 Related: #96513 Releases: main Change-Id: I1679b1755454b05c3cb104ac11d1acf8410cd27d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73005 Tested-by:Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: -
Oliver Bartsch authored
Resolves: #91077 Releases: main Change-Id: Iac0b8433a77ef4d6f6f0d1734e84c6a35f6addb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73008 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de> -
Configure classes in Services.yaml towards dependency injection. Also rename NoteController to NoteRenderer as it's not really a controller that handles requests, but just a renderer used as dependency in events. Controllers are usually public DI services, renderes not. Resolves: #96528 Releases: main Change-Id: Idfadc75763ad0a7a84fd572473affb9040575b54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73006 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
This introduces a new PSR-14 event, enabling extension authors to modify the header and footer content of the page module in a flexible way, since also reordering and overwriting is possible now. This replaces the previously available hooks - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/db_layout.php']['drawHeaderHook'] - $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/db_layout.php']['drawFooterHook'] which are now removed. Resolves: #96526 Releases: main Change-Id: I5fb3f3098394b70ecc4e5cc11c804f7125ad2a4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73003 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
The option prefixLocalAnchors in HtmlParser was not used anymore since the removal of its main functionality in #65934 with TYPO3 v8.0, and is now removed, as it is a leftover of past functionality before site handling and proper URL generation. Resolves: #96501 Releases: main Change-Id: Ia037f02729cf731ea60e4a49174bdb0caff34c0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72945 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Bartsch authored
To improve the workflow for editors while selecting records or folders in TCA type "group" fields, a new field configuration "entryPoints" is introduced. It can be used to define the default page / folder, which should be selected when opening the element browser. This can be configured for all or for each table individually. This configuration might be quite useful since TYPO3 systems usually use dedicated storage pages for record types nowadays. To further support site administrators, the new configuration also allows the usage of the known TCA markers and additionally is also added to FormEngine's "allowOverrideMatrix". Resolves: #91077 Releases: main Change-Id: Ie6e4e8675ff07288480bce69467805409defdc57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72911 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
This change introduces a new PSR-14 event for manipulating menu items in a menu. The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/tslib/class.tslib_menu.php']['filterMenuPages'] is removed, and AbstractMenuFilterPagesHookInterface deprecated. Resolves: #92508 Releases: main Change-Id: I2960e5021b2ba49e1b26e68f2bb0cbed809d60a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72955 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 12 Jan, 2022 8 commits
-
-
Using inline JavaScript when initializing RequireJS modules in individual dashboard widgets has been deprecated. Widget implementations have to be adjusted accordingly. Basically `RequireJsModuleInterface` has to be replaced by `JavaScriptInterface` relying on `JavaScriptModuleInstruction`. Resolves: #96524 Releases: main Change-Id: I5eb74aa54aef6d4f3a9419aaa7e2d391d98ce408 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73002 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Global constants TYPO3_version and TYPO3_branch have been deprecated with introduction of class \TYPO3\CMS\Core\Information\Typo3Version in v9.5.15 and are removed together with some last usages. Resolves: #96523 Related: #96107 Releases: main Change-Id: I0fd90a9f913d83a555a9744117f76d63468a1048 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73000 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Custom FormEngine components loading additional RequireJS modules must use corresponding JavaScriptModuleInstruction instances to declare modules and optional method invocations. Assigning scalar values to FormEngine node section 'requireJsModules' (e.g. used for arbitrary inline JavaScript callbacks) is not possible anymore and will throw a LogicException. Resolves: #96221 Related: #95200 Releases: main Change-Id: I8c487fa3914a46ae1ce2e75db0bf6a59756273d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72485 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
When the "collapse" option in the HMENU ContentObject is activated, any active page links to its actual parent page. This option was never touched since TYPO3 4.0 and stems from the time when TYPO3 still included JSMENU and GMENU_LAYERS functionalities, which is not needed anymore as more modern solutions such as MenuProcessor for Fluid are more-widespread. Resolves: #96517 Releases: main Change-Id: I7f16369efaaeb17cc9d510307df808aefedd5945 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72939 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Christian Kuhn authored
This patch introduces a new EXT:fluid view class "BackendTemplateView" to be used as main view for backend-related non-Extbase views. This class is the base of a new non-Extbase and non-request dependent backend view. The class is for now marked @internal and experimental since we'll probably add a factory to configure backend template overrides for any backend view later-on. A few ViewHelpers are changed to work without accessing the request if enough VH arguments are provided. This is the first patch in a series of patches that will switch from StandaloneView usages in backend controllers to this new BackendTemplateView. Basic strategy: * $view->getRequest()->setControllerExtensionName('SysNote') is removed. This is Extbase-specific and not needed nor wanted for common non-Extbase controllers. * Instantiate the View (for now with makeInstance, will be replaced with a factory later-on) * Set the needed paths via ->setTemplateRootPaths() etc. For these, we *always* use the main extension's entry templating paths, for instance 'EXT:sys_note/Resources/Private/Templates' or 'EXT:sys_note/Resources/Private/Partials'. We do *not* use sub directories here to clear up path logic. * ->assign() / ->assignMultiple() whatever is needed. * ->render('SubDirectory/TemplateName') the actual action / template, no '.html' suffix. As a demo, EXT:sys_note is adapted accordingly which hands over arguments to the above mentioned VH's in a way so these don't access the request object anymore. The sys_note code gets a couple of additional changes so the hooks can prepare request dependent arguments and set them as template variables (here: returnUrl). This patch triggers a hidden gem: Since ViewHelpers no longer receive an Extbase request, they also don't trigger Extbase magic anymore. The casual victim here is f:translate, which has already been prepared to not trigger Extbase's frontend TypoScript parsing if there is no Extbase request. This often improves backend view performance by 25% or more, depending on the amount of frontend TypoScript to parse. Further patches will adapt other core backend routes and will relate to this patch for reference. Change-Id: I4fec3ad690452a00e731c9f6928273048397dd89 Resolves: #96513 Related: #96473 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72966 Reviewed-by:Oliver Bartsch <bo@cedev.de>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: -
Fixes 'Undefined array key "crop"' exception in PHP 8.0/8.1 when rendering an image with enabled clickenlarge and defined cropVariants. Releases: main, 11.5 Resolves: #96508 Change-Id: I47dfdf4a1a8c2d5f8465e84eb93c06ed4bb292ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72965 Tested-by:
core-ci <typo3@b13.com>
Tested-by: -
Oliver Bartsch authored
Instead of using multiple "fake" <option> elements with the same value `--div--`, the SelectMultipleSideBySideElement does now use proper HTML <optgroup> elements for grouping of the available options. This is in line with other select elements, e.g. the SelectSingleElement. Besides the improved HTML markup, this also improves the UI, since the <optgroup> element is non-selectable. It is also no longer considered by the filter, which previously led to confusion, especially when filtering and having the "dividers" as only options left. Resolves: #95137 Releases: main, 11.5 Change-Id: Ia51e2623217eb0c7abd6c0cd2e9c4a742686641d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72992 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Benni Mack authored
Previously, the tstemplate Object Browser would wrongly show hidden typoscript templates, if they were the first one to be found (which determined by the sorting key). The hidden flag will now only be ignored, if a hidden template is explicitly requested by its uid (using the template selector switch). Resolves: #88507 Releases: main, 11.5 Change-Id: Ibbfeb2de7f8ee79a1e343ff23f9d1064219eb344 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63516 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 11 Jan, 2022 7 commits
-
-
Oliver Bartsch authored
With #95387 the menu generation of the page module was moved to the end of the request handling method. However, the `makeActionMenu()` method does currently not only create the menu but does also make some sanity check, whether the currently selected `function` is actually available. If not, the `function` is reset to the default ("columns mode"). This e.g. happens when in languages mode and then switching to another domain / another site, which is single language only. This then led to the user being unable to work in "columns mode", since no action menu is generated for such sites. This is now fixed by executing the mentioned method before the content gets generated. Resolves: #96084 Related: #95387 Releases: main, 11.5 Change-Id: Iadb67ece1724b6d34a4724d7782bdd295cece642 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72971 Tested-by:core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de> -
Benni Mack authored
The path gets htmlspecialchared with linkPageATagWrap() and before that it gets treated within getPathFromPageId() already. This change removes the double encoding. Resolves: #90935 Releases: main, 11.5 Change-Id: I7fd9c1afa4462f5d59618ca5ef760356e5d2fa0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72934 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Benni Mack authored
This change keeps the anchor when clicking on a page in the link browser. Resolves: #93893 Related: #89033 Releases: main, 11.5 Change-Id: I65a876a4fecf508b810e08116810f3cd73e30c19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72935 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Benni Mack authored
The method cObj->getMailTo() is only used in EmailLinkBuilder and its functionality is now moved into this class, as the scope belongs to this class. Resolves: #96500 Releases: main Change-Id: Id051a5889997be7a2115a2a68e223797b5a6431c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72944 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Christian Kuhn authored
When having an extension loaded that specifies a cache without a specific backend like ext:adminpanel, the caching framework falls back to default Typo3DatabaseBackend. The scheduler task "Caching framework garbage collection" does not reflect this and renders an empty entry when no specific backend is configured. Fix this by adding the fallback to the tasks additional field provider, too. Resolves: #96504 Releases: main, 11.5 Change-Id: I985ff3b9888723986e7938238be99e45c1999064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72961 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
NewRecordController (+ icon in doc header of list module) renders "Create a new page" on top. This is not a link and looks misplaced. It is a 'section header' for optional content that can be enabled via pageTS. mod.wizards.newRecord.pages.show.pageSelectPosition = 1 mod.wizards.newRecord.pages.show.pageInside = 1 mod.wizards.newRecord.pages.show.pageAfter = 1 When at least one of these are enabled, the header makes sense, but should be avoided otherwise. Resolves: #96505 Releases: main, 11.5 Change-Id: I6468cda44e719f268f6b59d7e61f240737da6f33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72962 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
The change for issue #94357 introduced handling for `event/` URLs, and accidentally modified handling for `video/` URLs as well. As a result, the `video/` IDs were incorrectly resolved containing a leading slash. Resolves: #96509 Releases: main, 11.5, 10.4 Change-Id: I5623ff59dac44a699877e4e5a2e91707f72a407e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72967 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by:
-
