- 13 Jan, 2022 1 commit
-
-
This change introduces a new PSR-14 event for manipulating menu items in a menu. The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/tslib/class.tslib_menu.php']['filterMenuPages'] is removed, and AbstractMenuFilterPagesHookInterface deprecated. Resolves: #92508 Releases: main Change-Id: I2960e5021b2ba49e1b26e68f2bb0cbed809d60a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72955 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 12 Jan, 2022 1 commit
-
-
When the "collapse" option in the HMENU ContentObject is activated, any active page links to its actual parent page. This option was never touched since TYPO3 4.0 and stems from the time when TYPO3 still included JSMENU and GMENU_LAYERS functionalities, which is not needed anymore as more modern solutions such as MenuProcessor for Fluid are more-widespread. Resolves: #96517 Releases: main Change-Id: I7f16369efaaeb17cc9d510307df808aefedd5945 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72939 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 10 Jan, 2022 1 commit
-
-
Benni Mack authored
Some code in HMENU stems back from TYPO3 v3.x days, and this code aims to streamline the functionality given current functionality. HMENU now has its own sys_page object, which should be used. In addition, HMENU should fetch TSFE->id consistently across all its code base. Resolves: #96492 Releases: main, 11.5 Change-Id: I971a5958417077d51ea5c5070fc4b9ef513cd738 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72936 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 06 Jan, 2022 1 commit
-
-
Benni Mack authored
This change now always checks for the actual page ID in the default language, not of the translated page to see if the page should be excluded. Resolves: #94427 Releases: main, 11.5 Change-Id: I89c67b7955ccb69af28accbcf573576156919481 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72802 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 05 Jan, 2022 2 commits
-
-
Benni Mack authored
The database field "pages.target" allows to define a custom target attribute for links in menus of external URLs. Before this was (wrongly) built in HMENU but applied after Typolink worked. This option belongs to the actual link building when building links to external URLs where $conf[extTarget] is evaluated. In addition, HMENU tests now also evaluate "target" for regular pages as well. Resolves: #96470 Releases: main, 11.5 Change-Id: I3919b6b13666565687e8ff56dcfc867c871837e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72866 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change moves the method resolveShortcutPage() into PageRepository as it is now also used in determining if a page is marked as active / current. The method `resolveShortcutPage()` is much more convenient when working with $page records instead of the properties, instead of `getPageShortcut()`. This also allows MenuProcessor to have a proper "active" and "current" values set properly without any workarounds. Resolves: #85138 Resolves: #80841 Resolves: #87923 Releases: main, 11.5 Change-Id: Ic401fb42696757199c5974120f24250c467d9b75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72860 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 23 Dec, 2021 2 commits
-
-
Benni Mack authored
Previously, HMENU.addQueryString, which is only available for special=language, was applied not within the typolink() functionality but before. By sorting out the properties, HMENU with special=language now properly uses typolinks addQueryString. Using the magic property _ADD_GETVARS to activate this option addQueryString but also using the "_PAGES_OVERLAY_REQUESTEDLANGUAGE" allows to fix special=language issues. Resolves: #94713 Releases: main, 11.5 Change-Id: Ic26e702fb97bb878308de5e1710d2a3c4f28552d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72801 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
There is a difference between > typolink.linkAccessRestrictedPages = 1 (only a toggle) and > HMENU.showAccessRestrictedPages = [pageId]|NONE HMENU.showAccessRestrictedPages behaves like the global option "config.typolinkLinkAccessRestrictedPages" Basically, if a page is access restricted, link to a different {pageId}. This change explains the behavior: -- https://review.typo3.org/c/Packages/TYPO3.CMS/+/35908/ "typolink.linkAccessRestrictedPages" in contrast still links to the actual disallowed page, which is also nice in case you have a 403 error page in place. This change fixes the behaviour of HMENU to behave EXACTLY like the global config.typolinkLinkAccessRestrictedPages, previously HMENU did some magic PLUS it set "typolink.linkAccessRestrictedPages" With this change, shortcuts to access restricted pages now get properly transformed and linked for menus. Resolves: #60258 Resolves: #65118 Related: #63804 Releases: main, 11.5 Change-Id: Ifd975243fe4b024b3fcbd4e356430d809cc0f429 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72796 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 21 Dec, 2021 1 commit
-
-
Benni Mack authored
Currently, HMENU generates the direct destination for a shortcut URL, but typolink does not. This is an inconsistency, and since HMENU is actually using typolink now as well (in 4.x this was different), the resolving of shortcuts can now be moved into the typolink/link building functionality. Page Shortcuts are now resolved (recursively!) at a single point for all links, except for RANDOM_SUBPAGE variants, as this is sorted out during runtime when hitting the RANDOM_SUBPAGE shortcut page. Resolves: #80113 Resolves: #95947 Releases: main, 11.5 Change-Id: Ib6204ff1b0ecb699ec87f5154dc18c974676e65c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71402 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 16 Dec, 2021 2 commits
-
-
Resolves: #96358 Releases: main, 11.5 Change-Id: I36b7ddc31eb3e240c86f3a550d068d7577099f6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72694 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
HMENU special="directory" and special="updated" did not use PageRepository directly, which led to duplicate entries with workspaces. This change does not use "$cObj->exec_..." anymore and fixes all problems. Resolves: #96226 Releases: main, 11.5 Change-Id: I595ac05981d03246eb7671c9ae072f499bff5188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72648 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 09 Dec, 2021 1 commit
-
-
Oliver Bartsch authored
The JavaScript for adding `linkTo_UnCryptMailto` to the `window` got obsolete with the removal of the f:uri.email ViewHelper and is therefore now removed. Resolves: #96202 Releases: main Change-Id: I7c958c6ad80fb654efae52c50afa73fe1786df5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72593 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 03 Dec, 2021 1 commit
-
-
Benni Mack authored
Resolves: #96214 Related: #95351 Releases: main Change-Id: I9581bcbb57e40e75dddcd9ee398d683798067b6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72440 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 13 Nov, 2021 1 commit
-
-
In #89871 (65dc0603) a fix was introduced, that forces the link generation to use the requested language of shortcuts instead of the current language of the frontend. In addition, another call to getPageOverlay was added. This is in fact not necessary, as overlaying is already done implicitly in getPageShortcut. This introduced a falsy behaviour, where shortcuts without the current language available would create a URL with the entry point of the fallback language. This can be fixed by simply using the request language from the original $menuItem variable before processing. Resolves: #94677 Related: #89871 Releases: master, 10.4 Change-Id: I5c9bd0439d821d5516a5cb58cdf53df6b63c3aab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70836 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 10 Nov, 2021 1 commit
-
-
Resolves: #95925 Releases: master Change-Id: I125fcb5e60561646ee8398b0536106a2d5c828ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72103 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 25 Oct, 2021 1 commit
-
-
Christian Kuhn authored
PHP 8.1 emits E_DEPRECATED if second argument to str_replace() is null. Adapt a null coalescence and add a cast to string for TSFE->page['uid'] in AbstractMenuContentObject to avoid this. Change-Id: Iafcf027471b976b160db768b4ada4a9535190319 Resolves: #95773 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71971 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 12 Oct, 2021 2 commits
-
-
These warnings have been fixed by adding a proper fallback where needed. Resolves: #95563 Releases: master Change-Id: I13b42cdc7c910f75de0adc093549438da44d734b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71534 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
The (ugly) statement strpos($haystack, 'needle') !== false can be safely replaced with str_contains($haystack, 'needle'). This is possible, as a symfony polyfill for php 8.0 functions is in place. Resolves: #95466 Releases: master Change-Id: I313f47832a254c23c6815b6b44557a01019e59e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71429 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 11 Oct, 2021 1 commit
-
-
Releases: master Resolves: #95490 Change-Id: I8c7f055182e9a4da8ea5a7a4bd946cc69ce26e0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71455 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- 08 Oct, 2021 2 commits
-
-
The coalesce operator has a relatively low precedence over other operators. If used as part of other expressions, it is almost always necessary to wrap it in parenthesis. Otherwise unexpected behaviour or undefined array key errors (in PHP 8.0) may occur. Resolves: #95482 Releases: master, 10.4 Change-Id: I4ddecdbeab03c215477f77742674ded01bc29257 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71449 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Prevent access to undefined array keys in content renderer and menu objects. Resolves: #95489 Releases: master Change-Id: I1ec4b046478e7e83176e1178153d57a2890b269e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71454 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 05 Oct, 2021 1 commit
-
-
Benni Mack authored
For historical reasons, HMENU created links to external URLs by calling typolink() twice. This is because HMENU did not always use the official typolink() method in the past (TYPO3 4.x/TYPO3 6.x). Because typolink() now provides much more information, the additional round-trip around typolink() can be removed as typolink() already provides this information directly now. Resolves: #95434 Releases: master Change-Id: I72f29220752ce61ebcbb039efbf33796396ba4a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71404 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 04 Oct, 2021 1 commit
-
-
Fixes PHP 8-related array access errors in ContentContentObject and AbstractMenuContentObject. Resolves: #95453 Releases: master Change-Id: Ic618200102720fe515236d2c9c292b684556f9cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71421 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 30 Sep, 2021 1 commit
-
-
Resolves: #95397 Releases: master Change-Id: I088ca979ff75ee0c09dea2be3c9c546a24f47975 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71348 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 28 Sep, 2021 1 commit
-
-
Resolves: #95373 Releases: master Change-Id: I961233104e0f3747aaa67f4e018852824181ee7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71333 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 24 Sep, 2021 2 commits
-
-
The HMENU / TMENU options for opening up links of a menu in a custom JavaScript popup are deprecated. Respective settings: page.123 = HMENU page.123.1 = TMENU page.123.1.JSWindow = 1 page.123.1.JSWindow.params = width=200,height=300,status=0,menubar=0 alternatively this syntax was possible as well: page.123.1 = TMENU page.123.1.target = 200x300 both variants and properties related to JavaScript are now deprecated. Resolves: #95351 Releases: master Change-Id: Iea28a8c8ecd907382cba327cb6c631e8beadfd4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71233 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 17 Sep, 2021 1 commit
-
-
For PHP8 in the frontend there are still undefined key warnings. This is fixed by adding fallbacks. Resolves: #95082 Releases: master Change-Id: I4ef512366aeb3b53adba4e96b07869657415b55d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70867 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 13 Sep, 2021 1 commit
-
-
isSubmenu() produces different results depending on the includeNotInMenu setting, Therefore we need to use separate cache entries. Resolves: #95043 Releases: master, 10.4 Change-Id: I34bdeb1a25606998e07ce2dc8aa366045dc3eefa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70828 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Tina Westner <tina.westner@bgm-gmbh.de> Tested-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Tina Westner <tina.westner@bgm-gmbh.de> Reviewed-by:
Peter Kraume <peter.kraume@gmx.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- 08 Sep, 2021 1 commit
-
-
This change extracts dynamically added frontend JavaScript `openPic` and `linkTo_UnCryptMailto` which are extracted to static file `EXT:frontend/Resources/Public/JavaScript/default_frontend.js`. Mentioned file is loaded automatically as async script element. As a result, view-helper `<f:uri.email>` became obsolete, which is deprecated and considered to be removed with TYPO3 v12.0. Resolves: #95041 Releases: master Change-Id: Ic1a17e11e5acfab4a1e3fe60d921a0ddc647f83e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70827 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org>
-
- 16 Aug, 2021 1 commit
-
-
`ContentObjectRenderer` and `AbstractMenuContentObject` are still relying HTML event attribute `onclick` to open new client window instances, which were (correctly) removed by HTML sanitizer. In order to keep the functionality, exceptional declarations have been added, and `vHWin=window.open(...)` substituted by `openPic(...)`. Resolves: #94866 Releases: master, 11.3, 10.4, 9.5 Change-Id: I961746b3776d12f302933ebb775ab215bdcd85ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70551 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- 04 Aug, 2021 1 commit
-
-
Benni Mack authored
PSR3 ships with a LogLevel class, whereas TYPO3 Core ships its own logging API which is based on a numeric log level syntax. This change reduces the amount of usages of numeric usages of error / message magic (such as TimeTracker), thus, slowly migrating towards PSR3-based LogLevels everywhere. Resolves: #94702 Releases: master Change-Id: I359c88ce50ab94ef1022be975c07f4a7e3c25d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70168 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 29 Jul, 2021 2 commits
-
-
Benni Mack authored
TYPO3 used RelationHandler for HMENU special=list to fetch all pages for this menu once, but fetched the full records again for MountPoint relation, and manual language + workspace overlay was taken care later-on. Once menus were generated with mountpoints and workspace and language overlays, the ordering was not in line, and existing queries were not used. Instead, the code is now simplified and fully relies on PageRepository functionality, just as most other Frontend-related code. Resolves: #94643 Releases: master Change-Id: Ib86116a74c7db6739c474e5efb13b77284e41b08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70112 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org>
-
This change migrates $result->fetch() methods to $result->fetchAssociative() and $result->closeCursor() to $result->free() methods. Since TYPO3 uses fetchMode "associative" by default when setting up the connections, this change is another step towards Doctrine DBAL 3.0 compatibility. Resolves: #94659 Releases: master Change-Id: Idce7c8466925a6e58059e7e16ebc3ffe35ca6fa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70125 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- 23 Jul, 2021 1 commit
-
-
Fix undefined array keys in form, core and indexed_search for the frontend and in extensionmanager. Resolves: #94613 Releases: master Change-Id: I96230feb46f33c9a606a72f765bc79e19d8b28dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70024 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 16 Jul, 2021 1 commit
-
-
Add fallback for undefined array keys in EXT:frontend, EXT:indexed_search, EXT:core. This fixes frontend rendering of a basic site package including all available content elements. Resolves: #94546 Releases: master Change-Id: I051f2d6d0b2278394e95af8eb26be11b3f4aa9a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69819 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- 25 May, 2021 1 commit
-
-
Daniel Goerz authored
* EXT:indexed_search * EXT:impexp * EXT:frontend * EXT:form * EXT:fluid Resolves: #94123 Releases: master Change-Id: I0b39af2080ff993193f3877efe9039135b356a30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69252 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- 27 Apr, 2021 1 commit
-
-
Update phpstan to version 0.12.84 and fix new issues detected by the new version. Releases: master Resolves: #93979 Change-Id: I7546fedf79656561369008765b303cfb9af246d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68850 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- 08 Mar, 2021 1 commit
-
-
TSFE now always contains the Site object so it is not necessary to use the SiteFinder based on the ID to fetch the correct Site anymore, but use TSFE->getSite() directly. Resolves: #93654 Releases: master Change-Id: I2ddd6b0409f73edc4f6fa8f6c7bb0ab21d567272 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68188 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
-
- 10 Feb, 2021 1 commit
-
-
When a shortcut page is used for a translated page, but its parent is not of type shortcut, the generated link would always use the current language of the frontend context instead of the actual required language set in _PAGES_OVERLAY_REQUESTEDLANGUAGE. Resolves: #89871 Related: #81657 Related: #86595 Related: #19114 Releases: master, 10.4 Change-Id: Iaa4e682e2bd79852b5e586b1764fd42ae8676644 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-