Commits · 45ae6943df9ed742abd35e754ec56904e67f71e5 · typo3 / typo3

13 Jan, 2022 1 commit

[!!!][FEATURE] Add new Event for filtering HMENU items · 45ae6943

Benni Mack authored Jan 10, 2022 and

Georg Ringer committed Jan 13, 2022

This change introduces a new PSR-14 event for manipulating
menu items in a menu.

The hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/tslib/class.tslib_menu.php']['filterMenuPages']
is removed, and AbstractMenuFilterPagesHookInterface deprecated.

Resolves: #92508
Releases: main
Change-Id: I2960e5021b2ba49e1b26e68f2bb0cbed809d60a7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72955

Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>

45ae6943

12 Jan, 2022 2 commits

[!!!][TASK] Remove HMENU.collapse option · 5547a732

Benni Mack authored Jan 10, 2022 and

Christian Kuhn committed Jan 12, 2022

When the "collapse" option in the HMENU ContentObject
is activated, any active page links to its actual parent
page. This option was never touched since TYPO3 4.0
and stems from the time when TYPO3 still included JSMENU
and GMENU_LAYERS functionalities, which is not needed anymore
as more modern solutions such as MenuProcessor for Fluid
are more-widespread.

Resolves: #96517
Releases: main
Change-Id: I7f16369efaaeb17cc9d510307df808aefedd5945
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72939

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

5547a732

[TASK] ClickEnlargeViewhelper PHP 8.0/8.1 compatibility · 3c76b9e0

dev-rke authored Jan 11, 2022 and

Christian Kuhn committed Jan 12, 2022

Fixes 'Undefined array key "crop"' exception in PHP 8.0/8.1
when rendering an image with enabled clickenlarge and defined
cropVariants.

Releases: main, 11.5
Resolves: #96508
Change-Id: I47dfdf4a1a8c2d5f8465e84eb93c06ed4bb292ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72965

Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

3c76b9e0

11 Jan, 2022 2 commits

[TASK] Deprecate cObj->getMailTo · 27940f08

Benni Mack authored Jan 10, 2022

The method cObj->getMailTo() is only used in EmailLinkBuilder
and its functionality is now moved into this class,
as the scope belongs to this class.

Resolves: #96500
Releases: main
Change-Id: Id051a5889997be7a2115a2a68e223797b5a6431c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72944

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

27940f08

[!!!][TASK] Remove config.spamProtectEmailAddresses = ascii · f79a3299

Benni Mack authored Jan 07, 2022

Since modern browsers already decode this "security"
measure, the option config.spamProtectEmailAddresses = ascii
is removed from TYPO3 Core.

Existing installations having the option set to "ascii"
will now behave as this option would be set to "0" (= disabled).

Resolves: #90044
Releases: main
Change-Id: I7fb4266e998ce7f2555f46e6c3ea216745ca54b6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72908

Tested-by: Stefan Froemken <froemken@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

f79a3299

10 Jan, 2022 3 commits

[BUGFIX] Correctly apply config.absRefPrefix to _assets resources · 16d97a0d

Oliver Hader authored Jan 10, 2022 and

Oliver Hader committed Jan 10, 2022

When using a composer-based installation, public frontend assets
such as JavaScript of stylesheet files are exposed in a dedicated
`_assets/` folder. In those scenarios TypoScript settings for
`config.absRefPrefix` need to be applied as well.

Resolves: #96452
Releases: main, 11.5
Change-Id: I0695850be18c9c152c647883c122a0680e8e734f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72952

Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>

16d97a0d

[TASK] Unify TSFE usage consistently in HMENU · 7b9ad91d

Benni Mack authored Jan 09, 2022

Some code in HMENU stems back from TYPO3 v3.x days,
and this code aims to streamline the functionality
given current functionality.

HMENU now has its own sys_page object, which should
be used. In addition, HMENU should fetch TSFE->id
consistently across all its code base.

Resolves: #96492
Releases: main, 11.5
Change-Id: I971a5958417077d51ea5c5070fc4b9ef513cd738
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72936

Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

7b9ad91d

[TASK] Clean up Page Link Builder code · 332ecefe

Benni Mack authored Jan 07, 2022

During the main work of TYPO3 v9 when Site Handling
was introduced, the Page Link Builder turned into
a single monster-method.

Now, that most bugs are solved and we have a very good
test coverage for this, this change splits several
functionality into smaller methods, allowing for better
readability, extensibility and further refactoring.

Extending PageLinkBuilder now is much easier to replace
a certain part of the existing functionality (also via XCLASS).

Resolves: #96484
Releases: main, 11.5
Change-Id: I231cf3c13ec15dd1ad99f710ca27ce340c0deee2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72898

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

332ecefe

08 Jan, 2022 1 commit

[TASK] Remove redundant @var tags · 1ac8bbdc

Nikita Hovratov authored Jan 07, 2022 and

Christian Kuhn committed Jan 08, 2022

The type can already be inferred from the source
code.

The cleanup was run automatically with a
PHPStorm plugin.

Resolves: #96482
Releases: main
Change-Id: I669145adc66dc898f3016de1958cf0105c988243
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72907

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

1ac8bbdc

06 Jan, 2022 4 commits

[BUGFIX] TypoLink is executed fully without href attribute · b72d3fd5

Benni Mack authored Jan 06, 2022

In #87992 an early return was added to have <a> tags
with just an "id" or "name" attribute. This is all nice,
but when used further typolink settings (such as userFunc
or custom "title"), these options were never run.

This change now uses typolink() natively again and
removes the introduced "resolveAnchorLinK" workaround.

Added tests show that additional attributes are executed
and links without href are actually created (was previously
untested).

Resolves: #96464
Related: #87992
Releases: main, 11.5
Change-Id: I67d4090228684fc89f72bc3d6367109437040ccf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72894

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

b72d3fd5

[BUGFIX] Ensure config.spamProtectEmailAddresses = ascii works for external URLs · 34b13837

Benni Mack authored Jan 06, 2022

When having a page of type "External URL", set to
an email address, and config.spamProtectEmailAddresses = ascii
set in TypoScript, the encoding now works properly.

Resolves: #87787
Releases: main, 11.5
Change-Id: I15563f08a8a0007dc292f5d7e1a311e38a55db26
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72893

Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

34b13837

[BUGFIX] Use typolink consistently for makelinks functionality · 90c2181b

Benni Mack authored Jan 06, 2022

TYPO3's "makelinks" functionality parses for in-text
external URLs and mailto links. This change uses
Typolink under the hood now to consistently check
for invalid content, and have the chance to use
all hooks in typolink for such links as well.

This way, typolink is used, but makelinks is
executed AFTER possible resolved <a> tags
avoiding double-calling parseFunc when <a> tag
processing is configured.

Resolves: #93012
Releases: main, 11.5
Change-Id: I574915e715793f6eccad1bdfc216e82e329179dd
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72871

Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

90c2181b

[BUGFIX] Check for excludeUidList in HMENU of default language · 3b54b044

Benni Mack authored Dec 23, 2021

This change now always checks for the actual page ID
in the default language, not of the translated page
to see if the page should be excluded.

Resolves: #94427
Releases: main, 11.5
Change-Id: I89c67b7955ccb69af28accbcf573576156919481
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72802

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

3b54b044

05 Jan, 2022 3 commits

[TASK] Ensure that hidden pages are not rendered as subpages in HMENU · fbc9e887

Benni Mack authored Jan 05, 2022 and

Oliver Bartsch committed Jan 05, 2022

This change adds tests to a very old issue to ensure
that a page with only hidden subpages is not marked
as IFSUB etc.

MenuProcessor is extended to set a "hasSubpages" flag
when IFSUB, CURIFSUB or ACTIFSUB is set.

Resolves: #22190
Releases: main, 11.5
Change-Id: Ia9b73e8ae1028eafa94ba4fa5ca0dacf2562c074
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72868

Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

fbc9e887

[BUGFIX] Use "pages.target" properly for Pages with External URL · 361bb8c3

Benni Mack authored Jan 05, 2022

The database field "pages.target" allows to define
a custom target attribute for links in menus of external
URLs.

Before this was (wrongly) built in HMENU but applied
after Typolink worked. This option belongs to the
actual link building when building links to external URLs
where $conf[extTarget] is evaluated.

In addition, HMENU tests now also evaluate "target"
for regular pages as well.

Resolves: #96470
Releases: main, 11.5
Change-Id: I3919b6b13666565687e8ff56dcfc867c871837e2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72866

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

361bb8c3

[BUGFIX] Mark shortcut pages as active in HMENU · fc6cf2c9

Benni Mack authored Jan 04, 2022

This change moves the method resolveShortcutPage()
into PageRepository as it is now also used in determining
if a page is marked as active / current.

The method `resolveShortcutPage()` is much more convenient
when working with $page records instead of the properties,
instead of `getPageShortcut()`.

This also allows MenuProcessor to have a proper "active"
and "current" values set properly without any workarounds.

Resolves: #85138
Resolves: #80841
Resolves: #87923
Releases: main, 11.5
Change-Id: Ic401fb42696757199c5974120f24250c467d9b75
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72860

Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

fc6cf2c9

04 Jan, 2022 1 commit

[BUGFIX] Do not overwrite previously set preview mode · 03c0c741

Susanne Moog authored Jan 02, 2022 and

Christian Kuhn committed Jan 04, 2022

The frontend preview aspect may be set from the admin panel
or the frontend extension or even from a third-party extension
in a middleware. The previous implementation overwrote the preview
settings on every initialisation, resulting in lost preview
information. Instead of overwriting the setting, this change takes
the current preview value into account - if the preview was enabled
by a previous instance this is kept.

Additionally, the logic to set the preview flag in both frontend
and admin panel has been streamlined.

Resolves: #91225
Releases: main, 11.5
Change-Id: I9f642bca1928638cac5eb5c1468710f5fad28137
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72825

Tested-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

03c0c741

03 Jan, 2022 1 commit

[BUGFIX] Allow rendering of subpages for spacers · 21addb0b

Benni Mack authored Dec 28, 2021 and

Oliver Bartsch committed Jan 03, 2022

If rendering of spacer pages in an HMENU is explicitly
given via SPC = 1, then subpages of pages are now rendered
as well.

This way, there is no difference between spacers and other
page types for submenu rendering anymore.

Resolves: #64428
Releases: main, 11.5
Change-Id: Ic4bc2661399498de61af486712ade85815ffa529
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72807

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

21addb0b

23 Dec, 2021 5 commits

[BUGFIX] Be consistent in HMENU.special = language · 3698b492

Benni Mack authored Dec 23, 2021

Previously, HMENU.addQueryString, which is only
available for special=language, was applied
not within the typolink() functionality but before.

By sorting out the properties, HMENU with
special=language now properly uses typolinks
addQueryString.

Using the magic property _ADD_GETVARS to activate
this option addQueryString but also using
the "_PAGES_OVERLAY_REQUESTEDLANGUAGE" allows
to fix special=language issues.

Resolves: #94713
Releases: main, 11.5
Change-Id: Ic26e702fb97bb878308de5e1710d2a3c4f28552d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72801

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

3698b492

[BUGFIX] Do not link to untranslated records · ab9aa327

Mathias Brodala authored Dec 21, 2018 and

Benni Mack committed Dec 23, 2021

This only fixes the issue for dedicated record links. Page links with
added query arguments can still lead to broken links.

Resolves: #87260
Releases: main, 11.5
Change-Id: Ib13aa1925de6463688e2b50612ce7b2820733ce7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59257

Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>

ab9aa327

[BUGFIX] Resolve shortcuts in HMENU to access restricted pages · 82d33fc2

Benni Mack authored Dec 22, 2021

There is a difference between

> typolink.linkAccessRestrictedPages = 1 (only a toggle)
and
> HMENU.showAccessRestrictedPages = [pageId]|NONE

HMENU.showAccessRestrictedPages behaves like
the global option "config.typolinkLinkAccessRestrictedPages"

Basically, if a page is access restricted, link
to a different {pageId}.

This change explains the behavior:
-- https://review.typo3.org/c/Packages/TYPO3.CMS/+/35908/

"typolink.linkAccessRestrictedPages" in contrast
still links to the actual disallowed page, which
is also nice in case you have a 403 error page in place.

This change fixes the behaviour of HMENU to behave
EXACTLY like the global config.typolinkLinkAccessRestrictedPages,
previously HMENU did some magic PLUS it set
"typolink.linkAccessRestrictedPages"

With this change, shortcuts to access restricted pages
now get properly transformed and linked for menus.

Resolves: #60258
Resolves: #65118
Related: #63804
Releases: main, 11.5
Change-Id: Ifd975243fe4b024b3fcbd4e356430d809cc0f429
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72796

Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

82d33fc2

[BUGFIX] Avoid undefined array key in TextMenuContentObject->writeMenu() · f8d021c8

Chris Müller authored Dec 22, 2021 and

Benni Mack committed Dec 23, 2021

Resolves: #96377
Releases: main, 11.5
Change-Id: I98dfe39cf04468d54ee979afa34e7dd3bd40acf6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72793

Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>

f8d021c8

[BUGFIX] Avoid undefined array key in ContentObjectRenderer->getTypoLink() · 93e1f9ec

Chris Müller authored Dec 22, 2021 and

Benni Mack committed Dec 23, 2021

Resolves: #96418
Releases: main, 11.5
Change-Id: I00b77f478c667f59b751c6f13c975d03799086d7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72792

Tested-by: core-ci <typo3@b13.com>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>

93e1f9ec

21 Dec, 2021 4 commits

[BUGFIX] Avoid undefined array key warnings in DatabaseRecordLinkBuilder · 529b3af9

Chris Müller authored Dec 21, 2021 and

Benni Mack committed Dec 21, 2021

Resolves: #96420
Releases: main, 11.5
Change-Id: Ida1b27956bfe759062904ee9d0c8246ea73f0667
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72763

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

529b3af9

[BUGFIX] Avoid PHP8 warning for "Insert records" with hidden records · 8c393e64

Chris Müller authored Dec 21, 2021 and

Benni Mack committed Dec 21, 2021

When one or more hidden records are referenced in an "Insert records"
content element, an "undefined array key" warning was thrown.

Resolves: #96419
Releases: main, 11.5
Change-Id: I4f90dc78540bf8c56163cfb8247a13c86869fbe1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72762

Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

8c393e64

[BUGFIX] Use generated TSFE in PageLinkBuilder · d2935594

Andreas Fernandez authored Nov 27, 2021

If the PageLinkBuilder is invoked with a non-available TSFE as e.g. in
the "Redirects" module, generating the URLs to pages with a fragment,
e.g. to a referenced content element, works now as we're using the
TSFE generated within PageLinkBuilder itself.

Resolves: #96101
Releases: main, 11.5
Change-Id: I481b7d8573424dab59df22b0d81a734e03b70575
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72323

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

d2935594

[BUGFIX] Resolve shortcuts in typolink directly · d5c7a963

Benni Mack authored Oct 01, 2021

Currently, HMENU generates the direct destination for
a shortcut URL, but typolink does not. This is an
inconsistency, and since HMENU is actually using typolink
now as well (in 4.x this was different), the resolving
of shortcuts can now be moved into the typolink/link building
functionality.

Page Shortcuts are now resolved (recursively!) at a single point for
all links, except for RANDOM_SUBPAGE variants, as this is sorted
out during runtime when hitting the RANDOM_SUBPAGE shortcut page.

Resolves: #80113
Resolves: #95947
Releases: main, 11.5
Change-Id: Ib6204ff1b0ecb699ec87f5154dc18c974676e65c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71402

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

d5c7a963

18 Dec, 2021 1 commit

[BUGFIX] Avoid exception in ContentObjectRenderer with PHP8 · b552afaf

Torben Hansen authored Dec 18, 2021 and

Benni Mack committed Dec 18, 2021

This patch ensures that the getQuery() function only uses the
minus operator to negate the $storagePid variable, if the variable
can be interpreted as an integer.

Resolves: #96321
Releases: main, 11.5
Change-Id: Idacd43fd6639218fc1126bffcd43e78338f18e0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72704

Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Benni Mack <benni@typo3.org>

b552afaf

16 Dec, 2021 3 commits

[BUGFIX] Do not render hidden pages in HMENU list · 8237e56c

Benni Mack authored Dec 16, 2021 and

Oliver Bartsch committed Dec 16, 2021

Resolves: #96358
Releases: main, 11.5
Change-Id: I36b7ddc31eb3e240c86f3a550d068d7577099f6e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72694

Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

8237e56c

[BUGFIX] Ensure getTreeList() keeps ordering of subpages · a26f9d16

Benni Mack authored Dec 09, 2021

Resolves: #96310
Releases: main, 11.5
Change-Id: Ie12ca1683b3d8668deafbd37af03437f047c0ac4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72599

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

a26f9d16

[BUGFIX] Avoid duplicate results in HMENU with workspaces · 76b5de17

Benni Mack authored Dec 15, 2021

HMENU special="directory" and special="updated" did not
use PageRepository directly, which led to duplicate
entries with workspaces.

This change does not use "$cObj->exec_..." anymore
and fixes all problems.

Resolves: #96226
Releases: main, 11.5
Change-Id: I595ac05981d03246eb7671c9ae072f499bff5188
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72648

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

76b5de17

15 Dec, 2021 1 commit

[BUGFIX] Always return a string for PHP 8.1 · 8c7227c1

Chris Müller authored Dec 14, 2021 and

Benni Mack committed Dec 15, 2021

The following deprecation occurred in PHP 8.1:
PHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated.

This happens in various places:
* Using stdWrap_field() or in stdWrap() places
* BackendUtility (e.g. new IRRE elements)
* ExtensionManager

Resolves: #96354
Releases: main, 11.5
Change-Id: Ie5c721784b51ed5493c8d9e1d557b08611263f6b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72659

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

8c7227c1

11 Dec, 2021 1 commit

[TASK] Remove leftover TSFE factory method · 6c6cb054

Nikita Hovratov authored Dec 11, 2021 and

Benjamin Franzke committed Dec 11, 2021

Since the removal of the container entry, the
factory method
TypoScriptFrontendController->getGlobalInstance() is
obsolete.

Resolves: #96338
Related: #96273
Releases: main
Change-Id: Ib8c973acb240cac0c7f18c10fbc801585b7c70b7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72635

Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>

6c6cb054

10 Dec, 2021 4 commits

[BUGFIX] Allow shortcut pages to pages of other sites · 0fe66dcc

Benni Mack authored Aug 10, 2021

TYPO3 has had a long history of linking to
other pages in other pagetrees. Most of the issues
were solved with the TYPO3 v9 Routing and Site Handling.

Through this feature, it is now possible to
easily create a page of type shortcut and link to
a page in a different page tree.

This was previously not possible because TYPO3 Core
by default generated URLs like "/index.php?id=123"
where people could simply add ?id=355 (where page 355
resides on a different page tree).

Since this change has been resolved, links to
other pages can be allowed and are automatically
redirected.

If we ever get rid of allowing to call pages with
an `?id=123` query parameter, the $pageNotFound=3 case
can be removed completely.

Resolves: #92859
Resolves: #92750
Releases: main, 11.5
Change-Id: I16ccc3e5b0ccb1419ccd2a8d78443616e7627a33
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

0fe66dcc

[TASK] Remove undocumented setting page.pageHeaderFooterTemplateFile · a7034bb0

Benni Mack authored Dec 10, 2021

The TypoScript option "page.pageHeaderFooterTemplate" is removed.

It was introduced in TYPO3 4.5, but never documented,
and is actually overridden by the option "config.pageRendererTemplateFile"
which IS documented, which was also introduced during TYPO3 4.x times.

Both options behave the exact same way.

Resolves: #96322
Releases: main
Change-Id: Ifeec8faec7f28121f3135838bcaa82cac461cb60
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72612

Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>

a7034bb0

[BUGFIX] Lower log level of TSFE->set_no_cache in preview mode · fd2eed45

Rémy DANIEL authored Dec 09, 2021 and

Benni Mack committed Dec 10, 2021

If TSFE->set_no_cache is called, either a warning or a notice is triggered,
depending if a BE user is connected or not.
With this change, the preview mode will trigger a notice instead of a warning.

This restores the same behaviour than before #86002.

Resolves: #96306
Releases: main, 11.5, 10.4
Change-Id: I40b9b1d90d42f14de2977aca61c24a9fd698ced0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72596

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

fd2eed45

[!!!][TASK] Require LinkResultInterface for generating typolinks · e1e71784

Benni Mack authored Dec 09, 2021 and

Oliver Bartsch committed Dec 10, 2021

The abstract AbstractTypolinkBuilder class change now
requires all subclasses to require a LinkResultInterface.

Resolves: #96317
Related: #94889
Releases: main
Change-Id: Ic914373fe3ca744a4b96cf470d44f3abae5df6d4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72611

Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

e1e71784

09 Dec, 2021 2 commits

[!!!][TASK] Make PSR-7 ServerRequest object required for arguments · f6718568

Benni Mack authored Dec 09, 2021

This change modifies various places to always have
a valid PSR-7 Request object handed in.

Previously this was optional as part of the backwards-compatibility
in TYPO3 v11.

Resolves: #96318
Releases: main
Change-Id: Idf46dec219cdbbdc97fbe745240770b364ecb38b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72601

Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>

f6718568

[BUGFIX] Followup: Remove unused linkTo_UnCryptMailto JavaScript · 7a019675

Oliver Bartsch authored Dec 09, 2021

The JavaScript for adding `linkTo_UnCryptMailto`
to the `window` got obsolete with the removal of
the f:uri.email ViewHelper and is therefore now
removed.

Resolves: #96202
Releases: main
Change-Id: I7c958c6ad80fb654efae52c50afa73fe1786df5f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72593

Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

7a019675

07 Dec, 2021 1 commit

[!!!][TASK] Remove $severity argument in ErrorPageController · 089c400f

Oliver Bartsch authored Dec 07, 2021

The argument got unused with #95463
and is therefore now removed.

Resolves: #96278
Related: #95463
Releases: main
Change-Id: I6f964a65b8e3fcdeeb3b0867a1a55807ceb78345
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72548

Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

089c400f