- 04 Jan, 2021 11 commits
-
-
The words FullyScanned, PartiallyScanned and NotScanned must not have any leading or trailing characters when on the last line of an ReST file for breaking changes or deprecations. Resolves: #93208 Releases: master, 10.4 Change-Id: I4a8f0e7cf61cc885df3566e2fb4621c80d82f744 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67332 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Kuhn authored
The security fix related to better hashed sessions had fallbacks to deal with existing non hashed sessions. This was for a smooth transition in security patch level releases. The patch drops these fallbacks in master. Resolves: #93140 Releases: master Change-Id: I68172fd26619d93068fc6a2490134bfb9b8a204e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67223 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
The patch for #93131 increased the db size of field ses_id in tables fe_sessions and be_sessions from 32 to 255 chars. The field is the tables primary key. With mysql/mariadb, if the table is created on an older db engine version that creates innodb tables with COMPACT row format using utf8_mb4 charset, the key length now exceeds the COMPACT maximum index length restrition of 767 bytes: 4*255+1 = 1021 bytes Since we don't strictly need a varchar(255), the patch reduces the field to 190, which does not collide with maximum key length restrictions: 4*190+1 = 761 bytes Change-Id: Ifc344a68a49ce0b863109cbfe8a7d27c0179c0cf Resolves: #93150 Related: #93131 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67336 Tested-by:
-
Remove jQuery dependency, avoid inline javascript and encapsulate initialization into a web component. Also use "codemirror" as import name, as that's what the npm package name is, and will eventually allow to make use of TypeScript typings. Releases: master Resolves: #93149 Change-Id: Ia85784b21a90e1986ea6ba7a915e032aa7963d92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67185 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
With #93135, selectMultipleSideBySide fields broke and didn't accept new values as both select fields share the same `data-formengine-input-name` which confuses the changed CSS selector. This patch removes the attribute from the "value provider" fields as it's not required there at all and also adapt FormEngine to not use the styling related form-select class. Resolves: #93213 Resolves: #93214 Related: #93135 Releases: master Change-Id: I2cf4ad6ff4d78072bf5474d7393ad4eb7f771070 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67335 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
With Bootstrap 5, <select> fields make use of the class `form-select`. This patch aims to replace every occurrence of `form-control` used with select fields. Since Bootstrap finally brings proper styling for select boxes, the custom implementation rendering chevrons can be removed. In the same run, the `input-$size` classes are migrated to its new class names and some obsolete classes have been removed. Resolves: #93135 Releases: master Change-Id: I0044127cc380bddfbaec0b9f730123959f7288bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67247 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
-
The setting $GLOBALS['TYPO3_CONF_VARS']['GFX']['colorspace'] is deprecated since TYPO3 8.0 and is now replaced with $GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_colorspace'] Since the hint now is too long, a manual linebreak has been added to avoid the automatic linebreak which adds a minus char to the processor_colorspace text. Resolves: #92707 Releases: master, 10.4, 9.5 Change-Id: I5f55f01df8af47eca4d32ae8fa9c7262302bf32f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66285 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Running a clean installation minimal setup throws a lot of "PHP Notice: Undefined index: " notices. This commit removes the ones from the frontend. Resolves: #91116 Releases: master, 10.4 Change-Id: I1f81150ed48ae170682d68d1169c1de2963e0021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64238 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
There is no global variable named REQUEST_TYPE, it is called TYPO3_REQUEST. Releases: master Resolves: #93206 Related: #92947 Change-Id: I86d3c2f8306744f41cfa504f4a42490f4b8eaa6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67330 Tested-by:
-
Make all the necessary changes to classes used during the first installation to run on PHP 8 Resolves: #93205 Releases: master, 10.4 Change-Id: I93f64b2848e4cea76a4f36d11d394cb09fd8301c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67227 Tested-by:
-
Because the method (finally) is deprecated in PHP 8, all calls in TYPO3 Core are wrapped in if statements to avoid deprecation warnings. PHP 8 effectively is more secure by default, which is a good thing, but we need to consider this in our code base, which still supports PHP 7 as well. Resolves: #93204 Releases: master, 10.4 Change-Id: I18d7e76e3de5cf48cd4c3cab0d68dea4e518f674 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67329 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- 03 Jan, 2021 1 commit
-
-
Georg Ringer authored
By defining `$hreflang` of SiteLanguage to an empty string instead of 'en-US' wrong hreflang tags are avoided in the frontend. Even though the field is set to required there are usecases where this field is not set, e.g. by changing the site configuration manually. This would have lead to hreflang tags pointing to a valid site but with a wrong hreflang information. Resolves: #92418 Releases: master Change-Id: I042c275a2b107cac48a877c7e4043f69e378347d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65888 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- 01 Jan, 2021 4 commits
-
-
Richard Haeser authored
In some edge cases you may want to disable or change the rendering of the hreflang tags. We added some hints how to deal with such cases. Resolves: #91353 Releases: master, 10.4 Change-Id: Id9ea8a0206cd9df1522d790c2cad93e2ab41afbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67315 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Benni Mack authored
A few dependencies now have PHP8 support and PHP 7.2 support, which we then update to the latest versions, also for v10.4. Updated dev-dependencies: * composer req "phpspec/prophecy:^1.12.2" --dev --with-all-dependencies * composer req "friendsofphp/php-cs-fixer:^2.17.3" --dev --with-all-dependencies * composer req "phpstan/phpstan:^0.12.64" --dev --with-all-dependencies * composer req "phpunit/phpunit:^8.5.13" --dev --with-all-dependencies Non-dev-dependency updates: * composer req "nikic/php-parser:^4.10.4" Also fix an undefined variable error that was introduced in #92497 and has now been discovered by the updated phpstan version. Resolves: #93201 Releases: master, 10.4 Change-Id: Ic8839606ea05a0825a6e518dd644655ecc7c578e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67324 Tested-by:
-
Releases: master, 10.4 Resolves: #93199 Change-Id: I774992a5aee0d51249853dee80f18ade99247ac9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67322 Tested-by:
-
d3 is currently manually patched to avoid a d3.request()/d3.json() bug in chome >= 64 – see #83741. The patch has not been merged in two years, and d3.request is deprecated, so it is now replaced. This will also help to upgrade to D3.js v5/v6 at some point. This allows to use an unpatched, vanilla D3.js build again. While at it, we also streamline the contrib path to avoid the unecessary d3/ subdirectory. Commands used: grunt build Resolves: #93186 Related: #83741 Releases: master Change-Id: I142462272b03edc53c33b2b7233d1902911fc837 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67313 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 29 Dec, 2020 5 commits
-
-
Loading the module menu on any page caused a JavaScript error. The fix prevents this by checking if the necessary HTML for the module menu is found in the HTML. Resolves: #91913 Releases: master Change-Id: I7d52b82706a06215583794b7bb4f9ffe44e3711a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67254 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
The module ImmediateActionElement is used to render a defined custom HTML tag triggering certain actions once it's rendered, like reloading the module menu or the backend's topbar. To achieve this, it needs functionality from the modules TYPO3.ModuleMenu.App.refreshMenu and TYPO3.Backend.Topbar.refresh. This module is loaded at a very early stage where those dependencies cannot do anything meaningful as there is nothing to do, namely the backend login, which causes JavaScript warnings and increases loading time. To relax the situation, the modules are now loaded dynamically when required by using async functions. In a perfect world, there would be some kind of a hooking system and no hardcoded list of actions, but we're not there, yet. Resolves: #92350 Releases: master, 10.4 Change-Id: I50029789f564ce339b3204d51f61e4cc39bb3cf9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65795 Tested-by:
-
Probably since ever, FormEngine validates the whole form when a field changed or an IRRE item got removed. This patch introduces the following changes: - only fields affected by the `change` event get validated - FormEngineValidation.validate() accepts an optional argument to define the container whose fields get validated. If omitted, the whole form is validated. Resolves: #93046 Releases: master, 10.4 Change-Id: I48d2f597c88815ebc0374bb02cf0aed6ac4086fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67094 Tested-by:
-
With this change, most of the jQuery-based code is migrated to either native APIs or substitutes provided by TYPO3. The ContextMenu is not touched here as the base implementation heavily relies on jQuery. Resolves: #93164 Releases: master Change-Id: Ie316837a00f1c497ef6028a46e1b00004ae4e09a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67246 Tested-by:
-
Also fix double-border when table-fit class is nested in a legacy panel (e.g. file list). Releases: master Resolves: #93161 Change-Id: Ia72e0ee452b2070edd9e0adbdc1636e45b3d7e35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67244 Tested-by:
-
- 23 Dec, 2020 1 commit
-
-
The AbstractRequestHandler was an abstract class which didn't add any helper method at all, concrete implementations did benefit from. In fact, it even implemented a contract method, which should notbe done by an abstract class but only by specific implementations. Besides that, only DI methods had been shared which also just hides the dependencies of the specific implementations. Releases: master Resolves: #93157 Change-Id: Ib054f9435e7fa3937e5250bfce62b210c1cbb4e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67219 Tested-by:
-
- 22 Dec, 2020 12 commits
-
-
To avoid annoying scroll when a lot of items are rendered, add the action buttons also above the list. Resolves: #92980 Releases: master, 10.4 Change-Id: I47c351352d2a0d7e3a1bc2ee8d53a5d1ad04eb67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66970 Tested-by:
Marcus Schwemer <ms@schwemer.de> Reviewed-by:
-
The text color of EXT:viewpage module options has got the necessary contrast again. Furthermore the duplicated "arrow-down" indicator removed, and the dropdown menu is adapted for bootstrap 5 markup to fix padding of dropdown items. Also a proper focus and hover state is added. Resolves: #93151 Releases: master Change-Id: I13feacac9d62a62d6d6de84556dcde0eef198913 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67240 Tested-by:
-
Brings v11 compatibility. composer require --dev friendsoftypo3/phpstan-typo3 ^0.6.0 Resolves: #93156 Releases: master Change-Id: I3b6e94a95c1880f0af0a447e441eb0f64fc4d522 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67242 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Benni Mack authored
Change-Id: I5a4c629d4e4b81bb74fac9b6116436e5e913384d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67239 Tested-by:
-
Adds the new parameter in ArrayObject::asort for PHP 8. As an additional parameter it's backwards-compatible with PHP 7.4. Resolves: #92141 Related: #92138 Releases: master Change-Id: I691bad5f19457b7456da1e624cf7289538317495 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67226 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
The form upgrade wizard skips a form content element if it has broken flexform data. Reasons for broken flexform data: * There is no data other than a base XML-structure * The data is invalid XML Resolves: #93146 Releases: master, 10.4 Change-Id: I1c2d9f9bf0a6e32a6d4051084c71306465e470c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67233 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Since the EXT:beuser module filter contains of a couple of filter options, which are not automatically reset on leaving the module, because they are stored in the user uc, one had to change every option manually to reset the whole filter. Therefore, a new button is now introduced, which allows to reset the whole filter at once. Resolves: #93117 Releases: master Change-Id: I38d49749ef461d4c2f81957a85ca93290fcad019 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67190 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Benni Mack authored
Change-Id: Ibcf3165f1628bec14ee50aaa601606ae37977f0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67238 Tested-by:
-
Remove background of card header and bottom/top border of card header/footer so the style does not change from TYPO3 v10 to v11. Also re-add checkbox-type-toggle absolute positioning of the hidden checkbox in order to avoid upper spacing above checkbox toggle elements (causes too much spacing in feature cards). Resolves: #93120 Releases: master Change-Id: Ibd2e87c4e4284218390c4e8d0722fcdee87de92f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67231 Tested-by:
-
Resolves: #93148 Related: #93104 Releases: master Change-Id: I27a501b01e483f6e51d3e0512f8aa92a99ce18e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67237 Tested-by:
-
This patch removes unused code in the persistence area of Extbase. Most removed code was part of internal classes and interfaces, thus they are removed without notice. Along with the removal of methods, two methods have been marked deprecated and for their removal in the future i.e. TYPO3 12.0. Releases: master Resolves: #89938 Change-Id: I66596bff9879a6850a71ada05891f80a551ffb74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62616 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
The installation process now uses floating inputs, and sorts the yellow box on step 4 properly. Resolves: #93147 Releases: master Change-Id: I89483171a0d58305d39cb4f75be642e89af16f55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67232 Tested-by:
Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by:
-
- 21 Dec, 2020 6 commits
-
-
Brings styleguide 11.0.2, which is hopefully deprecation free with core v11. composer require --dev typo3/cms-styleguide ~11.0.2 Resolves: #93145 Releases: master Change-Id: Ic02ac8cce63247a5fffc0ad59ae33b3e9a047b2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67230 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Christian Kuhn authored
When extbase controller action don't return a ResponseInterface, a deprecation log is raised: "Controller action TYPO3\CMS\Extbase\Mvc\Controller\ActionController:: does not return ..." Using late static binding and proper action name resolving changes this to a much more helpful message: "Controller action TYPO3\CMS\Styleguide\Controller\StyleguideController->tabAction does not return ..." Resolves: #93144 Related: #92784 Releases: master Change-Id: Ife9acd9dcf9e076eea617c31e7720304c59db75a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67228 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
After the merge of #93104 one more patch with a changelog documentation file was merged. This file now also needs to join it's peers in the 11.0 folder. Resolves: #93143 Related: #93104 Releases: master Change-Id: I0dabd352ae9e8d141dcadbb6d7e02562f2e27c20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67225 Tested-by:
-
The (standalone) install tool login screen content is now correctly aligned. The sudo mode confirmation modal now has the correct backdrop opacity again. Resolves: #93142 Releases: master Change-Id: Id8e3926b58ce905380ecabb0fcf629afbae995b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67224 Tested-by:
-
This reverts commit 844f024a due to some unexpected behaviour when cropping and scaling, see #93090 and related issues in https://forge.typo3.org/issues/91855 for details Change-Id: If3f38cfeeb860e1a13648d239f05d2754f2f9102 Resolves: #93139 Revertes: #91855 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67202 Reviewed-by:
-
When deleting a record in workspaces that has been changed in comparison to live - if it is a new, a moved or a changed workspace record, those records where subject to the 'soft-delete' strategy of the core: Soft-delete enabled tables like pages or tt_content did set deleted=1 for those records instead of fully deleting them from the table. The idea was to allow 'undelete' via recycler or history module if those records have been deleted by accident. However, the undelete workspace records functionality never worked and has never been fixed. The oldest open forge issue on this topic is 11 (!) years old. The solution is to discard those records instead of soft-deleting them. This effectively drops soft-delete for workspace records. It's done by a trivial switch in the main DataHandler delete method to re-route workspace delete operation to the recently refactored discard methods instead. This change allows us to further refactor the remaining tasks the DataHandler delete functionality is concerned with, since delete still handles three things: * Deleting and soft-deleting records in live. * Creating 'delete placeholder' records in workspaces. This is the 'mark the record as to-be-deleted in live on workspace publish' operation. * Undeleting records using recycler and partially the history module. Dropping the workspace-delete scenarios reduces complexity significantly. The codebase can now be changed with upcoming patches to separate remaining concerns - similar to what has been done with discard already. The according scenarios will see improved test coverage and far better understandable code along the way. This will ultimately allow us to fix remaining bugs in this area on one hand and to improve user experience on the other hand. Change-Id: I33e1258cb6205668511933c0d9b225f4470655e7 Resolves: #93121 Resolves: #21299 Resolves: #89383 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67191 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
