- 21 Dec, 2021 1 commit
-
-
According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types it is only allowed to use "string|null" and not "?string" Resolves: #96407 Releases: main, 11.5 Change-Id: I4e9ec53d05feb5cfffc4eebc29de447d6225ab66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72774 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- 22 Sep, 2021 1 commit
-
-
Resolves: #95234 Releases: master Change-Id: Ic6e8326d0e9f97429a727ac1ceae6aab2ff976d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71078 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- 08 Aug, 2021 1 commit
-
-
Strip declare declaration from concatenated ext_localconf files. Resolves: #94739 Releases: master Change-Id: I006278888b950a3a4aa105dc6bb822390cd29aef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70281 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 02 Aug, 2021 1 commit
-
-
Christian Kuhn authored
Extbase provides a couple of generic domain repositories and models, especially frontend / backend users and groups. Those are flawed by design: The main issue is that domain models have to be specific for the domain they are used in. By definition, a generic, opinionated model can't be "correct" since the domain it is used in, is unique: It might be that a backend user email has to be set and the domain does not model anything but email and firstname? Many usages don't need backend groups attached to a backend user model at all, or if they need them, then maybe in a recursive presentation, or a specific order or something similar. Having a default group resolution is thus at least misleading, if not wrong, and can be a performance issue on top. A generic model can never foresee its usages. The existing models thus try to 1:1 adapt the database fields, which is also misleading since a domain model is not and should not be a direct representation of a database table. It would only be by chance if the generic models fit a specific domain. Similar issues exist with the repositories: The CategoryRepository for instance assumes it is a good idea to set respectStoragePid(false), which is most likely not the right thing for an extension use. In the end, whatever extbase delivers here, is most likely wrong and does not fit the problem domain. The patch keeps the 'experimental' FAL related models since those can be actually useful for extensions and their final fate has not been decided, yet. The other generic models, especially those with lots of properties are marked as deprecated with the patch. Change-Id: I06629fddd0258c517f3fa8bdf2e9c4b342be9678 Resolves: #94654 Related: #83296 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70061 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 15 Apr, 2020 2 commits
-
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/extbase/Classes bin/rector process --set=php53 typo3/sysext/extbase/Tests Releases: master Resolves: #91047 Change-Id: Idcd1e10e5bf6dd5fa504873e450e31a980fab9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64180 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 20 Sep, 2018 1 commit
-
-
Some tests are just documenting current, buggy behavior. So once bugs are fixed assertions needs to be updated. See inline comments for details (and list of related issues below). Resolves: #86327 Related: #45873 Related: #68672 Releases: master Change-Id: I780f77fa95d3824a2dafd58a1a73df2bb5fac9e4 Reviewed-on: https://review.typo3.org/58276 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- 22 Jun, 2018 1 commit
-
-
Class properties explicitly initialized with NULL and redundant assignments in constructors are removed. Resolves: #85287 Releases: master Change-Id: I44c565a0b54e7e98ffa6d2d1de5335a6212a5742 Reviewed-on: https://review.typo3.org/57243 Tested-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- 14 May, 2018 1 commit
-
-
This patch introduces the "TYPO3\CMS\Extbase\Annotation\Validate" annotation that replaces the @validate annotation which is deprecated from now on. Releases: master Resolves: #83167 Change-Id: I9a0a3804cfb7429eaf81ec2b3ffa21c3a3d84c63 Reviewed-on: https://review.typo3.org/54870 Reviewed-by:
-
- 14 Jan, 2018 2 commits
-
-
Releases: master Resolves: #83521 Change-Id: I8bd477ccf2ae6fca478b758cf61654a1bec388cd Reviewed-on: https://review.typo3.org/55313 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Releases: master Resolves: #83520 Change-Id: Idd10aa62692198f7aa20af1492fb9670149d5ac9 Reviewed-on: https://review.typo3.org/55312 Reviewed-by:
-
- 29 Nov, 2017 1 commit
-
-
Add local getPlainValue method in persistence backend, so a null value instead of string 'NULL' is written to database. Resolves: #68994 Related: #57255 Releases: master, 8.7 Change-Id: Idb61caabf5115da4bb818d2ed8bb4faa16f5df2c Reviewed-on: https://review.typo3.org/43627 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- 13 Dec, 2014 2 commits
-
-
At the moment in some classes you can find an empty line between the copyright comment and the namespace statement. In some other classes there is no such empty line. This commit adds an empty line after the namespace statement if there is no empty line. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: (namespace .*\n)(/\*) Replace: $1\n$2 Resolves: #63831 Releases: master Change-Id: I14c08c64ccbdb39001a5c303c629b1dfaa3a6c0f Reviewed-on: http://review.typo3.org/35392 Reviewed-by:
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
- 09 Sep, 2014 1 commit
-
-
The Typo3DbBackend doesn't respect the columns tablenames and fieldname when updating mm releations. As result wrong relations are adjusted. Resolves: #61268 Releases: 6.2, 6.3 Change-Id: Ica1c04fb54b2f152ccf0f9bd766091854f01721a Reviewed-on: http://review.typo3.org/32505 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
- 07 Sep, 2014 1 commit
-
-
During the last year some closing PHP tags are added again. Remove the new added closing tags. Resolves: #61393 Releases: 6.3 Change-Id: I40612b7ae10f3b0341bf46a894d193dbd732a70b Reviewed-on: http://review.typo3.org/32614 Reviewed-by:
Frank Nägler <typo3@naegler.net> Reviewed-by:
-
- 22 Jun, 2014 1 commit
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59784 for further details. Resolves: #59784 Releases: 6.3, 6.2 Change-Id: I1eacf9bf4537776e850d091d9d50bc72f8c2b20d Reviewed-on: https://review.typo3.org/31029 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- 05 Mar, 2014 1 commit
-
-
Add functional tests for persisting 1:M and M:M relations in Extbase. This patch adds blog_example as an fixture extension. Resolves: #55786 Releases: 6.2 Change-Id: If90c854c9cb86fd45dcdbc14319a0a416e9447a0 Reviewed-on: https://review.typo3.org/27492 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
