1. 21 Dec, 2021 1 commit
  2. 10 Nov, 2021 1 commit
    • Alexander Schnitzler's avatar
      [BUGFIX] Fix method signature of Query::logicalOr() · e4d5450a
      Alexander Schnitzler authored and Christian Kuhn's avatar Christian Kuhn committed
      The method signature of Query::locicalOr() is very misleading
      because it only states there is one method argument $constraint1.
      
      Actually, the method does accept any number of arguments, evaluated
      via func_get_args(). It also accepts any number of arguments if
      $constraint1 is an array of constraints. This leads to multiple
      issues when working with phpstan and also when simply using an IDE
      which does not understand the internal magic.
      
      The goal is to state, that logicalOr() needs at least two
      constraints but also accepts any number of further constraints.
      
      Since that requires a breaking change, the method signature can
      only be fixed partly for now. $constraint1 remains as is, a 2nd
      argument $constraint2 is introduced, null by default to make it
      optional and a variadic argument ...$furtherConstraints is also
      introduced.
      
      This approach keeps the bc promise but also lays the foundation
      for further changes in the next version.
      
      Releases: master, 10.4
      Resolves: #95938
      Change-Id: I2a605cb4f42ec5324d973b63cf838278287de516
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72135
      
      
      Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      e4d5450a
  3. 09 Nov, 2021 1 commit
    • Alexander Schnitzler's avatar
      [BUGFIX] Streamline arguments for logicalAnd() query in Extbase · 03cc0ab9
      Alexander Schnitzler authored and Christian Kuhn's avatar Christian Kuhn committed
      The method signature of Query::locicalAnd() is very misleading
      because it only states there is one method argument $constraint1.
      
      Actually, the method does accept any number of arguments, evaluated
      via func_get_args(). It also accepts any number of arguments if
      $constraint1 is an array of constraints. This leads to multiple
      issues when working with phpstan and also when simply using an IDE
      which does not understand the internal magic.
      
      The goal is to state, that logicalAnd() needs at least two
      constraints but also accepts any number of further constraints.
      
      Since that requires a breaking change, the method signature can
      only be fixed partly for now. $constraint1 remains as is, a 2nd
      argument $constraint2 is introduced, null by default to make it
      optional and a variadic argument ...$furtherConstraints is also
      introduced.
      
      This approach keeps the bc promise but also lays the foundation
      for further changes in the next version.
      
      Releases: master, 10.4
      Resolves: #95889
      Change-Id: Ife1be32d99371b82a84b6f6d800a58d242c8ff0d
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72063
      
      
      Tested-by: core-ci's avatarcore-ci <typo3@b13.com>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Tested-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Reviewed-by: Christian Kuhn's avatarChristian Kuhn <lolli@schwarzbu.ch>
      03cc0ab9
  4. 22 Jul, 2021 1 commit
  5. 04 May, 2021 1 commit
  6. 22 Dec, 2020 1 commit
  7. 15 Apr, 2020 2 commits
  8. 14 Apr, 2020 1 commit
  9. 06 Apr, 2020 1 commit
  10. 15 Mar, 2020 1 commit
  11. 29 Feb, 2020 1 commit
  12. 07 Oct, 2019 1 commit
  13. 01 Oct, 2018 1 commit
  14. 30 Sep, 2018 1 commit
  15. 20 Sep, 2018 1 commit
  16. 03 Sep, 2018 1 commit
  17. 27 Aug, 2018 1 commit
  18. 16 Dec, 2017 1 commit
  19. 27 Nov, 2017 1 commit
  20. 23 Aug, 2017 1 commit
  21. 22 Apr, 2017 1 commit
  22. 20 Apr, 2017 1 commit
  23. 28 Mar, 2017 1 commit
    • Wouter Wolters's avatar
      [TASK] Streamline return tags in phpdocs · eb049dba
      Wouter Wolters authored and Benni Mack's avatar Benni Mack committed
      The TYPO3 Core currently has no guidline how to handle phpdoc
      comments regarding @return annoations related to "void" and "null".
      
      In practice, these annotations have no additional value if no additional
      documentation is given.
      
      With this change, the php-cs-fixer will remove any unnecessary linebreaks
      within the comments above the @return annotation, as well as remove completely
      empty phpdoc comments because the @return annotation is removed.
      
      Please be aware, that once PSR-5 is accepted, this coding standard
      within the TYPO3 Core will change again, where there are currently
      some further proposal details like inheritance information.
      
      Resolves: #80454
      Releases: master
      Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
      Reviewed-on: https://review.typo3.org/51686
      
      
      Reviewed-by: Nicole Cordes's avatarNicole Cordes <typo3@cordes.co>
      Tested-by: Nicole Cordes's avatarNicole Cordes <typo3@cordes.co>
      Reviewed-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      Tested-by: Benni Mack's avatarBenni Mack <benni@typo3.org>
      eb049dba
  24. 15 Feb, 2017 1 commit
  25. 13 Dec, 2016 1 commit
  26. 05 Dec, 2016 1 commit
  27. 21 Oct, 2016 1 commit
  28. 10 Oct, 2016 1 commit
  29. 30 Aug, 2016 1 commit
  30. 08 Oct, 2015 1 commit
  31. 08 Sep, 2015 1 commit
  32. 05 Aug, 2015 1 commit
  33. 02 Jan, 2015 1 commit
  34. 16 Dec, 2014 1 commit
  35. 13 Dec, 2014 2 commits
  36. 06 Dec, 2014 1 commit
  37. 21 Nov, 2014 1 commit
  38. 20 Nov, 2014 1 commit