- 21 Dec, 2021 1 commit
-
-
According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types it is only allowed to use "string|null" and not "?string" Resolves: #96407 Releases: main, 11.5 Change-Id: I4e9ec53d05feb5cfffc4eebc29de447d6225ab66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72774 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- 10 Nov, 2021 1 commit
-
-
The method signature of Query::locicalOr() is very misleading because it only states there is one method argument $constraint1. Actually, the method does accept any number of arguments, evaluated via func_get_args(). It also accepts any number of arguments if $constraint1 is an array of constraints. This leads to multiple issues when working with phpstan and also when simply using an IDE which does not understand the internal magic. The goal is to state, that logicalOr() needs at least two constraints but also accepts any number of further constraints. Since that requires a breaking change, the method signature can only be fixed partly for now. $constraint1 remains as is, a 2nd argument $constraint2 is introduced, null by default to make it optional and a variadic argument ...$furtherConstraints is also introduced. This approach keeps the bc promise but also lays the foundation for further changes in the next version. Releases: master, 10.4 Resolves: #95938 Change-Id: I2a605cb4f42ec5324d973b63cf838278287de516 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72135 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org> Tested-by:
-
- 09 Nov, 2021 1 commit
-
-
The method signature of Query::locicalAnd() is very misleading because it only states there is one method argument $constraint1. Actually, the method does accept any number of arguments, evaluated via func_get_args(). It also accepts any number of arguments if $constraint1 is an array of constraints. This leads to multiple issues when working with phpstan and also when simply using an IDE which does not understand the internal magic. The goal is to state, that logicalAnd() needs at least two constraints but also accepts any number of further constraints. Since that requires a breaking change, the method signature can only be fixed partly for now. $constraint1 remains as is, a 2nd argument $constraint2 is introduced, null by default to make it optional and a variadic argument ...$furtherConstraints is also introduced. This approach keeps the bc promise but also lays the foundation for further changes in the next version. Releases: master, 10.4 Resolves: #95889 Change-Id: Ife1be32d99371b82a84b6f6d800a58d242c8ff0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72063 Tested-by:
core-ci <typo3@b13.com>
Tested-by:
-
- 22 Jul, 2021 1 commit
-
-
Christian Kuhn authored
This finishes removal of regular extbase ObjectManager usages throughout the core: All left over places are fallback situations if extensions don't provide proper service definitions. Most places are casual replacements, many of them have been prepared with previous patches. Some places like Query and QueryResult still need special handling: The patch introduces some 'ForwardCompatible' interfaces implemented by core to otherwise OM-fallback if extensions didn't catch up yet. This avoids expensive runtime reflection in potentially often-called areas. When this patch is merged, a final patch can be done, including a ReST with some dedicated transition tips and the ultimate ObjectManager deprecation. Resolves: #94451 Related: #90803 Related: #92238 Releases: master Change-Id: Ic53f3bf6a04d15052680a953c76d19182a2e5e87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69676 Tested-by:
core-ci <typo3@b13.com>
Tested-by: 
Jochen <rothjochen@gmail.com>
Tested-by: Jochen <rothjochen@gmail.com>
Reviewed-by:
-
- 04 May, 2021 1 commit
-
-
Resolves: #94059 Releases: master Change-Id: I9687dddef9889d79359e64987e8886a305d3149f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69016 Tested-by:
core-ci <typo3@b13.com>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- 22 Dec, 2020 1 commit
-
-
This patch removes unused code in the persistence area of Extbase. Most removed code was part of internal classes and interfaces, thus they are removed without notice. Along with the removal of methods, two methods have been marked deprecated and for their removal in the future i.e. TYPO3 12.0. Releases: master Resolves: #89938 Change-Id: I66596bff9879a6850a71ada05891f80a551ffb74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62616 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- 15 Apr, 2020 2 commits
-
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/extbase/Classes bin/rector process --set=php53 typo3/sysext/extbase/Tests Releases: master Resolves: #91047 Change-Id: Idcd1e10e5bf6dd5fa504873e450e31a980fab9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64180 Tested-by:Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- 14 Apr, 2020 1 commit
-
-
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by:
-
- 06 Apr, 2020 1 commit
-
-
Releases: master Resolves: #90893 Change-Id: Icc339442cded9a268fb66fe932b0f13de292e3b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- 15 Mar, 2020 1 commit
-
-
This commit adds missing doc blocks and missing type hints to existing doc blocks to help static code analyzers like phpstan do a better job. Also, wrong type hints have been changed. Releases: master Resolves: #90661 Change-Id: I966884b15e33f5668498290d3fd80b67a7ddcba0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63561 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- 29 Feb, 2020 1 commit
-
-
Resolves: #90590 Releases: master Change-Id: Ieeef9bb93804f0de090fd787eb143c913b1b19a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63496 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- 07 Oct, 2019 1 commit
-
-
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- 01 Oct, 2018 1 commit
-
-
EXT:extbase uses @api and @internal phpDoc annotations. Going with a cleaner approach with marking code as just @internal, and everything not annotated as @internal is public, is the way to go, also the way PSR-5 is heading. For EXT:extbase: Every PHP class that had nothing marked, is now @internal, everything that was @api is now implicitly part of TYPO3 Core API. On top, all license headers and @license annotations have been streamlined. This means: - TYPO3 Core's PHP classes area all public API by default unless marked as @internal or an extension class - @api is not allowed anymore and will be restricted in the future from adding. - @internal should be used for everything that should not be explicitly exposed as public API in the future. - Everything under Tests/ is not part of TYPO3's Public API Resolves: #86521 Releases: master Change-Id: I83c5a27d9af001929142d2620600668ad0a84c92 Reviewed-on: https://review.typo3.org/58535 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- 30 Sep, 2018 1 commit
-
-
Tymoteusz Motylewski authored
Make Extbase fetch records in the same way as in TypoScript rendering, making QuerySettings options mean the same as corresponding settings from TypoScript. This change allows e.g. to filter and sort by translated values of the aggregate root. To make upgrades easier a feature switch is introduced which enables the new behavior. It can be disabled with TypoScript if somebody relies on the old behavior. The feature switch is enabled by default in v9 and will be gone in v10 so in version 10 the fixed way will be the only way to fetch records in Extbase. Releases: master Resolves: #82363 Resolves: #84011 Change-Id: I58d0a24c1f73debc6b9251efea9c28c9cf09d6d0 Reviewed-on: https://review.typo3.org/53974 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- 20 Sep, 2018 1 commit
-
-
DataMapper is not a singleton any more. Thanks to that, a further refactoring can be done to pass aggregate root query configuration to the DataMapper, which will allow to fix inconsistencies in Extbase language handling. The runtime cache of data maps is moved to DataMapFactory. Resolves: #86268 Releases: master Change-Id: I003451c4d07855ff25d695578c9ec7b443f630bc Reviewed-on: https://review.typo3.org/58287 Tested-by:
-
- 03 Sep, 2018 1 commit
-
-
Resolves: #86088 Releases: master Change-Id: Ia011b8ca85b8665edd80a093844b5a60a5fe2e29 Reviewed-on: https://review.typo3.org/58129 Tested-by:
-
- 27 Aug, 2018 1 commit
-
-
A series of unused and dead code places are fixed with the patch: * Switch + return + break -> the break is obsolete * A couple of 'too many arguments' when calling methods * Various assignments of variables that are never used Change-Id: I8472597f73a739bce053cf6de772c111ae7044d7 Resolves: #85993 Releases: master Reviewed-on: https://review.typo3.org/58047 Reviewed-by:
-
- 16 Dec, 2017 1 commit
-
-
The "self_accessor" fixer is more strict with younger php-cs-fixer releases and changes method argument type hints to self if a class object of the same class is expected. It also changes return type hints to self in this case. This fixer now may collide with the "xclass" system of the core and is thus deactivated. We shoud decide manually if self or class name is used. Change-Id: I3a8c20bea1d79ac2c7bc1e9ecbc2d435c4047843 Resolves: #83360 Related: #83331 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55121 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by:
-
- 27 Nov, 2017 1 commit
-
-
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
-
- 23 Aug, 2017 1 commit
-
-
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
- 22 Apr, 2017 1 commit
-
-
Christian Kuhn authored
Change-Id: Ibf10d464bbd0d50e2c20deefaf505cd6292c076d Resolves: #80929 Releases: master Reviewed-on: https://review.typo3.org/52532 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- 20 Apr, 2017 1 commit
-
-
Removes and adapts some classes, methods and parameters which were marked as deprecated. Resolves: #80713 Releases: master Change-Id: Iae9c7035f72e3af0f9b4056cc507515546ecdbf9 Reviewed-on: https://review.typo3.org/52507 Tested-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
-
- 28 Mar, 2017 1 commit
-
-
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
-
- 15 Feb, 2017 1 commit
-
-
Code cleanup based on the static analyser Psalm. https://github.com/vimeo/psalm Resolves: #79815 Releases: master Change-Id: I67dd33a79564b81931515f210644e980f83d3b7b Reviewed-on: https://review.typo3.org/51679 Reviewed-by:
-
- 13 Dec, 2016 1 commit
-
-
To fully utilize Extbase in conjunction with Doctrine DBAL, Extbases' StorageBackend now supports native QueryBuilder and Doctrine DBAL Statements, which can be used for prepared statements. Resolves: #78116 Releases: master Change-Id: I73b5a9588465e345029b7985327fb0cd0d7875df Reviewed-on: https://review.typo3.org/50178 Reviewed-by:
-
- 05 Dec, 2016 1 commit
-
-
We remove the iconv support in the CharsetConverter as the PHP internal implementation of some functions differ from their mb_string pendants. This gives us a real headache in edge-cases. We already have the mbstring-polyfill as an indirect dependency in the Core (by symfony), so we simply require it our own now and use mb_string all over the places. This renders quite a few methods of CharsetConverter useless and we therefore deprecate those. Resolves: #78670 Releases: master Change-Id: I88479f7939e0afb46f704d4e8f347abd2e10fc6d Reviewed-on: https://review.typo3.org/50607 Tested-by:
-
- 21 Oct, 2016 1 commit
-
-
In contrast to a case insensitive query a case sensitive query can not be enforced as it largely depends on the settings of the database system. Deprecate the parameter as it isn't used at all and log an appropriate notice. Change-Id: Ie767c6a9d5d3de5857c7a3bf38a5dd43ce580d07 Resolves: #57385 Releases: master Reviewed-on: https://review.typo3.org/49856 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- 10 Oct, 2016 1 commit
-
-
* better regex finds more with less false positives * use grep instead of ack-grep * find exceptions without exception code * the script kills travis for unkown reasons and removed Change-Id: I6ae7c005bc9f493365d36f9602aebf389f1f7786 Resolves: #78221 Releases: master Reviewed-on: https://review.typo3.org/50150 Reviewed-by:
-
- 30 Aug, 2016 1 commit
-
-
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- 08 Oct, 2015 1 commit
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- 08 Sep, 2015 1 commit
-
-
Support for ``between`` has been added to the Extbase Query object. As there is no performance advantage to using BETWEEN on the DBMS side (the query optimizers converts it to `min <= expr AND expr <= max)` this method replicates the DBMS behaviour by building a logical AND condition that has the advantage of working on all DBMS. Resolves: #47812 Releases: master Change-Id: Ic3b416515eedc651faf69de1db21eab288a8ad33 Reviewed-on: http://review.typo3.org/42813 Reviewed-by:
-
- 05 Aug, 2015 1 commit
-
-
Wouter Wolters authored
Because of performance reasons we replace the @inject annotations back to inject methods. Resolves: #54605 Releases: master Change-Id: I433e2ecccc2aa319ec8904dbc65b84f63e9959aa Reviewed-on: http://review.typo3.org/42270 Reviewed-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
-
- 02 Jan, 2015 1 commit
-
-
Some words are missing in QuerySettingsInterface method header comments. Also, all places within Extbase referring to FLOW3 are changed to TYPO3.Flow. Resolves: #61570 Releases: master Change-Id: Iafbc8215ae647fca532de2fe8526f4215a157a03 Reviewed-on: http://review.typo3.org/35738 Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
-
- 16 Dec, 2014 1 commit
-
-
Most of TYPO3's PHP files have an empty line before a class' closing curly brace. This commit adds this empty line (if it is missing) before a class' closing curly brace. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: (}\n)(}) Replace: $1\n$2 Resolves: #63942 Release: master Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7 Reviewed-on: http://review.typo3.org/35527 Reviewed-by:
-
- 13 Dec, 2014 2 commits
-
-
At the moment in some classes you can find an empty line between the copyright comment and the first use statement. In some (far less) other classes there is no such empty line. This commit adds an empty line between those comments if there is no empty line. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: ( \* The TYPO3 project - inspiring people to share!\n \*/\n)(use ) Replace: $1\n$2 Resolves: #63829 Releases: master Change-Id: I4b28a1cfcfc727016ac5d89b3988d236270f37e2 Reviewed-on: http://review.typo3.org/35391 Reviewed-by:
-
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
- 06 Dec, 2014 1 commit
-
-
Stefan Neufeind authored
Also convert FIXME to @todo. Change-Id: I98cf8a2c4c732acc7024e36ed949fc4546bee439 Resolves: #63619 Releases: master Reviewed-on: http://review.typo3.org/35086 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
- 21 Nov, 2014 1 commit
-
-
Since PHP 5.5 is a requirement, calls with the objectManager should use the ::class construct instead of a string argument. Resolves: #63112 Releases: master Change-Id: Iedbb896607adddce2b23ab67f990fa2296c0d1bb Reviewed-on: http://review.typo3.org/34414 Reviewed-by:
-
- 20 Nov, 2014 1 commit
-
-
Resolves: #62673 Releases: master Change-Id: If468f183fa0e31624e7bf4621728066d4e770066 Reviewed-on: http://review.typo3.org/33771 Reviewed-by:
-
