Commits · 3344f50063aaadb5dda84604d7b47a577ef629c3 · typo3 / typo3

21 Dec, 2021 4 commits

[BUGFIX] Fix doctype annotations · 3344f500

Simon Schaufelberger authored Dec 20, 2021 and

Christian Kuhn committed Dec 21, 2021

According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types
it is only allowed to use "string|null" and not "?string"

Resolves: #96407
Releases: main, 11.5
Change-Id: I4e9ec53d05feb5cfffc4eebc29de447d6225ab66
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72774


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

3344f500

[BUGFIX] Resolve shortcuts in typolink directly · ad385665

Benni Mack authored Oct 01, 2021

Currently, HMENU generates the direct destination for
a shortcut URL, but typolink does not. This is an
inconsistency, and since HMENU is actually using typolink
now as well (in 4.x this was different), the resolving
of shortcuts can now be moved into the typolink/link building
functionality.

Page Shortcuts are now resolved (recursively!) at a single point for
all links, except for RANDOM_SUBPAGE variants, as this is sorted
out during runtime when hitting the RANDOM_SUBPAGE shortcut page.

Resolves: #80113
Resolves: #95947
Releases: main, 11.5
Change-Id: Ib6204ff1b0ecb699ec87f5154dc18c974676e65c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72772


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

ad385665

[TASK] Switch to new REST API end point · e9b43754

Simon Gilli authored Aug 16, 2020 and

Christian Kuhn committed Dec 21, 2021

The core version service now uses the new entry point of the REST API
available via https://get.typo3.org/api.

The old entry point is still available but should not be longer used.

For more information see `https://get.typo3.org/api/doc <https://get.typo3.org/api/doc>`_
and `https://github.com/TYPO3/get.typo3.org/pull/272 <https://github.com/TYPO3/get.typo3.org/pull/272>`_.

Resolves: #92020
Releases: main, 11.5, 10.4
Change-Id: I2c92554e9ba212827b6412d4a88ac5c92e26aa17
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72756


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

e9b43754

[TASK] Raise friendsofphp/php-cs-fixer:^3.4 · 79a5e13b

Benni Mack authored Dec 20, 2021

The dev dependency friendsofphp/php-cs-fixer now
has a minimum requirement to 3.4, which comes
with PHP8.1 support.

This allows TYPO3 to run PHP-CS Fixer with
PHP 8.1 in the CI pipeline.

Testing configuration is not adjusted with this
patch, but allows using corresponding runTests.sh
testsuites cgl and cglGit:

Build/Scripts/runTests.sh -p 8.1 -s cglGit -n
Build/Scripts/runTests.sh -p 8.1 -s cgl -n

Used command:

composer req friendsofphp/php-cs-fixer:^3.4 --dev

Resolves: #96398
Releases: main, 11.5
Change-Id: I6a4eaec0294829afcdf84b7b32303eaafbaa72bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72718


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

79a5e13b

20 Dec, 2021 5 commits

[BUGFIX] Remove useless string cast of idn_to_ascii() · 9faf357a

Andreas Fernandez authored Dec 20, 2021 and

Oliver Bartsch committed Dec 21, 2021

The function `idn_to_ascii()` will return either `false` or a string,
the former one is returned on errors. In #93900, the result was cast to
string, making the check for `false` useless.

As `idn_to_ascii()` can return both, the string cast is removed to make
the check for `false` functional again.

Resolves: #96399
Related: #93900
Releases: main, 11.5
Change-Id: Ib5327766fc545a75feb7389d18358aa85b76e5db
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72720


Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

9faf357a

[BUGFIX] Forward-compatible prepared statement support · ed725d12

Stefan Bürk authored Dec 09, 2021 and

Benni Mack committed Dec 20, 2021

doctrine/dbal:^3.2 changed return type of result for QueryBuilder
execute methods, no longer have used prepared statement accessible
for further query execution with other placeholder values.

To raise doctrine/dbal:^3.2 two places have been changed to reuse
the QueryBuilder instance itself instead of prepared statement with
the corresponding patch #96287, thus given up the performance gain
through reusable query execution plan in corresponding dbms systems.

This patch adds support for prepared statements to TYPO3's
QueryBuilder facade as this was not publicly available yet
for TYPO3 users to be forward-compatible with Doctrine DBAL 3.

Resolves: #96393
Related: #96287
Releases: main
Change-Id: I814670ebf9920ed3162a31f98ad9efd4031f47c9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72716


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

ed725d12

[BUGFIX] Fix scoping issue in FormEngineValidation · 21798082

Benjamin Franzke authored Dec 14, 2021 and

Andreas Fernandez committed Dec 20, 2021

theChar is not initialized and therefore pollutes global scope.
(It is assigned to window.theChar in the FormEngine iframe).

Currently not an error (we are not using strict mode in RequireJS),
just bad style, but once we switch to strict mode (type="module"),
this will fail without proper declaration.

Releases: main, 11.5
Resolves: #96395
Related: #96323
Change-Id: Ie82da6a1b664e4010179cccaabb07e7d87b19038
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72717


Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

21798082

[TASK] Avoid deprecated doctrine/dbal method 'executeUpdate()' · b20ef47f

Stefan Bürk authored Dec 19, 2021 and

Benni Mack committed Dec 20, 2021

doctrine/dbal deprecated quite some methods to cleanup
their codebase and provided replacements with more
speaking method names.

Most deprecated method usages have been replaced in
the core, but we missed some.

The patch replaces the deprecated method 'executeUpdate()'
with the corresponding 'executeStatement()' method in
several places to clean this up.

This can be done also in 11.5 too, the required minimum
version of doctrine/dbal provides these new methods as
upwards compatible layer.

Resolves: #96389
Releases: main, 11.5
Change-Id: Ibf8f49a27a1c8c4b34bda88a20f4fba6afe45cb8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72715


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

b20ef47f

[BUGFIX] Fix extension path in ComposerDeficitDetector · fd8d65c5

Helmut Hummel authored Dec 16, 2021

Instead of relying on a hard coded extension install path,
now the real extension path is used provided by the package manager

Releases: main, 11.5
Resolves: #96375
Change-Id: Ic2e4d71413416a5271420e939e5f74fa28cbaca6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72691


Tested-by: core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>

fd8d65c5

19 Dec, 2021 1 commit

[BUGFIX] Avoid exception in ContentObjectRenderer with PHP8 · 783abed0

Torben Hansen authored Dec 18, 2021 and

Benni Mack committed Dec 19, 2021

This patch ensures that the getQuery() function only uses the
minus operator to negate the $storagePid variable, if the variable
can be interpreted as an integer.

Resolves: #96321
Releases: main, 11.5
Change-Id: Idacd43fd6639218fc1126bffcd43e78338f18e0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72714


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

783abed0

18 Dec, 2021 1 commit

[BUGFIX] Fix PHP 8 strict warning in Package MetaData · 9f4edc9f

Helmut Hummel authored Dec 16, 2021

A "type" does not need to be set in a composer.json,
so the checks for package type must account for the type
being null, to not trigger a warning in PHP 8

Releases: 11.5, main
Resolves: #96372
Change-Id: Ic607c3dbb16dfcf4a28b0417b8340be36bcafa87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72712


Tested-by: core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>

9f4edc9f

17 Dec, 2021 3 commits

[BUGFIX] Make RichTextElement PHP 8 compatible · 99d92d22

Markus Klein authored Dec 17, 2021 and

Oliver Bartsch committed Dec 17, 2021

RTE yaml configuration can be incomplete/wrong or empty.
Do not access configuration settings without a safeguard.

Resolves: #96383
Releases: main, 11.5
Change-Id: Ie0888402e64a669816edd200d2d54e401e0c399f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72713


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>

99d92d22

[BUGFIX] Pass sanitized additional where as string in DatabaseRecordList · 0a2730c7

Oliver Bartsch authored Dec 17, 2021

The RecordListGetTable hook allows to add an additional
where clause to the recordlist query. Since the sanitized
result was wrapped in an array before being passed to
$queryBuilder->andWhere(), this led to an exception.

This is now fixed by passing the sanitized clause as
string to `addWhere()`.

Resolves: #96378
Related: #92065
Releases: main, 11.5
Change-Id: I99fa184f49f9db9f7edf061d4137e1e6c275446e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72689


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

0a2730c7

[BUGFIX] Avoid select and therefore fetchFirstColumn() of doctrine/dbal · cfa17a74

Helmut Hummel authored Dec 16, 2021

Get rid of the select query entirely, which optimises
the task to only require one update query instead of
one select and possibly multiple update queries and
gets rid of doctrine version related incompatibilities
with fetching the select result.

Resolves: #96369
Related: #87162
Releases: main, 11.5, 10.4
Change-Id: I87b570f5efa3d77ed5f2c5fc0074e84bef4675a4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72690


Tested-by: core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Helmut Hummel <typo3@helhum.io>

cfa17a74

16 Dec, 2021 6 commits

[BUGFIX] Fix validation in form override settings · bf3eaa6c

Nikita Hovratov authored Oct 07, 2021 and

Benni Mack committed Dec 17, 2021

The FinisherOptionGenerator of the form extension
generates the data structure for the form setting
overrides on the fly. By doing so, it didn't make
a distinction between normal TCA fields and flexform
specific sections/containers and added the wrapper
"TCEforms" to sections as well, which broke the
validation in DataHandler for the fields inside the
container (E.g. the email field).

The patch checks if section is set to "true" and
adds the "TCEforms" key only for normal TCA field
configurations.

Unit tests have been added for the DataHandler
checkValue_flex_procInData_travDS method, which
show cases with and without the "TCEforms" key.

Also, since this works now, a PHP 8 warning
appeared. This is fixed now, too.

Resolves: #95441
Releases: main, 11.5
Change-Id: Ib12a0484bcbdc827664181ca6af89edfadee13d8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72688


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

bf3eaa6c

[BUGFIX] Ensure getTreeList() keeps ordering of subpages · b10cddb6

Benni Mack authored Dec 09, 2021

Resolves: #96310
Releases: main, 11.5
Change-Id: Ie12ca1683b3d8668deafbd37af03437f047c0ac4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72685


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

b10cddb6

[BUGFIX] Do not render hidden pages in HMENU list · 0c04d918

Benni Mack authored Dec 16, 2021 and

Oliver Bartsch committed Dec 16, 2021

Resolves: #96358
Releases: main, 11.5
Change-Id: I36b7ddc31eb3e240c86f3a550d068d7577099f6e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72686


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

0c04d918

[BUGFIX] Handle missing $_SERVER['PATH_INFO'] · 9fbda173

Markus Klein authored Dec 16, 2021 and

Helmut Hummel committed Dec 16, 2021

Fix PHP8 warning issue if $_SERVER['PATH_INFO'] is not set.

Resolves: #96373
Releases: main, 11.4
Change-Id: I427aee39c6f6389e418f27474c01cbfd973355e1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72687


Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io>

9fbda173

[BUGFIX] Avoid duplicate results in HMENU with workspaces · 20d8dd77

Benni Mack authored Dec 15, 2021

HMENU special="directory" and special="updated" did not
use PageRepository directly, which led to duplicate
entries with workspaces.

This change does not use "$cObj->exec_..." anymore
and fixes all problems.

composer req --dev typo3/testing-framework:^6.15.2

Resolves: #96226
Releases: main, 11.5
Change-Id: I595ac05981d03246eb7671c9ae072f499bff5188
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72684


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

20d8dd77

[TASK] Avoid extending view helpers in ext:extensionmanager · 873f6777

Christian Kuhn authored Dec 15, 2021

ext:extensionmanager has a couple of view helpers that
extend ActionViewHelper for no apparent reason. Change
those to extend AbstractTagBasedViewHelper instead.

Resolves: #96361
Releases: main, 11.5
Change-Id: Iedab908a30df0418a7c86d073d97a47548a87ab4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72683


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

873f6777

15 Dec, 2021 8 commits

[BUGFIX] Missing rootline in BE ConditionMatcher if page id is determined · 0d4f8ac3

Marc Bastian Heinrichs authored Dec 09, 2021 and

Christian Kuhn committed Dec 15, 2021

Resolves: #96308
Releases: main, 11.5, 10.4
Change-Id: Ibcbda7fd97a338d721cf00b38026727e941c72ac
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72680


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

0d4f8ac3

[BUGFIX] Remove workspace info from logging module if not needed · 6841ca1b

Georg Ringer authored Dec 09, 2021 and

Christian Kuhn committed Dec 15, 2021

If EXT:workspaces is not installed, the workspace information should
also be skipped in the logging module. This makes it easier to read
and less bloated.

Resolves: #96314
Releases: main, 11.5
Change-Id: I22277ca681cc877d57686e02f36fe54e630d2f9a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72679


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

6841ca1b

[BUGFIX] Consider Context API when using f:format.date · f6981e7c

Benni Mack authored Dec 14, 2021

Resolves: #94308
Releases: main, 11.5
Change-Id: I84836ba46e3b8e3fa8d4ac915efb5a6a7afbdca7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72678


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

f6981e7c

[BUGFIX] Always return a string for PHP 8.1 · 537e227a

Chris Müller authored Dec 14, 2021 and

Benni Mack committed Dec 15, 2021

The following deprecation occurred in PHP 8.1:
PHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated.

This happens in various places:
* Using stdWrap_field() or in stdWrap() places
* BackendUtility (e.g. new IRRE elements)
* ExtensionManager

Resolves: #96354
Releases: main, 11.5
Change-Id: Ie5c721784b51ed5493c8d9e1d557b08611263f6b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72677


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

537e227a

[BUGFIX] Load all backend routes in installer controller · 58f03b18

Simon Gilli authored Dec 02, 2021 and

Benni Mack committed Dec 15, 2021

The routes added via ExtensionManagementUtility::addModule() are missing
when the UriBuilder/Router is used prior to ext_localconf loading.

Also for this particular case, multiple instances of the Router class
were created, as UriBuilder is loaded from the failsafe installtool
container instead of using an instance from the symfony container
(as created by LateBootService n loadExtLocalconfDatabaseAndExtTables).
This resulted in multiple routers being loaded with different sets of
routes.

This patch ensures that the routes are loaded from a UriBuilder/Router
instance that is fully populated with information from ext_localconf.
Therefore GeneralUtility::makeInstance() is avoided and
UriBuilder is fetched from the late booted container instead.

Resolves: #95806
Releases: main, 11.5
Change-Id: Id57bf09fb7798eac26dbdbc6ed89228c54fbafb9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72675


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

58f03b18

[BUGFIX] Fix undefined key warning in EXT:core/TimeTracker with PHP8 · c3a1c238

Rival Florian authored Dec 14, 2021 and

Christian Kuhn committed Dec 15, 2021

Resolves: #96350
Releases: main, 11.5
Change-Id: I67e9fd68de038b84c83f7f12a465e6e37f918568
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72676


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

c3a1c238

[BUGFIX] Render hreflang only for translated pages · fa7a8656

Guido Schmechel authored Jul 19, 2021 and

Benni Mack committed Dec 15, 2021

If a language in the SiteConfig is set to the fallbackType
free and there is no translated page for this language, then
there is now no generated hreflang.

Previously, a link was always generated with default language
slug, which lead to 404 page not found.

Resolves: #94270
Releases: main, 11.5, 10.4
Change-Id: Ifb261cf388fccbaabbf2bcae9ac805b143c9b42f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72673


Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

fa7a8656

[DOCS] Resolve warnings in EXT:form manual · 9485dcad

Lina Wolf authored Dec 14, 2021 and

Lina Wolf committed Dec 15, 2021

Releases: main, 11.5
Resolves: #96346
Change-Id: Ie64e82e84c63142f86b4e0f3e5072514b516aa33
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72672


Tested-by: core-ci <typo3@b13.com>
Tested-by: Lina Wolf <112@linawolf.de>
Reviewed-by: Lina Wolf <112@linawolf.de>

9485dcad

14 Dec, 2021 4 commits

[BUGFIX] Pass default/override values to FormSelectTreeAjaxController · 0dbce15e

Oliver Bartsch authored Dec 13, 2021

The SelectTree and the CategoryTree use a placeholder
form element with all the information like current value
and then calls the FormSelectTreeAjaxController to
actually build the tree.

When using default / override values for such field,
the information was previously only available on
building the placeholder. Therefore the value was
correctly filled and stored, but not displayed in
corresponding tree.

This is now fixed by passing those values to the
Ajax endpoint, which then adds them to the form
compiler input. This allows the data providers to
properly select the values in the tree.

Resolves: #91607
Releases: main, 11.5
Change-Id: I8743bc3c28977b8d8758096b573a0be332d825e8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72645


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72655

0dbce15e

[DOCS] Resolve warnings in System extensions manuals · 19290a6a

Lina Wolf authored Dec 13, 2021 and

Lina Wolf committed Dec 14, 2021

Includes changed links, missing images, wrong path's in includes etc.
Excluded EXT:form as resolving the warnings is a large TASK there.

Releases: main, 11.5
Resolves: #96345
Change-Id: I05d73d7fa211bbf9308a3c7a2161b1b5184d7b31
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72591


Tested-by: Lina Wolf <112@linawolf.de>
Reviewed-by: Lina Wolf <112@linawolf.de>

19290a6a

[TASK] Set TYPO3 version to 11.5.5-dev · ad34bbb4

Benni Mack authored Dec 14, 2021 and

Oliver Hader committed Dec 14, 2021

Change-Id: I39067da924f96b5e69eaf2e060b348edd39a6755
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72650


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>

ad34bbb4

[RELEASE] Release of TYPO3 11.5.4 · 6424b989

Benni Mack authored Dec 14, 2021

Change-Id: Idaced9f8520ebf697cbb175716989946acac3c92
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72649


Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

6424b989

13 Dec, 2021 6 commits

[BUGFIX] Fix undefined key warning in EXT:install/mail preset with PHP8 · d6ec30ae

Rival Florian authored Dec 13, 2021 and

Oliver Bartsch committed Dec 13, 2021

This fix a warning when you click on "SMTP Settings" in "Configuration preset".

Resolves: #96348
Releases: main, 11.5
Change-Id: Ic6ec6b7efd9dde2f7c365fa391e6c358192dc23b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72590


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>

d6ec30ae

[BUGFIX] Fix undefined key warning when opening record list · 5f49aefc

Robert Kärner authored Dec 13, 2021 and

Benni Mack committed Dec 13, 2021

Access to array key $this->pageRow['editlock'] must be protected
with the necessary fallback to false.

Resolves: #96343
Releases: main, 11.5
Change-Id: Ic181911709ba053e9c1f8b77d8b35684ba6c41c8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72588


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>

5f49aefc

[BUGFIX] Fix array access warnings in EditDocumentController · 9aa8a0df

Robert Kärner authored Dec 13, 2021 and

Benni Mack committed Dec 13, 2021

$this->firstEl is checked for !== null several times in
EditDocumentController, but it most certainly isn't, because
reset() returns false instead of null, if the array is empty.

This patch resolves this problem by setting $this->firstEl to
null, if reset($this->elementsData) returned false.

Resolves: #96342
Releases: main, 11.5
Change-Id: I45b7aff02d7b601e16fd05862542a9e3955de908
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72589


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>

9aa8a0df

[TASK] Log site configuration actions · 276f9d8f

Oliver Bartsch authored Dec 10, 2021

Actions to site configurations, in the site
configuration module, are now properly
logged with the new logging type "site".

Resolves: #91744
Releases: main, 11.5
Change-Id: I43156f0ac4eaa538e1f10442d4e54d141073e6da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72587


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

276f9d8f

[BUGFIX] Cast $uid to int in ConditionMatcher · 16ab4f9c

Oliver Bartsch authored Dec 11, 2021

With #95258 `ConditionMatcher->getPageIdByRecord()`
got type hinted. Therefore, the $uid has to be casted to
int before passing it to the method.

Additionally, a left over type cast in the method itself
is removed.

Resolves: #96336
Related: #95258
Releases: main, 11.5
Change-Id: I3d154e99464bf30ec00124780f949e1b3dac33c6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72586


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>

16ab4f9c

[TASK] Add tests for DataHandler->applyFiltersToValues · cfba66de

Nikita Hovratov authored Dec 11, 2021 and

Benni Mack committed Dec 13, 2021

This adds missing tests for the TCA "filter" option
for group, select and inline.

Resolves: #96339
Related: #36810
Releases: main, 11.5
Change-Id: I402edf4774f35c3b15aa53eb630d9d098f847e87
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72585


Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

cfba66de

12 Dec, 2021 2 commits

[BUGFIX] Allow shortcut pages to pages of other sites · 130f3423

Benni Mack authored Aug 10, 2021

TYPO3 has had a long history of linking to
other pages in other pagetrees. Most of the issues
were solved with the TYPO3 v9 Routing and Site Handling.

Through this feature, it is now possible to
easily create a page of type shortcut and link to
a page in a different page tree.

This was previously not possible because TYPO3 Core
by default generated URLs like "/index.php?id=123"
where people could simply add ?id=355 (where page 355
resides on a different page tree).

Since this change has been resolved, links to
other pages can be allowed and are automatically
redirected.

If we ever get rid of allowing to call pages with
an `?id=123` query parameter, the $pageNotFound=3 case
can be removed completely.

Resolves: #92859
Resolves: #92750
Releases: main, 11.5
Change-Id: I16ccc3e5b0ccb1419ccd2a8d78443616e7627a33
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72582


Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benni Mack <benni@typo3.org>

130f3423

[TASK] Simplify ErrorHandler code · 1167b9fa

Helmut Hummel authored Dec 09, 2021

To decide whether an error should be handled by the ErrorHandler
or not, only three things must be taken into account.

1. The current error_reporting() level
2. Error levels that are ignored by configuration
3. Error level of the error that is just handled

When combining the first two (with logical and),
results in the error level for the errors
that should be handled at all.

When combining this with the error level of the
currently handled error (again with logical and),
we can determine wether the error should be handled or not.

This always works with any PHP version and with suppressed
errors and without.

Therefore the PHP version check becomes obsolete and is removed.

Releases: main, 11.5
Resolves: #96311
Change-Id: I96d440d9db05a3acf1f8a12664787e05a3e31254
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72581


Tested-by: core-ci <typo3@b13.com>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Helmut Hummel <typo3@helhum.io>

1167b9fa