- 11 Sep, 2019 4 commits
-
-
This patch deprecate some methods and public properties. Also some code was moved into new classes to seperate creations and rollback of record history entries. Resolves: #89127 Releases: master Change-Id: Ib30930bc2bce129cdbdb6039d0e361020799e8e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61631 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Since site handling, finding the correct languages and the amount of languages in a page can be simplified. NewRecordController->checkIfLanguagesExist() is never in use, and can be removed completely. Resolves: #89125 Releases: master Change-Id: I523bf8ecdf0598d7acb062200710c4fae2935cc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61656 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
* Clipboard now correctly resolves record localizations of a workspace * PageLayoutController new correctly determines sub-pages that are new in a particular workspace * SlugHelper & TypoScriptTemplateModuleController can be simplified by using WorkspaceRestriction directly * common function test scenario tree (based on YAML) is introduced for ext:backend in order to be used as structure for other tests * required testing framework changes support version and language variants and combination much better now Resolves: #89138 Releases: master Change-Id: Ia4b412d48dd3ea92adc60c729ad6feb27c22b812 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61663 Tested-by:
Daniel Gorges <daniel.gorges@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Achim Fritz <af@achimfritz.de>
-
There are a few places left where Kasper-Kode stopped a process with die(). Nowadays, with PHP 7, Errors and Exceptions are used in order to avoid the full stop of a process. Using Exceptions instead of die() allows for ExceptionHandlers to handle such an error and return a proper HTTP response if called from the web. Resolves: #89128 Releases: master Change-Id: Ia50863104fb91303ca3b2ae5ac5cd1466fa982b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61659 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
- 10 Sep, 2019 5 commits
-
-
Currently, slug sanitization removes a wide range of characters not assumed suitable for slugs, for example single accent characters or control characters. This patch adds support for mark characters used for example in the devanagari alphabet. Resolves: #89123 Releases: master, 9.5 Change-Id: Iac7350d716044225164aef8585b833e3c46423fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61655 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
* Use the same parser for constants no matter the context * Use a dedicated class for constant configuration parsing * Remove custom flatten implementation and use ArrayUtility * Use the TypoScriptParser for value parsing of constants * Remove Code Duplication Resolves: #89113 Releases: master Change-Id: I4caae04d65b02e3220c4f1f3c478fd212cddf587 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61644 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
When a new site configuration gets written, removed values are determined first and changed values are determined afterwards to keep nested structures intact. Resolves: #89116 Related: #86803 Releases: master Change-Id: I6deae2a3f6eed121aa2753f2ba9a5cafa058a54d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61646 Tested-by:
-
In order to introduce site wide accessible settings, a site settings file can be placed into the sites configuration folder. The provided data will be available via the sites object. Resolves: #89102 Releases: master Change-Id: Ic010b3f8c3b10df0b6dc0cfca1cd57a8346e3b88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61636 Tested-by:
-
Also fix some typos where 'overidden' was used. Resolves: #89119 Releases: master Change-Id: I3d42fd662b978bc9688d2116b1c08eca9f9e7090 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61651 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- 09 Sep, 2019 4 commits
-
-
To avoid possible conflicts with JS minification, the commenting style is changed. Resolves: #89093 Releases: master, 9.5 Change-Id: I1afce194b89eeb64988f48c37b6ba1107d21f61b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61647 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
The second argument of ExtensionManagementUtility::addPItoST43() has been made obsolete with TYPO3 v8, but is still required when using the method. This patch sets the default value of that argument to an empty string to make the argument truly optional. Releases: master, 9.5 Resolves: #89117 Change-Id: Ie99a4599481db61e425711eefec783d5826aa11d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61648 Tested-by:
-
Eliminating OR combination of subselects within same table, as they get wrongly managed by DBMS (mostly MySQL). Using JOIN and UNION reduces time to execute (on larger data sets) from 10 s to 0.01 s. This helps to get the page tree view working if an editor is inside workspace. Resolves: #86945 Releases: master, 9.5, 8.7 Change-Id: I7a5aa66baa6cef160de66fff3f80aec49b46295f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59037 Tested-by:
-
Benni Mack authored
EXT:workspace code has leftover functionality from "reviewers" and "vtypes". * "vtypes" defined whether element-, branch or page-type versioning was used until TYPO3 v4.x. * "reviewers" defined a database field which was migrated to responsible persons for a stage The database fields are fully removed, as well as database access (for the empty fields) and labels. Resolves: #41419 Releases: master Change-Id: I8a82bdce83638c290dba96e9e07dd28d695d720a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61643 Tested-by:
-
- 08 Sep, 2019 1 commit
-
-
The API method BackendUtility::isTableWorkspaceEnabled($table) should be used when dealing with a backend context to determine if a table has versioning support enabled. This functionality wasn't used consistently throughout TYPO3 Backend / CLI code and should be used in order to determine. For PageRepository a separate protected method is introduced to avoid a dependency on BackendUtility. This patch is a precursor for streamlining the workspaces API further. Resolves: #89108 Releases: master Change-Id: Id63e04a5faa1520459d23fb5467ebfb523d9d958 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61639 Tested-by:
-
- 07 Sep, 2019 3 commits
-
-
After shedding tears, blood and sacrificing brain cells and CPU time, we finally managed to upgrade the code base to a recent TypeScript version. With this patch, our code is compiled with TypeScript 3.6, which has been added by the following command: yarn add --dev typescript@~3.6.2 Resolves: #89104 Releases: master Change-Id: I023ba89b4d4d8d98394d046c53db7fa64c12d44c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61637 Reviewed-by:
-
To ease the upgrade to TypeScript 3.6, this patch adjusts the source code in a TS 2.4 compatible way. This way, the upgrade patch stays as small as possible. Resolves: #89106 Releases: master Change-Id: I7e2d65262395e19f958182f8658aa326dd0aec43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61638 Tested-by:
-
YAML SiteConfiguration allows imports and custom configuration that is not configurable via UI to be written directly into the configuration files, however, when saving with the UI these settings are overwritten and resolved. This change changes the SiteConfiguration in a way, that only modified values are written and imports are completely left as they are. Resolves: #86803 Releases: master, 9.5 Change-Id: I92ece4959d57f41535e6fc8c3c7c9d2894d7f920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61573 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
- 06 Sep, 2019 5 commits
-
-
A new Symfony command checks for redirects that may conflict with existing and accessible sites. The command is schedulable and thus may be created as a scheduler task. Additionally, this patch comes with a report informing a backend user about such conflicts. Command: ./typo3/sysext/core/bin/typo3 redirects:checkintegrity [--site=some-site-identifier] Resolves: #89090 Releases: master Change-Id: Ide1bf0143ff55623cca268e6844e331805fb0178 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61627 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
When a third party extension that contains a requireJS backend module is updated, the cache bust parameter needs to be updated as well, otherwise browsers would not download the updated asset. We will now include all extensions that contain requireJS modules into the requireJS bust parameter hash calculation (by extension name and version). That means an extension update of these extensions will trigger a new bust parameter. This has the slight drawback that the requireJS bust parameter will need to be re-calculated after every extension update of such extensions, but that's actually limited to extensions that provide requireJS modules, and better than no asset updates at all. This patch uses the PackageManager instead of ExtensionManagementUtility to get access to the package version using the PackageInterface. Having the full package array available we can also drop the GeneralUtility::getFileAbsFilename('EXT:…') indirection which ends up calling PackageManager anyway (only with added string parsing overhead). Releases: master, 9.5 Resolves: #89086 Change-Id: Id183c935aad60a38231eb1b39aae5baed269f8ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61625 Tested-by: -
It must be possible to also filter translated rows in the element browser similarly to regular rows. This is essential to e.g. prevent selection of translated rows in relation fields. Resolves: #73165 Releases: master, 9.5 Change-Id: If0dbfb0841a0e69db3644eb7015786958c88e647 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58888 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
Resolves: #89089 Releases: master, 9.5 Change-Id: I7971e27e01bd26f1ea7fe03a008447c8475cac9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61629 Tested-by:
-
The minimum version of phpspec/prophecy is 1.7.6 and does not contain the method `shouldBeCalledOnce()`. Resolves: #89098 Related: #89066 Releases: master Change-Id: Iacfda5c100ec809ea0f7f21ce2e113571b6ae25a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61633 Tested-by:
-
- 05 Sep, 2019 4 commits
-
-
If a TCA field is set to readOnly=true and is using the type "inline", all buttons are now hidden and the fields of the relation are set to readOnly as well. Resolves: #56060 Releases: master, 9.5 Change-Id: If2b1cb2be0591d765f40512aaf341a9c26a2f87f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61490 Tested-by:
-
Add information about how user can fix the issue. Releases: master, 9.5 Resolves: #89065 Change-Id: I4110e38ba69fbe277f5f1c08fb25fbbdd52d1fcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61591 Tested-by:
Oliver Bartsch <bo@cedev.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: -
The subject under test is SiteConfigurationDataGroup::class, due to the wrong name IDEs will not connect the test class with it. To resolve the confusion, the test class gets named after the class it tests. Resolves: #89088 Releases: master, 9.5 Change-Id: Ice6f2857eb6bc416795b4576d6cce3410a81df96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61628 Tested-by:
-
Andreas Fernandez authored
Resolves: #89085 Related: #89049 Releases: master Change-Id: I3f2d83afcd833eac2caba13faedad3e449683bda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61624 Tested-by:
-
- 04 Sep, 2019 12 commits
-
-
Susanne Moog authored
composer update typo3/cms-styleguide Resolves: #89080 Releases: master, 9.5, 8.7 Change-Id: Ic4c62758efac128f61b2b8d1502ff671982a3e7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61618 Tested-by: -
Resolves: #89082 Releases: master Change-Id: I845a6689374ec0e94e16286c58ce2a7deae43450 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61623 Tested-by:
-
The case covers given HTTP_HOST and HTTP_X_FORWARDED_HOST with a configuration for an (intransparent) proxy. As some reverse proxies can be configured to have a rewritten HTTP_HOST (usually some internal name that matches the virtual host config on the webserver) I wondered if I can safely assume that TYPO3 handles that. Resolves: #88898 Releases: master Change-Id: I05302afdea0366674748445808ff00a48716e7f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61404 Tested-by:
-
Resolves: #89066 Related: #89061 Releases: master Change-Id: Iba28c90287f35818d7d669f2bb8400a4fc089856 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61590 Tested-by:
-
The filter functionality of fields `type = select` with renderType = selectMultipleSideBySide is always enabled now. Resolves: #88907 Releases: master Change-Id: I7332f39abd6444fc164e8b60009690f6af637b73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61428 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
This patch introduces the ability to attach action items to a notification, as known from nowadays operating systems. Resolves: #89061 Releases: master Change-Id: I9a36118cea12b58683746a8758b68ac0a4d0f710 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61589 Tested-by:
-
Susanne Moog authored
Releases: master, 9.5 Resolves: #89059 Change-Id: Iafbe5cb8ade38f29c13fd8ded68e42d552a28891 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61576 Tested-by:
-
Since TYPO3 v10 dropped support for Internet Explorer, JavaScript files may be shipped using the ECMAScript 6 standard. External assets simply get transpiled as far as possible. TypeScript loads the internal for ES6 and ES7 to generate native ECMAScript 6 builds. Resolves: #89047 Releases: master Change-Id: I5ab877ae07bba26e3953441040a519c628501b6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61582 Tested-by:
-
This patch deprecated the well-known `jumpToUrl()` function which simply does a redirect nowadays. Any occurence may be replaced by either using `window.location.href` or using simple `<a>` tags. Resolves: #89033 Releases: master Change-Id: I213d89825b8ee4736e168653cddb1929ceb9844e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61389 Tested-by:
-
Susanne Moog authored
As Phantom is discontinued and ChromeHeadless is an easy to use alternative, we should use ChromeHeadless to run our CI tests. In addition, a dedicated JS image for all JavaScript related tasks has been added, enabling us to easier update node versions and adjust our JavaScript builds in the future. Resolves: #89049 Releases: master Change-Id: I15c3af0796b0398f62b228d3aeefa1030c5e6ae7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61614 Tested-by:
-
composer require typo3/testing-framework:"~5.0.12" Resolves: #89073 Releases: master Change-Id: If6384d11c0201cea760b384a8b7d7b361874e815 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61617 Tested-by: -
Increase the size of the fields `db_mountpoints` and `file_mountpoints` and allow 100 instead of 25 items. Resolves: #89071 Releases: master Change-Id: I410900874475bce01a7f5f739640de6bd7d39d7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61616 Tested-by:
-
- 03 Sep, 2019 1 commit
-
-
Deprecate the usage of LocallangXmlParser in favor of xlf. Resolves: #89037 Releases: master Change-Id: I3f5a6beb28bf5e93fb83579c09f6c9aa4bacd662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61572 Tested-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
-
- 02 Sep, 2019 1 commit
-
-
When building the additionalWhere clause in the RecordsXmlSitemapDataProvider, a possible `AND` operator must be removed. Doctrine's queryBuilder adds this prefix automatically. Resolves: #88865 Releases: master,9.5 Change-Id: I6fd1f170c1c3a3b46bcaab4f2a9589e98e489a79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61392 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
